Re: [LEDE-DEV] per device rootfs vs multiple devices

[Karl Palsson]

Matthias Schiffer  wrote:
> Hi,
> {*} means that the package can't be disabled completely, but it can be set
> to M. This should give you the desired behaviour.

Right, ok. This is one of those things that's not in the Kconfig
legend. (Not in kernel upstream either, just magic knowledge) I
presume it comes from reusing modules as targets or something.

> 
> Creating a new config and setting
> CONFIG_TARGET_PER_DEVICE_ROOTFS from the beginning also works
> and sets all used DEVICE_PACKAGES to M. As your workflow
> created a config with these packages set to * first, you ended
> up with these packages still being selected after switching to
> CONFIG_TARGET_PER_DEVICE_ROOTFS.

Right, yes. After manually making some config stubs and applying
"make defconfig" I get the expected behaviour of device packages
only in the device. Pretty high surprise factor for the way
menuconfig works, but ok, that's what I'm adding the
documentation for :)

It would be _nice_ if the help in kconfig could say where it had
been pulled in from too, but I live with that. currently it just
says...

"Selected by: MODULE_DEFAULT_avrdude [=y] &&
TARGET_PER_DEVICE_ROOTFS [=y] && m && MODULES [=y]"

but not what "module" it was that pulled it in.
 
> The additional rootfs aren't ever copied to the bin directory,
> so finding only a single lede-ar71xx-generic-root.squashfs is
> expected.

The other things I can document, but this seems just wrong. If
you have a per device rootfs, what would even be _in_ the
"generic" one? Surely if you have chosen per device rootfs, you
expect to get per device rootfs?

In any case, this per device rootfs setting makes a complete mess
of scripts/diffconfig.sh. I get duplicate lines for each target,
and now _al_ of the base core packages that were untouched
are now marked as explicitly selected.
CONFIG_TARGET_DEVICE_PACKAGES_ar71xx_generic_DEVICE_dragino2=""
<< duplicated

Sincerely,
Karl Palsson

signature.asc
Description: OpenPGP Digital Signature
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] per device rootfs vs multiple devices

[Matthias Schiffer]

On 10/12/2016 12:59 PM, Karl Palsson wrote:
> 
> Hi,
> 
> I was trying to add help text to the generated Kconfig for the
> CONFIG_TARGET_MULTI_PROFILE and CONFIG_TARGET_PER_DEVICE_ROOTFS
> settings based on some irc conversations with nbd, and was trying
> out the behaviour to verify my help text.
> 
> The text I've got for per device rootfs is:
> 
> "When disabled, all device packages from all selected devices
> will be included in all images. When enabled, this is split,
> however you can no longer disable individual device packages."
> 
> I locally modified two targets to have extra "DEVICE_PACKAGES"
> (Added avrdude to one target and sqlite3-cli to another)
> 
> Doing a full "make clean; rm .config, menuconfig; select multi
> profile, select two devices; make" _without_ per device rotofs,
> gives me an image with both device packages in both device
> images, as expected. In menuconfig, the two packages are marked
> as * by default, but can be deselected, or changed to M without
> problem.
> 
> However, enabling CONFIG_TARGET_PER_DEVICE_ROOTFS seems to only
> be affecting the select/deselect behaviour. The two packages are
> now shown in menuconfig as {*} and can't be disabled anymore.
> That is as per nbd's description. But with the full make clean,
> rm .config builds, _both_ target images are still including both
> packages. Further, there's only a single rootfs file built in the
> bin directory. "lede-ar71xx-generic-root.squashfs"
> 
> I presume this is a bug in the PER_DEVICE_ROOTFS support, but it
> could also just be that the documentation isn't clear and I
> misunderstood nbd's description.
> 
> Directions?
> 
> Sincerely,
> Karl Palsson

Hi,
{*} means that the package can't be disabled completely, but it can be set
to M. This should give you the desired behaviour.

Creating a new config and setting CONFIG_TARGET_PER_DEVICE_ROOTFS from the
beginning also works and sets all used DEVICE_PACKAGES to M. As your
workflow created a config with these packages set to * first, you ended up
with these packages still being selected after switching to
CONFIG_TARGET_PER_DEVICE_ROOTFS.

The additional rootfs aren't ever copied to the bin directory, so finding
only a single lede-ar71xx-generic-root.squashfs is expected.

Regards,
Matthias



signature.asc
Description: OpenPGP digital signature
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev