Re: [Lensfun-users] vignetting under-correction

2019-01-09 Thread Jim Robinson
On Wed, Jan 9, 2019 at 5:03 PM Andreas Schneider wrote: > > > I've done some changes to the script. We specify the colorspace for all > tools > now. I would guess that convert has more influence on this and the options > to > it matter. > > > Success! That produces almost identical results for l

Re: [Lensfun-users] vignetting under-correction

2019-01-09 Thread Andreas Schneider
On Wednesday, January 9, 2019 12:25:37 PM CET Jim Robinson wrote: > On Wed, Jan 9, 2019 at 9:46 AM Andreas Schneider wrote: > > However it could be also an issue with your image. Are you sure that your > > shot > > is exposed correctly? > > > > I have tried with both a 'normal' exposure and with

Re: [Lensfun-users] vignetting under-correction

2019-01-09 Thread Jim Robinson
On Wed, Jan 9, 2019 at 9:46 AM Andreas Schneider wrote: > > > > However it could be also an issue with your image. Are you sure that your > shot > is exposed correctly? > > I have tried with both a 'normal' exposure and with a couple of stops of overexposure to use more of the dynamic range but w

Re: [Lensfun-users] vignetting under-correction

2019-01-09 Thread Andreas Schneider
On Tuesday, January 8, 2019 3:57:34 PM CET Jim Robinson wrote: > Perhaps using sRGB as the input color profile does make some sense. > Darktable/rawspeed would I think normally demosaic the raw file into its > internal color space (RGB). Using sRGB as the input color profile means > that no remappi

Re: [Lensfun-users] vignetting under-correction

2019-01-08 Thread Jim Robinson
Perhaps using sRGB as the input color profile does make some sense. Darktable/rawspeed would I think normally demosaic the raw file into its internal color space (RGB). Using sRGB as the input color profile means that no remapping occurs after demosaicing, and so we have the image in the intended l

Re: [Lensfun-users] vignetting under-correction

2019-01-08 Thread Jim Robinson
I have now checked the vignetting data with some real images and they do a good job. Whilst sRGB is indeed the color space set in the camera and does appear in the metadata of the raw file I don't think that it can be relevant to the raw data. I see from the dcraw man page that olympus raw files

Re: [Lensfun-users] vignetting under-correction

2019-01-08 Thread Jim Robinson
I not sure that this makes sense, but I have edited the lens_calibrate.py script to use sRGB as the input color profile, rerun the script and updated the lensfun database. Now if I import the raw flatfield images used to create the correction data into darktable, with the usual 'enhanced color mat

Re: [Lensfun-users] vignetting under-correction

2019-01-08 Thread Andreas Schneider
On Tuesday, January 8, 2019 9:48:27 AM CET Jim Robinson wrote: > I have tried your new version of the script and whilst the polynomial > coeffients are slightly different the overall outcome is essentially the > same, i.e very poor correction for raw file in darktable. This is not > surprising as

Re: [Lensfun-users] vignetting under-correction

2019-01-08 Thread Jim Robinson
I have tried your new version of the script and whilst the polynomial coeffients are slightly different the overall outcome is essentially the same, i.e very poor correction for raw file in darktable. This is not surprising as the changes shown on screen on changing the input color profile from 'e

Re: [Lensfun-users] vignetting under-correction

2019-01-07 Thread Andreas Schneider
On Monday, 7 January 2019 15:49:55 CET Jim Robinson wrote: > I am trying to determine the vignetting corrections for a new lens (Laowa > 7.5mm F2.0 MFT) using using the lens_calibrate.py program and images taken > through a translucent sheet. I appreciate that with a very wide angle lens > like thi

Re: [Lensfun-users] vignetting under-correction

2019-01-07 Thread Andreas Schneider
On Monday, 7 January 2019 15:49:55 CET Jim Robinson wrote: > I am trying to determine the vignetting corrections for a new lens (Laowa > 7.5mm F2.0 MFT) using using the lens_calibrate.py program and images taken > through a translucent sheet. I appreciate that with a very wide angle lens > like thi

Re: [Lensfun-users] vignetting under-correction

2019-01-07 Thread jys
On Mon, Jan 7, 2019, at 06:49, Jim Robinson wrote: > I am trying to determine the vignetting corrections for a new lens (Laowa > 7.5mm F2.0 MFT) using using the lens_calibrate.py program and images taken > through a translucent sheet. I appreciate that with a very wide angle lens > like this it mig

[Lensfun-users] vignetting under-correction

2019-01-07 Thread Jim Robinson
I am trying to determine the vignetting corrections for a new lens (Laowa 7.5mm F2.0 MFT) using using the lens_calibrate.py program and images taken through a translucent sheet. I appreciate that with a very wide angle lens like this it might overestimate the vignetting, but that is not the problem