Re: minor rclick issue
On Jun 16, 8:51 am, Edward K. Ream [EMAIL PROTECTED] wrote: You were wise not to attempt a specific fix. Actually, the fix involved creating new callbacks in several plugins where there are calls of the form: b.configure(command=command) In other words, a common pattern is: b = c.frame.addIconButton() ... b.configure(command=command) As I write this, I realize that addIconButton can also have a command arg, so maybe a few more fixes are needed... Perhaps one or more new convenience methods would be good too. This is turning out to be a bit tricky. It would be nice to have a cleaner solution... Edward --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
On Jun 13, 12:22 pm, Edward K. Ream [EMAIL PROTECTED] wrote: On Fri, Jun 13, 2008 at 3:58 AM, bobjack [EMAIL PROTECTED] wrote: The same thing applies to menu.add_radiobutton and menu.add_checkbutton. Another potential source of problems is in button commands, especially as some commands are set using btn.configure rather than in the constructor. Hmm. I'll look into this. Edward For instance have you noticed the hoist/de-hoist buttons don't redraw? I was going to fix this by putting a c.outerUpdate in the callback, but I thought you had better look at it first in case you can find a more generic solution. I did in fact do something similar for the chapter control a while ago as it was not redrawing when you selected a new chapter. Something weird is going on with the nav buttons as well but I can't quite put my finger on it, not enough to make a decent bug report anyway. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
On Thu, Jun 12, 2008 at 8:14 AM, bobjack [EMAIL PROTECTED] wrote: On Jun 11, 3:51 pm, Edward K. Ream [EMAIL PROTECTED] wrote: On Jun 11, 8:44 am, Edward K. Ream [EMAIL PROTECTED] wrote: The little mystery of the missing redraw has been solved: cleo uses aMenu.add_command to invoke several commands. This is another way into code. add_command is used by several plugins, so I suppose changing m.add_command(...) to c.add_command(m,...) would be the way to handle this. I'll play with this today. rClick is broken by this. Sorry about that. I could have sworn I checked rClick specifically. I'll fix this today. No need to revert anything. Edward --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
On Jun 12, 10:07 am, Edward K. Ream [EMAIL PROTECTED] wrote: rClick is broken by this. Sorry about that. I could have sworn I checked rClick specifically. I'll fix this today. No need to revert anything. The fix is on the trunk. All unit tests pass. Please let me know how it works for you. Edward --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
On Jun 10, 5:26 pm, Terry Brown [EMAIL PROTECTED] wrote: With rclick enabled I don't get redraws when I change cleo priority icons, there is an redraw with rclick disabled. This isn't so! The problem occurs regardless of whether rclick is enabled or not. The problem is in Edwards new redraw code, c.redraw_now() only sets a flag it doesn't do a redraw. Adding c.outerUpdate() after c.redraw_now() in cleo's redraw method cures the problem. Alternatively you could discuss with Edward the possibility of making c.redraw_now() call c.outerUpdate() itself. I'm not sure if the current situation is a bug or intentional in that regard. I'm starting to get paranoid ... :-D Bob --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
Yipee! I can now commit to bzr again! Doh! Now I have to go to work :-( --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
No. On Jun 11, 11:26 am, Edward K. Ream [EMAIL PROTECTED] wrote: Some of yesterday's changes (augmented with today's fix of c.tag_bind) may solve the problem. Those changes were intended to guarantee that c.outerUpdate gets called after all events get handled. As a special case, I suppose, c.redraw_now could call c.outerUpdate. But it should not be necessary. Does the code work now (rev519) if you remove the call to c.outerUpdate in cleo? Edward --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
On Jun 11, 8:22 am, Edward K. Ream [EMAIL PROTECTED] wrote: On second thought, c.redraw_now indeed probably should call c.outerUpdate. The little mystery of the missing redraw has been solved: cleo uses aMenu.add_command to invoke several commands. This is another way into code. add_command is used by several plugins, so I suppose changing m.add_command(...) to c.add_command(m,...) would be the way to handle this. I'll play with this today. Edward --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
On Jun 11, 8:44 am, Edward K. Ream [EMAIL PROTECTED] wrote: The little mystery of the missing redraw has been solved: cleo uses aMenu.add_command to invoke several commands. This is another way into code. add_command is used by several plugins, so I suppose changing m.add_command(...) to c.add_command(m,...) would be the way to handle this. I'll play with this today. The trunk now contains a mass update as described above. Besides Leo's core, this affects the following plugins: at_produce.py base64Packager.py cleo.py fastGotoNode.py groupOperations.py multifile.py nodenavigator.py rClick.py searchbox.py table.py word_count.py xcc_nodes.py xsltWithNodes.py Please test these if you use them. Thanks. All unit tests pass. Edward --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
Re: minor rclick issue
On Wed, Jun 11, 2008 at 12:07 PM, Terry Brown [EMAIL PROTECTED] wrote: I just committed cleo.py with a couple of c = self.c needed for c.add_command to work. Thanks. Edward --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
minor rclick issue
With rclick enabled I don't get redraws when I change cleo priority icons, there is an redraw with rclick disabled. Cheers -Terry --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups leo-editor group. To post to this group, send email to leo-editor@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~--~~~~--~~--~--~---
