Re: Possible bug in pluginsController.registerOneHandler

2017-04-06 Thread Edward K. Ream
On Thu, Apr 6, 2017 at 8:39 AM, 'Terry Brown' via leo-editor < leo-editor@googlegroups.com> wrote: > On Thu, 6 Apr 2017 03:49:25 -0700 (PDT) > vitalije wrote: > ​Thanks, Vitalije, for your work. e2ad1d1 contains it, slightly modified. All my unit tests pass. I've marked changes with # Vitalije

Re: Possible bug in pluginsController.registerOneHandler

2017-04-06 Thread 'Terry Brown' via leo-editor
On Thu, 6 Apr 2017 03:49:25 -0700 (PDT) vitalije wrote: > However, when I tried to run all unit tests to check that I didn't > broke something else in Leo codebase, I've got more than 100 failed > tests?! Am I missing something? What is the correct way to run all > tests before committing changes

Re: Possible bug in pluginsController.registerOneHandler

2017-04-06 Thread vitalije
Pull request is here Vitalije -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegrou

Re: Possible bug in pluginsController.registerOneHandler

2017-04-06 Thread vitalije
I tried to `git push` my corrections but was refused with status 403. So I forked leo-editor and pushed changes to my fork of leo-editor. I have added two new @test nodes in leo/test/unitTest.leo that test expected behavior of registerOneHandler and registerOneExclusiveHandler. After that I hav

Re: Possible bug in pluginsController.registerOneHandler

2017-04-05 Thread Edward K. Ream
On Wed, Apr 5, 2017 at 3:38 PM, vitalije wrote: On Wednesday, April 5, 2017 at 7:24:15 PM UTC+2, Edward K. Ream wrote: >> >> ​Good catch. The test above looks like mistaken defensive programming. We >> could eliminate the test entirely, or test each bunch in items: if >> bunch.fn == fn:... >> >>

Re: Possible bug in pluginsController.registerOneHandler

2017-04-05 Thread vitalije
On Wednesday, April 5, 2017 at 7:24:15 PM UTC+2, Edward K. Ream wrote: > > ​Good catch. The test above looks like mistaken defensive programming. We > could eliminate the test entirely, or test each bunch in items: if > bunch.fn == fn:... > > Care to change this yourself? > > Edward > I'll tr

Re: Possible bug in pluginsController.registerOneHandler

2017-04-05 Thread Edward K. Ream
On Wed, Apr 5, 2017 at 11:45 AM, vitalije wrote: > # from leoPlugins.py file > > def registerOneHandler(self, tag, fn): > > """Register one handler""" > > try: > > moduleName = self.loadingModuleNameStack[-1] > > except IndexError: > > moduleName = '' > > ... > >

Possible bug in pluginsController.registerOneHandler

2017-04-05 Thread vitalije
# from leoPlugins.py file def registerOneHandler(self, tag, fn): """Register one handler""" try: moduleName = self.loadingModuleNameStack[-1] except IndexError: moduleName = '' ... items = self.handlers.get(tag, []) if fn not in items: bunc