Re: error in leo.plugins.mod_scripting

2010-07-27 Thread Edward K. Ream
On Sat, Jul 24, 2010 at 11:13 AM, Terry Brown wrote: > these are almost duplicates of each other, and I missed the second one.  I've > made a trivial change in qtGui.py to eliminate the problem. DRY (Don't repeat yourself) is a good principle, but it's no panacea. Refactoring duplicate code *me

Re: error in leo.plugins.mod_scripting

2010-07-25 Thread vitalije
> Let me know if it works. > Works for me on rev no. 3171 :-) Vitalije -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to leo-edi...@googlegroups.com. To unsubscribe from this group, send email to leo-editor+uns

Re: error in leo.plugins.mod_scripting

2010-07-24 Thread Terry Brown
On Fri, 23 Jul 2010 14:32:23 -0700 (PDT) vitalije wrote: > I think that you should look at two methods > createAtButtonHelper > and > createAtButtonFromSettingHelper you're right, of course, these are almost duplicates of each other, and I missed the second one. I've made a trivial change in q

Re: error in leo.plugins.mod_scripting

2010-07-23 Thread Terry Brown
--- On Fri, 7/23/10, vitalije wrote: > I have noticed the same error. I think it happens only if > you have > @button or @command nodes somewhere in @settings tree. Hmm, I have that situation, and still don't see the error. > I think that you should look at two methods > createAtButtonHelper >

Re: error in leo.plugins.mod_scripting

2010-07-23 Thread vitalije
> Hmm, I was touching this code recently, adding the Goto Script and button > submenu stuff. > > But it's working for me bzr revno = 3169. I have noticed the same error. I think it happens only if you have @button or @command nodes somewhere in @settings tree. I think that you should look at two

Re: error in leo.plugins.mod_scripting

2010-07-22 Thread Terry Brown
On Thu, 22 Jul 2010 10:55:38 -0700 Matt Wilkie wrote: > File "C:\local\apps\leo-editor\leo\plugins\mod_scripting.py", line > 312, in createAtButtonFromSettingHelper > self.iconBar.setCommandForButton(b,atSettingButtonCallback) Hmm, I was touching this code recently, adding the Goto Script

error in leo.plugins.mod_scripting

2010-07-22 Thread Matt Wilkie
Hello, For the first time I'm trying to use Leo from bzr. I checked out the trunk branch a few weeks ago but haven't done more than edit a couple of nodes since then. Today I pulled all updates to r3169 and now when I start Leo I get an error: hook failed: open2, , leo.plugins.mod_scripting Trace