Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Sun, Oct 23, 2016 at 09:06:19AM (+), Mattia Rizzolo wrote: > On Sun, Oct 23, 2016 at 09:01:32AM +, Mattia Rizzolo wrote: > > > Let me know if I missed something, > > > > nothing, cool by me, uploaded! > > trying to push the git tag: … > This usually means the repository doesn't have > core.sharedrepository=true and/or the objects directories aren't g+w or > the groups is not scm_letsencrypt. > I don't know how you created the repository, but please fix it (I notice > now this team doesn't have a "setup-repository" script like most do, but > anyway setting up the basics shouldn't be hard by hand either). > > Can you please fix the permissions? :) Indeed, core.sharedrepository was ok, but I missed to change the group… It's now fixed. Thanks again! Seb signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Sun, Oct 23, 2016 at 09:01:35AM (+), Mattia Rizzolo wrote: > On Fri, Oct 21, 2016 at 07:51:56PM +0200, Sebastien Badia wrote: > > Just renamed also the source package, and the git repo. > > > > https://anonscm.debian.org/cgit/letsencrypt/lecm.git > > oh, wow, you redid the git repo from scratch u.U > I kinda assumed you would just mv(1) it… Hello, Yeah, it's simpler (than clean pristine-tar branchs and forget things), and we start with a clean repo :) > nothing, cool by me, uploaded! Cool! Thanks \o/ Seb signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Sun, Oct 23, 2016 at 09:01:32AM +, Mattia Rizzolo wrote: > > Let me know if I missed something, > > nothing, cool by me, uploaded! trying to push the git tag: Counting objects: 1, done. Writing objects: 100% (1/1), 790 bytes | 0 bytes/s, done. Total 1 (delta 0), reused 0 (delta 0) remote: error: insufficient permission for adding an object to repository database ./objects remote: fatal: failed to write object 8e6f45a29fb3013b866d908ab1fba179c140870c error: unpack failed: unpack-objects abnormal exit To git+ssh://git.debian.org/git/letsencrypt/lecm.git ! [remote rejected] debian/0.0.5-1 -> debian/0.0.5-1 (unpacker error) error: failed to push some refs to 'git+ssh://git.debian.org/git/letsencrypt/lecm.git' This usually means the repository doesn't have core.sharedrepository=true and/or the objects directories aren't g+w or the groups is not scm_letsencrypt. I don't know how you created the repository, but please fix it (I notice now this team doesn't have a "setup-repository" script like most do, but anyway setting up the basics shouldn't be hard by hand either). Can you please fix the permissions? :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Fri, Oct 21, 2016 at 07:51:56PM +0200, Sebastien Badia wrote: > Just renamed also the source package, and the git repo. > > https://anonscm.debian.org/cgit/letsencrypt/lecm.git oh, wow, you redid the git repo from scratch u.U I kinda assumed you would just mv(1) it… > Let me know if I missed something, nothing, cool by me, uploaded! -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Fri, Oct 21, 2016 at 09:52:43AM (+), Mattia Rizzolo wrote: > imho, yes too. > It's an application (=> users shouldn't need to care too much about the > implementation language), and upstream's name doesn't contain 'python', > imho there is no reason to specify in the name that it's in python. Hi Mattia, Thanks for the review! Just renamed also the source package, and the git repo. https://anonscm.debian.org/cgit/letsencrypt/lecm.git > oh, now I also noticed that the clean target doesn't clean > appropriately. > If you try to rebuild twice the package you get > > dpkg-source: info: local changes detected, the modified files are: > python-lecm-0.0.5/lecm.egg-info/PKG-INFO > python-lecm-0.0.5/lecm.egg-info/SOURCES.txt > python-lecm-0.0.5/lecm.egg-info/dependency_links.txt > python-lecm-0.0.5/lecm.egg-info/entry_points.txt > python-lecm-0.0.5/lecm.egg-info/requires.txt > python-lecm-0.0.5/lecm.egg-info/top_level.txt > dpkg-source: error: aborting due to unexpected upstream changes, see > /tmp/python-lecm_0.0.5-1.diff.2w_sk2 > > Also you don't delete debian/lecm.1 > > You can just add lecm.egg-info and debian/lemc.1 to debian/clean. > > You can test this by using pbuilder with the option --twice (though it's > not a comprehensive test, as that just thest that you can build twice > (and you currently can't, that's an RC), but not that you actually > restore the source package to initial situation). Oh indeed, I missed that point :-/ I use sbuild, and sbuild doesn't seems to have an easy way to do this check. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=424846 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=671074 Let me know if I missed something, Thanks! Seb signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Fri, Oct 21, 2016 at 01:41:25AM +0200, Sebastien Badia wrote: > On Wed, Oct 19, 2016 at 01:46:06AM (+0200), Sebastien Badia wrote: > > On Mon, Oct 17, 2016 at 05:40:03PM (+), Mattia Rizzolo wrote: > > > * you are also shipping a binary in /usr/bin; that imho shouldn't be in > > > a package named python3-* which usually denotes a library, or anyway > > > an application which implementation language matters. > > > I do not know lecm, but I'd probably name everything 'lecm', or > > > perhaps only the python library in a binary python3-lecm. > > > but I'm not sure if what I'm saying makes sense for this case. > > > (note that also lintian notices this, with > > > library-package-name-for-application) > > > > Yeah! I asked myself the question, and indeed, it's only a binary, so you're > > right. Should rename also the source package? > > Any comment about this point? imho, yes too. It's an application (=> users shouldn't need to care too much about the implementation language), and upstream's name doesn't contain 'python', imho there is no reason to specify in the name that it's in python. > Anyway, I just imported a new release, and addressed all points mentioned > here, > (thanks for the review!) > > If you want to take a look :) oh, now I also noticed that the clean target doesn't clean appropriately. If you try to rebuild twice the package you get dpkg-source: info: local changes detected, the modified files are: python-lecm-0.0.5/lecm.egg-info/PKG-INFO python-lecm-0.0.5/lecm.egg-info/SOURCES.txt python-lecm-0.0.5/lecm.egg-info/dependency_links.txt python-lecm-0.0.5/lecm.egg-info/entry_points.txt python-lecm-0.0.5/lecm.egg-info/requires.txt python-lecm-0.0.5/lecm.egg-info/top_level.txt dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/python-lecm_0.0.5-1.diff.2w_sk2 Also you don't delete debian/lecm.1 You can just add lecm.egg-info and debian/lemc.1 to debian/clean. You can test this by using pbuilder with the option --twice (though it's not a comprehensive test, as that just thest that you can build twice (and you currently can't, that's an RC), but not that you actually restore the source package to initial situation). -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Wed, Oct 19, 2016 at 01:46:06AM (+0200), Sebastien Badia wrote: > On Mon, Oct 17, 2016 at 05:40:03PM (+), Mattia Rizzolo wrote: > > * you are also shipping a binary in /usr/bin; that imho shouldn't be in > > a package named python3-* which usually denotes a library, or anyway > > an application which implementation language matters. > > I do not know lecm, but I'd probably name everything 'lecm', or > > perhaps only the python library in a binary python3-lecm. > > but I'm not sure if what I'm saying makes sense for this case. > > (note that also lintian notices this, with > > library-package-name-for-application) > > Yeah! I asked myself the question, and indeed, it's only a binary, so you're > right. Should rename also the source package? Hello, Any comment about this point? Anyway, I just imported a new release, and addressed all points mentioned here, (thanks for the review!) If you want to take a look :) https://anonscm.debian.org/cgit/letsencrypt/python-lecm.git Thanks in advance! Seb signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
Hello, On Mon, Oct 17, 2016 at 05:40:03PM (+), Mattia Rizzolo wrote: > I'm on the ML, so no need to Cc me here; also I assume you are, so I > won't Cc you either! Yep sorry, it was just in case of :-) > > https://anonscm.debian.org/cgit/letsencrypt/python-lecm.git Many thanks Mattia for the review! Just pushed in our git repo. > * d/control: > + mind using /git/ also in Vcs-Browser? I like it more to have both > Vcs-* being the same. (this is just me…) Fixed, I finally used explicitly /cgit/ for Vcs-Browser > + you are packaging only a binary named python3-* something; I'd just > leave out the "this is a py3 version" stuff from the description, > and instead try to make the long description more useful Fixed also, I tried to write an extended description, but I'm not a native English speaker, don't hesitate to re-world if needed… > * you are also shipping a binary in /usr/bin; that imho shouldn't be in > a package named python3-* which usually denotes a library, or anyway > an application which implementation language matters. > I do not know lecm, but I'd probably name everything 'lecm', or > perhaps only the python library in a binary python3-lecm. > but I'm not sure if what I'm saying makes sense for this case. > (note that also lintian notices this, with > library-package-name-for-application) Yeah! I asked myself the question, and indeed, it's only a binary, so you're right. Should rename also the source package? > * do you think you can put that manpage somewhere upstream? also I see > you're shipping the .md which seems to be the source of the groff > file, could you generate it at build time? manpage removed, and generated during build time, I also submitted the .md file upstream :) > * why not debhelper compat level 10? Yes, good idea. Thanks! Seb signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
Re: [Letsencrypt-devel] RFS: python-lecm/0.0.4-1: Let's Encrypt Manager (ITP: #840641)
On Mon, Oct 17, 2016 at 07:27:05PM +0200, Sebastien Badia wrote: > Hello! > > I'm new in the team, I just joined according a Mattia proposal on the ITP > #840641. Hi! I'm on the ML, so no need to Cc me here; also I assume you are, so I won't Cc you either! > python-lecm package is now pushed inside letsencrypt team, and should be ready > for a review/upload. > > https://anonscm.debian.org/cgit/letsencrypt/python-lecm.git > > https://mentors.debian.net/debian/pool/main/p/python-lecm/python-lecm_0.0.4-1.dsc be aware that I totally ignore tarballs (as distributed by mentors.d.n in this case) if possible, and just stick to the git repo. * d/control: + mind using /git/ also in Vcs-Browser? I like it more to have both Vcs-* being the same. (this is just me…) + you are packaging only a binary named python3-* something; I'd just leave out the "this is a py3 version" stuff from the description, and instead try to make the long description more useful * you are also shipping a binary in /usr/bin; that imho shouldn't be in a package named python3-* which usually denotes a library, or anyway an application which implementation language matters. I do not know lecm, but I'd probably name everything 'lecm', or perhaps only the python library in a binary python3-lecm. but I'm not sure if what I'm saying makes sense for this case. (note that also lintian notices this, with library-package-name-for-application) * do you think you can put that manpage somewhere upstream? also I see you're shipping the .md which seems to be the source of the groff file, could you generate it at build time? * why not debhelper compat level 10? -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature ___ Letsencrypt-devel mailing list Letsencrypt-devel@lists.alioth.debian.org https://lists.alioth.debian.org/mailman/listinfo/letsencrypt-devel
