Re: [libav-devel] [FFmpeg-devel] GSoC project (JPEG 2000)

2011-04-11 Thread rukhsana afroz
On Wed, Apr 6, 2011 at 6:35 PM, rukhsana afroz wrote: > > > On Wed, Apr 6, 2011 at 9:24 AM, Michael Niedermayer wrote: > >> I suspect the If statement is there as the implementation only supports >> cblk_style==0 >> the others simply are not implemented >> >> Do you think you can implement them?

Re: [libav-devel] [PATCH] oggdec: use av_freep() instead of av_free()

2011-04-11 Thread Anton Khirnov
On Mon, Apr 11, 2011 at 10:22:31PM -0700, Alex Converse wrote: > $subj > From c104a6e90226eaa253aeba471c8859e0da922da7 Mon Sep 17 00:00:00 2001 > From: Michael Niedermayer > Date: Mon, 11 Apr 2011 11:49:07 +0200 > Subject: [PATCH] oggdec: use av_freep() instead of av_free() > Signed-off-by: Mich

[libav-devel] [PATCH] oggdec: use av_freep() instead of av_free()

2011-04-11 Thread Alex Converse
$subj From c104a6e90226eaa253aeba471c8859e0da922da7 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Mon, 11 Apr 2011 11:49:07 +0200 Subject: [PATCH] oggdec: use av_freep() instead of av_free() Signed-off-by: Michael Niedermayer --- libavformat/oggdec.c |4 ++-- 1 files changed, 2

Re: [libav-devel] [PATCH] Convert some undefined 1<<31 shifts into 1U<<31.

2011-04-11 Thread Alex Converse
On Mon, Apr 11, 2011 at 9:49 PM, Alex Converse wrote: > On Sat, Apr 9, 2011 at 5:48 PM, Luca Barbato wrote: >> On 04/10/2011 02:41 AM, Alex Converse wrote: >>> Passes make fate, altivec untested. >> >> Altivec should not have problems (the variable is already unsigned). >> >> lu >> >> -- > > push

Re: [libav-devel] [PATCH 2/2] mp3enc: write a xing frame containing number of frames in the file

2011-04-11 Thread Alex Converse
On Mon, Mar 28, 2011 at 3:36 AM, Anton Khirnov wrote: > --- >  libavcodec/Makefile  |    1 + >  libavformat/mp3enc.c |   74 ++--- >  2 files changed, 70 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index 85d9

Re: [libav-devel] [PATCH] Fix the conversion of AV_SAMPLE_FMT_FLT and _DBL to AV_SAMPLE_FMT_S32.

2011-04-11 Thread Alex Converse
On Mon, Apr 11, 2011 at 1:34 AM, Luca Barbato wrote: >> (1<<31) is undefined and seems to be evaluated by gcc to -2^31 when >> these formulae require 2^31. >> --- >>  libavcodec/audioconvert.c |    4 ++-- >>  1 files changed, 2 insertions(+), 2 deletions(-) > > Looks ok, put a note about adding te

Re: [libav-devel] [PATCH] Convert some undefined 1<<31 shifts into 1U<<31.

2011-04-11 Thread Alex Converse
On Sat, Apr 9, 2011 at 5:48 PM, Luca Barbato wrote: > On 04/10/2011 02:41 AM, Alex Converse wrote: >> Passes make fate, altivec untested. > > Altivec should not have problems (the variable is already unsigned). > > lu > > -- pushed ___ libav-devel maili

Re: [libav-devel] [PATCH]AAC audio: Skip ADTS Header when copied from TS container to Non-TS containers

2011-04-11 Thread Aℓex Converse
On Mon, Apr 11, 2011 at 2:24 PM, Luca Barbato wrote: > On 04/11/2011 11:14 PM, Manjunath Siddaiah wrote: >> Hi, >> >> When we do "-acodec  copy" if input is "mpegts" and output is non-mpegts >> ( MOV, MP4, 3GP, FLV, ISM) ADTS header also got copied. >> AAC audio do not need ADTS header in MOV, MP4

Re: [libav-devel] [PATCH 19/27] patch checklist:git format-patch Signed-off-by: Michael Niedermayer

2011-04-11 Thread Michael Niedermayer
On Sat, Apr 09, 2011 at 05:10:35PM -0400, Ronald S. Bultje wrote: [...] > > -@item > > -    Did you provide a suggestion for a clear commit log message? > > I don't think this is right. Git still doesn't write your log messages > for you. You could reword it as "did you provide a clear git commit

Re: [libav-devel] [FFmpeg-devel] [PATCH 1/3] Add avio_check() function.

2011-04-11 Thread Michael Niedermayer
On Sun, Apr 10, 2011 at 12:52:57AM +0200, Stefano Sabatini wrote: > [CC-ing ffmpeg-devel] > > On date Saturday 2011-04-09 12:35:58 +0200, Anton Khirnov wrote: > > On Sat, Apr 09, 2011 at 02:47:35AM +0200, Stefano Sabatini wrote: > > > From b563c12cb285f1e6eb8dc19d1a18323cd9280ea1 Mon Sep 17 00:00:

Re: [libav-devel] [PATCH]AAC audio: Skip ADTS Header when copied from TS container to Non-TS containers

2011-04-11 Thread Luca Barbato
On 04/11/2011 11:14 PM, Manjunath Siddaiah wrote: > Hi, > > When we do "-acodec copy" if input is "mpegts" and output is non-mpegts > ( MOV, MP4, 3GP, FLV, ISM) ADTS header also got copied. > AAC audio do not need ADTS header in MOV, MP4, 3GP, FLV, ISM containers. > This patch skips the ADTS head

[libav-devel] [PATCH]AAC audio: Skip ADTS Header when copied from TS container to Non-TS containers

2011-04-11 Thread Manjunath Siddaiah
Hi, When we do "-acodec copy" if input is "mpegts" and output is non-mpegts ( MOV, MP4, 3GP, FLV, ISM) ADTS header also got copied. AAC audio do not need ADTS header in MOV, MP4, 3GP, FLV, ISM containers. This patch skips the ADTS header copying to non-mpegts formats. -Manjunath H Siddaiah

Re: [libav-devel] [PATCH 1/5] swscale: factorize FAST_BGR2YV12

2011-04-11 Thread Luca Barbato
On 04/11/2011 10:34 PM, Luca Barbato wrote: > Right, they are leftovers... updated my github branch. lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/li

Re: [libav-devel] [PATCH 1/5] swscale: factorize FAST_BGR2YV12

2011-04-11 Thread Luca Barbato
On 04/11/2011 10:21 PM, Aℓex Converse wrote: > On Mon, Apr 11, 2011 at 1:01 PM, Luca Barbato wrote: >> It is used only for x86 so it will be moved once the code is moved in >> the arch dir >> >> Question: should we build an accurate BGR2YV12 variant? >> --- >> libswscale/rgb2rgb.c |4

Re: [libav-devel] [PATCH] RTMP streaming crashes after some time with Flash Media Server (FMS), Issue 2236

2011-04-11 Thread Manjunath Siddaiah
-Original Message- From: libav-devel-boun...@libav.org [mailto:libav-devel-boun...@libav.org] On Behalf Of Kostya Sent: Thursday, March 24, 2011 3:50 AM To: libav development Subject: Re: [libav-devel] [PATCH] RTMP streaming crashes after some time with Flash Media Server (FMS), Issue 223

Re: [libav-devel] [PATCH 1/5] swscale: factorize FAST_BGR2YV12

2011-04-11 Thread Aℓex Converse
On Mon, Apr 11, 2011 at 1:01 PM, Luca Barbato wrote: > It is used only for x86 so it will be moved once the code is moved in > the arch dir > > Question: should we build an accurate BGR2YV12 variant? > --- >  libswscale/rgb2rgb.c          |    4 ++-- >  libswscale/swscale.c          |    2 -- >  l

[libav-devel] [PATCH 5/5] swscale: simplify initialization code

2011-04-11 Thread Luca Barbato
From: Josh Allmann Simplify the fallthrough case when no accelerated functions can be initialized. --- libswscale/swscale.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index e830bb6..277a0d3 100644 --- a/libswscale/

[libav-devel] [PATCH 4/5] swscale: further cleanup swscale.c

2011-04-11 Thread Luca Barbato
From: Josh Allmann Move x86-specific constants out of swscale.c --- libswscale/swscale.c | 57 - libswscale/x86/swscale_template.c | 54 +++ 2 files changed, 54 insertions(+), 57 deletions(-) diff --git a/libsw

[libav-devel] [PATCH 1/5] swscale: factorize FAST_BGR2YV12

2011-04-11 Thread Luca Barbato
It is used only for x86 so it will be moved once the code is moved in the arch dir Question: should we build an accurate BGR2YV12 variant? --- libswscale/rgb2rgb.c |4 ++-- libswscale/swscale.c |2 -- libswscale/swscale_internal.h |2 ++ 3 files changed, 4 insertions

[libav-devel] Cleanup swscale (still partial)

2011-04-11 Thread Luca Barbato
I squashed the patches and reworded the commit messages. I hope they look a little better, now. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 05/14] Switch x86_reg to int for the C code

2011-04-11 Thread Luca Barbato
On 04/11/2011 07:03 PM, Diego Biurrun wrote: > On Mon, Apr 11, 2011 at 09:34:11AM -0700, Aℓex Converse wrote: >> On Mon, Apr 11, 2011 at 3:06 AM, Diego Biurrun wrote: >>> On Mon, Apr 11, 2011 at 11:07:38AM +0200, Luca Barbato wrote: --- libswscale/rgb2rgb_template.c | 28 +

Re: [libav-devel] [PATCH 05/14] Switch x86_reg to int for the C code

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 09:34:11AM -0700, Aℓex Converse wrote: > On Mon, Apr 11, 2011 at 3:06 AM, Diego Biurrun wrote: > > On Mon, Apr 11, 2011 at 11:07:38AM +0200, Luca Barbato wrote: > >> --- > >>  libswscale/rgb2rgb_template.c |   28 ++-- > >>  1 files changed, 14 insert

Re: [libav-devel] [PATCH 05/14] Switch x86_reg to int for the C code

2011-04-11 Thread Aℓex Converse
On Mon, Apr 11, 2011 at 3:06 AM, Diego Biurrun wrote: > On Mon, Apr 11, 2011 at 11:07:38AM +0200, Luca Barbato wrote: >> --- >>  libswscale/rgb2rgb_template.c |   28 ++-- >>  1 files changed, 14 insertions(+), 14 deletions(-) > > Why?  The log message is descriptive, but no

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 09:44:49AM -0400, Ronald S. Bultje wrote: > > On Sun, Apr 10, 2011 at 3:44 PM, Diego Biurrun wrote: > > When HAVE_7REGS was not defined these functions had an empty body > > causing the following warnings during compilation. > > In file included from libswscale/x86/yuv2rgb

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 10:06:43AM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, Apr 11, 2011 at 10:01 AM, Luca Barbato wrote: > > On 04/11/2011 03:44 PM, Ronald S. Bultje wrote: > >> This isn't right. You're declaring empty functions for stuff that is > >> supposed to do something. In x86/yuv

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Ronald S. Bultje
Hi, On Mon, Apr 11, 2011 at 10:01 AM, Luca Barbato wrote: > On 04/11/2011 03:44 PM, Ronald S. Bultje wrote: >> This isn't right. You're declaring empty functions for stuff that is >> supposed to do something. In x86/yuv2rgb_mmx.c, you'll see these >> functions are only called under if (HAVE_7REGS

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Luca Barbato
On 04/11/2011 03:44 PM, Ronald S. Bultje wrote: > This isn't right. You're declaring empty functions for stuff that is > supposed to do something. In x86/yuv2rgb_mmx.c, you'll see these > functions are only called under if (HAVE_7REGS) anyway, so the proper > fix is to not declare these functions a

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Ronald S. Bultje
Hi, On Sun, Apr 10, 2011 at 3:44 PM, Diego Biurrun wrote: > When HAVE_7REGS was not defined these functions had an empty body > causing the following warnings during compilation. > In file included from libswscale/x86/yuv2rgb_mmx.c:58: > libswscale/x86/yuv2rgb_template.c: In function ‘yuva420_rgb

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:25:49AM +0200, Luca Barbato wrote: > On 04/10/2011 09:44 PM, Diego Biurrun wrote: > > When HAVE_7REGS was not defined these functions had an empty body > > causing the following warnings during compilation. > > In file included from libswscale/x86/yuv2rgb_mmx.c:58: > > li

Re: [libav-devel] [PATCH] Fix compilation of timefilter test program.

2011-04-11 Thread Diego Biurrun
On Sun, Apr 10, 2011 at 09:54:56PM +0200, Luca Barbato wrote: > On 04/10/2011 09:46 PM, Diego Biurrun wrote: > > The printf function is forbidden in library code, but not in test programs, > > so #undefine the printf macro that disables the system printf function. > > ok Pushed. Diego __

Re: [libav-devel] Swscale cleanup part I

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 01:48:04PM +0200, Luca Barbato wrote: > On 04/11/2011 12:16 PM, Diego Biurrun wrote: > > On Mon, Apr 11, 2011 at 11:07:33AM +0200, Luca Barbato wrote: > >> Hi this patchset does still apply today. > >> Even if not complete I'm considering to merge it since seems not > >> int

Re: [libav-devel] [PATCH 1/2] Add an AAC encoder by using the libvo-aacenc library

2011-04-11 Thread Martin Storsjö
On Mon, 11 Apr 2011, Luca Barbato wrote: > On 04/08/2011 12:21 AM, Martin Storsjö wrote: > > Changelog |1 + > > configure |6 ++ > > doc/general.texi |2 +- > > libavcodec/Makefile |1 + > > libavcodec/allcodecs.c|1 + > > li

Re: [libav-devel] [PATCH 2/2] Add support for AMR-WB encoding via libvo-amrwbenc

2011-04-11 Thread Martin Storsjö
On Mon, 11 Apr 2011, Luca Barbato wrote: > On 04/08/2011 12:22 AM, Martin Storsjö wrote: > > > The wrapper code is based on the libamr wrapper removed in SVN rev 19365. > > --- > > Changelog |1 + > > configure |6 ++ > > doc/general.texi|

Re: [libav-devel] [PATCH 1/2] Add an AAC encoder by using the libvo-aacenc library

2011-04-11 Thread Luca Barbato
On 04/08/2011 12:21 AM, Martin Storsjö wrote: > Changelog |1 + > configure |6 ++ > doc/general.texi |2 +- > libavcodec/Makefile |1 + > libavcodec/allcodecs.c|1 + > libavcodec/libvo-aacenc.c | 128 > ++

Re: [libav-devel] [PATCH 2/2] Add support for AMR-WB encoding via libvo-amrwbenc

2011-04-11 Thread Luca Barbato
On 04/08/2011 12:22 AM, Martin Storsjö wrote: > The wrapper code is based on the libamr wrapper removed in SVN rev 19365. > --- > Changelog |1 + > configure |6 ++ > doc/general.texi|3 +- > libavcodec/Makefile |1 + > libav

Re: [libav-devel] Swscale cleanup part I

2011-04-11 Thread Luca Barbato
On 04/11/2011 12:16 PM, Diego Biurrun wrote: > On Mon, Apr 11, 2011 at 11:07:33AM +0200, Luca Barbato wrote: >> Hi this patchset does still apply today. >> Even if not complete I'm considering to merge it since seems not >> introduce changes and already moves most of the x86 code in its >> director

Re: [libav-devel] [PATCH 10/14] Fixup

2011-04-11 Thread Luca Barbato
On 04/11/2011 12:09 PM, Diego Biurrun wrote: > On Mon, Apr 11, 2011 at 11:07:43AM +0200, Luca Barbato wrote: >> --- >> libswscale/swscale.c | 13 + >> 1 files changed, 5 insertions(+), 8 deletions(-) > > "Fixup" what? Please be more descriptive. > > Diego > ___

Re: [libav-devel] [PATCH 09/14] Factorize init between C and x86

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:42AM +0200, Luca Barbato wrote: > Always call first the C init and make the optional optimization > init follow. > The unaccelerated function pointer shouldn't be set again, > likewise the other common logic should be present only on the C > init. Factorize initiali

Re: [libav-devel] [PATCH 08/14] Untemplatize swscale_template

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:41AM +0200, Luca Barbato wrote: > move all the functions to the _c suffix Please add the rationale for this change to the log message :) > --- a/libswscale/swscale_template.c > +++ b/libswscale/swscale_template.c > @@ -18,7 +18,7 @@ > > -static inline void RENAME(y

Re: [libav-devel] [PATCH 06/14] Move away x86 specific code from rgb2rgb part 2

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:26:16AM +0200, Kostya wrote: > On Mon, Apr 11, 2011 at 11:07:39AM +0200, Luca Barbato wrote: > > With this commit we should have all the arch specific code moved away. > > Init pattern now: > > - generic C init first > > - arch specific init later overwriting > > > > ---

Re: [libav-devel] [PATCH 06/14] Move away x86 specific code from rgb2rgb part 2

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:39AM +0200, Luca Barbato wrote: > With this commit we should have all the arch specific code moved away. > Init pattern now: > - generic C init first > - arch specific init later overwriting > > --- a/libswscale/rgb2rgb.c > +++ b/libswscale/rgb2rgb.c > @@ -130,21 +51,

Re: [libav-devel] Swscale cleanup part I

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:33AM +0200, Luca Barbato wrote: > Hi this patchset does still apply today. > Even if not complete I'm considering to merge it since seems not > introduce changes and already moves most of the x86 code in its > directory. A general remark: I find the log messages a bit

Re: [libav-devel] [PATCH 04/14] Untemplatize C code part 1

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:37AM +0200, Luca Barbato wrote: > --- > libswscale/rgb2rgb.c |9 +- > libswscale/rgb2rgb_template.c | 174 > 2 files changed, 91 insertions(+), 92 deletions(-) I'd be happy to see you explain the reason for this

Re: [libav-devel] [PATCH 10/14] Fixup

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:43AM +0200, Luca Barbato wrote: > --- > libswscale/swscale.c | 13 + > 1 files changed, 5 insertions(+), 8 deletions(-) "Fixup" what? Please be more descriptive. Diego ___ libav-devel mailing list libav-deve

Re: [libav-devel] [PATCH 05/14] Switch x86_reg to int for the C code

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:38AM +0200, Luca Barbato wrote: > --- > libswscale/rgb2rgb_template.c | 28 ++-- > 1 files changed, 14 insertions(+), 14 deletions(-) Why? The log message is descriptive, but not explanatory... > --- a/libswscale/rgb2rgb_template.c > +++ b

Re: [libav-devel] [PATCH 01/14] Thin rgb2rgb a little part 1 of many

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 11:07:34AM +0200, Luca Barbato wrote: > Move the function pointers in a separate file. > It will removed once the pointers will be factored in a more structured > form > > --- /dev/null > +++ b/libswscale/swscale_functions.c > @@ -0,0 +1,67 @@ > +#include stdint.h is enou

Re: [libav-devel] [PATCH 14/14] Simplify the fallthrough case when no accelerated functions can be initialized.

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:47AM +0200, Luca Barbato wrote: > From: Josh Allmann looks ok ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 13/14] Move x86-specific constants out of swscale.c

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:46AM +0200, Luca Barbato wrote: > From: Josh Allmann ok ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 12/14] Unset h*scale_fast in arch specific init (x86)

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:45AM +0200, Luca Barbato wrote: > That makes the output consistent, to be investigated if it could be > avoided. Thanks to Josh for spotting it. > --- isn't the whole context zeroed before initialisation? But in general looks ok ___

Re: [libav-devel] [PATCH 11/14] Move back the function pointers in rgb2rgb.c

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:44AM +0200, Luca Barbato wrote: > This unbreak darwin. unbreakS Also maybe you should merge it with patch 1 then? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 10/14] Fixup

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:43AM +0200, Luca Barbato wrote: > --- > libswscale/swscale.c | 13 + > 1 files changed, 5 insertions(+), 8 deletions(-) ok ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/lis

Re: [libav-devel] [PATCH 09/14] Factorize init between C and x86

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:42AM +0200, Luca Barbato wrote: > Always call first the C init and make the optional optimization > init follow. > The unaccelerated function pointer shouldn't be set again, > likewise the other common logic should be present only on the C > init. looks reasonable ___

Re: [libav-devel] [PATCH 08/14] Untemplatize swscale_template

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:41AM +0200, Luca Barbato wrote: > move all the functions to the _c suffix > --- > libswscale/swscale_template.c | 130 > 1 files changed, 65 insertions(+), 65 deletions(-) looks ok but somebody would also ask breaking those l

Re: [libav-devel] [PATCH 06/14] Move away x86 specific code from rgb2rgb part 2

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:39AM +0200, Luca Barbato wrote: > With this commit we should have all the arch specific code moved away. > Init pattern now: > - generic C init first > - arch specific init later overwriting > > In future the arch specific init will overwrite just the generics for > w

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Luca Barbato
On 04/10/2011 09:44 PM, Diego Biurrun wrote: > When HAVE_7REGS was not defined these functions had an empty body > causing the following warnings during compilation. > In file included from libswscale/x86/yuv2rgb_mmx.c:58: > libswscale/x86/yuv2rgb_template.c: In function ‘yuva420_rgb32_MMX’: > libs

Re: [libav-devel] [PATCH 05/14] Switch x86_reg to int for the C code

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:38AM +0200, Luca Barbato wrote: > --- > libswscale/rgb2rgb_template.c | 28 ++-- > 1 files changed, 14 insertions(+), 14 deletions(-) Could you also deniedermayerize it? I find "var= value" style improper. But in general ok.

Re: [libav-devel] [PATCH 04/14] Untemplatize C code part 1

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:37AM +0200, Luca Barbato wrote: > --- > libswscale/rgb2rgb.c |9 +- > libswscale/rgb2rgb_template.c | 174 > 2 files changed, 91 insertions(+), 92 deletions(-) looks ok ___

Re: [libav-devel] [PATCH 02/14] Factorize FAST_BGR2YV12

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:13:29AM +0200, Kostya wrote: > On Mon, Apr 11, 2011 at 11:07:35AM +0200, Luca Barbato wrote: > > It is used only for x86 so it will be moved once the code is moved in > > the arch dir > > > > Question: should we build an accurate BGR2YV12 variant? > > maybe when we have

Re: [libav-devel] [PATCH 02/14] Factorize FAST_BGR2YV12

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:35AM +0200, Luca Barbato wrote: > It is used only for x86 so it will be moved once the code is moved in > the arch dir > > Question: should we build an accurate BGR2YV12 variant? maybe when we have optimisations for it ___

Re: [libav-devel] [PATCH 01/14] Thin rgb2rgb a little part 1 of many

2011-04-11 Thread Kostya
On Mon, Apr 11, 2011 at 11:07:34AM +0200, Luca Barbato wrote: > Move the function pointers in a separate file. > It will removed once the pointers will be factored in a more structured > form > --- probably ok (and having YUV-to-YUV conversion in rgb2rgb.c is somehow a bit baffling) __

[libav-devel] [PATCH 14/14] Simplify the fallthrough case when no accelerated functions can be initialized.

2011-04-11 Thread Luca Barbato
From: Josh Allmann --- libswscale/swscale.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index e830bb6..277a0d3 100644 --- a/libswscale/swscale.c +++ b/libswscale/swscale.c @@ -1211,8 +1211,6 @@ SwsFunc ff_getSwsFunc

[libav-devel] [PATCH 13/14] Move x86-specific constants out of swscale.c

2011-04-11 Thread Luca Barbato
From: Josh Allmann --- libswscale/swscale.c | 57 - libswscale/x86/swscale_template.c | 54 +++ 2 files changed, 54 insertions(+), 57 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index

[libav-devel] [PATCH 12/14] Unset h*scale_fast in arch specific init (x86)

2011-04-11 Thread Luca Barbato
That makes the output consistent, to be investigated if it could be avoided. Thanks to Josh for spotting it. --- libswscale/x86/swscale_template.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libswscale/x86/swscale_template.c b/libswscale/x86/swscale_template.c index

[libav-devel] [PATCH 11/14] Move back the function pointers in rgb2rgb.c

2011-04-11 Thread Luca Barbato
This unbreak darwin. --- libswscale/Makefile|2 +- libswscale/rgb2rgb.c | 65 ++ libswscale/swscale_functions.c | 67 3 files changed, 66 insertions(+), 68 deletions(-) delete mode 100644 li

[libav-devel] [PATCH 10/14] Fixup

2011-04-11 Thread Luca Barbato
--- libswscale/swscale.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 8d8c625..fe96141 100644 --- a/libswscale/swscale.c +++ b/libswscale/swscale.c @@ -1197,10 +1197,7 @@ static inline void monoblack2Y(uint8_

[libav-devel] [PATCH 09/14] Factorize init between C and x86

2011-04-11 Thread Luca Barbato
Always call first the C init and make the optional optimization init follow. The unaccelerated function pointer shouldn't be set again, likewise the other common logic should be present only on the C init. --- libswscale/swscale.c |6 +-- libswscale/x86/swscale_template.c | 73 +

[libav-devel] [PATCH 08/14] Untemplatize swscale_template

2011-04-11 Thread Luca Barbato
move all the functions to the _c suffix --- libswscale/swscale_template.c | 130 1 files changed, 65 insertions(+), 65 deletions(-) diff --git a/libswscale/swscale_template.c b/libswscale/swscale_template.c index c983fc0..cac9725 100644 --- a/libswscale/s

[libav-devel] [PATCH 06/14] Move away x86 specific code from rgb2rgb part 2

2011-04-11 Thread Luca Barbato
With this commit we should have all the arch specific code moved away. Init pattern now: - generic C init first - arch specific init later overwriting In future the arch specific init will overwrite just the generics for which we have an optimization. --- libswscale/Makefile |3 +- libsw

[libav-devel] [PATCH 05/14] Switch x86_reg to int for the C code

2011-04-11 Thread Luca Barbato
--- libswscale/rgb2rgb_template.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libswscale/rgb2rgb_template.c b/libswscale/rgb2rgb_template.c index 30c3ad2..69f0683 100644 --- a/libswscale/rgb2rgb_template.c +++ b/libswscale/rgb2rgb_template.

[libav-devel] [PATCH 04/14] Untemplatize C code part 1

2011-04-11 Thread Luca Barbato
--- libswscale/rgb2rgb.c |9 +- libswscale/rgb2rgb_template.c | 174 2 files changed, 91 insertions(+), 92 deletions(-) diff --git a/libswscale/rgb2rgb.c b/libswscale/rgb2rgb.c index dd34c9d..e6d7971 100644 --- a/libswscale/rgb2rgb.c +++ b/li

[libav-devel] [PATCH 02/14] Factorize FAST_BGR2YV12

2011-04-11 Thread Luca Barbato
It is used only for x86 so it will be moved once the code is moved in the arch dir Question: should we build an accurate BGR2YV12 variant? --- libswscale/rgb2rgb.c |2 -- libswscale/swscale.c |2 -- libswscale/swscale_internal.h |2 ++ 3 files changed, 2 insertions(+

[libav-devel] [PATCH 01/14] Thin rgb2rgb a little part 1 of many

2011-04-11 Thread Luca Barbato
Move the function pointers in a separate file. It will removed once the pointers will be factored in a more structured form --- libswscale/Makefile|2 +- libswscale/rgb2rgb.c | 66 --- libswscale/swscale_functions.c | 67 +++

[libav-devel] Swscale cleanup part I

2011-04-11 Thread Luca Barbato
Hi this patchset does still apply today. Even if not complete I'm considering to merge it since seems not introduce changes and already moves most of the x86 code in its directory. You can fork it from my libav repo on github https://github.com/lu-zero/libav/tree/swscale-cleanup Many thanks to J

Re: [libav-devel] [PATCH] Add unconditional return statement to yuva420_rgb32_MMX() / yuva420_bgr32_MMX().

2011-04-11 Thread Kostya
On Sun, Apr 10, 2011 at 09:44:51PM +0200, Diego Biurrun wrote: > When HAVE_7REGS was not defined these functions had an empty body > causing the following warnings during compilation. > In file included from libswscale/x86/yuv2rgb_mmx.c:58: > libswscale/x86/yuv2rgb_template.c: In function ‘yuva420_

Re: [libav-devel] [PATCH 2/2] Provide isnan replacement for systems that do not have it.

2011-04-11 Thread Diego Biurrun
On Mon, Apr 11, 2011 at 09:40:32AM +0400, Konstantin Pavlov wrote: > > --- a/libavutil/libm.h > +++ b/libavutil/libm.h > @@ -38,6 +38,14 @@ > > +#if !HAVE_ISNAN > +#undef isnan > +#define isnan(x) \ > + (sizeof (x) == sizeof (long double) ? __builtin_isnanl ((long double)(x)) > : \ > + size

Re: [libav-devel] [PATCH] g722: Return 8 bits per sample for g722 in av_get_bits_per_sample

2011-04-11 Thread Martin Storsjö
On Sun, 10 Apr 2011, Kostya wrote: > On Sun, Apr 10, 2011 at 08:39:43PM +0300, Martin Storsjö wrote: > > This fixes a failing assert in ff_raw_read_header (in > > fate-g722dec-1), where bits_per_coded_sample is set using this > > function and is required to have a positive value. > > --- > > yes,

Re: [libav-devel] [PATCH] Fix the conversion of AV_SAMPLE_FMT_FLT and _DBL to AV_SAMPLE_FMT_S32.

2011-04-11 Thread Luca Barbato
> (1<<31) is undefined and seems to be evaluated by gcc to -2^31 when > these formulae require 2^31. > --- > libavcodec/audioconvert.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Looks ok, put a note about adding tests. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu

Re: [libav-devel] [PATCH] Allow custom stride in V210

2011-04-11 Thread Luca Barbato
On 04/10/2011 11:59 PM, Kieran Kunhya wrote: > Blackmagic hardware SDI cards output V210 with a custom stride. > This patch allows libav to decode these streams. > How to test it? Not sure we need it as global avcodec parameter, as avoption might be nicer. lu -- Luca Barbato Gentoo/linux htt