Re: [libav-devel] [PATCH] mss4, ra288, truemotion1: Remove unused DSPContext local context members

2013-02-08 Thread Kostya Shishkov
On Sat, Feb 09, 2013 at 12:13:08AM +0100, Diego Biurrun wrote: > --- > libavcodec/mss4.c|1 - > libavcodec/ra288.c |1 - > libavcodec/truemotion1.c |2 +- > 3 files changed, 1 insertion(+), 3 deletions(-) LGTM ___ libav-devel m

Re: [libav-devel] [PATCH] h264 sps cropping (right and bottom)

2013-02-08 Thread Vittorio Giovara
So, following up from the discussion on IRC, I think it better to start out fresh. I think I have fixed cropping for the right and bottom offset (with just minor modifications and only two files touched). What this patch does is: 1. keep the video size (width and height) to the full size of the vi

[libav-devel] [PATCH] mss4, ra288, truemotion1: Remove unused DSPContext local context members

2013-02-08 Thread Diego Biurrun
--- libavcodec/mss4.c|1 - libavcodec/ra288.c |1 - libavcodec/truemotion1.c |2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/mss4.c b/libavcodec/mss4.c index 7c714cb..f4e4d8d 100644 --- a/libavcodec/mss4.c +++ b/libavcodec/mss4.c @@ -126,7

[libav-devel] [PATCH 35/59] mpegaudio: decode directly to the user-provided AVFrame

2013-02-08 Thread Justin Ruggles
--- libavcodec/mpegaudiodec.c | 40 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/libavcodec/mpegaudiodec.c b/libavcodec/mpegaudiodec.c index 3524cff..d1460c8 100644 --- a/libavcodec/mpegaudiodec.c +++ b/libavcodec/mpegaudiodec.c @@ -84

Re: [libav-devel] [PATCH 34/59] mlp/truehd: decode directly to the user-provided AVFrame

2013-02-08 Thread Justin Ruggles
On 01/18/2013 01:35 AM, Anton Khirnov wrote: > > On Wed, 9 Jan 2013 12:11:53 -0500, Justin Ruggles > wrote: >> --- >> libavcodec/mlpdec.c | 17 ++--- >> 1 files changed, 6 insertions(+), 11 deletions(-) >> >> diff --git a/libavcodec/mlpdec.c b/libavcodec/mlpdec.c >> index 3852f6e

Re: [libav-devel] [PATCH] dsputil: Move fdct function declarations to dct.h

2013-02-08 Thread Diego Biurrun
On Fri, Feb 08, 2013 at 07:49:13PM +0100, Diego Biurrun wrote: > --- > > Now moves the declarations to dct.h instead of into a separate fdct.h. OKed by Luca on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailma

Re: [libav-devel] [PATCH 35/59] mpegaudio: decode directly to the user-provided AVFrame

2013-02-08 Thread Justin Ruggles
On 01/18/2013 01:39 AM, Anton Khirnov wrote: > > On Wed, 9 Jan 2013 12:11:54 -0500, Justin Ruggles > wrote: >> --- >> libavcodec/mpegaudiodec.c | 55 >> +--- >> 1 files changed, 26 insertions(+), 29 deletions(-) >> >> diff --git a/libavcodec/mpegaudio

[libav-devel] [PATCH 5/5] lavr: fix mixing matrix reduction when normalization is disabled

2013-02-08 Thread Justin Ruggles
In some cases when an input contributes fully to the corresponding output, other inputs may also contribute to the same output. This is the case, for example, for the default 5.1 to stereo downmix matrix without normalization. --- libavresample/audio_mix.c | 11 +++ 1 files changed, 11 i

[libav-devel] [PATCH 4/5] lavr: fix matrix reduction for upmixing in certain cases

2013-02-08 Thread Justin Ruggles
Do not skip an output if the corresponding input contributes to other output channels. --- libavresample/audio_mix.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/libavresample/audio_mix.c b/libavresample/audio_mix.c index eaa985e..9a5ffcc 100644 --- a/libavres

[libav-devel] [PATCH 3/3] dsputil: Move STRIDE_ALIGN macro to the only place it is used

2013-02-08 Thread Diego Biurrun
--- libavcodec/dsputil.h |6 -- libavcodec/utils.c |7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h index 4b697ef..f95077f 100644 --- a/libavcodec/dsputil.h +++ b/libavcodec/dsputil.h @@ -397,10 +397,4 @@ void ff_d

[libav-devel] [PATCH 2/3] avcodec/rectangle: Remove nonsense assert

2013-02-08 Thread Diego Biurrun
--- See the following IRC discussion: 00:48 <@DonDiego> libavcodec/rectangle.h:assertlong)vp)&(FFMIN(w, STRIDE_ALIGN)-1)) == 0); 00:48 <@DonDiego> how much sense does that asser make? 00:50 <@DonDiego> it is the only use of STRIDE_ALIGN outside of libavcodec/utils.c 01:21 <+astrange> hm

[libav-devel] [PATCH 1/3] avcodec/utils: cosmetics: Move INTERNAL_BUFFER_SIZE define to a better place

2013-02-08 Thread Diego Biurrun
--- libavcodec/utils.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 19c8a99..35ad4c2 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -50,6 +50,8 @@ static int (*ff_lockmgr_cb)(void **mutex, enum AVLockOp op);

Re: [libav-devel] [PATCH 14/14] dsputil: Move LOCAL_ALIGNED macros to a more suitable place

2013-02-08 Thread Diego Biurrun
On Fri, Feb 08, 2013 at 03:47:08PM +0100, Luca Barbato wrote: > On 08/02/13 00:42, Diego Biurrun wrote: > > --- > > libavcodec/aacps.c|2 +- > > libavcodec/aacsbr.c |1 + > > libavcodec/ac3enc.c |2 +- > > libavcodec/ac3enc_templa

[libav-devel] [PATCH] dsputil: Move fdct function declarations to dct.h

2013-02-08 Thread Diego Biurrun
--- Now moves the declarations to dct.h instead of into a separate fdct.h. libavcodec/dct-test.c |2 +- libavcodec/dct.h| 15 +++ libavcodec/dsputil.c|1 + libavcodec/dsputil.h| 14 -- libavcodec/jfdctfst.c

Re: [libav-devel] [PATCH 14/14] dsputil: Move LOCAL_ALIGNED macros to a more suitable place

2013-02-08 Thread Luca Barbato
On 08/02/13 00:42, Diego Biurrun wrote: > --- > libavcodec/aacps.c|2 +- > libavcodec/aacsbr.c |1 + > libavcodec/ac3enc.c |2 +- > libavcodec/ac3enc_template.c |1 + > libavcodec/bink.c |1 + >

Re: [libav-devel] [PATCH 12/14] dsputil: Move rnd_avg inline functions to a separate header

2013-02-08 Thread Luca Barbato
On 08/02/13 00:42, Diego Biurrun wrote: > --- > libavcodec/bit_depth_template.c |1 + > libavcodec/dsputil.h| 23 --- > libavcodec/rnd_avg.h| 47 > +++ > libavcodec/sh4/dsputil_align.c |1 + > libavcodec/sh4/

Re: [libav-devel] [PATCH 09/14] dsputil: Move ff_shrink* function declarations to separate header

2013-02-08 Thread Luca Barbato
On 08/02/13 00:42, Diego Biurrun wrote: > --- > libavcodec/dsputil.c|1 + > libavcodec/dsputil.h|5 - > libavcodec/imgconvert.c |1 + > libavcodec/imgconvert.h | 29 + > 4 files changed, 31 insertions(+), 5 deletions(-) > create mode 100644 li

Re: [libav-devel] [PATCH 1/2] asfdec: do not assume every AVStream has a correspodning ASFStream

2013-02-08 Thread Vladimir Pantelic
On 02/08/2013 02:01 PM, Anton Khirnov wrote: This won't be true for ID3 attached picture. Also stop allocating now useless dummy ASFStreams for ASF native attached pictures. --- libavformat/asfdec.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/

Re: [libav-devel] [PATCH 2/2] FATE: add tests for additional flavors of asf cover art

2013-02-08 Thread Diego Biurrun
On Fri, Feb 08, 2013 at 02:01:31PM +0100, Anton Khirnov wrote: > --- > tests/fate/cover-art.mak |8 > 1 file changed, 8 insertions(+) s/asf/ASF/ > --- a/tests/fate/cover-art.mak > +++ b/tests/fate/cover-art.mak > @@ -14,6 +14,14 @@ FATE_COVER_ART += fate-cover-art-wma > > +FATE_CO

Re: [libav-devel] [PATCH 08/14] dsputil: Move ff_svq3 function declarations to a separate header

2013-02-08 Thread Luca Barbato
On 08/02/13 00:42, Diego Biurrun wrote: > --- > libavcodec/dsputil.h |3 --- > libavcodec/h264.c|1 + > libavcodec/svq3.c|1 + > libavcodec/svq3.h| 27 +++ > 4 files changed, 29 insertions(+), 3 deletions(-) > create mode 100644 libavcodec/svq3.h

[libav-devel] [PATCH 2/2] FATE: add tests for additional flavors of asf cover art

2013-02-08 Thread Anton Khirnov
--- tests/fate/cover-art.mak |8 1 file changed, 8 insertions(+) diff --git a/tests/fate/cover-art.mak b/tests/fate/cover-art.mak index dadfcd8..ea08b39 100644 --- a/tests/fate/cover-art.mak +++ b/tests/fate/cover-art.mak @@ -14,6 +14,14 @@ FATE_COVER_ART += fate-cover-art-wma fate-

[libav-devel] [PATCH 1/2] asfdec: do not assume every AVStream has a correspodning ASFStream

2013-02-08 Thread Anton Khirnov
This won't be true for ID3 attached picture. Also stop allocating now useless dummy ASFStreams for ASF native attached pictures. --- libavformat/asfdec.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 3329814..18

Re: [libav-devel] [PATCH] error_resilience: decouple ER from MpegEncContext

2013-02-08 Thread Anton Khirnov
On Fri, 8 Feb 2013 11:04:25 +0100, Kostya Shishkov wrote: > On Fri, Feb 08, 2013 at 07:26:34AM +0100, Anton Khirnov wrote: > > --- > > * moved ER_ defines to error_resilience.h > > * removed error_status_table from MpegEncContext > > * check for field_picture, not interlaced_frame in ff_er_frame

Re: [libav-devel] [PATCH] asfdec: support reading ID3v2 tags in ASF files

2013-02-08 Thread Luca Barbato
On 08/02/13 11:06, Vladimir Pantelic wrote: > Yes, these files do exist > > Signed-off-by: Vladimir Pantelic > --- > Changelog|1 + > libavformat/asfdec.c | 24 +--- > 2 files changed, 22 insertions(+), 3 deletions(-) Ok. __

Re: [libav-devel] [PATCH 10/14] dsputil: Move fdct function declarations to a separate header

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 11:40:19AM +0100, Diego Biurrun wrote: > On Fri, Feb 08, 2013 at 11:07:04AM +0100, Kostya Shishkov wrote: > > On Fri, Feb 08, 2013 at 10:59:28AM +0100, Diego Biurrun wrote: > > > On Fri, Feb 08, 2013 at 09:36:36AM +0100, Kostya Shishkov wrote: > > > > On Fri, Feb 08, 2013 at

Re: [libav-devel] [PATCH 10/14] dsputil: Move fdct function declarations to a separate header

2013-02-08 Thread Diego Biurrun
On Fri, Feb 08, 2013 at 11:07:04AM +0100, Kostya Shishkov wrote: > On Fri, Feb 08, 2013 at 10:59:28AM +0100, Diego Biurrun wrote: > > On Fri, Feb 08, 2013 at 09:36:36AM +0100, Kostya Shishkov wrote: > > > On Fri, Feb 08, 2013 at 12:42:53AM +0100, Diego Biurrun wrote: > > > > --- > > > > libavcodec

[libav-devel] [PATCH] asfdec: support reading ID3v2 tags in ASF files

2013-02-08 Thread Vladimir Pantelic
Yes, these files do exist Signed-off-by: Vladimir Pantelic --- Changelog|1 + libavformat/asfdec.c | 24 +--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/Changelog b/Changelog index c235727..f56c112 100644 --- a/Changelog +++ b/Changelog

Re: [libav-devel] [PATCH 10/14] dsputil: Move fdct function declarations to a separate header

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 10:59:28AM +0100, Diego Biurrun wrote: > On Fri, Feb 08, 2013 at 09:36:36AM +0100, Kostya Shishkov wrote: > > On Fri, Feb 08, 2013 at 12:42:53AM +0100, Diego Biurrun wrote: > > > --- > > > libavcodec/dct-test.c |2 +- > > > libavcodec/dsputil.c|

Re: [libav-devel] [PATCH] error_resilience: decouple ER from MpegEncContext

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 07:26:34AM +0100, Anton Khirnov wrote: > --- > * moved ER_ defines to error_resilience.h > * removed error_status_table from MpegEncContext > * check for field_picture, not interlaced_frame in ff_er_frame_end. > this is what the previous code did > * in h264 decode_mb, don

Re: [libav-devel] [PATCH 10/14] dsputil: Move fdct function declarations to a separate header

2013-02-08 Thread Diego Biurrun
On Fri, Feb 08, 2013 at 09:36:36AM +0100, Kostya Shishkov wrote: > On Fri, Feb 08, 2013 at 12:42:53AM +0100, Diego Biurrun wrote: > > --- > > libavcodec/dct-test.c |2 +- > > libavcodec/dsputil.c|1 + > > libavcodec/dsputil.h| 14 -- > > liba

Re: [libav-devel] [PATCH 13/14] dsputil: Move WRAPPER8_16_SQ macro to the only place it is used

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:56AM +0100, Diego Biurrun wrote: > --- > libavcodec/dsputil.c | 14 ++ > libavcodec/dsputil.h | 14 -- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c > index a48a371..dea70

Re: [libav-devel] [PATCH 11/14] dsputil: Remove commented-out, unused function declarations

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:54AM +0100, Diego Biurrun wrote: > --- > libavcodec/dsputil.h |8 > 1 file changed, 8 deletions(-) > > diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h > index 8bfc74b..1f67733 100644 > --- a/libavcodec/dsputil.h > +++ b/libavcodec/dsputil.h > @@

Re: [libav-devel] [PATCH 10/14] dsputil: Move fdct function declarations to a separate header

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:53AM +0100, Diego Biurrun wrote: > --- > libavcodec/dct-test.c |2 +- > libavcodec/dsputil.c|1 + > libavcodec/dsputil.h| 14 -- > libavcodec/fdct.h | 37 + > l

Re: [libav-devel] [PATCH 07/14] dsputil: Move ff_h264_idct function declarations to a separate header

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:50AM +0100, Diego Biurrun wrote: > --- > libavcodec/dsputil.h | 18 -- > libavcodec/h264dsp.c |1 + > libavcodec/h264idct.c |2 ++ > libavcodec/h264idct.h | 42 ++ > 4 files changed, 45 insertions(+

Re: [libav-devel] [PATCH 06/14] dsputil: Move copy_block functions to a separate header

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:49AM +0100, Diego Biurrun wrote: > --- > libavcodec/copy_block.h | 61 > +++ > libavcodec/dsputil.c|1 + > libavcodec/dsputil.h| 36 > libavcodec/sh4/qpel.c |1 + > 4 files

Re: [libav-devel] [PATCH 05/14] dsputil: Drop unused functions copy_block{2|4|16}

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:48AM +0100, Diego Biurrun wrote: > --- > libavcodec/dsputil.h | 33 - > 1 file changed, 33 deletions(-) some of them got unused after the previous patches in the patchset, but OK ___ libav-

Re: [libav-devel] [PATCH 04/14] indeo3: replace use of copy_block4 with put_pixels

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:47AM +0100, Diego Biurrun wrote: > From: Mans Rullgard > > The destination is sufficiently aligned for put_pixels here. > > Signed-off-by: Mans Rullgard > --- > libavcodec/indeo3.c | 21 - > 1 file changed, 12 insertions(+), 9 deletions(-) L

Re: [libav-devel] [PATCH 03/14] mjpegdec: use put_pixels instead of copy_block8

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:46AM +0100, Diego Biurrun wrote: > From: Mans Rullgard > > Signed-off-by: Mans Rullgard > --- > libavcodec/mjpegdec.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c > index d13c85

Re: [libav-devel] [PATCH 02/14] dsputil: Move get_penalty_factor() to the only place it is used.

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:45AM +0100, Diego Biurrun wrote: > --- > libavcodec/dsputil.h| 20 > libavcodec/motion_est.c | 20 > 2 files changed, 20 insertions(+), 20 deletions(-) looks reasonable too

Re: [libav-devel] [PATCH 01/14] dsputil: Move ff_block_permute to mpegvideo_enc

2013-02-08 Thread Kostya Shishkov
On Fri, Feb 08, 2013 at 12:42:44AM +0100, Diego Biurrun wrote: > --- > libavcodec/dsputil.c | 29 - > libavcodec/dsputil.h |6 -- > libavcodec/mpegvideo.c | 29 + > libavcodec/mpegvideo.h |6 ++ > 4 files changed, 35 i