[libav-devel] [PATCH 1/2] lavfi: add compand audio filter

2014-02-23 Thread Andrew Kelley
This patch adds the `compand` audio filter from ffmpeg master branch (currently at 9026c49c82) adapted to work with libav. --- Changes from last patch send to mailing list (all cosmetic): http://paste.ubuntu.com/6984879/ Changelog| 1 + doc/filters.texi | 73 ++ li

[libav-devel] [PATCH 2/2] af_compand: fix invalid read

2014-02-23 Thread Andrew Kelley
--- Nothing is changed here from the last patch. I am sending it again just so that it will not be accidentally forgotten. libavfilter/af_compand.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavfilter/af_compand.c b/libavfilter/af_compand.c index e10e4e6..4

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Justin Ruggles
On 02/23/2014 08:20 PM, Andrew Kelley wrote: > This patch adds the `compand` audio filter from ffmpeg master branch > (currently at 9026c49c82) adapted to work with libav. > --- > > Don't assume that pts starts at 0. > > Here's the diff: http://paste.ubuntu.com/6984821/ > > > Changelog

[libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Andrew Kelley
This patch adds the `compand` audio filter from ffmpeg master branch (currently at 9026c49c82) adapted to work with libav. --- Don't assume that pts starts at 0. Here's the diff: http://paste.ubuntu.com/6984821/ Changelog| 1 + doc/filters.texi | 73 ++ libavfilt

[libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Andrew Kelley
This patch adds the `compand` audio filter from ffmpeg master branch (currently at 9026c49c82) adapted to work with libav. --- I changed all the configuration floats to doubles and added relevant comments. Changelog| 1 + doc/filters.texi | 73 ++ libavfilter/Makef

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Justin Ruggles
On 02/23/2014 05:38 PM, Andrew Kelley wrote: > Thanks for the review. Comments below: > > On Sun, Feb 23, 2014 at 4:03 PM, Justin Ruggles > wrote: > >>> +frame = ff_get_audio_buffer(outlink, FFMIN(2048, s->delay_count)); >> >> Why 2048? >> > > Honestly I don't know. I'll spend some time try

[libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Andrew Kelley
This patch adds the `compand` audio filter from ffmpeg master branch (currently at 9026c49c82) adapted to work with libav. --- This incorporates Justin's feedback. Changelog| 1 + doc/filters.texi | 73 ++ libavfilter/Makefile | 1 + libavfilter/af_compand.c |

[libav-devel] [PATCH] parser: K&R cosmetic refactoring

2014-02-23 Thread Luca Barbato
--- Reviews in patch update form please. libavcodec/parser.c | 187 1 file changed, 102 insertions(+), 85 deletions(-) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index 511f1f3..18969d0 100644 --- a/libavcodec/parser.c +++ b/libavc

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Andrew Kelley
Thanks for the review. Comments below: On Sun, Feb 23, 2014 at 4:03 PM, Justin Ruggles wrote: > > +frame = ff_get_audio_buffer(outlink, FFMIN(2048, s->delay_count)); > > Why 2048? > Honestly I don't know. I'll spend some time trying to understand. > You can use doubles for the intermediate

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Justin Ruggles
dOn 02/20/2014 08:30 PM, Andrew Kelley wrote: > This patch adds the `compand` audio filter from ffmpeg master branch > (currently at 9026c49c82) adapted to work with libav. > --- > Here is the diff from the previous patch I just sent to the mailing list: > http://paste.ubuntu.com/6968598/ > > >

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Tim Walker
On 23 Feb 2014, at 19:06, Janne Grunau wrote: > On 2014-02-23 18:53:32 +0100, Tim Walker wrote: >> >> On 23 Feb 2014, at 18:40, Janne Grunau wrote: >> >>> On 2014-02-23 17:21:10 +, Derek Buitenhuis wrote: On 2/23/2014 3:20 PM, Janne Grunau wrote: > This doesn't look right, AV_PIX_

Re: [libav-devel] [PATCH 03/27] lavc: remove disabled FF_API_OLD_ENCODE_VIDEO cruft

2014-02-23 Thread Luca Barbato
On 23/02/14 15:34, Reinhard Tartler wrote: > The patch quoted below requires quite non-trivial changes to > applications. Consider amide's http://amide.sourceforge.net/ > mpeg_encode_frame() function: > > > gboolean mpeg_encode_frame(gpointer data, GdkPixbuf * pixbuf) { > encode_t * encode = da

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Luca Barbato
On 23/02/14 18:46, Andrew Kelley wrote: > Ping. > Justin could you have a look? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] x86: add detection for Bit Manipulation Instruction sets

2014-02-23 Thread James Almer
On 23/02/14 11:20 AM, Janne Grunau wrote: > Do you plan to write assembly using any of these instructions? Having > the tests while not using the instructions is just an exercise in > completeness. > > Janne No, not for BMI1/2. I saw the "TODO" line as i was adding FMA3 so i thought i might as w

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Janne Grunau
On 2014-02-23 18:53:32 +0100, Tim Walker wrote: > > On 23 Feb 2014, at 18:40, Janne Grunau wrote: > > > On 2014-02-23 17:21:10 +, Derek Buitenhuis wrote: > >> On 2/23/2014 3:20 PM, Janne Grunau wrote: > >>> This doesn't look right, AV_PIX_FMT_YUV420P is a valid pixel format for > >>> 'x265_m

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Tim Walker
On 23 Feb 2014, at 18:40, Janne Grunau wrote: > On 2014-02-23 17:21:10 +, Derek Buitenhuis wrote: >> On 2/23/2014 3:20 PM, Janne Grunau wrote: >>> This doesn't look right, AV_PIX_FMT_YUV420P is a valid pixel format for >>> 'x265_max_bit_depth == 12' and I can't see how x265 could deduce that

Re: [libav-devel] [PATCH] lavfi: add compand audio filter

2014-02-23 Thread Andrew Kelley
Ping. On Thu, Feb 20, 2014 at 8:30 PM, Andrew Kelley wrote: > This patch adds the `compand` audio filter from ffmpeg master branch > (currently at 9026c49c82) adapted to work with libav. > --- > Here is the diff from the previous patch I just sent to the mailing list: > http://paste.ubuntu.com/

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Janne Grunau
On 2014-02-23 17:21:10 +, Derek Buitenhuis wrote: > On 2/23/2014 3:20 PM, Janne Grunau wrote: > > This doesn't look right, AV_PIX_FMT_YUV420P is a valid pixel format for > > 'x265_max_bit_depth == 12' and I can't see how x265 could deduce that > > otherwise. > > No, the *internal* depth is not

Re: [libav-devel] [PATCH 03/27] lavc: remove disabled FF_API_OLD_ENCODE_VIDEO cruft

2014-02-23 Thread Sean McGovern
On Sun, Feb 23, 2014 at 10:59 AM, Reinhard Tartler wrote: > On Sun, Feb 23, 2014 at 10:29 AM, Anton Khirnov wrote: > > [snipped for brevity] > > > > This can be replaced by > > if (ret >= 0 && got_packet) { > > fwrite(pkt.data, 1, pkt.size, encode->output_file); > > av_free_packet(&pkt);

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Tim Walker
On 23 Feb 2014, at 18:21, Derek Buitenhuis wrote: > On 2/23/2014 3:20 PM, Janne Grunau wrote: >> This doesn't look right, AV_PIX_FMT_YUV420P is a valid pixel format for >> 'x265_max_bit_depth == 12' and I can't see how x265 could deduce that >> otherwise. > > No, the *internal* depth is not the

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Derek Buitenhuis
On 2/23/2014 3:20 PM, Janne Grunau wrote: > This doesn't look right, AV_PIX_FMT_YUV420P is a valid pixel format for > 'x265_max_bit_depth == 12' and I can't see how x265 could deduce that > otherwise. No, the *internal* depth is not the same as *input* depth. The input depth is set in the picture

Re: [libav-devel] [PATCH 03/27] lavc: remove disabled FF_API_OLD_ENCODE_VIDEO cruft

2014-02-23 Thread Reinhard Tartler
On Sun, Feb 23, 2014 at 10:29 AM, Anton Khirnov wrote: > > On Sun, 23 Feb 2014 09:34:46 -0500, Reinhard Tartler > wrote: >> The patch quoted below requires quite non-trivial changes to >> applications. Consider amide's http://amide.sourceforge.net/ >> mpeg_encode_frame() function: >> >> >> gbool

Re: [libav-devel] [PATCH 03/27] lavc: remove disabled FF_API_OLD_ENCODE_VIDEO cruft

2014-02-23 Thread Anton Khirnov
On Sun, 23 Feb 2014 09:34:46 -0500, Reinhard Tartler wrote: > The patch quoted below requires quite non-trivial changes to > applications. Consider amide's http://amide.sourceforge.net/ > mpeg_encode_frame() function: > > > gboolean mpeg_encode_frame(gpointer data, GdkPixbuf * pixbuf) { > enc

Re: [libav-devel] [PATCH 2/4] libx265: Support 4:4:4

2014-02-23 Thread Janne Grunau
On 2014-02-21 20:34:49 +, Derek Buitenhuis wrote: > On 2/21/2014 5:16 PM, Derek Buitenhuis wrote: > > Signed-off-by: Derek Buitenhuis > > --- > > libavcodec/libx265.c | 14 ++ > > 1 file changed, 14 insertions(+) > > FYI, I've changed this to be marked as experimental locally, si

Re: [libav-devel] [PATCH 4/4] libx265: Properly handled dynamic linking with MSVC

2014-02-23 Thread Janne Grunau
On 2014-02-21 17:16:20 +, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index 7fdccc7..9833e48 100644 > --- a/libavcodec/libx265.c > +++ b/libav

Re: [libav-devel] [PATCH 3/4] libx265: Support SAR

2014-02-23 Thread Janne Grunau
On 2014-02-21 17:16:19 +, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index 1546853..7fdccc7 100644 > --- a/libavcodec/libx265.c > +++ b/

Re: [libav-devel] [PATCH 1/4] libx265: Update API usage

2014-02-23 Thread Janne Grunau
On 2014-02-21 17:16:17 +, Derek Buitenhuis wrote: > Framerate is now a sane rational instead of an integer, and > inputDepth is changed to what it actually is. > > Signed-off-by: Derek Buitenhuis > --- > configure| 4 ++-- > libavcodec/libx265.c | 9 +++-- > 2 files changed,

Re: [libav-devel] [PATCH] avconv: support forcing codec tags for input streams

2014-02-23 Thread Janne Grunau
On 2014-02-23 08:43:13 +0100, Anton Khirnov wrote: > --- > avconv_opt.c| 12 +++- > doc/avconv.texi |2 +- > 2 files changed, 12 insertions(+), 2 deletions(-) ok Janne ___ libav-devel mailing list libav-devel@libav.org https://lists.l

Re: [libav-devel] [PATCH 2/3] lavc: use AVFrame API properly in ff_reget_buffer()

2014-02-23 Thread Janne Grunau
On 2014-02-15 21:33:52 +0100, Anton Khirnov wrote: > --- > libavcodec/utils.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index b2b11ef..c88b346 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c >

Re: [libav-devel] [PATCH 2/3] lavc: use AVFrame API properly in ff_reget_buffer()

2014-02-23 Thread Anton Khirnov
On Sat, 15 Feb 2014 21:33:52 +0100, Anton Khirnov wrote: > --- > libavcodec/utils.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) > ping -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.

Re: [libav-devel] [PATCH 03/27] lavc: remove disabled FF_API_OLD_ENCODE_VIDEO cruft

2014-02-23 Thread Reinhard Tartler
The patch quoted below requires quite non-trivial changes to applications. Consider amide's http://amide.sourceforge.net/ mpeg_encode_frame() function: gboolean mpeg_encode_frame(gpointer data, GdkPixbuf * pixbuf) { encode_t * encode = data; gint out_size; convert_rgb_pixbuf_to_yuv(encode-

Re: [libav-devel] [PATCH 1/1] configure: disable cpunop is the check fails

2014-02-23 Thread Janne Grunau
On 2014-02-23 14:18:21 +0100, Janne Grunau wrote: is/if typo in the subject fixed locally Janne ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] x86: add detection for Bit Manipulation Instruction sets

2014-02-23 Thread Janne Grunau
On 2014-02-22 02:54:02 -0300, James Almer wrote: > Based on x264 code > > Signed-off-by: James Almer > --- > libavutil/cpu.c | 6 ++ > libavutil/cpu.h | 2 ++ > libavutil/x86/cpu.c | 16 +++- > 3 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/libavuti

Re: [libav-devel] [PATCH 2/3] x86: add detection for FMA3 instruction set

2014-02-23 Thread Janne Grunau
On 2014-02-22 02:54:01 -0300, James Almer wrote: > Based on x264 code > > Signed-off-by: James Almer commit author changed to your full name > --- > configure | 5 + > libavutil/cpu.c | 3 +++ > libavutil/cpu.h | 1 + > libavutil/x86/cpu.c | 5 - > libavutil/x86/cpu.h

Re: [libav-devel] [PATCH 1/1] configure: disable cpunop is the check fails

2014-02-23 Thread Luca Barbato
On 23/02/14 14:18, Janne Grunau wrote: > Entries in ARCH_EXT_LIST get enabled by default so Diego missed to > change the check for cpunop. See patch below. > Push anytime, we should start documenting the configure and I guess might be time to split it in components to ease reuse. lu

[libav-devel] [PATCH 1/1] configure: disable cpunop is the check fails

2014-02-23 Thread Janne Grunau
On 2014-02-23 04:08:58 +0100, Luca Barbato wrote: > On 23/02/14 04:02, James Almer wrote: > > On 22/02/14 11:57 PM, Luca Barbato wrote: > >> On 23/02/14 00:52, Dave Yeo wrote: > >> > >> HAVE_LIST has ARCH_EXT_LIST > >> > >> ARCH_EXT_LIST has ARCH_EXT_LIST_X86 > >> > >> I'm wondering why it is broke

Re: [libav-devel] [PATCH 1/5] configure: miscellaneous cosmetics

2014-02-23 Thread Janne Grunau
On 2013-11-02 17:21:49 +0100, Diego Biurrun wrote: > Sort lists of components. Sort function checks and group them in more > sensible blocks. Add some whitespace where it helps readability. > Consistently use double instead of single quotes around component lists. > --- > configure | 68 > +

Re: [libav-devel] [PATCH 7/7] hevc: Do not left shift a negative value

2014-02-23 Thread Janne Grunau
On 2014-02-22 21:34:19 +0100, Guillaume Martres wrote: > On Wednesday 19 February 2014 22:43:13 Luca Barbato wrote: > > +if (x < 0) > > +x_pos = -((-x / 2) << s->sps->pixel_shift); > > This seems very weird to me, x and y are used to get an index inside

Re: [libav-devel] [PATCH] avconv: support forcing codec tags for input streams

2014-02-23 Thread Luca Barbato
On 23/02/14 08:43, Anton Khirnov wrote: > --- > avconv_opt.c| 12 +++- > doc/avconv.texi |2 +- > 2 files changed, 12 insertions(+), 2 deletions(-) > Possibly ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav