On 2013-11-02 17:21:49 +0100, Diego Biurrun wrote:
> Sort lists of components. Sort function checks and group them in more
> sensible blocks. Add some whitespace where it helps readability.
> Consistently use double instead of single quotes around component lists.
> ---
> configure | 68
> ++++++++++++++++++++++++++++++++-----------------------------
> 1 file changed, 36 insertions(+), 32 deletions(-)
>
> diff --git a/configure b/configure
> index 4aa66c0..d199778 100755
> --- a/configure
> +++ b/configure
skipped hunks are ok
> @@ -3675,16 +3676,18 @@ if ! disabled network; then
> fi
> fi
>
> -# Solaris has nanosleep in -lrt, OpenSolaris no longer needs that
> -check_func nanosleep || { check_func nanosleep -lrt && add_extralibs -lrt; }
> +check_builtin sync_val_compare_and_swap "" "int *ptr; int oldval, newval;
> __sync_val_compare_and_swap(ptr, oldval, newval)"
> +check_builtin machine_rw_barrier mbarrier.h "__machine_rw_barrier()"
> +check_builtin atomic_cas_ptr atomic.h "void **ptr; void *oldval, *newval;
> atomic_cas_ptr(ptr, oldval, newval)"
> +check_builtin MemoryBarrier windows.h "MemoryBarrier()"
ok
> +check_func_headers malloc.h _aligned_malloc && enable aligned_malloc
> check_func fcntl
> check_func fork
> check_func_headers stdlib.h getenv
> check_func gethrtime
> check_func getopt
> check_func getrusage
> -check_struct "sys/time.h sys/resource.h" "struct rusage" ru_maxrss
no, not everything is or should be alphabetically sorted
> check_func gettimeofday
> check_func inet_aton $network_extralibs
> check_func isatty
> @@ -3693,24 +3696,19 @@ check_func ${malloc_prefix}memalign &&
> enable memalign
> check_func mkstemp
> check_func mmap
> check_func mprotect
> +# Solaris has nanosleep in -lrt, OpenSolaris no longer needs that
> +check_func nanosleep || { check_func nanosleep -lrt && add_extralibs -lrt; }
> check_func ${malloc_prefix}posix_memalign && enable posix_memalign
> -check_func_headers malloc.h _aligned_malloc && enable aligned_malloc
ah, I see now what you're sorting but can we please keep this logical
grouping too
> +check_func sched_getaffinity
> +check_func_headers io.h setmode
> check_func setrlimit
> check_func strerror_r
> check_func strptime
> check_func strtok_r
> -check_func sched_getaffinity
> -check_builtin sync_val_compare_and_swap "" "int *ptr; int oldval, newval;
> __sync_val_compare_and_swap(ptr, oldval, newval)"
> -check_builtin machine_rw_barrier mbarrier.h "__machine_rw_barrier()"
> -check_builtin atomic_cas_ptr atomic.h "void **ptr; void *oldval, *newval;
> atomic_cas_ptr(ptr, oldval, newval)"
> -check_builtin MemoryBarrier windows.h "MemoryBarrier()"
> check_func sysconf
> check_func sysctl
> check_func usleep
> -check_func_headers io.h setmode
> -check_lib2 "windows.h shellapi.h" CommandLineToArgvW -lshell32
> -check_lib2 "windows.h wincrypt.h" CryptGenRandom -ladvapi32
> -check_lib2 "windows.h psapi.h" GetProcessMemoryInfo -lpsapi
> +
> check_func_headers windows.h GetProcessAffinityMask
> check_func_headers windows.h GetProcessTimes
> check_func_headers windows.h GetSystemTimeAsFileTime
> @@ -3739,6 +3737,12 @@ check_header VideoDecodeAcceleration/VDADecoder.h
> check_header windows.h
> check_header X11/extensions/XvMClib.h
>
> +check_lib2 "windows.h shellapi.h" CommandLineToArgvW -lshell32
> +check_lib2 "windows.h wincrypt.h" CryptGenRandom -ladvapi32
> +check_lib2 "windows.h psapi.h" GetProcessMemoryInfo -lpsapi
probably ok if tested that the other windows check_ld type checks do not
depend on any of this libs being added before.
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
