Re: [libav-devel] [PATCH 05/12] h264: Replace mpegvideo-specific MAX_PICTURE_COUNT by private define

2014-03-05 Thread Anton Khirnov
On Tue, 4 Mar 2014 19:24:35 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- libavcodec/h264.c| 22 +++--- libavcodec/h264.h| 2 ++ libavcodec/h264_ps.c | 2 +- 3 files changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/h264.c

Re: [libav-devel] [PATCH 2/8] resample: fix avresample_get_delay() return value

2014-03-05 Thread Luca Barbato
On 05/03/14 07:50, Anton Khirnov wrote: The correct next input sample is not the first sample of the resampling buffer, but the center sample of the filter_length-sized block at the beginning. Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 3/8] resample: split the nearest neighbour path into a separate function pointer

2014-03-05 Thread Luca Barbato
On 05/03/14 07:50, Anton Khirnov wrote: --- libavresample/resample.c | 26 ++ libavresample/resample_template.c | 13 - 2 files changed, 26 insertions(+), 13 deletions(-) stray space aside looks ok.

Re: [libav-devel] [PATCH 4/8] resample: reindent

2014-03-05 Thread Luca Barbato
On 05/03/14 07:50, Anton Khirnov wrote: --- libavresample/resample_template.c | 41 ++--- 1 file changed, 20 insertions(+), 21 deletions(-) Probably could be folded with the previous. ___ libav-devel mailing

[libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Luca Barbato
Arch specific calls should have an emms_c following to keep the cpu state consistent. Reported-By: wm4 CC: libav-sta...@libav.org --- libavfilter/af_volume.c | 1 + libavfilter/vf_gradfun.c | 1 + libavfilter/vf_hqdn3d.c | 1 + 3 files changed, 3 insertions(+) diff --git

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Kostya Shishkov
On Wed, Mar 05, 2014 at 10:43:24AM +0100, Luca Barbato wrote: Arch specific calls should have an emms_c following to keep the cpu state consistent. Reported-By: wm4 CC: libav-sta...@libav.org --- libavfilter/af_volume.c | 1 + libavfilter/vf_gradfun.c | 1 + libavfilter/vf_hqdn3d.c |

[libav-devel] [PATCH 1/1] arm: hpeldsp: prevent overreads in armv6 asm

2014-03-05 Thread Janne Grunau
Based on a patch by Russel King rmk+li...@arm.linux.org.uk Bug-Id: 646 CC: libav-sta...@libav.org --- libavcodec/arm/hpeldsp_armv6.S | 20 libavutil/arm/asm.S| 7 +++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git

Re: [libav-devel] [PATCH 1/1] arm: hpeldsp: prevent overreads in armv6 asm

2014-03-05 Thread Martin Storsjö
On Wed, 5 Mar 2014, Janne Grunau wrote: Based on a patch by Russel King rmk+li...@arm.linux.org.uk Bug-Id: 646 CC: libav-sta...@libav.org --- libavcodec/arm/hpeldsp_armv6.S | 20 libavutil/arm/asm.S| 7 +++ 2 files changed, 19 insertions(+), 8 deletions(-)

Re: [libav-devel] [PATCH 1/2] vda: Use the current hwaccel1 layout

2014-03-05 Thread Diego Biurrun
On Wed, Mar 05, 2014 at 01:29:59AM +0100, Luca Barbato wrote: --- a/libavcodec/vda.h +++ b/libavcodec/vda.h @@ -125,15 +129,119 @@ struct vda_context { +#if 0 ? Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/2] vda: Use the current hwaccel1 layout

2014-03-05 Thread Luca Barbato
On 05/03/14 13:48, Diego Biurrun wrote: On Wed, Mar 05, 2014 at 01:29:59AM +0100, Luca Barbato wrote: --- a/libavcodec/vda.h +++ b/libavcodec/vda.h @@ -125,15 +129,119 @@ struct vda_context { +#if 0 ? Diego I couldn't find a better place to put the example functions and if the

[libav-devel] [PATCH] af_channelmap: fix ONE_STR mapping mode

2014-03-05 Thread Anton Khirnov
get_channel() returns 0 on success CC:libav-sta...@libav.org --- Indeed, good catch --- libavfilter/af_channelmap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index 71d51e7..3e5cc3d 100644 ---

Re: [libav-devel] [PATCH 1/1] avcodec: guarantee one addtional picture line

2014-03-05 Thread Anton Khirnov
On Tue, 4 Mar 2014 13:01:51 +0100, Janne Grunau janne-li...@jannau.net wrote: Various optimized DSP functions read one line past the aligned picture. Several ARMv6 put_pixels functions in HpelDSPContext load the input of the next line while processing the current one. Explicitly allow this

[libav-devel] [PATCH] x86: dcadsp: Fix linking with yasm and optimizations disabled

2014-03-05 Thread Diego Biurrun
Some optimized functions reference optimized symbols, so the functions must be explicitly disabled when those symbols are unavailable. --- Now with a more general #if, as suggested by James. libavcodec/x86/dcadsp_init.c |4 1 file changed, 4 insertions(+) diff --git

Re: [libav-devel] [RFC] exporting replaygain and other similar metadata

2014-03-05 Thread Anton Khirnov
On Wed, 26 Feb 2014 01:49:14 +0100, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Tue, Feb 25, 2014 at 11:32 AM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Tue, Feb 25, 2014 at 11:27:09AM +0100, Anton Khirnov wrote: On Thu, 20 Feb 2014 00:13:35 +0100, Vittorio Giovara

Re: [libav-devel] [PATCH 1/8] FATE: add tests for more resampling modes

2014-03-05 Thread Diego Biurrun
On Wed, Mar 05, 2014 at 07:50:52AM +0100, Anton Khirnov wrote: --- tests/fate/libavresample.mak | 14 ++ 1 file changed, 14 insertions(+) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Justin Ruggles
On 03/05/2014 04:43 AM, Luca Barbato wrote: diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c index 12d496e..2cdfe23 100644 --- a/libavfilter/af_volume.c +++ b/libavfilter/af_volume.c @@ -262,6 +262,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *buf)

Re: [libav-devel] [PATCH] avformat/rtmppkt: handle extended timestamp field even for one-byte header

2014-03-05 Thread Martin Storsjö
Hi Martin, Thanks for your patch! It looks mostly good - I've added a few comments below. I'll split up your patch in a few smaller patches and resend it to libav-devel@libav.org (and to you so you can verify, I can't test it myself). On Wed, 5 Mar 2014, Martin Panter wrote: From

[libav-devel] [PATCH 3/4] rtmppkt: Properly handle extended timestamps when writing

2014-03-05 Thread Martin Storsjö
From: Martin Panter vadm...@gmail.com --- libavformat/rtmppkt.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index a8432c8..241a521 100644 --- a/libavformat/rtmppkt.c +++

[libav-devel] [PATCH 2/4] rtmppkt: Add a descriptive comment

2014-03-05 Thread Martin Storsjö
From: Martin Panter vadm...@gmail.com --- libavformat/rtmppkt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index fb3726b..a8432c8 100644 --- a/libavformat/rtmppkt.c +++ b/libavformat/rtmppkt.c @@ -194,7 +194,7 @@ static int

[libav-devel] [PATCH 4/4] rtmppkt: Rename the ts_delta field to ts_field

2014-03-05 Thread Martin Storsjö
Based on a suggestion by Martin Panter. This is more descriptive, since it's the actual timestamp field from the RTMP packet, which might or might not be a delta depending on context (in some packets it's a delta, in some packets it's an absolute timestamp, and in some packets it's 0xff to

[libav-devel] [PATCH 1/4] rtmppkt: handle extended timestamp field even for one-byte header

2014-03-05 Thread Martin Storsjö
From: Martin Panter vadm...@gmail.com Related fix in rtmpdump: https://repo.or.cz/w/rtmpdump.git/commitdiff/79459a2 Adobe's RTMP specification (21 Dec 2012), section 5.3.1.3 (Extended Timestamp), says this field is present in Type 3 chunks. Type 3 chunks are those with the one-byte header size.

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Anton Khirnov
On Wed, 05 Mar 2014 08:56:52 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/05/2014 04:43 AM, Luca Barbato wrote: diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c index 12d496e..2cdfe23 100644 --- a/libavfilter/af_volume.c +++ b/libavfilter/af_volume.c @@

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Janne Grunau
On 2014-03-05 15:25:40 +0100, Anton Khirnov wrote: On Wed, 05 Mar 2014 08:56:52 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/05/2014 04:43 AM, Luca Barbato wrote: diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c index 12d496e..2cdfe23 100644 ---

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Kostya Shishkov
On Wed, Mar 05, 2014 at 04:01:15PM +0100, Janne Grunau wrote: On 2014-03-05 15:25:40 +0100, Anton Khirnov wrote: On Wed, 05 Mar 2014 08:56:52 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/05/2014 04:43 AM, Luca Barbato wrote: diff --git a/libavfilter/af_volume.c

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Justin Ruggles
On 03/05/2014 09:25 AM, Anton Khirnov wrote: On Wed, 05 Mar 2014 08:56:52 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/05/2014 04:43 AM, Luca Barbato wrote: diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c index 12d496e..2cdfe23 100644 ---

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Anton Khirnov
On Wed, 05 Mar 2014 10:59:20 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/05/2014 09:25 AM, Anton Khirnov wrote: On Wed, 05 Mar 2014 08:56:52 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/05/2014 04:43 AM, Luca Barbato wrote: diff --git

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Hendrik Leppkes
On Wed, Mar 5, 2014 at 6:11 PM, Anton Khirnov an...@khirnov.net wrote: On Wed, 05 Mar 2014 10:59:20 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On 03/05/2014 09:25 AM, Anton Khirnov wrote: On Wed, 05 Mar 2014 08:56:52 -0500, Justin Ruggles justin.rugg...@gmail.com wrote: On

Re: [libav-devel] [PATCH 2/2] arm: get_cabac inline asm

2014-03-05 Thread Martin Storsjö
On Sun, 2 Mar 2014, Janne Grunau wrote: Based on the aarch64 asm. CPU cycle counts on cortex-a9 compared to gcc 4.8.2: before: 475 decicycles in get_cabac_noinline, 67106035 runs, 2829 skips after: 393 decicycles in get_cabac_noinline, 67106474 runs, 2390 skips Overall speedup is above 2%.

Re: [libav-devel] [PATCH] x86: dcadsp: Fix linking with yasm and optimizations disabled

2014-03-05 Thread Janne Grunau
On 2014-03-05 14:10:24 +0100, Diego Biurrun wrote: Some optimized functions reference optimized symbols, so the functions must be explicitly disabled when those symbols are unavailable. --- Now with a more general #if, as suggested by James. I think --disable-optimizations --disable-sse2

Re: [libav-devel] [PATCH] avfilter: Add missing emms_c when needed

2014-03-05 Thread Tim Walker
On 05 Mar 2014, at 18:29, Hendrik Leppkes h.lepp...@gmail.com wrote: Is it very likely to get MMX code written these days, and not at least SSE/SSE2? Maybe put a notice in float_dsp to warn people. :p - Hendrik How much MMX do we still have? Port it to SSE* and drop support for it :P

[libav-devel] [RFC 0/3] lavf/http: import HTTP implementation from ffmpeg

2014-03-05 Thread Alessandro Ghedini
This imports the HTTP implementation from ffmpeg. It also includes the av_strtok() and av_asprintf() functions (again from ffmpeg) which are necessary to build. Except for the av_strtok() and av_asprintf() patches (for which I used more or less the original patches) I included a list of the IDs

[libav-devel] [RFC 2/3] lavu: add av_strtok()

2014-03-05 Thread Alessandro Ghedini
From: Stefano Sabatini stefa...@gmail.com The function strtok_r() is part of the POSIX.1 specification, but is not available on some platforms. We provide an internal implementation, so we do not need to rely on a platform implementation. --- doc/APIchanges | 3 +++ libavutil/avstring.c |

[libav-devel] [RFC 3/3] lavf/http: import HTTP implementation from ffmpeg

2014-03-05 Thread Alessandro Ghedini
This patch imports the HTTP implementation from ffmpeg. Incomplete list of new features and fixes: * Support for HTTP seeking (intial ffmpeg commit e05655f) * Custom user agent (initial ffmpeg commit 2bb1c71) * Support for reading ICY metadata (initial ffmpeg commit a92fbe1) * Support for

[libav-devel] [RFC 1/3] lavu: add av_asprintf()

2014-03-05 Thread Alessandro Ghedini
From: Clément Bœsch ubi...@gmail.com --- doc/APIchanges | 3 +++ libavutil/avstring.c | 26 ++ libavutil/avstring.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 40 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index

Re: [libav-devel] [PATCH] x86: dcadsp: Fix linking with yasm and optimizations disabled

2014-03-05 Thread Diego Biurrun
On Wed, Mar 05, 2014 at 08:12:27PM +0100, Janne Grunau wrote: On 2014-03-05 14:10:24 +0100, Diego Biurrun wrote: Some optimized functions reference optimized symbols, so the functions must be explicitly disabled when those symbols are unavailable. --- Now with a more general #if, as

[libav-devel] [PATCH 2/5] mxf: Set audio packets pts

2014-03-05 Thread Luca Barbato
From: Matthieu Bouron matthieu.bou...@gmail.com Extrapolate audio timestamps based on the number of samples demuxed. Deal with some MXF nastiness involving fractional number of samples per EditUnit when seeking (the specs handwave this away). Further fixes from Tomas Härdin. Signed-off-by:

[libav-devel] [PATCH 5/5] mxf: Return meaningful errors

2014-03-05 Thread Luca Barbato
--- libavformat/mxfdec.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index dcae26d..27f996f 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2263,17 +2263,18 @@ static int

[libav-devel] [PATCH 3/5] mxf: Handle identification metadata

2014-03-05 Thread Luca Barbato
From: Matthieu Bouron matthieu.bou...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavformat/mxfdec.c | 115 +++ 1 file changed, 115 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 8591f69..d8bfb46

[libav-devel] Pending mxf patches

2014-03-05 Thread Luca Barbato
After those I will try to make easier to hack this codebase in various ways e.g it is completely wasteful having 3 different formats to describe 16 byte strings and none of them match the specifications. ___ libav-devel mailing list

[libav-devel] [PATCH 1/5] mxf: Introduce ff_mxf_get_samples_per_frame

2014-03-05 Thread Luca Barbato
From: Matthieu Bouron matthieu.bou...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavformat/mxf.c | 40 libavformat/mxf.h | 7 +++ 2 files changed, 47 insertions(+) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index

[libav-devel] [PATCH 4/5] mxf: Parse random index pack

2014-03-05 Thread Luca Barbato
From: Paul B Mahol one...@gmail.com Get the last partition offset and use it when footer partition offset is missing. Footer partition may not be present and even if present footer partition offset may not be set in any partition except last one. Signed-off-by: Luca Barbato lu_z...@gentoo.org

Re: [libav-devel] [PATCH 10/12] mpegvideo: move ff_draw_horiz_band() in utils.c

2014-03-05 Thread Diego Biurrun
On Tue, Mar 04, 2014 at 07:24:40PM +0100, Vittorio Giovara wrote: --- libavcodec/internal.h | 7 +++ libavcodec/mpegvideo.c | 50 --- libavcodec/mpegvideo.h | 3 --- libavcodec/utils.c | 53

Re: [libav-devel] [PATCH 3/4] float_dsp: add test program for float dsp

2014-03-05 Thread Diego Biurrun
On Tue, Mar 04, 2014 at 12:42:09AM +0100, Janne Grunau wrote: Not hooked up to FATE due to fear of random failures due to float instability. Why don't you try it on Oracle? Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 3/4] float_dsp: add test program for float dsp

2014-03-05 Thread Anton Khirnov
On Tue, 4 Mar 2014 00:42:09 +0100, Janne Grunau janne-li...@jannau.net wrote: Not hooked up to FATE due to fear of random failures due to float instability. float_dsp-test: use 16 * 3 * 5 as length --- libavutil/Makefile| 1 + libavutil/float_dsp.c | 274

Re: [libav-devel] [PATCH 4/5] mxf: Parse random index pack

2014-03-05 Thread Anton Khirnov
On Wed, 5 Mar 2014 23:26:27 +0100, Luca Barbato lu_z...@gentoo.org wrote: From: Paul B Mahol one...@gmail.com Get the last partition offset and use it when footer partition offset is missing. Footer partition may not be present and even if present footer partition offset may not be set

Re: [libav-devel] [PATCH 5/5] mxf: Return meaningful errors

2014-03-05 Thread Anton Khirnov
On Wed, 5 Mar 2014 23:26:28 +0100, Luca Barbato lu_z...@gentoo.org wrote: --- libavformat/mxfdec.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) This one has also been approved previously -- did you change anything? -- Anton Khirnov

Re: [libav-devel] [PATCH 1/5] mxf: Introduce ff_mxf_get_samples_per_frame

2014-03-05 Thread Anton Khirnov
On Wed, 5 Mar 2014 23:26:24 +0100, Luca Barbato lu_z...@gentoo.org wrote: From: Matthieu Bouron matthieu.bou...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavformat/mxf.c | 40 libavformat/mxf.h | 7 +++ 2 files changed,

Re: [libav-devel] [PATCH 2/5] mxf: Set audio packets pts

2014-03-05 Thread Anton Khirnov
On Wed, 5 Mar 2014 23:26:25 +0100, Luca Barbato lu_z...@gentoo.org wrote: From: Matthieu Bouron matthieu.bou...@gmail.com Extrapolate audio timestamps based on the number of samples demuxed. Deal with some MXF nastiness involving fractional number of samples per EditUnit when seeking

Re: [libav-devel] [PATCH 3/5] mxf: Handle identification metadata

2014-03-05 Thread Anton Khirnov
On Wed, 5 Mar 2014 23:26:26 +0100, Luca Barbato lu_z...@gentoo.org wrote: From: Matthieu Bouron matthieu.bou...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavformat/mxfdec.c | 115 +++ 1 file changed, 115 insertions(+)

Re: [libav-devel] [PATCH 4/4] rtmppkt: Rename the ts_delta field to ts_field

2014-03-05 Thread Anton Khirnov
From a quick look there's nothing obviously wrong with the set. So if you think it's ok, feel free to push. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] vf_shuffleplanes: fix the type of the mapping indices

2014-03-05 Thread Anton Khirnov
They are TYPE_INT AVOptions, so they must be ints --- libavfilter/vf_shuffleplanes.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_shuffleplanes.c b/libavfilter/vf_shuffleplanes.c index 8422d2f..1bc77b0 100644 --- a/libavfilter/vf_shuffleplanes.c +++

Re: [libav-devel] [RFC 3/3] lavf/http: import HTTP implementation from ffmpeg

2014-03-05 Thread Martin Storsjö
On Wed, 5 Mar 2014, Alessandro Ghedini wrote: This patch imports the HTTP implementation from ffmpeg. Incomplete list of new features and fixes: * Support for HTTP seeking (intial ffmpeg commit e05655f) * Custom user agent (initial ffmpeg commit 2bb1c71) * Support for reading ICY metadata