Re: [libav-devel] [PATCH 1/2] aac: Don't fail if channels aren't known yet

2015-06-03 Thread Timothy Gu
On Wed, Jun 3, 2015 at 11:32 PM Luca Barbato wrote: > On 04/06/15 07:42, nu774 wrote: > > (backport from ffmpeg) > Proper authorship would be appreciated. > > --- > > libavcodec/aacdec.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c

Re: [libav-devel] [PATCH 1/2] aac: Don't fail if channels aren't known yet

2015-06-03 Thread nu774
This one works for both patches. https://lists.libav.org/pipermail/libav-devel/2015-June/069933.html If first patch is applied, this sample can be decoded with -request_channel_layout 0x8000 option specified, but still fails without it. If second patch is also applied, it can be dec

Re: [libav-devel] [PATCH 2/2] aac: correctly map 7.1ch-wide AAC from FDK AAC encoder

2015-06-03 Thread Luca Barbato
On 04/06/15 07:45, nu774 wrote: > Sample file for this: > https://dl.dropboxusercontent.com/u/76042064/FDK_7.1ch_wide.aac Thanks! I'd candidate this set and the previous to go to stable. lu ___ libav-devel mailing list libav-devel@libav.org https://li

Re: [libav-devel] [PATCH 1/2] aac: Don't fail if channels aren't known yet

2015-06-03 Thread Luca Barbato
On 04/06/15 07:42, nu774 wrote: > Required to decode ADTS AAC with custom channel config (0). > (backport from ffmpeg) > --- > libavcodec/aacdec.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c > index 0c7e2c4..f2873b1 100644 > --- a/libavcod

Re: [libav-devel] [PATCH 2/2] aac: correctly map 7.1ch-wide AAC from FDK AAC encoder

2015-06-03 Thread nu774
Sample file for this: https://dl.dropboxusercontent.com/u/76042064/FDK_7.1ch_wide.aac ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 1/2] aac: Don't fail if channels aren't known yet

2015-06-03 Thread nu774
Required to decode ADTS AAC with custom channel config (0). (backport from ffmpeg) --- libavcodec/aacdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 0c7e2c4..f2873b1 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -184,6 +1

[libav-devel] [PATCH 2/2] aac: correctly map 7.1ch-wide AAC from FDK AAC encoder

2015-06-03 Thread nu774
FDK AAC encoder outputs SCE(front)+CPE(front)+CPE(back)+CPE(back) on MODE_7_1_REAR_SURROUND configuration. Since decoder couldn't properly map 4 back channels, decoding failed unless -request_channel_layout 0x8000 has been specified. Now we treat first CPE(back) as CPE(side) on channel

[libav-devel] [PATCH] mpjpeg: Initial implementation

2015-06-03 Thread Luca Barbato
Support only streams with Content-Length. Signed-off-by: Luca Barbato --- Now w/out a custom get_line. libavformat/Makefile | 1 + libavformat/allformats.c | 2 +- libavformat/mpjpegdec.c | 223 +++ 3 files changed, 225 insertions(+), 1 dele

Re: [libav-devel] [PATCH 2/7] rtspdec: Always initialize rbuf arrarys

2015-06-03 Thread Vittorio Giovara
On Wed, Jun 3, 2015 at 6:51 PM, Martin Storsjö wrote: > On Wed, 3 Jun 2015, Vittorio Giovara wrote: > >> CC: libav-sta...@libav.org >> Bug-Id: CID 732301 >> --- >> libavformat/rtspdec.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/rtspdec.c b/libavform

Re: [libav-devel] [PATCH] libvpx: Support all pixel formats available in encoding and decoding

2015-06-03 Thread Luca Barbato
On 03/06/15 19:39, James Almer wrote: > On 03/06/15 11:29 AM, Luca Barbato wrote: >> On 31/05/15 17:01, Luca Barbato wrote: >>> On 27/05/15 22:25, James Almer wrote: Yes, that plus a considerable amount of ifdeffery in the code. It will be ugly, but i also think it's worth keeping compati

Re: [libav-devel] [PATCH 7/7] [RFC] rtpenc: Avoid a NULL pointer access

2015-06-03 Thread Martin Storsjö
On Wed, 3 Jun 2015, Martin Storsjö wrote: On Wed, 3 Jun 2015, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1035715 --- libavformat/rtpenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 6158934..55a3820 100644 --- a/l

Re: [libav-devel] [PATCH 7/7] [RFC] rtpenc: Avoid a NULL pointer access

2015-06-03 Thread Vittorio Giovara
On Wed, Jun 3, 2015 at 6:56 PM, Martin Storsjö wrote: > On Wed, 3 Jun 2015, Vittorio Giovara wrote: > >> CC: libav-sta...@libav.org >> Bug-Id: CID 1035715 >> --- >> libavformat/rtpenc.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c >> in

Re: [libav-devel] [PATCH 1/7] stcp: Always initialize outmsg struct

2015-06-03 Thread Martin Storsjö
On Wed, 3 Jun 2015, Luca Barbato wrote: 1-6 -> Ok 7 -> I guess should be an error. Martin, do you agree? Nope, there are a few issues with the patches, and 7 is outright wrong. // Martin ___ libav-devel mailing list libav-devel@libav.org https://li

Re: [libav-devel] [PATCH 7/7] [RFC] rtpenc: Avoid a NULL pointer access

2015-06-03 Thread Martin Storsjö
On Wed, 3 Jun 2015, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1035715 --- libavformat/rtpenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 6158934..55a3820 100644 --- a/libavformat/rtpenc.c +++ b/libavformat/rtpenc

Re: [libav-devel] [PATCH 6/7] rtpdec_asf: Check memory allocation and free memory on error

2015-06-03 Thread Martin Storsjö
On Wed, 3 Jun 2015, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1257774 --- libavformat/rtpdec_asf.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Ok I think. // Martin ___ libav-devel mailing list libav-devel

Re: [libav-devel] [PATCH 2/7] rtspdec: Always initialize rbuf arrarys

2015-06-03 Thread Martin Storsjö
On Wed, 3 Jun 2015, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 732301 --- libavformat/rtspdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 6c92c69..d69a9c5 100644 --- a/libavformat/rtspdec.c +++ b

Re: [libav-devel] [PATCH] configure: Provide an option to override the environment

2015-06-03 Thread Martin Storsjö
On Wed, 3 Jun 2015, Diego Biurrun wrote: On Tue, May 12, 2015 at 01:24:40PM +0300, Martin Storsjö wrote: On Tue, 12 May 2015, Diego Biurrun wrote: >On Tue, May 12, 2015 at 12:34:25AM +0200, Luca Barbato wrote: >>On 11/05/15 23:09, Diego Biurrun wrote: >>>On Wed, May 06, 2015 at 01:37:31PM +0200

Re: [libav-devel] [PATCH] libvpx: Support all pixel formats available in encoding and decoding

2015-06-03 Thread James Almer
On 03/06/15 11:29 AM, Luca Barbato wrote: > On 31/05/15 17:01, Luca Barbato wrote: >> On 27/05/15 22:25, James Almer wrote: >>> Yes, that plus a considerable amount of ifdeffery in the code. It >>> will be ugly, but i also think it's worth keeping compatibility with >>> at least 1.3.0 >>> >> >> 1.3

Re: [libav-devel] [PATCH 11/13] lavc: Replace every instance of coded_frame with AVPacketCodingParams

2015-06-03 Thread Luca Barbato
On 20/05/15 03:09, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- Seems fine. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 10/13] lavc: Gather all coded_frame allocation and free functions to a single place

2015-06-03 Thread Luca Barbato
On 20/05/15 03:09, Vittorio Giovara wrote: > Allocating coded_frame is what most encoders do anyway, so it makes > sense to always allocate it in a single place. This bring uniformity to > encoder behaviour and prevents applications from erroneusly accessing > this field when not allocated. > > Ad

Re: [libav-devel] [PATCH 01/13] Introduce AVPacketCodingParams to carry compression parameters

2015-06-03 Thread Diego Biurrun
On Sun, May 31, 2015 at 11:29:39PM +0200, Vittorio Giovara wrote: > On Wed, May 20, 2015 at 1:21 PM, Diego Biurrun wrote: > > On Wed, May 20, 2015 at 02:08:55AM +0100, Vittorio Giovara wrote: > >> --- a/libavcodec/internal.h > >> +++ b/libavcodec/internal.h > >> @@ -219,6 +219,11 @@ int ff_side_da

Re: [libav-devel] [PATCH 13/13] Deprecate avctx.coded_frame

2015-06-03 Thread Luca Barbato
On 20/05/15 03:09, Vittorio Giovara wrote: > + * @deprecated use AVStats side data instead The documentation should be updated in this regard? lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 09/13] qtrleenc: Keep coded_frame.key_frame a write-only variable

2015-06-03 Thread Luca Barbato
On 20/05/15 03:09, Vittorio Giovara wrote: > --- > libavcodec/qtrleenc.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-deve

Re: [libav-devel] [PATCH 08/13] libtheoraenc: Keep coded_frame.key_frame a write-only variable

2015-06-03 Thread Luca Barbato
On 20/05/15 03:09, Vittorio Giovara wrote: > --- > libavcodec/libtheoraenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c > index 462bc94..3781043 100644 > --- a/libavcodec/libtheoraenc.c > +++ b/libavcodec/libtheor

Re: [libav-devel] [PATCH 06/13] svq1enc: Do not entangle coded_frame

2015-06-03 Thread Luca Barbato
On 20/05/15 03:09, Vittorio Giovara wrote: > Just save the fields needed for encoding. > --- > libavcodec/svq1enc.c | 32 +--- > libavcodec/svq1enc.h | 4 > 2 files changed, 21 insertions(+), 15 deletions(-) > Ok. ___

Re: [libav-devel] [PATCH 07/13] ffv1enc: Keep coded_frame.key_frame a write-only variable

2015-06-03 Thread Luca Barbato
On 20/05/15 03:09, Vittorio Giovara wrote: > --- > libavcodec/ffv1.h| 1 + > libavcodec/ffv1enc.c | 11 ++- > 2 files changed, 7 insertions(+), 5 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.or

Re: [libav-devel] [PATCH 04/13] libvpxenc: Do not entangle coded_frame

2015-06-03 Thread Luca Barbato
On 20/05/15 03:08, Vittorio Giovara wrote: > Keep coded_frame.key_frame a write-only variable. > --- > libavcodec/libvpxenc.c | 19 +-- > 1 file changed, 9 insertions(+), 10 deletions(-) > Fine for me. ___ libav-devel mailing list liba

Re: [libav-devel] [PATCH 05/13] proresenc: Do not entangle coded_frame

2015-06-03 Thread Luca Barbato
On 20/05/15 03:08, Vittorio Giovara wrote: > This is similar to what other encoders employ. > --- > libavcodec/proresenc.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > Fine for me. ___ libav-devel mailing list libav-devel@

Re: [libav-devel] [PATCH 1/4] mpegvideo: Move various temporary buffers to a separate context

2015-06-03 Thread Luca Barbato
On 31/05/15 15:49, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 4 ++-- > libavcodec/mpegvideo.c| 49 > ++- > libavcodec/mpegvideo.h| 13 > libavcodec/mpegvideo_enc.c| 14 ++--- > libavcodec/mpegv

Re: [libav-devel] [PATCH] libvpx: Support all pixel formats available in encoding and decoding

2015-06-03 Thread Luca Barbato
On 31/05/15 17:01, Luca Barbato wrote: > On 27/05/15 22:25, James Almer wrote: >> Yes, that plus a considerable amount of ifdeffery in the code. It >> will be ugly, but i also think it's worth keeping compatibility with >> at least 1.3.0 >> > > 1.3.0 explodes on 422p that at least in theory should

Re: [libav-devel] [PATCH] configure: Provide an option to override the environment

2015-06-03 Thread Diego Biurrun
On Tue, May 12, 2015 at 01:24:40PM +0300, Martin Storsjö wrote: > On Tue, 12 May 2015, Diego Biurrun wrote: > >On Tue, May 12, 2015 at 12:34:25AM +0200, Luca Barbato wrote: > >>On 11/05/15 23:09, Diego Biurrun wrote: > >>>On Wed, May 06, 2015 at 01:37:31PM +0200, Luca Barbato wrote: > Useful to

Re: [libav-devel] [PATCH 1/7] stcp: Always initialize outmsg struct

2015-06-03 Thread Luca Barbato
1-6 -> Ok 7 -> I guess should be an error. Martin, do you agree? ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 3/7] audiointerleave: Always initialize new_pkt

2015-06-03 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 609333 --- libavformat/audiointerleave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/audiointerleave.c b/libavformat/audiointerleave.c index ba78d4e..fd07893 100644 --- a/libavformat/audiointerleave.c +++ b/libavformat/audi

[libav-devel] [PATCH 4/7] jack: Check memory allocation

2015-06-03 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 1292520 --- libavdevice/jack.c | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/jack.c b/libavdevice/jack.c index 5d000a3..aa9348d 100644 --- a/libavdevice/jack.c +++ b/libavdevice/jack.c @@ -202,6 +202,10 @@ static int start_jack(AVFormatC

[libav-devel] [PATCH 6/7] rtpdec_asf: Check memory allocation and free memory on error

2015-06-03 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 1257774 --- libavformat/rtpdec_asf.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec_asf.c b/libavformat/rtpdec_asf.c index 3ca3f71..597f29f 100644 --- a/libavformat/rtpdec_asf.c +++ b/libavformat/rtpdec_as

[libav-devel] [PATCH 7/7] [RFC] rtpenc: Avoid a NULL pointer access

2015-06-03 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 1035715 --- libavformat/rtpenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 6158934..55a3820 100644 --- a/libavformat/rtpenc.c +++ b/libavformat/rtpenc.c @@ -558,6 +558,10 @@ static int rtp_write_

[libav-devel] [PATCH 1/7] stcp: Always initialize outmsg struct

2015-06-03 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 1302711 --- libavformat/sctp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/sctp.c b/libavformat/sctp.c index 71b3a4b..57fd044 100644 --- a/libavformat/sctp.c +++ b/libavformat/sctp.c @@ -116,7 +116,7 @@ static int ff_sctp_r

[libav-devel] [PATCH 2/7] rtspdec: Always initialize rbuf arrarys

2015-06-03 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 732301 --- libavformat/rtspdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 6c92c69..d69a9c5 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -143,7 +143,7 @@ st

[libav-devel] [PATCH 5/7] mov: Check memory allocation

2015-06-03 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 1292518 --- libavformat/mov.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 80681b7..f603446 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1661,7 +1661,11 @@ static int mov_fi

Re: [libav-devel] [PATCH] bink: Factorize bink put_pixel

2015-06-03 Thread Vittorio Giovara
On Wed, Jun 3, 2015 at 1:43 AM, Luca Barbato wrote: > And make sure to check INTER_BLOCK as had been fixed by Michael > Niedermayer. > > Reported-By: Andreas Cadhalpun > CC: libav-sta...@libav.org > --- > > I'll stab bink.c a little more later once I'm awake =p > > libavcodec/bink.c | 55 > +

Re: [libav-devel] [PATCH 2/2] configure: Check for DXVA2_ConfigPictureDecode instead of LPDIRECT3DSURFACE9

2015-06-03 Thread Martin Storsjö
On Tue, 2 Jun 2015, Martin Storsjö wrote: Checking this struct is a bit more natural for this dependency. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index e8cd1f1..96a97df 100755 --- a/configure +++ b/configure @@ -1981,7 +1981,7 @@

Re: [libav-devel] [PATCH] fix an issue on multichannel ADTS AAC with non-zero channel_config + PCE

2015-06-03 Thread nu774
Looks OK. On 2015/06/03 18:56, Luca Barbato wrote: On 03/06/15 07:01, nu774 wrote: --- libavcodec/aacdec.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) I'll use ``` aac: Correctly map multichannel ADTS AAC with non-zero channel_config + PCE The decoder assigns ch

Re: [libav-devel] [PATCH] fix an issue on multichannel ADTS AAC with non-zero channel_config + PCE

2015-06-03 Thread Luca Barbato
On 03/06/15 07:01, nu774 wrote: > --- > libavcodec/aacdec.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > I'll use ``` aac: Correctly map multichannel ADTS AAC with non-zero channel_config + PCE The decoder assigns channels using default channel configuration for 5.1

Re: [libav-devel] [PATCH] fix an issue on multichannel ADTS AAC with non-zero channel_config + PCE

2015-06-03 Thread Hendrik Leppkes
On Wed, Jun 3, 2015 at 9:30 AM, nu774 wrote: > Hi, > >> Is it ok to make a fate-test out of it? > > > Well, are you asking if it is allowed to include that sample in the source > distribution for > testing purpose? > Personally, I don't care... but I'm not the copyright holder of the > broadcasted

Re: [libav-devel] [PATCH] fix an issue on multichannel ADTS AAC with non-zero channel_config + PCE

2015-06-03 Thread nu774
Hi, Is it ok to make a fate-test out of it? Well, are you asking if it is allowed to include that sample in the source distribution for testing purpose? Personally, I don't care... but I'm not the copyright holder of the broadcasted material who can grant permission on it. On 2015/06/03 1