Re: [libav-devel] [PATCH] nvenc: add initial QP value options for I, P and B pictures.

2017-03-06 Thread Konda Raju
I changed the code as per you suggestion and also fixed the config errors. Please review the attached patch. Thanks and regards, Konda Raju -Original Message- From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Diego Biurrun Sent: Monday, February 27, 2017 7:48 PM

Re: [libav-devel] [PATCH] pixlet: Fix architecture-dependent code and values

2017-03-06 Thread Vittorio Giovara
On Thu, Mar 2, 2017 at 4:34 PM, Vittorio Giovara wrote: > @@ -389,29 +387,29 @@ static void filterfn(int16_t *dest, int16_t *tmp, > size_t size, float SCALE) > } > > for (i = 0; i < hsize; i++) { > -value = low [i + 1] * -0.07576144003329376f + > -

Re: [libav-devel] [PATCH] build: Make x86 assembler commandline-selectable

2017-03-06 Thread Martin Storsjö
On Thu, 2 Mar 2017, Diego Biurrun wrote: --- Moved the command line selection before changing the default. configure | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/configure b/configure index a58ef1c..e2823d1 100755 --- a/configure +++

Re: [libav-devel] [PATCH] configure: Check for -no_weak_imports in ldflags on macOS

2017-03-06 Thread Sean McGovern
Hi Martin, On Mar 6, 2017 16:15, "Martin Storsjö" wrote: From: Luca Barbato Recent versions of macOS provide more posix API (in particular, clock_gettime) than previous versions and recent Apple toolchains provide all that API, even when targeting older

Re: [libav-devel] [PATCH] configure: Check for -no_weak_imports in ldflags on macOS

2017-03-06 Thread Luca Barbato
On 06/03/2017 22:15, Martin Storsjö wrote: > From: Luca Barbato > > Recent versions of macOS provide more posix API (in particular, > clock_gettime) than previous versions and recent Apple toolchains > provide all that API, even when targeting older releases without > said

[libav-devel] [PATCH] configure: Check for -no_weak_imports in ldflags on macOS

2017-03-06 Thread Martin Storsjö
From: Luca Barbato Recent versions of macOS provide more posix API (in particular, clock_gettime) than previous versions and recent Apple toolchains provide all that API, even when targeting older releases without said API. Disallow linking to functions which might not be

Re: [libav-devel] [PATCH] configure: Fix logic of clock_gettime() check

2017-03-06 Thread Luca Barbato
On 06/03/2017 19:39, Diego Biurrun wrote: > Bug 1033 is on OS X, I have no way to test this .. Drop the Bug-Id, it is not related to that. Patch good nonetheless. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] configure: Add -no_weak_imports to the ldflags for MacOS

2017-03-06 Thread Diego Biurrun
On Mon, Mar 06, 2017 at 08:21:19PM +0100, Luca Barbato wrote: > Recent version of MacOS provide more posix API that the previous > versions and recent toolchains do not fail the check even if > they are supposed to target an older version without this flag. configure: Add -no_weak_imports to

[libav-devel] [PATCH] configure: Add -no_weak_imports to the ldflags for MacOS

2017-03-06 Thread Luca Barbato
Recent version of MacOS provide more posix API that the previous versions and recent toolchains do not fail the check even if they are supposed to target an older version without this flag. Bug-Id: 1033 CC: libav-sta...@libav.org --- configure | 2 +- 1 file changed, 1 insertion(+), 1

Re: [libav-devel] [PATCH] build: Prefer NASM assembler over YASM

2017-03-06 Thread Luca Barbato
On 06/03/2017 18:45, Diego Biurrun wrote: > Added a note to the changelog on how to restore old behavior. Sounds good. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] configure: Fix logic of clock_gettime() check

2017-03-06 Thread Diego Biurrun
We should only check for clock_gettime() if _POSIX_MONOTONIC_CLOCK is available and do a full link check for clock_gettime() in all cases. Bug-Id: 1033 --- Bug 1033 is on OS X, I have no way to test this .. configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[libav-devel] [PATCH] build: Prefer NASM assembler over YASM

2017-03-06 Thread Diego Biurrun
NASM is more actively maintained and permits generating dependency information as a sideeffect of assembling, thus cutting build times in half. --- Added a note to the changelog on how to restore old behavior. .travis.yml | 4 ++-- Changelog| 2 ++ configure|

Re: [libav-devel] [PATCH] build: Special-case handling of SDL CFLAGS

2017-03-06 Thread Martin Storsjö
On Thu, 2 Mar 2017, Diego Biurrun wrote: SDL adds some "special" CFLAGS that interfere with building normal binaries. Capture those CFLAGS separately and avoid adding them to the general CFLAGS. --- configure | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/configure

Re: [libav-devel] [PATCH 25/25] lavfi: Add OpenCL overlay filter

2017-03-06 Thread Luca Barbato
On 06/03/2017 11:15, Mark Thompson wrote: > Change to vf_program_opencl, then? I don't really mind. If it is fine for you, that's good :) lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 20/25] lavu: OpenCL hwcontext implementation

2017-03-06 Thread Luca Barbato
On 06/03/2017 10:43, wm4 wrote: > Isn't OpenCL technically provided by the driver, which makes the > licensing questionable, but is usually not an issue because it's > considered a system-provided thing? There are multiple OpenCL implementations, usually they are provided by the driver,

Re: [libav-devel] [PATCH] avcodec: clarify some decoding/encoding API details

2017-03-06 Thread Diego Biurrun
On Mon, Mar 06, 2017 at 11:34:20AM +0100, wm4 wrote: > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -161,7 +168,22 @@ > * and will result in arbitrary behavior. > * > * Some codecs might require using the new API; using the old API will return > - * an error when calling it.

[libav-devel] [PATCH] avcodec: clarify some decoding/encoding API details

2017-03-06 Thread wm4
Make it clear that there is no timing-dependent behavior. In particular, there is no state in which both input and output are denied, and where you have to wait for a while yourself to make progress (apparently some hardware decoders like to do this). Avoid wording that makes references to time.

Re: [libav-devel] [PATCH 20/25] lavu: OpenCL hwcontext implementation

2017-03-06 Thread Mark Thompson
On 06/03/17 09:43, wm4 wrote: > On Mon, 6 Mar 2017 10:38:53 +0100 > Luca Barbato wrote: > >> On 06/03/2017 09:33, Diego Biurrun wrote: >>> On Sat, Mar 04, 2017 at 11:57:47PM +, Mark Thompson wrote: --- a/configure +++ b/configure @@ -1272,6 +1273,7 @@

Re: [libav-devel] [PATCH] build: Special-case handling of SDL CFLAGS

2017-03-06 Thread Diego Biurrun
On Thu, Mar 02, 2017 at 02:57:36PM +0100, Diego Biurrun wrote: > SDL adds some "special" CFLAGS that interfere with building normal > binaries. Capture those CFLAGS separately and avoid adding them to > the general CFLAGS. > --- > configure | 8 +++- > 1 file changed, 7 insertions(+), 1

Re: [libav-devel] [PATCH 25/25] lavfi: Add OpenCL overlay filter

2017-03-06 Thread Mark Thompson
On 06/03/17 08:59, wm4 wrote: > On Mon, 6 Mar 2017 09:37:13 +0100 > Diego Biurrun wrote: > >> On Sat, Mar 04, 2017 at 11:57:52PM +, Mark Thompson wrote: >>> --- a/libavfilter/Makefile >>> +++ b/libavfilter/Makefile >>> @@ -77,6 +77,7 @@ OBJS-$(CONFIG_NULL_FILTER)

Re: [libav-devel] [PATCH 12/25] hwcontext: Add frame context mapping for nontrivial contexts

2017-03-06 Thread Mark Thompson
On 06/03/17 08:25, Diego Biurrun wrote: > On Sat, Mar 04, 2017 at 11:57:39PM +, Mark Thompson wrote: >> Some frames contexts are not usable without additional format-specific > > "frame context" or "frame's contexts" "frames contexts", as in multiple instances of AVHWFramesContext. >> state

Re: [libav-devel] [PATCH] build: Make x86 assembler commandline-selectable

2017-03-06 Thread Diego Biurrun
On Thu, Mar 02, 2017 at 01:24:10PM +0100, Diego Biurrun wrote: > --- > > Moved the command line selection before changing the default. > > configure | 30 ++ > 1 file changed, 22 insertions(+), 8 deletions(-) ping Diego

Re: [libav-devel] [PATCH 02/25] hwcontext: Make it easier to work with device types

2017-03-06 Thread Mark Thompson
On 06/03/17 08:13, wm4 wrote: > On Sat, 4 Mar 2017 23:57:29 + > Mark Thompson wrote: > >> Adds functions to convert to/from strings and a function to iterate >> over all supported device types. Also adds a new invalid type >> AV_HWDEVICE_TYPE_NONE, which acts as a sentinel

Re: [libav-devel] [PATCH] avcodec: clarify some decoding/encoding API details

2017-03-06 Thread Diego Biurrun
On Mon, Mar 06, 2017 at 10:38:12AM +0100, wm4 wrote: > --- a/libavcodec/avcodec.h > +++ b/libavcodec/avcodec.h > @@ -161,7 +168,20 @@ > + * A codec is not allowed to return EAGAIN for both sending and receiving. > This > + * would be an invalid state, which could put the codec user into an

Re: [libav-devel] [PATCH 20/25] lavu: OpenCL hwcontext implementation

2017-03-06 Thread wm4
On Mon, 6 Mar 2017 10:38:53 +0100 Luca Barbato wrote: > On 06/03/2017 09:33, Diego Biurrun wrote: > > On Sat, Mar 04, 2017 at 11:57:47PM +, Mark Thompson wrote: > >> --- a/configure > >> +++ b/configure > >> @@ -1272,6 +1273,7 @@ HWACCEL_LIBRARY_LIST=" > >> mmal >

Re: [libav-devel] [PATCH 25/25] lavfi: Add OpenCL overlay filter

2017-03-06 Thread Luca Barbato
On 06/03/2017 09:37, Diego Biurrun wrote: > On Sat, Mar 04, 2017 at 11:57:52PM +, Mark Thompson wrote: >> --- a/libavfilter/Makefile >> +++ b/libavfilter/Makefile >> @@ -77,6 +77,7 @@ OBJS-$(CONFIG_NULL_FILTER) += vf_null.o >> OBJS-$(CONFIG_OPENCL_PROGRAM_FILTER) +=

Re: [libav-devel] [PATCH 20/25] lavu: OpenCL hwcontext implementation

2017-03-06 Thread Luca Barbato
On 06/03/2017 09:33, Diego Biurrun wrote: > On Sat, Mar 04, 2017 at 11:57:47PM +, Mark Thompson wrote: >> --- a/configure >> +++ b/configure >> @@ -1272,6 +1273,7 @@ HWACCEL_LIBRARY_LIST=" >> mmal >> nvenc >> omx >> +opencl >> vaapi >> vda >> vdpau > > Does

[libav-devel] [PATCH] avcodec: clarify some decoding/encoding API details

2017-03-06 Thread wm4
Make it clear that there is no timing-dependent behavior. In particular, there is no state in which both input and output are denied, and where you have to wait for a while yourself to make progress (apparently some hardware decoders like to do this). Avoid wording that makes references to time.

Re: [libav-devel] [PATCH 25/25] lavfi: Add OpenCL overlay filter

2017-03-06 Thread wm4
On Mon, 6 Mar 2017 09:37:13 +0100 Diego Biurrun wrote: > On Sat, Mar 04, 2017 at 11:57:52PM +, Mark Thompson wrote: > > --- a/libavfilter/Makefile > > +++ b/libavfilter/Makefile > > @@ -77,6 +77,7 @@ OBJS-$(CONFIG_NULL_FILTER) += vf_null.o > >

Re: [libav-devel] [PATCH 25/25] lavfi: Add OpenCL overlay filter

2017-03-06 Thread Diego Biurrun
On Sat, Mar 04, 2017 at 11:57:52PM +, Mark Thompson wrote: > --- a/libavfilter/Makefile > +++ b/libavfilter/Makefile > @@ -77,6 +77,7 @@ OBJS-$(CONFIG_NULL_FILTER) += vf_null.o > OBJS-$(CONFIG_OPENCL_PROGRAM_FILTER) += vf_opencl_program.o opencl.o >

Re: [libav-devel] [PATCH 20/25] lavu: OpenCL hwcontext implementation

2017-03-06 Thread Diego Biurrun
On Sat, Mar 04, 2017 at 11:57:47PM +, Mark Thompson wrote: > --- a/configure > +++ b/configure > @@ -1272,6 +1273,7 @@ HWACCEL_LIBRARY_LIST=" > mmal > nvenc > omx > +opencl > vaapi > vda > vdpau Does opencl have a compatible license? Which one? Diego

Re: [libav-devel] [PATCH 20/25] lavu: OpenCL hwcontext implementation

2017-03-06 Thread wm4
On Sat, 4 Mar 2017 23:57:47 + Mark Thompson wrote: > --- > configure |5 +- > doc/APIchanges |4 + > libavutil/Makefile |2 + > libavutil/hwcontext.c |4 + > libavutil/hwcontext.h |1 + >

Re: [libav-devel] [PATCH 14/25] vf_hwmap: Add device derivation

2017-03-06 Thread Diego Biurrun
On Sat, Mar 04, 2017 at 11:57:41PM +, Mark Thompson wrote: > --- a/libavfilter/vf_hwmap.c > +++ b/libavfilter/vf_hwmap.c > @@ -59,30 +61,61 @@ static int hwmap_config_output(AVFilterLink *outlink) > -if (err < 0) > +if (err < 0) { > +av_log(avctx,

Re: [libav-devel] [PATCH 12/25] hwcontext: Add frame context mapping for nontrivial contexts

2017-03-06 Thread Diego Biurrun
On Sat, Mar 04, 2017 at 11:57:39PM +, Mark Thompson wrote: > Some frames contexts are not usable without additional format-specific "frame context" or "frame's contexts" > state in hwctx. This adds new functions map_frames_from and > map_frames_to to set this up appropriately when deriving

Re: [libav-devel] [PATCH 02/25] hwcontext: Make it easier to work with device types

2017-03-06 Thread wm4
On Sat, 4 Mar 2017 23:57:29 + Mark Thompson wrote: > Adds functions to convert to/from strings and a function to iterate > over all supported device types. Also adds a new invalid type > AV_HWDEVICE_TYPE_NONE, which acts as a sentinel value. > --- > libavutil/hwcontext.c |