Re: [libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Vittorio Giovara
On Fri, Mar 24, 2017 at 10:44 PM, Luca Barbato wrote: > On 24/03/2017 18:36, Sean McGovern wrote: >> Fixes invalid reads with corrupted files. >> >> CC: libav-sta...@libav.org >> Bug-Id: 1039 >> --- >> libavformat/nsvdec.c | 7 +-- >> 1 file changed, 5 insertions(+), 2

Re: [libav-devel] [PATCH] vc1_pred: Fix undefined negative shifts

2017-03-24 Thread Luca Barbato
On 24/03/2017 19:46, Vittorio Giovara wrote: > From: Michael Niedermayer > > Signed-off-by: Vittorio Giovara > --- > libavcodec/vc1_pred.c | 28 > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git

Re: [libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Luca Barbato
On 24/03/2017 18:36, Sean McGovern wrote: > Fixes invalid reads with corrupted files. > > CC: libav-sta...@libav.org > Bug-Id: 1039 > --- > libavformat/nsvdec.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c > index

Re: [libav-devel] [PATCH] [RFC] configure: Disable inline assembly for PathScale compilers

2017-03-24 Thread Martin Storsjö
On Fri, 24 Mar 2017, Diego Biurrun wrote: These compilers pass the inline assembly check, but fail to compile our inline assembly in various ways. --- Martin, better log message welcome :) configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index

Re: [libav-devel] [PATCH] configure: Skip check for inline assembly capabilities when explicitly disabled

2017-03-24 Thread Martin Storsjö
On Fri, 24 Mar 2017, Diego Biurrun wrote: Otherwise inline assembly may get enabled when disabled on the command line. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 366520c..d9609fc 100755 --- a/configure +++ b/configure @@ -4251,7

Re: [libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Sean McGovern
Hi Diego, On Fri, Mar 24, 2017 at 3:35 PM, Diego Biurrun wrote: > On Fri, Mar 24, 2017 at 03:31:26PM -0400, Sean McGovern wrote: >> --- a/libavformat/nsvdec.c >> +++ b/libavformat/nsvdec.c >> @@ -571,7 +572,10 @@ null_chunk_retry: >> if (vsize && st[NSV_ST_VIDEO]) { >>

Re: [libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Diego Biurrun
On Fri, Mar 24, 2017 at 03:31:26PM -0400, Sean McGovern wrote: > --- a/libavformat/nsvdec.c > +++ b/libavformat/nsvdec.c > @@ -571,7 +572,10 @@ null_chunk_retry: > if (vsize && st[NSV_ST_VIDEO]) { > nst = st[NSV_ST_VIDEO]->priv_data; > pkt = >ahead[NSV_ST_VIDEO]; > -

[libav-devel] [PATCH] [RFC] configure: Disable inline assembly for PathScale compilers

2017-03-24 Thread Diego Biurrun
These compilers pass the inline assembly check, but fail to compile our inline assembly in various ways. --- Martin, better log message welcome :) configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index d9609fc..2d84700 100755 --- a/configure +++ b/configure @@

[libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Sean McGovern
Fixes invalid reads with corrupted files. CC: libav-sta...@libav.org Bug-Id: 1039 --- libavformat/nsvdec.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c index c91d2a1..640fb3b 100644 --- a/libavformat/nsvdec.c +++

[libav-devel] [PATCH] configure: Skip check for inline assembly capabilities when explicitly disabled

2017-03-24 Thread Diego Biurrun
Otherwise inline assembly may get enabled when disabled on the command line. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 366520c..d9609fc 100755 --- a/configure +++ b/configure @@ -4251,7 +4251,7 @@ EOF sym=$($nm $TMPO | awk

Re: [libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Sean McGovern
Hi Vittorio On Fri, Mar 24, 2017 at 2:43 PM, Vittorio Giovara wrote: > On Fri, Mar 24, 2017 at 6:36 PM, Sean McGovern wrote: >> Fixes invalid reads with corrupted files. >> >> CC: libav-sta...@libav.org >> Bug-Id: 1039 >> --- >>

[libav-devel] [PATCH 2/3] ifdef update_thread/init_thread functions away if threads are disabled

2017-03-24 Thread Diego Biurrun
This silences a bunch of warnings with threads disabled. --- libavcodec/exr.c | 2 ++ libavcodec/h264dec.c | 2 ++ libavcodec/huffyuvdec.c| 2 ++ libavcodec/mdec.c | 2 ++ libavcodec/mimic.c | 2 ++ libavcodec/mpeg12dec.c | 2 ++ libavcodec/mpeg4videodec.c

[libav-devel] [PATCH 3/3] thread: Define ff_mutex_* macros as empty when threads are disabled

2017-03-24 Thread Diego Biurrun
This silences a bunch of warnings with threads disabled. --- libavutil/thread.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/thread.h b/libavutil/thread.h index cf0fbdd..d107964 100644 --- a/libavutil/thread.h +++ b/libavutil/thread.h @@ -48,10 +48,10 @@

[libav-devel] [PATCH 1/3] takdec: Use ISO C printf conversion specifiers where appropriate

2017-03-24 Thread Diego Biurrun
libavformat/takdec.c:144:20: warning: format '%X' expects argument of type 'unsigned int', but argument 4 has type 'uint32_t' --- libavformat/takdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/takdec.c b/libavformat/takdec.c index 4b3037d..b3739e4 100644 ---

Re: [libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Diego Biurrun
On Fri, Mar 24, 2017 at 01:36:51PM -0400, Sean McGovern wrote: > Fixes invalid reads with corrupted files. > > CC: libav-sta...@libav.org > Bug-Id: 1039 > --- > libavformat/nsvdec.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Nice! rmdec.c also ignores the return values of

Re: [libav-devel] [PATCH] APIchanges: Update bump dates

2017-03-24 Thread Vittorio Giovara
On Fri, Mar 24, 2017 at 7:46 PM, Vittorio Giovara wrote: > --- > doc/APIchanges | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) please ignore -- Vittorio ___ libav-devel mailing list

[libav-devel] [PATCH] vc1_pred: Fix undefined negative shifts

2017-03-24 Thread Vittorio Giovara
From: Michael Niedermayer Signed-off-by: Vittorio Giovara --- libavcodec/vc1_pred.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index

[libav-devel] [PATCH] APIchanges: Update bump dates

2017-03-24 Thread Vittorio Giovara
--- doc/APIchanges | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index c6a5d82b99..a0ca3b7ac0 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,13 +2,13 @@ Never assume the API of libav* to be stable unless at least 1

Re: [libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Vittorio Giovara
On Fri, Mar 24, 2017 at 6:36 PM, Sean McGovern wrote: > Fixes invalid reads with corrupted files. > > CC: libav-sta...@libav.org > Bug-Id: 1039 > --- > libavformat/nsvdec.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavformat/nsvdec.c

[libav-devel] [PATCH] nsvdec: don't ignore the return value of av_get_packet()

2017-03-24 Thread Sean McGovern
Fixes invalid reads with corrupted files. CC: libav-sta...@libav.org Bug-Id: 1039 --- libavformat/nsvdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/nsvdec.c b/libavformat/nsvdec.c index c91d2a1..924c869 100644 --- a/libavformat/nsvdec.c +++

Re: [libav-devel] [PATCH 2/3] Add FM Screen Capture Codec decoder

2017-03-24 Thread Vittorio Giovara
On Fri, Mar 24, 2017 at 4:10 PM, Diego Biurrun wrote: > From: Paul B Mahol > > Signed-off-by: Paul B Mahol > Signed-off-by: Diego Biurrun > --- > > decode_type2() is, ummm, interesting .. > > Changelog | 1

Re: [libav-devel] [PATCH 1/3] Add av_calloc() helper

2017-03-24 Thread Vittorio Giovara
On Fri, Mar 24, 2017 at 4:10 PM, Diego Biurrun wrote: > From: Laurent Aimar > > Signed-off-by: Diego Biurrun > --- > libavutil/mem.c | 7 +++ > libavutil/mem.h | 12 > 2 files changed, 19 insertions(+) > > diff --git

Re: [libav-devel] [PATCH] lavc: deprecate old vdpau APIs

2017-03-24 Thread Diego Biurrun
On Thu, Mar 23, 2017 at 02:01:52PM +0100, wm4 wrote: > --- a/libavcodec/vdpau.c > +++ b/libavcodec/vdpau.c > @@ -60,6 +60,10 @@ static int vdpau_error(VdpStatus status) > > +// Note: becomes private with FF_API_VDPAU_OLD_API > +#if !FF_API_VDPAU_OLD_API > +static > +#endif > int

Re: [libav-devel] [PATCH 3/3] fate: Add tests for FMVC

2017-03-24 Thread Luca Barbato
On 24/03/2017 16:10, Diego Biurrun wrote: > --- > tests/fate/screen.mak | 9 + > tests/ref/fate/fmvc-type1 | 7 +++ > tests/ref/fate/fmvc-type2 | 29 + > 3 files changed, 45 insertions(+) > create mode 100644 tests/ref/fate/fmvc-type1 > create mode

Re: [libav-devel] [PATCH 1/3] Add av_calloc() helper

2017-03-24 Thread Luca Barbato
On 24/03/2017 16:10, Diego Biurrun wrote: > From: Laurent Aimar > > Signed-off-by: Diego Biurrun > --- > libavutil/mem.c | 7 +++ > libavutil/mem.h | 12 > 2 files changed, 19 insertions(+) > > diff --git a/libavutil/mem.c

[libav-devel] [PATCH 3/3] fate: Add tests for FMVC

2017-03-24 Thread Diego Biurrun
--- tests/fate/screen.mak | 9 + tests/ref/fate/fmvc-type1 | 7 +++ tests/ref/fate/fmvc-type2 | 29 + 3 files changed, 45 insertions(+) create mode 100644 tests/ref/fate/fmvc-type1 create mode 100644 tests/ref/fate/fmvc-type2 diff --git

[libav-devel] [PATCH 2/3] Add FM Screen Capture Codec decoder

2017-03-24 Thread Diego Biurrun
From: Paul B Mahol Signed-off-by: Paul B Mahol Signed-off-by: Diego Biurrun --- decode_type2() is, ummm, interesting .. Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 +

[libav-devel] [PATCH 1/3] Add av_calloc() helper

2017-03-24 Thread Diego Biurrun
From: Laurent Aimar Signed-off-by: Diego Biurrun --- libavutil/mem.c | 7 +++ libavutil/mem.h | 12 2 files changed, 19 insertions(+) diff --git a/libavutil/mem.c b/libavutil/mem.c index 0f506d3..8231431 100644 --- a/libavutil/mem.c +++

Re: [libav-devel] [libav-commits] configure: Simplify inline asm check with appropriate helper function

2017-03-24 Thread Martin Storsjö
On Thu, 2 Feb 2017, Diego Biurrun wrote: Module: libav Branch: master Commit: 24d5680bbc01fc124709d522d348572ad4672563 Author:Diego Biurrun Committer: Diego Biurrun Date: Fri Jan 20 15:30:36 2017 +0100 configure: Simplify inline asm check with

Re: [libav-devel] [PATCH] hwcontext: Move NONE to the be the first member of AVHWDeviceType

2017-03-24 Thread Luca Barbato
On 23/03/2017 21:03, Mark Thompson wrote: > Also use that to fix a warning in av_hwdevice_get_type_name(). > --- > Yay for major version bumps. > Ok. ___ libav-devel mailing list libav-devel@libav.org