Re: [libav-devel] [PATCH 002/200] lavu: support AVChannelLayout AVOptions

On 5/26/17 7:30 PM, Anton Khirnov wrote: > Quoting Luca Barbato (2017-05-23 22:08:49) >> On 5/17/17 7:46 PM, Vittorio Giovara wrote: >>> +av_channel_layout_uninit(dst); >>> +return av_channel_layout_copy(dst, channel_layout); >> >> Maybe put the uninit directly in the layout_copy so there

Re: [libav-devel] [PATCH] [RFC] Disentangle TLS protocol

On Fri, 26 May 2017, Hendrik Leppkes wrote: On Fri, May 26, 2017 at 7:27 PM, Diego Biurrun wrote: On Fri, May 26, 2017 at 03:12:43PM +0300, Martin Storsjö wrote: On Fri, 26 May 2017, Diego Biurrun wrote: >--- >TLS is not handled like other protocols. Instead the

Re: [libav-devel] [PATCH 002/200] lavu: support AVChannelLayout AVOptions

Quoting wm4 (2017-05-26 20:03:07) > On Fri, 26 May 2017 19:30:40 +0200 > Anton Khirnov wrote: > > > Quoting Luca Barbato (2017-05-23 22:08:49) > > > On 5/17/17 7:46 PM, Vittorio Giovara wrote: > > > > +av_channel_layout_uninit(dst); > > > > +return

Re: [libav-devel] [PATCH] [RFC] Disentangle TLS protocol

On Fri, May 26, 2017 at 7:27 PM, Diego Biurrun wrote: > On Fri, May 26, 2017 at 03:12:43PM +0300, Martin Storsjö wrote: >> On Fri, 26 May 2017, Diego Biurrun wrote: >> >--- >> >TLS is not handled like other protocols. Instead the implementation details >> >of which crypto

Re: [libav-devel] [PATCH 002/200] lavu: support AVChannelLayout AVOptions

On Fri, 26 May 2017 19:30:40 +0200 Anton Khirnov wrote: > Quoting Luca Barbato (2017-05-23 22:08:49) > > On 5/17/17 7:46 PM, Vittorio Giovara wrote: > > > +av_channel_layout_uninit(dst); > > > +return av_channel_layout_copy(dst, channel_layout); > > > > Maybe put

Re: [libav-devel] [PATCH 2/3] log: move all the "advanced" logging from lavu into cmdutils

Quoting Vittorio Giovara (2017-05-22 22:05:55) > On Sat, May 20, 2017 at 7:57 AM, Anton Khirnov wrote: > > The default logging callback in lavu currently contains several > > "advanced" features, such as > > - suppressing repeated messages > > - automatically hiding the log

Re: [libav-devel] [PATCH 05/14] lavc: Add coded bitstream read/write support for H.264

Quoting Mark Thompson (2017-05-26 01:37:21) > On 21/05/17 09:46, Anton Khirnov wrote: > > Quoting Mark Thompson (2017-05-14 23:24:11) > >> + > >> +start = end = 6; > >> +for (i = 0; i < count; i++) { > >> +size = AV_RB16(data + end) + 2; > >> +if (end + size

Re: [libav-devel] [PATCH 04/14] lavc: Add coded bitstream read/write API

Quoting Mark Thompson (2017-05-26 00:46:09) > On 20/05/17 07:35, Anton Khirnov wrote: > > Quoting Mark Thompson (2017-05-14 23:24:10) > >> +int ff_cbs_insert_unit(CodedBitstreamContext *ctx, > >> + CodedBitstreamFragment *frag, > >> + int position, int

Re: [libav-devel] [PATCH 1/3] build: Skip generating .version files when reconfiguring

The commit message could use more detail, it's not entirely obvious why this is the correct thing to do. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 002/200] lavu: support AVChannelLayout AVOptions

Quoting Luca Barbato (2017-05-23 22:08:49) > On 5/17/17 7:46 PM, Vittorio Giovara wrote: > > +av_channel_layout_uninit(dst); > > +return av_channel_layout_copy(dst, channel_layout); > > Maybe put the uninit directly in the layout_copy so there isn't risk to > leak memory if you forget. I

Re: [libav-devel] [PATCH] [RFC] Disentangle TLS protocol

On Fri, May 26, 2017 at 03:12:43PM +0300, Martin Storsjö wrote: > On Fri, 26 May 2017, Diego Biurrun wrote: > >--- > >TLS is not handled like other protocols. Instead the implementation details > >of which crypto library is used get exposed to the user. Hiding those > >details allows simplifying

Re: [libav-devel] [PATCH] configure: Do not check for the __builtin_vec_vsx_ld

On Wed, May 10, 2017 at 05:20:29PM +0200, Luca Barbato wrote: > --- a/configure > +++ b/configure > @@ -4452,7 +4452,14 @@ EOF > > if enabled vsx; then > check_cflags -mvsx && > -check_builtin vec_vsx_ld "altivec.h" "__builtin_vec_vsx_ld" || > disable vsx > +

Re: [libav-devel] [PATCH 002/200] lavu: support AVChannelLayout AVOptions

On 5/26/17 6:03 PM, Vittorio Giovara wrote: > On Tue, May 23, 2017 at 4:08 PM, Luca Barbato wrote: >> On 5/17/17 7:46 PM, Vittorio Giovara wrote: >>> +av_channel_layout_uninit(dst); >>> +return av_channel_layout_copy(dst, channel_layout); >> >> Maybe put the uninit

Re: [libav-devel] [PATCH 004/200] avframe: switch to the new channel layout API

On 5/26/17 5:27 PM, Vittorio Giovara wrote: > On Tue, May 23, 2017 at 4:09 PM, Luca Barbato wrote: >> On 5/17/17 7:46 PM, Vittorio Giovara wrote: >>> +ret = av_channel_layout_copy(>ch_layout, >>> >to_free->ch_layout); >> >> Doesn't need to uninit first? > > I'll move

[libav-devel] [PATCH 022/200] lavfi: Port filter negotiation to use the new channel layout API

Signed-off-by: Vittorio Giovara --- Moved portions of code to functions as Luca requested. I only left the code from MERGE_FORMATS unchanged because it was too heavily entwined in that function. Vittorio libavfilter/af_aformat.c | 30 +---

Re: [libav-devel] [PATCH 002/200] lavu: support AVChannelLayout AVOptions

On Tue, May 23, 2017 at 4:08 PM, Luca Barbato wrote: > On 5/17/17 7:46 PM, Vittorio Giovara wrote: >> +av_channel_layout_uninit(dst); >> +return av_channel_layout_copy(dst, channel_layout); > > Maybe put the uninit directly in the layout_copy so there isn't risk to >

[libav-devel] [PATCH 001/200] Add a new channel layout API

From: Anton Khirnov The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just uint64_t bitmasks. Expanded

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

On Fri, May 26, 2017 at 02:06:02PM +0200, Luca Barbato wrote: > On 5/26/17 1:50 PM, Diego Biurrun wrote: > > Both libraries provide similar functionality and cannot be used together. > > When both are enabled one is used and the other ignored arbitrarily. Error > > out instead and have the user

Re: [libav-devel] [PATCH 007/200] lavfi: switch to the new channel layout API

On Wed, May 17, 2017 at 1:46 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > libavfilter/audio.c | 17 +++-- > libavfilter/avfilter.c | 9 - > libavfilter/avfilter.h | 13

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

On Fri, May 26, 2017 at 02:06:04PM +0200, wm4 wrote: > On Fri, 26 May 2017 13:50:11 +0200 > Diego Biurrun wrote: > > Both libraries provide similar functionality and cannot be used together. > > When both are enabled one is used and the other ignored arbitrarily. Error > > out

Re: [libav-devel] [PATCH 006/200] lavr: switch to the new channel layout API

On Wed, May 17, 2017 at 1:46 PM, Vittorio Giovara wrote: > From: Anton Khirnov > > Signed-off-by: Vittorio Giovara > --- > libavresample/audio_mix.c| 148 ++-- > libavresample/audio_mix_matrix.c | 477 >

Re: [libav-devel] [PATCH 004/200] avframe: switch to the new channel layout API

On Tue, May 23, 2017 at 4:09 PM, Luca Barbato wrote: > On 5/17/17 7:46 PM, Vittorio Giovara wrote: >> +ret = av_channel_layout_copy(>ch_layout, >> >to_free->ch_layout); > > Doesn't need to uninit first? I'll move uninit in _copy(). Ok otherwise? -- Vittorio

Re: [libav-devel] [PATCH] [RFC] Disentangle TLS protocol

On Fri, 26 May 2017, Diego Biurrun wrote: --- TLS is not handled like other protocols. Instead the implementation details of which crypto library is used get exposed to the user. Hiding those details allows simplifying and refactoring some code and avoiding the special-casing of TLS. This

Re: [libav-devel] [PATCH] [RFC] Disentangle TLS protocol

On Fri, 26 May 2017 13:56:13 +0200 Diego Biurrun wrote: > --- > TLS is not handled like other protocols. Instead the implementation details > of which crypto library is used get exposed to the user. Hiding those > details allows simplifying and refactoring some code and

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

On 5/26/17 1:50 PM, Diego Biurrun wrote: > Both libraries provide similar functionality and cannot be used together. > When both are enabled one is used and the other ignored arbitrarily. Error > out instead and have the user choose which library to use. > --- > configure | 3 +++ > 1 file

Re: [libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

On Fri, 26 May 2017 13:50:11 +0200 Diego Biurrun wrote: > Both libraries provide similar functionality and cannot be used together. > When both are enabled one is used and the other ignored arbitrarily. Error > out instead and have the user choose which library to use. > --- >

[libav-devel] [PATCH] [RFC] Disentangle TLS protocol

--- TLS is not handled like other protocols. Instead the implementation details of which crypto library is used get exposed to the user. Hiding those details allows simplifying and refactoring some code and avoiding the special-casing of TLS. This should get a slightly more elaborate log message

[libav-devel] [PATCH 1/2] configure: Bail out if both GnuTLS and OpenSSL are enabled

Both libraries provide similar functionality and cannot be used together. When both are enabled one is used and the other ignored arbitrarily. Error out instead and have the user choose which library to use. --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure

[libav-devel] [PATCH 2/2] configure: Fix handling of _select dependencies

The handling of _select dependencies had two issues: 1) extralibs from _select dependencies of a component were not added to the list of extralibs for that component. 2) Previously, _select components were enabled after checking dependencies for that component. However, extralibs for each