[libav-devel] License consent (cinepakenc.c)

2017-05-16 Thread Tomas Härdin
Hi (re-sending the same message I sent to ffmpeg-devel, minus a bit about MAINTAINERS) I got a question from Diego via IRC about what license cinepakenc.c actually has, since the first commit message just has a message by"Rl" saying that I said it was OK but with no appropriately signed message

Re: [libav-devel] [PATCH 4/9] mxfenc: always assume long gop

2014-11-28 Thread Tomas Härdin
On Fri, 2014-11-28 at 13:16 +0100, Anton Khirnov wrote: Checking the codec context parameters to find out this information is far too unreliable to be useful, so it is safer to assume B-frames are always present. --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [libav-devel] [PATCH 7/8] mxfdec: avoid out-of-bounds write

2014-10-25 Thread Tomas Härdin
On Fri, 2014-10-24 at 13:11 +0100, Vittorio Giovara wrote: On Fri, Oct 24, 2014 at 7:15 AM, Anton Khirnov an...@khirnov.net wrote: Quoting Vittorio Giovara (2014-10-24 01:05:58) CC: libav-sta...@libav.org Bug-Id: CID 732262 --- libavformat/mxfdec.c | 5 +++-- 1 file changed, 3

Re: [libav-devel] [PATCH 3/4] mxf: Support AAC

2014-08-18 Thread Tomas Härdin
On 2014-08-14 23:18, Luca Barbato wrote: On 14/08/14 22:11, Tomas Härdin wrote: On Wed, 2014-08-13 at 19:37 +0200, Luca Barbato wrote: On 13/08/14 19:15, Anton Khirnov wrote: diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 410c13b..eb0f5d0 100644 --- a/libavformat/mxfdec.c

Re: [libav-devel] [PATCH 3/4] mxf: Support AAC

2014-08-14 Thread Tomas Härdin
On Wed, 2014-08-13 at 19:37 +0200, Luca Barbato wrote: On 13/08/14 19:15, Anton Khirnov wrote: diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 410c13b..eb0f5d0 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -972,6 +972,7 @@ static const MXFCodecUL

Re: [libav-devel] [PATCH 10/20] mxfdec: Set audio packets pts

2014-01-29 Thread Tomas Härdin
On Fri, 2014-01-17 at 11:38 +, Kieran Kunhya wrote: On 17 January 2014 09:41, Anton Khirnov an...@khirnov.net wrote: On Wed, 8 Jan 2014 03:25:41 +0100, Luca Barbato lu_z...@gentoo.org wrote: From: Matthieu Bouron matthieu.bou...@gmail.com Further fixes from Tomas Härdin. Pretty

Re: [libav-devel] [PATCH 07/20] mxfdec: Correctly support files from Pinnacle Thunder

2014-01-29 Thread Tomas Härdin
On Fri, 2014-01-10 at 21:19 +0100, Anton Khirnov wrote: On Wed, 8 Jan 2014 03:25:38 +0100, Luca Barbato lu_z...@gentoo.org wrote: From: Tomas Härdin tomas.har...@codemill.se Such files have IndexTableSegments which when parsed cover EditUnit ranges like this: [0,1) [249,250

Re: [libav-devel] [PATCH 1/1] mxfdec: fix typo in mxf_read_seek()

2012-12-03 Thread Tomas Härdin
On Fri, 2012-10-26 at 20:05 +0200, Janne Grunau wrote: Check the number of index tables before using byte offset based seeking instead of the index_tables pointer. Found by Måns Rullgård m...@mansr.com. --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libav-devel] [PATCH 3/3] avconv: warn about inappropriate output stream format

2012-10-25 Thread Tomas Härdin
On Thu, 2012-10-25 at 06:43 +0200, Kostya Shishkov wrote: On Wed, Oct 24, 2012 at 09:27:57PM +0200, Luca Barbato wrote: On 10/24/2012 04:15 PM, Tomas Härdin wrote: Oh boy, here we go. On Wed, 2012-10-24 at 12:10 +0200, Kostya Shishkov wrote: @@ -1605,6 +1606,12 @@ static int

Re: [libav-devel] [PATCH] mov: Do not apply dts shift from edit lists coming from data tracks.

2012-10-25 Thread Tomas Härdin
On Thu, 2012-10-11 at 21:52 -0700, Alex Converse wrote: Some files in the wild have time code tracks with very negative initial offsets. --- libavformat/mov.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index

Re: [libav-devel] [PATCH 3/3] avconv: warn about inappropriate output stream format

2012-10-25 Thread Tomas Härdin
On Thu, 2012-10-25 at 11:37 +0200, Kostya Shishkov wrote: On Thu, Oct 25, 2012 at 11:30:02AM +0200, Tomas Härdin wrote: On Thu, 2012-10-25 at 06:43 +0200, Kostya Shishkov wrote: On Wed, Oct 24, 2012 at 09:27:57PM +0200, Luca Barbato wrote: On 10/24/2012 04:15 PM, Tomas Härdin wrote

Re: [libav-devel] [PATCH 3/3] avconv: warn about inappropriate output stream format

2012-10-24 Thread Tomas Härdin
Oh boy, here we go. On Wed, 2012-10-24 at 12:10 +0200, Kostya Shishkov wrote: @@ -1605,6 +1606,12 @@ static int transcode_init(void) codec-codec_tag = icodec-codec_tag; } +desc = avcodec_descriptor_get(codec-codec_id); +if (desc

Re: [libav-devel] [PATCH] img2dec: Don't leave AVIOContexts open on zero byte files

2012-09-12 Thread Tomas Härdin
On Mon, 2012-09-10 at 11:19 +0200, Luca Barbato wrote: On 9/10/12 10:52 AM, Tomas Härdin wrote: On Fri, 2012-09-07 at 11:03 +0200, Tomas Härdin wrote: Hi The attached patch fixes img2dec leaving file descriptors/HTTP connections/etc. open if an image sequence contains a zero-sized file

Re: [libav-devel] [PATCH] img2dec: Don't leave AVIOContexts open on zero byte files

2012-09-10 Thread Tomas Härdin
On Fri, 2012-09-07 at 11:03 +0200, Tomas Härdin wrote: Hi The attached patch fixes img2dec leaving file descriptors/HTTP connections/etc. open if an image sequence contains a zero-sized file. make fate ran fine. Here's a prettier patch. Re-ran FATE, works fine. Tested with both foo.jpeg

[libav-devel] [PATCH] img2dec: Don't leave AVIOContexts open on zero byte files

2012-09-07 Thread Tomas Härdin
Hi The attached patch fixes img2dec leaving file descriptors/HTTP connections/etc. open if an image sequence contains a zero-sized file. make fate ran fine. /Tomas From 9392598119ccbaaa943fa0bee83078ac8122d3dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=

Re: [libav-devel] [PATCH] mem: introduce av_malloc_array and av_mallocz_array

2012-07-10 Thread Tomas Härdin
On Tue, 2012-07-10 at 02:27 +0200, Luca Barbato wrote: Both function ease allocating large arrays implementing the overflow check inside it. --- I'd rather be self consistent, pick what you like best. libavutil/mem.h | 37 +++-- I suppose this is more

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Tomas Härdin
On Tue, 2012-07-10 at 13:03 +0200, Luca Barbato wrote: On 07/10/2012 11:59 AM, Diego Biurrun wrote: On Tue, Jul 10, 2012 at 05:16:06AM +0200, Luca Barbato wrote: --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1873,6 +1873,9 @@ static int mxf_read_header(AVFormatContext *s)

Re: [libav-devel] [PATCH 09/10] mxfdec: Only parse next partition pack if parsing forward

2012-07-10 Thread Tomas Härdin
On Tue, 2012-07-10 at 17:44 +0200, Luca Barbato wrote: On 07/10/2012 04:19 PM, Tomas Härdin wrote: The backward parsing is due to PartitionPack not having any offset to the *next* partition - only the previous one (PreviousPartition). Since we don't want to parse the essence and in general

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void *av_calloc(size_t nmemb, size_t size) +{ +if (size = 0 || nmemb = INT_MAX / size) +return NULL; +return av_mallocz(nmemb * size); +} The places where

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Sun, 2012-07-08 at 18:44 +0200, Luca Barbato wrote: I thought you were making it an inline. Normal function - smaller binaries. Also, this patch already existed - less work. /Tomas ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-09 Thread Tomas Härdin
On Mon, 2012-07-09 at 14:28 +0200, Luca Barbato wrote: On 07/09/2012 12:18 PM, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Sun, 2012-07-08 at 21:12 +0100, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: +void *av_calloc(size_t nmemb, size_t

[libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-08 Thread Tomas Härdin
Hi The attached patch adds av_calloc() to libavutil. See the mxfdec thread ([PATCH] mxfdec: replace xav_log2(sizeof(..)) by x/sizeof(..)). This allows for simpler, smaller code and smaller binaries. /Tomas From f614808c28a58c14906c81962871d2c2dfc73afe Mon Sep 17 00:00:00 2001 From: Laurent Aimar

[libav-devel] [PATCH 2/2] lavu: Bump minor version for av_calloc()

2012-07-08 Thread Tomas Härdin
From f247a5c2c4c61dc5b3fecf348d90f1655ad1bcbe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= tomas.har...@codemill.se Date: Sun, 8 Jul 2012 16:17:37 +0200 Subject: [PATCH 2/2] lavu: Bump minor version for av_calloc() --- doc/APIchanges |3 +++ libavutil/version.h |2

Re: [libav-devel] [PATCH 1/2] Add av_calloc() helper.

2012-07-08 Thread Tomas Härdin
On Sun, 2012-07-08 at 18:06 +0200, Diego Biurrun wrote: On Sun, Jul 08, 2012 at 05:18:23PM +0200, Tomas Härdin wrote: --- a/libavutil/mem.h +++ b/libavutil/mem.h @@ -113,6 +113,18 @@ void av_free(void *ptr); /** + * Allocate a block of nmemb * size bytes with alignment suitable

Re: [libav-devel] [PATCH] mxfdec: replace xav_log2(sizeof(..)) by x/sizeof(..).

2012-07-05 Thread Tomas Härdin
On Wed, 2012-07-04 at 14:02 -0700, Ronald S. Bultje wrote: Why not simply add av_calloc() to lavu and use it? These kind of allocations are all over the place - it'd make them prettier. I've suggested this before in [1]. You could even have it static inline. IMO muxers shouldn't have to

Re: [libav-devel] [PATCH] mxfdec: replace xav_log2(sizeof(..)) by x/sizeof(..).

2012-07-04 Thread Tomas Härdin
On Wed, 2012-07-04 at 12:14 +0100, Måns Rullgård wrote: Kostya Shishkov kostya.shish...@gmail.com writes: On Wed, Jul 04, 2012 at 11:09:57AM +0100, Måns Rullgård wrote: Ronald S. Bultje rsbul...@gmail.com writes: From: Ronald S. Bultje rsbul...@gmail.com ---

Re: [libav-devel] [PATCH 04/14] avcodec: add YCgCo color space.

2012-05-02 Thread Tomas Härdin
On Sun, 2012-04-29 at 13:33 -0400, Derek Buitenhuis wrote: From: Hendrik Leppkes h.lepp...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/avcodec.h |1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index

Re: [libav-devel] [PATCH] aiffdec: Fix SIGFPE on pcm_f32be

2012-03-22 Thread Tomas Härdin
On Wed, 2012-03-21 at 10:50 -0700, Ronald S. Bultje wrote: Hi, On Wed, Mar 21, 2012 at 5:17 AM, Tomas Härdin tomas.har...@codemill.se wrote: Hi Running ffprobe/avprobe on http://titan.codemill.se/~tomhar/samples/sigfpe.aif results in SIGFPE at libavformat/aiffdec.c:162 since aiff

[libav-devel] [PATCH] aiffdec: Fix SIGFPE on pcm_f32be

2012-03-21 Thread Tomas Härdin
Hi Running ffprobe/avprobe on http://titan.codemill.se/~tomhar/samples/sigfpe.aif results in SIGFPE at libavformat/aiffdec.c:162 since aiff-block_duration == 0. Attached patch sets block_duration = 1 in the default case. Fixes the problem for both projects. /Tomas From

Re: [libav-devel] [PATCH 01/16] mxfdec: Ignore the last entry in Avid's index table segments

2012-02-09 Thread Tomas Härdin
Ping? Some of these fix crashes and/or hangs.. /Tomas ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 05/16] mxfdec: Check for NULL component

2012-01-26 Thread Tomas Härdin
This fixes SIGSEGV with zzuf1.mxf --- libavformat/mxfdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index aa7ebe6..6c3f0e2 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1311,7 +1311,7 @@ static int

[libav-devel] [PATCH 04/16] mxfdec: Sanity-check SampleRate

2012-01-26 Thread Tomas Härdin
This avoids a SIGFPE if SampleRate is missing or set to naughty values. --- libavformat/mxfdec.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 9051874..aa7ebe6 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c

[libav-devel] [PATCH 02/16] mxfdec: Make sure x index_table-nb_ptses

2012-01-26 Thread Tomas Härdin
Without this the demuxer will SIGSEGV on files with IndexEntryCount IndexDuration --- libavformat/mxfdec.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index fa2bb65..fb9cac4 100644 --- a/libavformat/mxfdec.c +++

[libav-devel] [PATCH 03/16] mxfdec: Make sure mxf-nb_index_tables 0 in mxf_packet_timestamps()

2012-01-26 Thread Tomas Härdin
Only the OPAtom demuxing logic is guaranteed to have index tables, meaning OP1a files that lack an index would cause SIGSEGV. --- libavformat/mxfdec.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index fb9cac4..9051874

[libav-devel] [PATCH 01/16] mxfdec: Ignore the last entry in Avid's index table segments

2012-01-26 Thread Tomas Härdin
The last entry is the total size of the essence container. Previously a TemporalOffset error would be logged, even though segments like these are expected. --- libavformat/mxfdec.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c

[libav-devel] [PATCH 07/16] mxfdec: Fix infinite loop in mxf_packet_timestamps()

2012-01-26 Thread Tomas Härdin
This can happen if an index table segment has a very large IndexStartPosition. zzuf3.mxf is an example of such a file. --- libavformat/mxfdec.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 28e8588..4ac90cd

[libav-devel] [PATCH 08/16] mxfdec: Move the current_partition check inside mxf_read_header()

2012-01-26 Thread Tomas Härdin
This fixes SIGSEGV on files where this is actually the case, such as zzuf4.mxf --- libavformat/mxfdec.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4ac90cd..6ae2b24 100644 --- a/libavformat/mxfdec.c +++

[libav-devel] [PATCH 12/16] mxfdec: Don't crash in mxf_packet_timestamps() if current_edit_unit overflows

2012-01-26 Thread Tomas Härdin
--- libavformat/mxfdec.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 08a5562..a3487bc 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1794,7 +1794,7 @@ static void mxf_packet_timestamps(MXFContext

[libav-devel] [PATCH 13/16] mxfdec: change av_log formatting %lx to PRIx64 and %li to PRIi64

2012-01-26 Thread Tomas Härdin
From: Jean First jeanfi...@gmail.com Signed-off-by: Jean First jeanfi...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/mxfdec.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index

[libav-devel] [PATCH 11/16] mxfdec: Zero nb_ptses in mxf_compute_ptses_fake_index()

2012-01-26 Thread Tomas Härdin
This fixes SIGSEGV on files with both CBR and VBR index segments (zzuf6.mxf). --- libavformat/mxfdec.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 0091582..08a5562 100644 --- a/libavformat/mxfdec.c +++

[libav-devel] [PATCH 14/16] mxfdec: Consider OPAtom files that don't have exactly one EC to be OP1a

2012-01-26 Thread Tomas Härdin
This fixes demuxing of 2011_DCPTEST_24FPS.V.mxf. Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/mxfdec.c | 18 +++--- 1 files changed, 15 insertions(+), 3 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 88142ca..cf9751a 100644 ---

[libav-devel] [PATCH 06/16] mxfdec: Check eof_reached in mxf_read_local_tags()

2012-01-26 Thread Tomas Härdin
This fixes the infinite loop with zzuf2.mxf --- libavformat/mxfdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 6c3f0e2..28e8588 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1472,7 +1472,7 @@

[libav-devel] [PATCH 16/16] mxfdec: Fix files 2 GiB

2012-01-26 Thread Tomas Härdin
Accumulating into an int would cause overflow for files with essence containers larger than 2 GiB. --- libavformat/mxfdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index d385a7e..c09893f 100644 ---

[libav-devel] [PATCH 15/16] mxfdec: Handle small EditUnitByteCount

2012-01-26 Thread Tomas Härdin
These are common with audio atoms. Without this the demuxer would read two bytes at a time for a mono 16-bit file. --- libavformat/mxfdec.c | 43 +-- 1 files changed, 41 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c

[libav-devel] [PATCH 09/16] mxfdec: Never seek back in local sets and KLVs

2012-01-26 Thread Tomas Härdin
Specially crafted files can lead the parsing code to take too long. We fix a lot of these problems by not allowing local tags to extend past the end of the set and not allowing other KLVs to be read past the end of themselves. --- libavformat/mxfdec.c | 15 +++ 1 files changed, 15

Re: [libav-devel] [PATCH 1/1] mxfdec: fix memleak on mxf_read_close()

2012-01-23 Thread Tomas Härdin
On Sun, 2012-01-22 at 19:58 +0100, Janne Grunau wrote: --- libavformat/mxfdec.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 4b63b27..0b514db 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@

Re: [libav-devel] [PATCH] mxfdec: parse MXF partitions

2012-01-21 Thread Tomas Härdin
On Sat, 2012-01-21 at 20:09 +0100, Janne Grunau wrote: On 2012-01-11 10:59:55 +0100, Tomas Härdin wrote: On Fri, 2011-12-23 at 14:40 +0100, Janne Grunau wrote: From: Tomas Härdin tomas.har...@codemill.se --- changed enum values back to original names Anyway, any news

Re: [libav-devel] [PATCH] mxfdec: parse MXF partitions

2012-01-11 Thread Tomas Härdin
On Fri, 2011-12-23 at 14:40 +0100, Janne Grunau wrote: From: Tomas Härdin tomas.har...@codemill.se --- changed enum values back to original names Janne Hooray! Anyway, any news on this and the other patch set? /Tomas ___ libav-devel mailing

Re: [libav-devel] [PATCH 1/2] lxf: add support for version 1 files

2012-01-02 Thread Tomas Härdin
On Fri, 2011-12-23 at 11:26 -0600, Phillip Blucas wrote: On Wed, Dec 21, 2011 at 4:33 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Tue, 2011-12-20 at 20:42 -0600, Phillip Blucas wrote: This newer format is used by Harris NEXIO playout servers. --- Changelog|1

Re: [libav-devel] MXF changes from FFmpeg

2011-12-23 Thread Tomas Härdin
On Thu, 2011-12-22 at 17:18 +0100, Luca Barbato wrote: On 22/12/11 13:45, Tomas Härdin wrote: It's also hard to define crazy when it comes to MXF. After all, we're talking about a format that allows indexing individual scanlines in raw footage.. So we should accept 64bit/sizeof(the thing

Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Tomas Härdin
On Wed, 2011-12-21 at 17:56 +0100, Janne Grunau wrote: On 2011-12-21 15:47:24 +0100, Tomas Härdin wrote: On Wed, 2011-12-21 at 15:28 +0100, Luca Barbato wrote: On 21/12/11 14:58, Tomas Härdin wrote: I hope you made sure the code still work fine on 32-bit systems, especially when

Re: [libav-devel] [PATCH 01/19] mxfdec: Parse MXF partitions.

2011-12-22 Thread Tomas Härdin
On Wed, 2011-12-21 at 19:45 +0100, Janne Grunau wrote: From: Tomas Härdin tomas.har...@codemill.se --- libavformat/mxfdec.c | 108 +- 1 files changed, 107 insertions(+), 1 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat

Re: [libav-devel] MXF changes from FFmpeg

2011-12-22 Thread Tomas Härdin
On Thu, 2011-12-22 at 11:52 +, Måns Rullgård wrote: Tomas Härdin tomas.har...@codemill.se writes: On Wed, 2011-12-21 at 17:56 +0100, Janne Grunau wrote: On 2011-12-21 15:47:24 +0100, Tomas Härdin wrote: On Wed, 2011-12-21 at 15:28 +0100, Luca Barbato wrote: On 21/12/11 14:58

Re: [libav-devel] MXF changes from FFmpeg

2011-12-21 Thread Tomas Härdin
On 12/20/2011 05:43 PM, Janne Grunau wrote: changed memory alloction from the pointless av_calloc to av_mallocz I hope you made sure the code still work fine on 32-bit systems, especially when entry counts are ~10^9. On Wed, 2011-12-21 at 11:56 +0100, Benjamin Larsson wrote: On 12/20/2011

Re: [libav-devel] [PATCH 1/2] lxf: add support for version 1 files

2011-12-21 Thread Tomas Härdin
On Tue, 2011-12-20 at 20:42 -0600, Phillip Blucas wrote: This newer format is used by Harris NEXIO playout servers. --- Changelog|1 + libavformat/lxfdec.c | 55 ++--- 2 files changed, 39 insertions(+), 17 deletions(-) Audio

Re: [libav-devel] MXF changes from FFmpeg

2011-12-21 Thread Tomas Härdin
On Wed, 2011-12-21 at 15:28 +0100, Luca Barbato wrote: On 21/12/11 14:58, Tomas Härdin wrote: I hope you made sure the code still work fine on 32-bit systems, especially when entry counts are ~10^9. Do you have a sample for that? FATE sample with a single bit flipped at 0x1e9d, turning

Re: [libav-devel] MXF changes from FFmpeg

2011-12-21 Thread Tomas Härdin
On 12/20/2011 05:43 PM, Janne Grunau wrote: changed memory alloction from the pointless av_calloc to av_mallocz I hope you made sure the code still work fine on 32-bit systems, especially when entry counts are ~10^9. On Wed, 2011-12-21 at 11:56 +0100, Benjamin Larsson wrote: On 12/20/2011

[libav-devel] [PATCH] mpegts: Attempt to seek back to beginning in non-seekable mpegts files.

2011-10-10 Thread Tomas Härdin
Hi Attached patch fixes demuxing/probing of http://titan.codemill.se/~tomhar/samples/not_playable_on_pipe.ts when opened via a pipe (ffplay/avplay - not_playable_on_pipe.ts). Sent to both lists since the problem exists in both projects. Meh. Passes make fate on both as well. /Tomas From

Re: [libav-devel] [PATCH] movenc: Don't wrap whole extradata atoms in glbl.

2011-09-30 Thread Tomas Härdin
On Fri, 2011-09-30 at 01:15 -0700, Alex Converse wrote: On Fri, Sep 30, 2011 at 12:19 AM, Tomas Härdin tomas.har...@codemill.se wrote: On Thu, 2011-09-29 at 13:44 -0700, Alex Converse wrote: This should result in more idiomatic output that is less confusing to marginal implementations

Re: [libav-devel] [PATCH] movenc: Don't wrap whole extradata atoms in glbl.

2011-09-30 Thread Tomas Härdin
On Fri, 2011-09-30 at 13:44 +0200, Luca Barbato wrote: On 9/30/11 10:59 AM, Benjamin Larsson wrote: At work we added an int interlacing; field to AVCodecContext. It's only set by a few decoders though (no demuxer sets it), and doesn't provide field order information. To support field

Re: [libav-devel] [PATCH] prores: mark prores as intra-only in libavformat/utils.c:is_intra_only()

2011-09-23 Thread Tomas Härdin
On Thu, 2011-09-22 at 17:54 -0700, Alex Converse wrote: On Thu, Sep 22, 2011 at 5:51 PM, Justin Ruggles justin.rugg...@gmail.com wrote: On 09/22/2011 08:33 PM, Måns Rullgård wrote: Benjamin Larsson benja...@southpole.se writes: On 09/23/2011 12:10 AM, Diego Biurrun wrote: ---

Re: [libav-devel] [PATCH] Apple ProRes decoder

2011-09-21 Thread Tomas Härdin
On Wed, 2011-09-21 at 13:09 +0200, Diego Biurrun wrote: From: Maxim Poliakovski max_p...@gmx.de +static int decode_frame_header(ProresContext *ctx, const uint8_t *buf, + const int data_size, AVCodecContext *avctx) +{ ... + +ctx-qmat_changed = 0; +ptr

[libav-devel] [PATCH] Fix VC-1 width/height handling.

2011-08-30 Thread Tomas Härdin
Attached patch cherry-picked from FFmpeg. It fixes issue2076. I uploaded a sample to http://titan.codemill.se/~tomhar/samples/double-free.vc1 in case the original went missing. /Tomas From bde3e96195421df37d879f1cc481a6b542e11b61 Mon Sep 17 00:00:00 2001 From:

[libav-devel] [PATCH] isom: Add missing 'ai52' tag (1080p AVC-Intra 50)

2011-08-29 Thread Tomas Härdin
$TOPIC /Tomas From 980ee54e31006951c95cd297161f1c61f045e0cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= tomas.har...@codemill.se Date: Mon, 29 Aug 2011 13:44:13 +0200 Subject: [PATCH] isom: Add missing 'ai52' tag (1080p AVC-Intra 50) --- libavformat/isom.c |1 + 1 files

Re: [libav-devel] [PATCH] Revert h264: Properly set coded_{width, height} when parsing H.264.

2011-08-23 Thread Tomas Härdin
Måns Rullgård skrev 2011-08-22 18:05: Tomas Härdintomas.har...@codemill.se writes: Måns Rullgård skrev 2011-08-22 16:04: Luca Barbatolu_z...@gentoo.org writes: On 8/22/11 11:54 AM, Måns Rullgård wrote: But that *is* the coded width/height. Using those as display width/height is broken.

Re: [libav-devel] [PATCH] Revert h264: Properly set coded_{width, height} when parsing H.264.

2011-08-22 Thread Tomas Härdin
Måns Rullgård skrev 2011-08-22 16:04: Luca Barbatolu_z...@gentoo.org writes: On 8/22/11 11:54 AM, Måns Rullgård wrote: But that *is* the coded width/height. Using those as display width/height is broken. then we have a documentation hole, which field contains the correct values? Both

Re: [libav-devel] Minimum Quality Standards For (Marginal) Encoders

2011-08-17 Thread Tomas Härdin
Mike Melanson skrev 2011-07-23 00:50: 2) There's a usable Cinepak encoder patch out there. It's chatty but it does the job. I don't know about the overall quality but given the vintage of the codec, the encoder is probably doing a good job. Should we push it in? I just figured out that the

Re: [libav-devel] [PATCH 1/6] Add bwf muxer, wav file with bext chunk

2011-07-13 Thread Tomas Härdin
Anton Khirnov skrev 2011-07-09 11:20: From: Benjamin Larssonbenja...@southpole.se Signed-off-by: Anton Khirnovan...@khirnov.net --- Changelog|4 ++ doc/general.texi |1 + libavformat/Makefile |1 + libavformat/allformats.c |1 +

Re: [libav-devel] [PATCH 5/6] wav: keep parsing until EOF if the input is seekable and we know the size of the data tag

2011-07-11 Thread Tomas Härdin
Anton Khirnov skrev 2011-07-09 11:20: From: Tomas Härdintomas.har...@codemill.se Signed-off-by: Anton Khirnovan...@khirnov.net --- libavformat/wav.c | 49 + 1 files changed, 33 insertions(+), 16 deletions(-) diff --git a/libavformat/wav.c

Re: [libav-devel] mpegtsenc: Random Access indicator take 2

2011-07-11 Thread Tomas Härdin
Jindřich Makovička skrev 2011-06-29 15:04: On Wed, Jun 29, 2011 at 12:06, Diego Biurrundi...@biurrun.de wrote: On Wed, Jun 29, 2011 at 07:35:30AM +, Gil Pedersen wrote: It most likely breaks fate. It does indeed - Jindrich, this needs to be addressed... biurrun@passion:~/src/priv/libav

Re: [libav-devel] mpegtsenc: Random Access indicator take 2

2011-06-23 Thread Tomas Härdin
Jindřich Makovička skrev 2011-06-21 18:52: Hi, I am attaching another, hopefully cleaner, version of the Random Access indicator patch for mpeg-ts muxer. Random Access indicator can be used to mark keyframes, and is required by some DVB recorders to be able to index and replay the recorded

[libav-devel] [PATCH] gxf: Fix 25 fps DV material in GXF being misdetected as 50 fps

2011-06-23 Thread Tomas Härdin
Hi It seems 25 fps DV muxed in GXF is misdetected as 50 fps by lavf. The attached patch fixes this issue by setting the duration of DV packets to fields_per_frame. Without this ffprobe reports packets as having duration=1, but all dts:es are even (0, 2, 4, time_base=1/50) which confuses

Re: [libav-devel] [PATCH] gxf: Fix 25 fps DV material in GXF being misdetected as 50 fps

2011-06-23 Thread Tomas Härdin
Tomas Härdin skrev 2011-06-23 16:22: Hi It seems 25 fps DV muxed in GXF is misdetected as 50 fps by lavf. The attached patch fixes this issue by setting the duration of DV packets to fields_per_frame. Oops, forgot to rebase. Updated patch attached. /Tomas From

Re: [libav-devel] [PATCH] Clip-Wrapped MXF support (attempt #5)

2011-06-17 Thread Tomas Härdin
Maksym Veremeyenko skrev 2011-06-16 13:07: 15.06.11 15:52, Diego Biurrun написав(ла): On Wed, Mar 30, 2011 at 01:59:56PM +0300, Maksym Veremeyenko wrote: This is another attempt to submit patches for clip-wrapped MXF files support (generated by Panasonic's P2 camera). Benjamin, Tomas, may be

Re: [libav-devel] dv aspect ratio

2011-05-25 Thread Tomas Härdin
Maksym Veremeyenko skrev 2011-05-25 07:06: hi, years ago there was a patch http://git.libav.org/?p=libav.git;a=commitdiff;h=6aafe463e5d1483b95ad259334c45d2741c92fb2 that splits aspect ratio detection for SMPTE 314M and IEC 61834. i have a bunch of files that properly displayed by quicktime,

Re: [libav-devel] [PATCH] Avoid divide by zero in compute_avg_bitrate()

2011-05-12 Thread Tomas Härdin
Ronald S. Bultje skrev 2011-05-12 16:36: Hi, On Wed, May 11, 2011 at 8:25 AM, Tomas Härdintomas.har...@codemill.se wrote: The attached patch fixes a possibility for movenc.c to SIGFPE if trackDuration is zero when writing esds. This can happen if the user manages to mux a single AAC packet

Re: [libav-devel] [PATCH] flic: do not set audio sample format. that is done by the decoder.

2011-04-21 Thread Tomas Härdin
Justin Ruggles skrev 2011-04-20 18:48: On 04/20/2011 03:29 AM, Tomas Härdin wrote: Justin Ruggles skrev 2011-04-20 01:17: diff --git a/libavformat/flic.c b/libavformat/flic.c index fcdf4c8..ad39d66 100644 --- a/libavformat/flic.c +++ b/libavformat/flic.c @@ -158,7 +158,6 @@ static int

Re: [libav-devel] [PATCH] flic: do not set audio sample format. that is done by the decoder.

2011-04-20 Thread Tomas Härdin
Justin Ruggles skrev 2011-04-20 01:17: diff --git a/libavformat/flic.c b/libavformat/flic.c index fcdf4c8..ad39d66 100644 --- a/libavformat/flic.c +++ b/libavformat/flic.c @@ -158,7 +158,6 @@ static int flic_read_header(AVFormatContext *s, ast-codec-codec_tag = 0;