Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-10 Thread Janne Grunau
On 2014-02-08 21:24:00 -0500, Justin Ruggles wrote: On 02/08/2014 09:19 PM, John Stebbins wrote: AVFrame.sample_rate is set in ff_get_buffer, but aacdec calls ff_get_buffer before the samplerate is known. So it needs to be set again before returning the frame. --- libavcodec/aacdec.c |

[libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-08 Thread John Stebbins
AVFrame.sample_rate is set in ff_get_buffer, but aacdec calls ff_get_buffer before the samplerate is known. So it needs to be set again before returning the frame. --- libavcodec/aacdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacdec.c

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-08 Thread Justin Ruggles
On 02/08/2014 09:19 PM, John Stebbins wrote: AVFrame.sample_rate is set in ff_get_buffer, but aacdec calls ff_get_buffer before the samplerate is known. So it needs to be set again before returning the frame. --- libavcodec/aacdec.c | 11 +++ 1 file changed, 7 insertions(+), 4

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-06 Thread Tim Walker
On 05 Feb 2014, at 19:44, John Stebbins stebb...@jetheaddev.com wrote: On further examination, I see that the latm code path also parses sample_rate before starting decoding. So the above comment about latm is incorrect. But we still can't move initialization of sample_rate earlier because

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-05 Thread John Stebbins
On 02/04/2014 04:38 AM, Tim Walker wrote: On 03 Feb 2014, at 00:24, John Stebbins stebb...@jetheaddev.com wrote: This does make a functional difference. I looked for the fallback code you mention. It looks like it is in ff_get_buffer()? In aacdec, ff_get_buffer is called before

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-05 Thread John Stebbins
On 02/05/2014 09:40 AM, John Stebbins wrote: On 02/04/2014 04:38 AM, Tim Walker wrote: On 03 Feb 2014, at 00:24, John Stebbins stebb...@jetheaddev.com wrote: This does make a functional difference. I looked for the fallback code you mention. It looks like it is in ff_get_buffer()? In

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-04 Thread Tim Walker
On 03 Feb 2014, at 00:24, John Stebbins stebb...@jetheaddev.com wrote: This does make a functional difference. I looked for the fallback code you mention. It looks like it is in ff_get_buffer()? In aacdec, ff_get_buffer is called before avctx-sample_rate has been set for the first time.

[libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-02 Thread John Stebbins
--- libavcodec/aacdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 70fbb53..a365209 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -2753,6 +2753,7 @@ static int aac_decode_er_frame(AVCodecContext

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-02 Thread Tim Walker
On 02 Feb 2014, at 17:39, John Stebbins stebb...@jetheaddev.com wrote: --- libavcodec/aacdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Did I really miss this? I was sure I had tested some AAC sources when switching to those AVFrame fields. Tim

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-02 Thread Hendrik Leppkes
On Sun, Feb 2, 2014 at 11:06 PM, Tim Walker tdskywal...@gmail.com wrote: On 02 Feb 2014, at 17:39, John Stebbins stebb...@jetheaddev.com wrote: --- libavcodec/aacdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Did I really miss this? I was sure I had tested some AAC

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-02 Thread John Stebbins
On 02/02/2014 02:13 PM, Hendrik Leppkes wrote: On Sun, Feb 2, 2014 at 11:06 PM, Tim Walker tdskywal...@gmail.com wrote: On 02 Feb 2014, at 17:39, John Stebbins stebb...@jetheaddev.com wrote: --- libavcodec/aacdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Did I

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-02 Thread John Stebbins
On 02/02/2014 03:24 PM, John Stebbins wrote: On 02/02/2014 02:13 PM, Hendrik Leppkes wrote: On Sun, Feb 2, 2014 at 11:06 PM, Tim Walker tdskywal...@gmail.com wrote: On 02 Feb 2014, at 17:39, John Stebbins stebb...@jetheaddev.com wrote: --- libavcodec/aacdec.c | 11 +++ 1 file

Re: [libav-devel] [PATCH] aacdec: set AVFrame sample_rate

2014-02-02 Thread Vittorio Giovara
On Monday, February 3, 2014, John Stebbins stebb...@jetheaddev.com wrote: On 02/02/2014 02:13 PM, Hendrik Leppkes wrote: On Sun, Feb 2, 2014 at 11:06 PM, Tim Walker tdskywal...@gmail.comjavascript:; wrote: On 02 Feb 2014, at 17:39, John Stebbins stebb...@jetheaddev.comjavascript:;