Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-14 Thread Steve Lhomme
LGTM On Wed, Dec 14, 2016 at 9:22 AM, Martin Storsjö wrote: > On Tue, 13 Dec 2016, Steve Lhomme wrote: > >> From: Steve Lhomme >> >> Otherwise some ARM and other unsupported CPU/OS is linked with -O0 >> --- >> configure | 1 + >> 1 file changed, 1 insertion(+)

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-14 Thread Martin Storsjö
On Tue, 13 Dec 2016, Steve Lhomme wrote: From: Steve Lhomme Otherwise some ARM and other unsupported CPU/OS is linked with -O0 --- configure | 1 + 1 file changed, 1 insertion(+) I find the commit message quite hard to understand and easily misleading. Would this make more

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-14 Thread Steve Lhomme
On Tue, Dec 13, 2016 at 5:17 PM, Diego Biurrun wrote: > On Tue, Dec 13, 2016 at 04:23:02PM +0100, Steve Lhomme wrote: >> On Tue, Dec 13, 2016 at 3:33 PM, Hendrik Leppkes wrote: >> > On Tue, Dec 13, 2016 at 2:24 PM, Steve Lhomme wrote: >>

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-13 Thread Diego Biurrun
On Tue, Dec 13, 2016 at 04:23:02PM +0100, Steve Lhomme wrote: > On Tue, Dec 13, 2016 at 3:33 PM, Hendrik Leppkes wrote: > > On Tue, Dec 13, 2016 at 2:24 PM, Steve Lhomme wrote: > >> From: Steve Lhomme > >> > >> Otherwise some ARM and

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-13 Thread Vittorio Giovara
On Tue, Dec 13, 2016 at 10:23 AM, Steve Lhomme wrote: > On Tue, Dec 13, 2016 at 3:33 PM, Hendrik Leppkes wrote: >> On Tue, Dec 13, 2016 at 2:24 PM, Steve Lhomme wrote: >>> From: Steve Lhomme >>> >>> Otherwise some ARM

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-13 Thread Steve Lhomme
On Tue, Dec 13, 2016 at 3:33 PM, Hendrik Leppkes wrote: > On Tue, Dec 13, 2016 at 2:24 PM, Steve Lhomme wrote: >> From: Steve Lhomme >> >> Otherwise some ARM and other unsupported CPU/OS is linked with -O0 >> --- >> configure | 1 + >> 1

Re: [libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-13 Thread Hendrik Leppkes
On Tue, Dec 13, 2016 at 2:24 PM, Steve Lhomme wrote: > From: Steve Lhomme > > Otherwise some ARM and other unsupported CPU/OS is linked with -O0 > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index

[libav-devel] [PATCH] configure: use -O1 with MSVC by default

2016-12-13 Thread Steve Lhomme
From: Steve Lhomme Otherwise some ARM and other unsupported CPU/OS is linked with -O0 --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 6d809f7..251b7c4 100755 --- a/configure +++ b/configure @@ -3278,6 +3278,7 @@ probe_cc(){