Re: [libav-devel] [PATCH 1/2] aac_ac3_parser: Drop in-parser downmix functionality

2017-04-27 Thread Vittorio Giovara
On Wed, Apr 26, 2017 at 1:30 PM, wm4 wrote: > On Wed, 26 Apr 2017 11:38:17 -0400 > Vittorio Giovara wrote: > >> request_channel_layout is a decoder option and it makes no sense >> to have it in a parser. > > Both patches LGTM if decoder downmix on its own still works. Looks like so, I asked a co

Re: [libav-devel] [PATCH 1/2] aac_ac3_parser: Drop in-parser downmix functionality

2017-04-26 Thread wm4
On Wed, 26 Apr 2017 11:38:17 -0400 Vittorio Giovara wrote: > request_channel_layout is a decoder option and it makes no sense > to have it in a parser. Both patches LGTM if decoder downmix on its own still works. ___ libav-devel mailing list libav-deve

Re: [libav-devel] [PATCH 1/2] aac_ac3_parser: Drop in-parser downmix functionality

2017-04-26 Thread Diego Biurrun
On Wed, Apr 26, 2017 at 11:38:17AM -0400, Vittorio Giovara wrote: > request_channel_layout is a decoder option and it makes no sense > to have it in a parser. > > This feature was needed in the past when the decoder was allowed > to reuse the avctx from the demuxer. Nowadays the decoder receives >

[libav-devel] [PATCH 1/2] aac_ac3_parser: Drop in-parser downmix functionality

2017-04-26 Thread Vittorio Giovara
request_channel_layout is a decoder option and it makes no sense to have it in a parser. This feature was needed in the past when the decoder was allowed to reuse the avctx from the demuxer. Nowadays the decoder receives only the parameters from it, already containing the real channel layout (and