Re: [libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-25 Thread Martin Storsjö
On Thu, 20 Mar 2014, Ben Avison wrote: Verified with profiling that this doesn't have a measurable effect upon overall performance. --- libavcodec/mlpdec.c | 40 +++- libavcodec/mlpdsp.c | 38 ++ libavcodec/mlpdsp.h | 22

Re: [libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-20 Thread Ben Avison
On Thu, 20 Mar 2014 11:38:28 -, Diego Biurrun wrote: On Wed, Mar 19, 2014 at 07:43:49PM -, Ben Avison wrote: >>--- a/libavcodec/mlpdsp.c >>+++ b/libavcodec/mlpdsp.c >>@@ -89,10 +89,46 @@ void ff_mlp_rematrix_channel(int32_t *samples, >>+int32_t *data_32 = (int32_t *)data; >>+int

[libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-20 Thread Ben Avison
Verified with profiling that this doesn't have a measurable effect upon overall performance. --- libavcodec/mlpdec.c | 40 +++- libavcodec/mlpdsp.c | 38 ++ libavcodec/mlpdsp.h | 22 ++ 3 files change

Re: [libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-20 Thread Diego Biurrun
On Wed, Mar 19, 2014 at 07:43:49PM -, Ben Avison wrote: > >>--- a/libavcodec/mlpdsp.c > >>+++ b/libavcodec/mlpdsp.c > >>@@ -89,10 +89,46 @@ void ff_mlp_rematrix_channel(int32_t *samples, > >>+int32_t *data_32 = (int32_t *)data; > >>+int16_t *data_16 = (int16_t *)data; > >pointless void*

[libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-19 Thread Ben Avison
Verified with profiling that this doesn't have a measurable effect upon overall performance. --- libavcodec/mlpdec.c | 40 +++- libavcodec/mlpdsp.c | 38 ++ libavcodec/mlpdsp.h | 22 ++ 3 files change

Re: [libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-19 Thread Ben Avison
--- a/libavcodec/mlpdsp.c +++ b/libavcodec/mlpdsp.c @@ -89,10 +89,46 @@ void ff_mlp_rematrix_channel(int32_t *samples, + +int32_t ff_mlp_pack_output(int32_t lossless_check_data, This function is not used outside of the file, so it can be made static and the ff_ prefix can be removed. It's used

Re: [libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-19 Thread James Almer
On 19/03/14 2:24 PM, Ben Avison wrote: > diff --git a/libavcodec/mlpdsp.h b/libavcodec/mlpdsp.h > index bd864d9..7b7640e 100644 > --- a/libavcodec/mlpdsp.h > +++ b/libavcodec/mlpdsp.h > @@ -23,6 +23,7 @@ > #define AVCODEC_MLPDSP_H > > #include > +#include "mlp.h" > > void ff_mlp_rematrix_ch

Re: [libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-19 Thread Diego Biurrun
On Wed, Mar 19, 2014 at 05:24:26PM +, Ben Avison wrote: > --- a/libavcodec/mlpdsp.c > +++ b/libavcodec/mlpdsp.c > @@ -89,10 +89,46 @@ void ff_mlp_rematrix_channel(int32_t *samples, > + > +int32_t ff_mlp_pack_output(int32_t lossless_check_data, This function is not used outside of the file, so

[libav-devel] [PATCH 5/6] truehd: break out part of output_data into platform-specific callback.

2014-03-19 Thread Ben Avison
Verified with profiling that this doesn't have a measurable effect upon overall performance. --- libavcodec/mlpdec.c | 40 +++- libavcodec/mlpdsp.c | 36 libavcodec/mlpdsp.h | 22 ++ 3 files changed,