Re: [libav-devel] [PATCH] avconv: fix bitstream filter option parsing

Quoting James Almer (2016-10-13 16:05:31) > On 10/10/2016 2:23 PM, Anton Khirnov wrote: > > Quoting James Almer (2016-10-03 21:40:06) > >> Arguments for bitstream filters weren't being parsed at all, and instead > >> checked by av_bsf_get_by_name() as if they were part of the filter's name > >> >

Re: [libav-devel] [PATCH] avformat/matroska: fix MatroskaVideoFieldOrder enum values

On 13/10/2016 15:53, James Almer wrote: > The spec says > > 9: Interlaced with bottom field displayed first and top field stored first > 14: Interlaced with top field displayed first and bottom field stored first > > And avcodec.h states > > AV_FIELD_TB, //< Top coded first, bottom

Re: [libav-devel] [PATCH] allow to pass custom sidedata through decoders

Quoting Francois Cartegnie (2016-10-12 14:50:03) > Because not every side data is handled or extracted > internally by libav, a libavcodec user might need > to attach some extradata and retrieve it in > presentation order after decoding. Attaching arbitrary data to frames to get it reordered from

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

On Thu, Oct 13, 2016 at 04:02:34PM +0200, Alexandra Hájková wrote: > --- a/libavcodec/x86/hevcdsp_init.c > +++ b/libavcodec/x86/hevcdsp_init.c > @@ -278,17 +297,24 @@ void ff_hevc_dsp_init_x86(HEVCDSPContext *c, const int > bit_depth) > +c->add_residual[1] =

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: > >> +#define randomize_buffers(buf, size)\ > >> +do {\ > >> +int j; \ > >> +for (j = 0; j < size; j++) {\ > >> +

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

On Thu, 13 Oct 2016, Diego Biurrun wrote: On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: >> +void checkasm_check_hevc_add_res(void) >> +{ >> +int bit_depth; >> + >> +for (bit_depth = 8; bit_depth <= 10; bit_depth++) { >> +HEVCDSPContext h; >> + >> +

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

Quoting Diego Biurrun (2016-10-13 22:09:03) > On Thu, Oct 13, 2016 at 09:53:47PM +0300, Martin Storsjö wrote: > > On Thu, 13 Oct 2016, Diego Biurrun wrote: > > > > >On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: > > > > > +void checkasm_check_hevc_add_res(void) > >

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

On Thu, Oct 13, 2016 at 09:53:47PM +0300, Martin Storsjö wrote: > On Thu, 13 Oct 2016, Diego Biurrun wrote: > > >On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková wrote: > > > +void checkasm_check_hevc_add_res(void) > +{ > +int bit_depth; > + > +for

[libav-devel] [PATCH] x86: Add missing colons after assembly labels

This fixes many warnings of the sort warning: label alone on a line without a colon might be in error --- libavcodec/x86/audiodsp.asm| 2 +- libavcodec/x86/dcadsp.asm | 2 +- libavcodec/x86/h264_qpel_10bit.asm | 2 +- libavcodec/x86/h264_weight.asm | 4 ++--

Re: [libav-devel] [PATCH 1/2] ppc: avcodec: Drop silly "_ppc" suffixes from files in ppc subdirectories

On 13/10/2016 22:19, Diego Biurrun wrote: > --- > libavcodec/ppc/Makefile | 2 +- > libavcodec/ppc/{videodsp_ppc.c => videodsp.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename libavcodec/ppc/{videodsp_ppc.c => videodsp.c} (100%) > > diff --git

[libav-devel] [PATCH 1/2] ppc: avcodec: Drop silly "_ppc" suffixes from files in ppc subdirectories

--- libavcodec/ppc/Makefile | 2 +- libavcodec/ppc/{videodsp_ppc.c => videodsp.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename libavcodec/ppc/{videodsp_ppc.c => videodsp.c} (100%) diff --git a/libavcodec/ppc/Makefile b/libavcodec/ppc/Makefile index

[libav-devel] [PATCH 2/2] build: Add VSX-OBJS to SUBDIR_VARS

The variable needs to be reset for each subdir. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4e026b0..aff7e23 100644 --- a/Makefile +++ b/Makefile @@ -125,7 +125,7 @@ config.h: .config SUBDIR_VARS := CLEANFILES EXAMPLES FFLIBS

Re: [libav-devel] [PATCH 3/3] mov: Evaluate the movie display matrix

On Thu, Oct 13, 2016 at 6:23 PM, Vittorio Giovara wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. > > So store it in main context and

Re: [libav-devel] [RFC] [PATCH] fate: Add --skip-tests configure option for omitting FATE tests

On Fri, 7 Oct 2016, Martin Storsjö wrote: On Fri, 7 Oct 2016, Martin Storsjö wrote: On Fri, 7 Oct 2016, Diego Biurrun wrote: On Fri, Oct 07, 2016 at 10:45:47AM +0300, Martin Storsjö wrote: On Fri, 7 Oct 2016, Diego Biurrun wrote: > This can be useful in known-broken scenarios like

[libav-devel] [PATCH 2/3] fate: Add tests for mov display matrix

Rotation, aspect ratio and pure matrix export. Signed-off-by: Vittorio Giovara --- tests/Makefile| 1 + tests/fate-run.sh | 5 + tests/ref/fate/mov-ar | 2 ++ tests/ref/fate/mov-display-matrix | 9 +

Re: [libav-devel] [RFC] [PATCH] fate: Add --skip-tests configure option for omitting FATE tests

On Thu, Oct 13, 2016 at 11:34:05PM +0300, Martin Storsjö wrote: > On Fri, 7 Oct 2016, Martin Storsjö wrote: > >On Fri, 7 Oct 2016, Martin Storsjö wrote: > >>On Fri, 7 Oct 2016, Diego Biurrun wrote: > >>>On Fri, Oct 07, 2016 at 10:45:47AM +0300, Martin Storsjö wrote: > On Fri, 7 Oct 2016, Diego

[libav-devel] [PATCH 3/3] mov: Evaluate the movie display matrix

This matrix needs to be applied after all others have (currently only display matrix from trak), but cannot be handled in movie box, since streams are not allocated yet. So store it in main context and if not identity, apply it when appropriate, handling the case when trak display matrix is

[libav-devel] [PATCH 1/3] avprobe: Add -show_stream_entry to get a single stream property

This is needed for improved fate testing and it is modeled after -show_format_entry. The main behavioral difference is that when a print function is called with an empty key, rather than discarding it, the closes key in the hierarchy is used instead. Signed-off-by: Vittorio Giovara

Re: [libav-devel] [PATCH 2/3] fate: Add tests for mov display matrix

On Thu, Oct 13, 2016 at 07:02:35PM -0400, Vittorio Giovara wrote: > On Thu, Oct 13, 2016 at 6:52 PM, Diego Biurrun wrote: > > On Thu, Oct 13, 2016 at 06:23:09PM -0400, Vittorio Giovara wrote: > >> --- a/tests/fate-run.sh > >> +++ b/tests/fate-run.sh > >> @@ -76,6 +76,11 @@

Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix

On Fri, Oct 14, 2016 at 01:13:42AM +0200, Diego Biurrun wrote: > On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote: > > --- /dev/null > > +++ b/tests/fate/mov.mak > > @@ -0,0 +1,12 @@ > > +FATE_MOV += fate-mov-display-matrix > > +fate-mov-display-matrix: CMD = run avprobe -v 0

Re: [libav-devel] [PATCH] fate: Add tests for mov display matrix

On Thu, Oct 13, 2016 at 07:03:01PM -0400, Vittorio Giovara wrote: > --- /dev/null > +++ b/tests/fate/mov.mak > @@ -0,0 +1,12 @@ > +FATE_MOV += fate-mov-display-matrix > +fate-mov-display-matrix: CMD = run avprobe -v 0 -show_stream_entry matrix > $(TARGET_SAMPLES)/mov/displaymatrix.mov > + >

[libav-devel] [RFC] assembly-related toolchain refactoring(s)

I decided to clean up an old crufty branch on the plane over the atlantic.. This generalizes the assembler program selection so that it works more like the compiler selection. After this set, the assembler is properly probed for and can be selected on the configure command line. We can also

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

On Thu, Oct 13, 2016 at 10:14:54PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-10-13 22:09:03) > > On Thu, Oct 13, 2016 at 09:53:47PM +0300, Martin Storsjö wrote: > > > On Thu, 13 Oct 2016, Diego Biurrun wrote: > > > > > > >On Thu, Oct 13, 2016 at 01:57:34PM +0200, Alexandra Hájková

[libav-devel] [PATCH 1/7] emms: Give apriv_emms_yasm() a more general name

--- libavutil/x86/emms.asm | 4 ++-- libavutil/x86/emms.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/x86/emms.asm b/libavutil/x86/emms.asm index 341f127..b0faec2 100644 --- a/libavutil/x86/emms.asm +++ b/libavutil/x86/emms.asm @@ -23,8 +23,8 @@ SECTION

[libav-devel] [PATCH 2/7] build: Generalize yasm/nasm-related variable names

None of them are specific to the YASM assembler. --- Makefile | 12 +++ arch.mak | 2 +- configure | 60 libavcodec/x86/Makefile | 72 +++

[libav-devel] [PATCH 3/7] configure: Rename "asm" option to "assembly"

It is a better name and will simplify upcoming commits. --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 5497c6d..d03707e 100755 --- a/configure +++ b/configure @@ -299,7 +299,7 @@ Advanced options (experts only):

[libav-devel] [PATCH 6/7] configure: Move probing of assemblers to its own function

--- configure | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/configure b/configure index 8f6a063..fee8f00 100755 --- a/configure +++ b/configure @@ -4227,6 +4227,20 @@ fi check_inline_asm inline_asm_labels '"1:\n"' +probe_asm(){ +if

[libav-devel] [PATCH 5/7] build: Allow generating dependencies as a side-effect of assembling

--- Makefile | 4 ++-- configure | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fef304f..348f876 100644 --- a/Makefile +++ b/Makefile @@ -42,6 +42,7 @@ endef COMPILE_C = $(call COMPILE,CC) COMPILE_S = $(call COMPILE,AS) COMPILE_M =

Re: [libav-devel] [PATCH 2/3] fate: Add tests for mov display matrix

On Thu, Oct 13, 2016 at 06:23:09PM -0400, Vittorio Giovara wrote: > Rotation, aspect ratio and pure matrix export. > > Signed-off-by: Vittorio Giovara > --- > tests/Makefile| 1 + > tests/fate-run.sh | 5 + >

Re: [libav-devel] [PATCH 2/3] fate: Add tests for mov display matrix

On Thu, Oct 13, 2016 at 6:52 PM, Diego Biurrun wrote: > On Thu, Oct 13, 2016 at 06:23:09PM -0400, Vittorio Giovara wrote: >> Rotation, aspect ratio and pure matrix export. >> >> Signed-off-by: Vittorio Giovara >> --- >> tests/Makefile

[libav-devel] [PATCH] fate: Add tests for mov display matrix

Rotation, aspect ratio and pure matrix export. Signed-off-by: Vittorio Giovara --- tests/Makefile| 1 + tests/fate-run.sh | 5 + tests/fate/mov.mak| 12 tests/ref/fate/mov-ar | 2 ++

Re: [libav-devel] [PATCH 2/3] fate: Add tests for mov display matrix

On Fri, Oct 14, 2016 at 01:07:39AM +0200, Diego Biurrun wrote: > On Thu, Oct 13, 2016 at 07:02:35PM -0400, Vittorio Giovara wrote: > > On Thu, Oct 13, 2016 at 6:52 PM, Diego Biurrun wrote: > > > On Thu, Oct 13, 2016 at 06:23:09PM -0400, Vittorio Giovara wrote: > > >> ---

[libav-devel] [PATCH 2/2] build: Drop arch-specific checkasm Makefiles

They only contain one line and will never get expanded. --- tests/checkasm/Makefile | 4 +++- tests/checkasm/aarch64/Makefile | 1 - tests/checkasm/arm/Makefile | 1 - tests/checkasm/x86/Makefile | 1 - 4 files changed, 3 insertions(+), 4 deletions(-) delete mode 100644

[libav-devel] [PATCH 1/2] build: checkasm: Drop duplicate yasm recipe

Also move yasm recipe next to the other local pattern rules for .o files. --- Makefile| 5 + library.mak | 5 - tests/checkasm/x86/Makefile | 5 - 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index

[libav-devel] [PATCH 4/7] build: Make standalone assembler command-line-selectable

--- configure | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/configure b/configure index d03707e..4d5dcf3 100755 --- a/configure +++ b/configure @@ -261,7 +261,8 @@ Toolchain options: --toolchain=NAME set tool defaults according to NAME --nm=NM

[libav-devel] [PATCH 7/7] build: Prefer NASM assembler over YASM

NASM is more actively maintained and permits generating dependency information as a sideeffect of assembling, thus cutting build times in half. --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index fee8f00..8e9f313 100755 --- a/configure

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

On Thu, Oct 13, 2016 at 04:02:34PM +0200, Alexandra Hájková wrote: > From: Pierre Edouard Lepere > > Initially written by Pierre Edouard Lepere > , > extended by James Almer . > > Signed-off-by:

Re: [libav-devel] [PATCH] file protocol: handle the file: protocol string in file_check

On Thu, 13 Oct 2016, Anton Khirnov wrote: This is consistent with what file_open() does. CC: libav-sta...@libav.org --- libavformat/file.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) LGTM // Martin ___ libav-devel mailing list

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

On Thu, 13 Oct 2016, Diego Biurrun wrote: On Wed, Oct 12, 2016 at 06:24:40PM +0200, Alexandra Hájková wrote: --- /dev/null +++ b/tests/checkasm/hevc_add_res.c @@ -0,0 +1,84 @@ + +#define randomize_buffers(buf, size)\ +do {\ +int

Re: [libav-devel] [PATCH 7/9] qsv{dec, enc}: always use an internal mfxFrameSurface1

Quoting Diego Biurrun (2016-10-13 00:46:55) > On Tue, Oct 11, 2016 at 09:34:33PM +0200, Anton Khirnov wrote: > > For encoding, this avoids modifying the input surface, which we are not > > allowed to do. > > This will also be useful in the following commits. > > --- > > libavcodec/qsv_internal.h

[libav-devel] [PATCH] file protocol: handle the file: protocol string in file_check

This is consistent with what file_open() does. CC: libav-sta...@libav.org --- libavformat/file.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/file.c b/libavformat/file.c index 8683c1b..27ce4de 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@

Re: [libav-devel] [PATCH 1/3] checkasm: add vp9dsp.itxfm_add tests.

On 12/10/2016 23:05, Martin Storsjö wrote: > From: "Ronald S. Bultje" > > This includes fixes by Henrik Gramner. > --- > tests/checkasm/vp9dsp.c | 272 > > 1 file changed, 272 insertions(+) > Seems fine, you might or might

[libav-devel] [PATCH] arm: vp9: Add NEON loop filters

This work is sponsored by, and copyright, Google. The implementation tries to have smart handling of cases where no pixels need the full filtering for the 8/16 width filters, skipping both calculation and writeback of the unmodified pixels in those cases. The actual effect of this is hard to test

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

On 13/10/2016 13:57, Alexandra Hájková wrote: > Because there's no 9 bit SIMD function, it's not tested but the code > looks simpler this way. And looks like there isn't much 9bit content out to warrant spending time on it right now =) lu ___

Re: [libav-devel] [PATCH] arm: vp9: Add NEON loop filters

On 13/10/2016 11:40, Martin Storsjö wrote: > The speedup vs C code is around 2-7x. The numbers are quite > inconclusive though, since the checkasm test runs multiple filterings > on top of each other, so later rounds might end up with different > codepaths (different decisions on which filter to

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

>> +#define randomize_buffers(buf, size)\ >> +do {\ >> +int j; \ >> +for (j = 0; j < size; j++) {\ >> +int16_t r = rnd(); \ >> +AV_WN16A(buf

[libav-devel] [PATCH] avformat/matroska: fix MatroskaVideoFieldOrder enum values

The spec says 9: Interlaced with bottom field displayed first and top field stored first 14: Interlaced with top field displayed first and bottom field stored first And avcodec.h states AV_FIELD_TB, //< Top coded first, bottom displayed first AV_FIELD_BT, //< Bottom coded

[libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

From: Pierre Edouard Lepere Initially written by Pierre Edouard Lepere , extended by James Almer . Signed-off-by: Alexandra Hájková --- libavcodec/x86/Makefile | 3

[libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

--- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 tests/checkasm/hevc_add_res.c

Re: [libav-devel] [PATCH] avconv: fix bitstream filter option parsing

On 10/10/2016 2:23 PM, Anton Khirnov wrote: > Quoting James Almer (2016-10-03 21:40:06) >> Arguments for bitstream filters weren't being parsed at all, and instead >> checked by av_bsf_get_by_name() as if they were part of the filter's name >> >> Signed-off-by: James Almer >>