[libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Niels Möller
The xll extension includes an hierachy of channel sets. I think I have understood the general idea (the file can can provide a channel set representing a downmix, followed by another channel set with the information needed to undo the downmix and generate additional channels), but not the fine

Re: [libav-devel] [PATCH] libavformat/mpegts: expose raw packet size

2014-02-12 Thread Anton Khirnov
Hi, On Fri, 31 Jan 2014 14:48:11 -0200, Leandro Dorileo leandro.maciel.dori...@intel.com wrote: We cannot easily determine if an mpeg TS's packet size is DVHS, FEC or so on, for that we need to expose the internal raw_packet_size field. Change-Id: I3eb179703b62748ae8bec6bd85a50760c0bc6d84

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Kostya Shishkov
On Wed, Feb 12, 2014 at 09:49:25AM +0100, Niels Möller wrote: The xll extension includes an hierachy of channel sets. I think I have understood the general idea (the file can can provide a channel set representing a downmix, followed by another channel set with the information needed to undo

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Niels Möller
Kostya Shishkov kostya.shish...@gmail.com writes: Well, IIRC you can have some independent channel sets that are alternative to each other (i.e. different sets of surround channels). So one has to determine what channel sets you want to decode But when parsing the stream, it's not what I want

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread madshi
2014-02-12 Niels Möller ni...@lysator.liu.se: Can you or Mathias (madshi) do that? And put the files either next to the sample files, or somewhere else where I can download them. I can do that. Is FLAC ok? For which files do you need this? Best regards, Mathias.

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Kostya Shishkov
On Wed, Feb 12, 2014 at 11:11:46AM +0100, Niels Möller wrote: Kostya Shishkov kostya.shish...@gmail.com writes: Well, IIRC you can have some independent channel sets that are alternative to each other (i.e. different sets of surround channels). So one has to determine what channel

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Niels Möller
madshi mad...@gmail.com writes: 2014-02-12 Niels Möller ni...@lysator.liu.se: Can you or Mathias (madshi) do that? And put the files either next to the sample files, or somewhere else where I can download them. I can do that. Great. Is FLAC ok? The XLL headers include some information

[libav-devel] [PATCH 1/1] header: fix mixed content warning due to forced http in img

2014-02-12 Thread Janne Grunau
Also do not force http for FATE. --- src/template_head2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/template_head2 b/src/template_head2 index 043d43f..e0b4fe6 100644 --- a/src/template_head2 +++ b/src/template_head2 @@ -8,7 +8,7 @@ header class=navbar

Re: [libav-devel] [PATCH 1/1] header: fix mixed content warning due to forced http in img

2014-02-12 Thread Luca Barbato
On 12/02/14 12:40, Janne Grunau wrote: Also do not force http for FATE. --- src/template_head2 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/template_head2 b/src/template_head2 index 043d43f..e0b4fe6 100644 --- a/src/template_head2 +++ b/src/template_head2

[libav-devel] [PATCH 1/1] h264: make context_count unsigned

2014-02-12 Thread Janne Grunau
Removes the bogus but scary looking warning 'libavcodec/h264.c:4529:49: warning: array subscript is below array bounds [-Warray-bounds]'. --- libavcodec/h264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index da2d4a5..9b5d6a0

Re: [libav-devel] [PATCH 1/1] h264: make context_count unsigned

2014-02-12 Thread Luca Barbato
On 12/02/14 12:52, Janne Grunau wrote: Removes the bogus but scary looking warning 'libavcodec/h264.c:4529:49: warning: array subscript is below array bounds [-Warray-bounds]'. --- libavcodec/h264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Probably ok, we never use -1 for

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread madshi
2014-02-12 Niels Möller ni...@lysator.liu.se: The XLL headers include some information about the original sample size (e.g, 20 vs 24 bits, where I guess 24 is the most common case), and I think the decoder is supposed to generate an output file with the same sample size. Not sure if that

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Christophe Gisquet
Hi, 2014-02-12 13:27 GMT+01:00 madshi mad...@gmail.com: According to eac3to, some 24bit files have the lower 4bit zeroed out, so they are really 20bit, but they are encoded as 24bit. Err, I would expect quantization/reconstruction/... to always create noisy bits, even if on the LSB and very

Re: [libav-devel] [PATCH 1/1] h264: make context_count unsigned

2014-02-12 Thread Janne Grunau
On 2014-02-12 13:08:43 +0100, Luca Barbato wrote: On 12/02/14 12:52, Janne Grunau wrote: Removes the bogus but scary looking warning 'libavcodec/h264.c:4529:49: warning: array subscript is below array bounds [-Warray-bounds]'. --- libavcodec/h264.c | 4 ++-- 1 file changed, 2

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Niels Möller
Christophe Gisquet christophe.gisq...@gmail.com writes: Are you sure it's not just a convenience to output the more practical, aligned 24bits? Like something in the bitstream actually indicating shift left 4 bits, and the audio is *actually* 20 bits? My inderstanding is that it really is 20

Re: [libav-devel] dca xll: Downmix coeffs in the channel set subheader

2014-02-12 Thread Kostya Shishkov
On Wed, Feb 12, 2014 at 02:14:01PM +0100, Niels Möller wrote: Christophe Gisquet christophe.gisq...@gmail.com writes: Are you sure it's not just a convenience to output the more practical, aligned 24bits? Like something in the bitstream actually indicating shift left 4 bits, and the audio

Re: [libav-devel] [PATCH 1/1] h264: make context_count unsigned

2014-02-12 Thread Luca Barbato
On 12/02/14 13:53, Janne Grunau wrote: On 2014-02-12 13:08:43 +0100, Luca Barbato wrote: On 12/02/14 12:52, Janne Grunau wrote: Removes the bogus but scary looking warning 'libavcodec/h264.c:4529:49: warning: array subscript is below array bounds [-Warray-bounds]'. --- libavcodec/h264.c | 4

Re: [libav-devel] [PATCH] libavfilter: example audio filtering program

2014-02-12 Thread Diego Biurrun
On Wed, Feb 12, 2014 at 07:30:57AM +0100, Anton Khirnov wrote: On Tue, 11 Feb 2014 21:44:34 +0100, Diego Biurrun di...@biurrun.de wrote: On Mon, Feb 10, 2014 at 09:23:40PM +0100, Anton Khirnov wrote: Based on a patch by Andrew Kelley superjo...@gmail.com --- configure

[libav-devel] [PATCH] h264: Report the missing PPS and SPS index

2014-02-12 Thread Luca Barbato
Useful for debugging. --- libavcodec/h264_parser.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index 1f82f52..0264c6b 100644 --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -261,13 +261,13 @@ static

Re: [libav-devel] [PATCHES] scalarproduct_and_madd_int16 and wma lossless

2014-02-12 Thread Christophe Gisquet
Hi, 2014-02-10 9:03 GMT+01:00 Kostya Shishkov kostya.shish...@gmail.com: What you suggest is still valid, and would catch things even if they changed, though. Maybe it's not worth warning about it at all. Well, the format allows 8N coefficients with N=1, so a file could theoretically contain

Re: [libav-devel] [PATCH] h264: Report the missing PPS and SPS index

2014-02-12 Thread Diego Biurrun
On Wed, Feb 12, 2014 at 03:44:27PM +0100, Luca Barbato wrote: --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -261,13 +261,13 @@ static inline int parse_nal_units(AVCodecParserContext *s, if (!h-pps_buffers[pps_id]) { av_log(h-avctx,

[libav-devel] [PATCH] build: doxy: Include code examples in Doxygen documentation

2014-02-12 Thread Diego Biurrun
--- Now without stray Make warnings. doc/Makefile | 2 +- library.mak | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/Makefile b/doc/Makefile index cf3fbab..6af8116 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -57,7 +57,7 @@ $(DOCS) doc/doxy/html: | doc/

[libav-devel] [PATCH 1/1] jv: detect partial packets in the demuxer

2014-02-12 Thread Janne Grunau
Fixes valgrind's use of initialized value warnings in fate-jv. --- libavformat/jvdec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/jvdec.c b/libavformat/jvdec.c index 006acec..84d55da 100644 --- a/libavformat/jvdec.c +++ b/libavformat/jvdec.c @@

Re: [libav-devel] [PATCH 1/1] jv: detect partial packets in the demuxer

2014-02-12 Thread Janne Grunau
On 2014-02-12 20:11:27 +0100, Janne Grunau wrote: Fixes valgrind's use of initialized value warnings in fate-jv. Commimt mesage changed to: Fixes fate-jv under valgrind which reports a different CRC for the last frame from a partial read. since it actually has different output. Janne

Re: [libav-devel] [PATCH 1/1] jv: detect partial packets in the demuxer

2014-02-12 Thread Luca Barbato
On 12/02/14 20:11, Janne Grunau wrote: Fixes valgrind's use of initialized value warnings in fate-jv. --- libavformat/jvdec.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Seems fine. ___ libav-devel mailing list

[libav-devel] [PATCH 2/3] h264: store current_sps_id inside the current sps

2014-02-12 Thread Vittorio Giovara
--- FATE says it's fine with this change. Vittorio libavcodec/h264.c| 5 ++--- libavcodec/h264.h| 2 +- libavcodec/h264_ps.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 8595909..701a5b1 100644 --- a/libavcodec/h264.c

[libav-devel] [PATCH 3/3] h264: drop outdated comments

2014-02-12 Thread Vittorio Giovara
--- Or at least they look that way. Any other findings would be welcome. Vittorio libavcodec/h264.c | 1 - libavcodec/h264.h | 6 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 701a5b1..8f2a3f1 100644 --- a/libavcodec/h264.c +++

[libav-devel] [PATCH 1/3] h264: print values in case of error

2014-02-12 Thread Vittorio Giovara
Also uniform error style and drop redudant information. --- Moar debugging! Vittorio libavcodec/h264.c| 23 +++ libavcodec/h264_parser.c | 8 libavcodec/h264_ps.c | 10 +- 3 files changed, 20 insertions(+), 21 deletions(-) diff --git

[libav-devel] [PATCH 1/2] configure: avserver does not need $ldl

2014-02-12 Thread Janne Grunau
Loadable plugins were removed in d010e95f86089abe9a3d4d4a66ac8102312d28a4. --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 1afba25..afb7680 100755 --- a/configure +++ b/configure @@ -2041,7 +2041,6 @@ avplay_select=rdft avprobe_deps=avcodec avformat

[libav-devel] [PATCH 2/2] configure: link only avconv against -lvpdau if needed

2014-02-12 Thread Janne Grunau
Write all LIBS-$program variables to config.mak. Bug-Id: 635 --- configure | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index afb7680..a150618 100755 --- a/configure +++ b/configure @@ -2038,6 +2038,7 @@ avconv_select=aformat_filter

Re: [libav-devel] [PATCH 1/3] h264: print values in case of error

2014-02-12 Thread Luca Barbato
On 13/02/14 00:47, Vittorio Giovara wrote: Also uniform error style and drop redudant information. --- Moar debugging! Vittorio libavcodec/h264.c| 23 +++ libavcodec/h264_parser.c | 8 libavcodec/h264_ps.c | 10 +- 3 files changed, 20

Re: [libav-devel] [PATCH 2/3] h264: store current_sps_id inside the current sps

2014-02-12 Thread Luca Barbato
On 13/02/14 00:47, Vittorio Giovara wrote: --- FATE says it's fine with this change. Vittorio Needs more explanation on why, I know but others do not. lu ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 2/3] h264: store current_sps_id inside the current sps

2014-02-12 Thread Janne Grunau
On 2014-02-13 00:47:28 +0100, Vittorio Giovara wrote: --- FATE says it's fine with this change. Vittorio should make a difference libavcodec/h264.c| 5 ++--- libavcodec/h264.h| 2 +- libavcodec/h264_ps.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) ok, not sure why I

Re: [libav-devel] [PATCH 3/3] h264: drop outdated comments

2014-02-12 Thread Janne Grunau
On 2014-02-13 00:47:29 +0100, Vittorio Giovara wrote: --- Or at least they look that way. Any other findings would be welcome. Vittorio libavcodec/h264.c | 1 - libavcodec/h264.h | 6 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/libavcodec/h264.c

[libav-devel] [PATCH] h264: name buffering period SEI type consistently

2014-02-12 Thread Vittorio Giovara
--- libavcodec/h264.h | 2 +- libavcodec/h264_sei.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264.h b/libavcodec/h264.h index 21b7996..f29bc6a 100644 --- a/libavcodec/h264.h +++ b/libavcodec/h264.h @@ -120,7 +120,7 @@ enum { * SEI message types */

Re: [libav-devel] [PATCH] h264: name buffering period SEI type consistently

2014-02-12 Thread Luca Barbato
On 13/02/14 02:26, Vittorio Giovara wrote: --- libavcodec/h264.h | 2 +- libavcodec/h264_sei.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] libavfilter: example audio filtering program

2014-02-12 Thread Anton Khirnov
On Wed, 12 Feb 2014 15:25:15 +0100, Diego Biurrun di...@biurrun.de wrote: On Wed, Feb 12, 2014 at 07:30:57AM +0100, Anton Khirnov wrote: On Tue, 11 Feb 2014 21:44:34 +0100, Diego Biurrun di...@biurrun.de wrote: On Mon, Feb 10, 2014 at 09:23:40PM +0100, Anton Khirnov wrote: Based on a

Re: [libav-devel] [PATCH 1/2] configure: avserver does not need $ldl

2014-02-12 Thread Martin Storsjö
On Thu, 13 Feb 2014, Janne Grunau wrote: Loadable plugins were removed in d010e95f86089abe9a3d4d4a66ac8102312d28a4. --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 1afba25..afb7680 100755 --- a/configure +++ b/configure @@ -2041,7 +2041,6 @@

[libav-devel] [PATCH] libavfilter: example audio filtering program

2014-02-12 Thread Anton Khirnov
Based on a patch by Andrew Kelley superjo...@gmail.com --- configure |2 + doc/Makefile|3 +- doc/examples/filter_audio.c | 364 +++ 3 files changed, 368 insertions(+), 1 deletion(-) create mode 100644