Re: [libav-devel] [FFmpeg-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

On Mon, Dec 26, 2016 at 2:52 PM, Ronald S. Bultje wrote: > Hm, OK, I think it affects unix64/x86-32 also when using 32-byte > alignment. We do use the stack pointer then. On 32-bit and UNIX64 it simply uses a different caller-saved register which doesn't require additional

Re: [libav-devel] [FFmpeg-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

Hi, On Mon, Dec 26, 2016 at 4:53 AM, Henrik Gramner wrote: > On Mon, Dec 26, 2016 at 2:32 AM, Ronald S. Bultje > wrote: > > I know I'm terribly nitpicking here for the limited scope of the comment, > > but this only matters for functions that have a

Re: [libav-devel] [PATCH 1/4] frame: add left/top cropping fields to AVFrame

Quoting Vittorio Giovara (2016-12-19 13:18:13) > On Mon, Dec 19, 2016 at 1:02 PM, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2016-12-19 10:11:29) > >> I have a couple of points about this, in random order: > >> > >> 1. I had thought agreement was more towards a side

Re: [libav-devel] [PATCH 2/5] libautil: add support for AV_HWDEVICE_TYPE_D3D11VA

Quoting wm4 (2016-12-20 16:02:20) > On Mon, 19 Dec 2016 13:04:38 +0100 > Anton Khirnov wrote: > > > Quoting Steve Lhomme (2016-12-16 11:05:40) > > > From: Steve Lhomme > > > > > > > +ZeroMemory(, sizeof(texDesc)); > > > > Isn't this just memset(..,

Re: [libav-devel] [PATCH] build: Move build-system-related helper files to a separate subdirectory

Quoting Diego Biurrun (2016-12-25 13:22:05) > On Sat, Dec 24, 2016 at 02:54:19PM -0300, James Almer wrote: > > On 12/22/2016 9:07 AM, Diego Biurrun wrote: > > > This unclutters the top-level directory and groups related files together. > > > --- > > > > > > Now with "avbuild" as directory to

Re: [libav-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

On 25/12/2016 20:24, Henrik Gramner wrote: > When allocating stack space with an alignment requirement that is > larger than the current stack alignment we need to store a copy of > the original stack pointer in order to be able to restore it later. > > If we chose to use another register for

Re: [libav-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

On Mon, Dec 26, 2016 at 2:32 AM, Ronald S. Bultje wrote: > I know I'm terribly nitpicking here for the limited scope of the comment, > but this only matters for functions that have a return value. Do you think > it makes sense to allow functions to opt out of this requirement