[libav-devel] [PATCH] AMF SDK integration code cleanup: replace writer_id option to LIBAV_AMF_WRITER_ID

AMFTraceWriter is abstraction to configure how AMF outputs its logs for current process, not for component. Example instances of AMFTraceWriter can be * FileWriter * SocketWriter * DebugOutputWriter * LibavWriter (output using av_log function). AMFTraceWriter can be

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

On Tue, Feb 27, 2018 at 08:39:48PM +0100, Luca Barbato wrote: > On 27/02/2018 19:24, Kravchenko, Alexander wrote: > > > -Original Message- > > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > > > Barbato > > > Sent: Tuesday, February 27, 2018 8:10 PM > > > To:

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

On 27/02/2018 19:24, Kravchenko, Alexander wrote: -Original Message- From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca Barbato Sent: Tuesday, February 27, 2018 8:10 PM To: libav-devel@libav.org Subject: Re: [libav-devel] [PATCH] AMF SDK integration code cleanup:

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Tuesday, February 27, 2018 8:10 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: > remove writer_id option & move

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

On 27/02/2018 16:13, Vittorio Giovara wrote: On Tue, Feb 27, 2018 at 5:25 AM, Luca Barbato wrote: On 26/02/2018 18:21, Vittorio Giovara wrote: On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato wrote: --- + +if (avctx->qmin > 0) +

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

On 27/02/2018 14:59, Kravchenko, Alexander wrote:> If we use multiple LibavWriter objects in one process, we will have duplication of output in avlib log. To prevent this scenario we should use one constant writer_id . Thanks for the explanation, I'm fine with this change now. lu

[libav-devel] [PATCH] examples: Use new API for transcoding example

Note: My use of avcodec_send_frame is slightly different from the encode_video example in that I distinguish between EOF and other negative return values. I found this to be necessary for my example files and it matches the documentation. ---  doc/examples/transcode_aac.c | 109

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

On Tue, Feb 27, 2018 at 5:25 AM, Luca Barbato wrote: > On 26/02/2018 18:21, Vittorio Giovara wrote: > >> On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato >> wrote: >> >> --- >>> >>> + >>> +if (avctx->qmin > 0) >>> +enccfg.rc_min_quantizer =

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Kravchenko, Alexander > Sent: February 27, 2018 8:59 AM > To: libav development > Subject: Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove > writer_id

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

> > Hi, I thought the library user would like to have a separate writer_id > since I assumed that the identifier is used for logging and resource > accounting purposes (e.g. browsers using this backend might want to use > a separate identifier per-tab). > > The common options pattern is used when

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

On 27/02/2018 11:51, Kravchenko, Alexander wrote: From 4d0efe3f5fd03db188f41d52ee9549a046939d1d Mon Sep 17 00:00:00 2001 From: diamond88 Date: Tue, 27 Feb 2018 09:46:08 +0300 Subject: [PATCH] AMF SDK integration code cleanup: remove writer_id option & move

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

> -Original Message- > From: Kravchenko, Alexander > Sent: Tuesday, February 27, 2018 2:47 PM > To: libav development > Subject: RE: [libav-devel] [PATCH] AMF SDK integration code cleanup: > remove writer_id option & move AMF_COMMON_OPTIONS out from > amfenc.h > > Comments are inline > > >

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

Comments are inline > -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Diego > Biurrun > Sent: Tuesday, February 27, 2018 2:11 PM > To: libav development > Subject: Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: > remove writer_id

Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

This patch accmoplishes multiple unrelated things. Ideally you would submit one patch per change. Also, there is no explanation of why you are doing these changes in the commit message. On Tue, Feb 27, 2018 at 10:34:27AM +, Kravchenko, Alexander wrote: > From

[libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

From 4d0efe3f5fd03db188f41d52ee9549a046939d1d Mon Sep 17 00:00:00 2001 From: diamond88 Date: Tue, 27 Feb 2018 09:46:08 +0300 Subject: [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h ---

[libav-devel] [PATCH] AMF SDK integration code cleanup: remove writer_id option & move AMF_COMMON_OPTIONS out from amfenc.h

This e-mail and any attachment(s) are intended only for the recipient(s) named above and others who have been specifically authorized to receive them. They may contain confidential information. If you are not the intended recipient, please do not read this

Re: [libav-devel] [PATCH] Support AV1 encoding using libaom

On 26/02/2018 18:21, Vittorio Giovara wrote: On Mon, Feb 26, 2018 at 12:10 AM, Luca Barbato wrote: --- + +if (avctx->qmin > 0) +enccfg.rc_min_quantizer = avctx->qmin; +if (avctx->qmax > 0) +enccfg.rc_max_quantizer = avctx->qmax; + +#if