Re: [libav-devel] [PATCH] matroskaenc: factor ts_offset in block timecode computation

On Wed, Feb 15, 2017 at 03:29:15PM -0700, John Stebbins wrote: > ts_offset was added to cluster timecode, but then effectively subtracted > back off the block timecode Factor ts_offset in*TO* block timecode computation? The commit title had me confused for a moment. Diego

Re: [libav-devel] [PATCH] vf_fade: Make sure to not miss the last lines of a frame

On Thu, Feb 16, 2017 at 12:33:36PM +0200, Martin Storsjö wrote: > When slice_h is rounded up due to chroma subsampling, there's > a risk that jobnr * slice_h exceeds frame->height. > > Prior to a638e9184d63, this wasn't an issue for the last slice > of a frame, since slice_end was set to

[libav-devel] [PATCH 3/5] build: Split logic for building examples off into a separate Makefile

--- Makefile | 4 ++-- doc/Makefile | 23 ++- doc/examples/Makefile | 26 ++ 3 files changed, 30 insertions(+), 23 deletions(-) create mode 100644 doc/examples/Makefile diff --git a/Makefile b/Makefile index b14b29d..c96e079

[libav-devel] [PATCH 4/5] build: Separate logic for building examples from that for building avtools

--- Makefile | 2 +- doc/examples/Makefile | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c96e079..2932e6e 100644 --- a/Makefile +++ b/Makefile @@ -165,7 +165,7 @@ $(1)$(EXESUF): FF_EXTRALIBS += $(EXTRALIBS-$(1)) -include

[libav-devel] [PATCH 2/5] build: Avoid duplication in examples lists

--- doc/Makefile | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/doc/Makefile b/doc/Makefile index bd5c2e4..365ac5d 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -25,16 +25,9 @@ DOC_EXAMPLES-$(CONFIG_METADATA_EXAMPLE) += metadata

[libav-devel] [PATCH 1/5] build: Drop leftover reference to old EXAMPLES logic

--- Noticed one more stray EXAMPLES reference. Makefile | 2 +- doc/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 98eb3ab..b14b29d 100644 --- a/Makefile +++ b/Makefile @@ -131,7 +131,7 @@ avbuild/.config: $(CONFIGURABLE_COMPONENTS)

[libav-devel] [PATCH 5/5] build: Move cli tool sources to a separate subdirectory

This unclutters the top-level directory and groups related files together. --- Cleaner and simpler now that the logic is separate from the examples. Makefile | 54 +++--- avtools/Makefile | 52

Re: [libav-devel] [PATCH] aarch64: Add parentheses around the offset parameter in movrel

On Thu, Feb 16, 2017 at 09:19:07AM +0200, Martin Storsjö wrote: > This fixes building with clang for linux with PIC enabled. > --- > libavutil/aarch64/asm.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) probably OK Diego ___ libav-devel

Re: [libav-devel] [PATCH 3/3] configure: Restructure the way check_pkg_config() operates

On Sat, Feb 11, 2017 at 07:08:37PM +0100, Diego Biurrun wrote: > --- a/configure > +++ b/configure > @@ -4732,9 +4721,8 @@ enabled omx_rpi && { check_header OMX_Core.h > || > +enabled openssl && { { check_pkg_config ""

Re: [libav-devel] [PATCH] configure: Handle SDL version check through pkg-config

On Wed, Feb 15, 2017 at 01:21:42PM +0100, Diego Biurrun wrote: > --- > > Now keeps the check_pkg_config call to ensure that the SDL libs are > actually usable. > > configure | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) OKed b

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Wed, Feb 15, 2017 at 11:32:47AM -0500, Vittorio Giovara wrote: > On Wed, Feb 15, 2017 at 11:29 AM, wm4 wrote: > > On Wed, 15 Feb 2017 11:16:40 -0500 > > Vittorio Giovara wrote: > > > >> On Wed, Feb 15, 2017 at 11:12 AM, wm4

Re: [libav-devel] [PATCH] fate: Add another SVQ3 test to increase coverage

On Tue, Feb 14, 2017 at 09:08:14PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2017-02-05 13:14:46) > > --- /dev/null > > +++ b/tests/ref/fate/svq3-2 > > @@ -0,0 +1,20 @@ > > +#tb 0: 1/19200 > > +0, -2, -2,0, 185280, 0x061c0d

[libav-devel] [PATCH] configure: Handle SDL version check through pkg-config

--- Now keeps the check_pkg_config call to ensure that the SDL libs are actually usable. configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index b8cbe17..4635b73 100755 --- a/configure +++ b/configure @@ -4748,9 +4748,7 @@ if enabled nvenc;

[libav-devel] [PATCH 3/3] build: Prefer NASM assembler over YASM

NASM is more actively maintained and permits generating dependency information as a sideeffect of assembling, thus cutting build times in half. --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 08c1e5d..a217a69 100755 ---

[libav-devel] [PATCH 2/3] build: Allow generating dependencies as a side-effect of assembling

--- Makefile | 6 +++--- configure | 8 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index d6ad753..a4a0fba 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,7 @@ CCFLAGS = $(CPPFLAGS) $(CFLAGS) OBJCFLAGS += $(EOBJCFLAGS) OBJCCFLAGS =

[libav-devel] [PATCH 1/3] build: Generalize yasm/nasm-related variable names

None of them are specific to the YASM assembler. --- Same as before, better names for the following are welcome: - --disable-yasm disable use of nasm/yasm assembly + --disable-assembler disable use of standalone assembly Plain "nasm" would be possible, the syntax is nasm after

[libav-devel] [v3] x86-assembler-related build system improvements

Third time's the charm? Due to popular demand this iteration of the set gets rid of the requirement of writing assembly %include statements with full source path. Now files in the current directory need not have the full path as part of the %include, same as for .c files.

Re: [libav-devel] [PATCH 3/4] Rename "tools" subdirectory to "utilities"

On Mon, Feb 13, 2017 at 05:16:00PM +0100, Diego Biurrun wrote: > On Mon, Feb 13, 2017 at 10:51:38AM -0500, Vittorio Giovara wrote: > > On Sat, Feb 11, 2017 at 2:58 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > > > On 06/01/2017 14:45, Diego Biurrun wrote: > >

Re: [libav-devel] [PATCH 3/4] Rename "tools" subdirectory to "utilities"

On Mon, Feb 13, 2017 at 10:51:38AM -0500, Vittorio Giovara wrote: > On Sat, Feb 11, 2017 at 2:58 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > > On 06/01/2017 14:45, Diego Biurrun wrote: > >> --- > > > > Seems fine. > > I don't mean to bikeshed the nam

Re: [libav-devel] [PATCH] aarch64: vp9lpf: Fix broken indentation/vertical alignment

On Sat, Feb 11, 2017 at 11:22:13PM +0200, Martin Storsjö wrote: > --- > libavcodec/aarch64/vp9lpf_neon.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] aac: Validate the sbr sample rate earlier

On Sat, Feb 11, 2017 at 03:44:20PM +0100, Luca Barbato wrote: > Avoid a floating point exception. > > Bug-Id: 1027 aac: Validate the sbr sample rate before using the value OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/3] configure: Check for xcb as well as xcb-shape before enabling libxcb

On Sat, Feb 11, 2017 at 07:22:13PM +0100, Luca Barbato wrote: > On 11/02/2017 19:08, Diego Biurrun wrote: > > -libx262 > > lgplv3 > > +libx262 > > +libxcb_shape > > That's a stray change, but I do not care much about it. I had it separate, but i

[libav-devel] [PATCH 1/3] configure: Check for xcb as well as xcb-shape before enabling libxcb

Newer versions of libxcb have xcb-foo pkg-config files that do not declare their xcb dependency so that required linker flags will not be generated. --- configure | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 9ebc3bf..3ca8d87 100755 ---

[libav-devel] [PATCH 3/3] configure: Restructure the way check_pkg_config() operates

Have check_pkg_config() enable variables and set cflags and extralibs instead of relegating that task to require_pkg_config. This simplifies require_pkg_config(), is consistent with what other helper functions like check_lib() do and allows getting rid of some manual variable setting in places

[libav-devel] [PATCH 2/3] configure: Handle SDL version check through pkg-config

--- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 3ca8d87..d7d4f94 100755 --- a/configure +++ b/configure @@ -4747,9 +4747,9 @@ if enabled nvenc; then require_cpp_condition nvEncodeAPI.h "NVENCAPI_MAJOR_VERSION >= 6" fi -if

Re: [libav-devel] [PATCH] configure: Move up the avbuild directory creation

On Fri, Feb 10, 2017 at 07:31:34PM +, Luca Barbato wrote: > The early check for inconsistent in-source vs out-of-source build > would not be able to generate a config.log otherwise. The early check for inconsistent in-source vs out-of-source build cannot generate a config.log otherwise.

[libav-devel] [RFC] [PATCH] aac: Do not signal AAC stream detection if fewer than 3 frames were found

This avoids (mis)detection of severely damaged or fuzzed streams and all sorts of crashes or failures down the line. Bug-Id: 1027 --- I have no idea how many (or any at all) real AAC streams this might stop from being detected, but trying not to crash in damaged or malicious streams down the

[libav-devel] [PATCH 2/2] build: Move cli tool sources to a separate subdirectory

This unclutters the top-level directory and groups related files together. --- Got rid of some code duplication that was still present in the previous version. Makefile | 49 -- avtools/Makefile | 44

[libav-devel] [PATCH 1/2] build: Drop leftover LIB_EXAMPLES reference

--- doc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/Makefile b/doc/Makefile index bda8153..bd5c2e4 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -73,7 +73,7 @@ $(DOCS) doc/doxy/html: | doc/ $(DOC_EXAMPLES:%$(EXESUF)=%.o): | doc/examples OBJDIRS +=

Re: [libav-devel] [PATCH] dv: Convert to the new bitreader

On Thu, Feb 09, 2017 at 05:41:21PM +0100, Diego Biurrun wrote: > --- a/libavcodec/bitstream.h > +++ b/libavcodec/bitstream.h > @@ -384,4 +384,32 @@ static inline int bitstream_apply_sign(BitstreamContext > *bc, int val) > > +static inline void bitstream_unget(BitstreamCon

[libav-devel] [PATCH] dv: Convert to the new bitreader

From: Luca Barbato --- Moved the bitstream_unwind() and bitstream_unget() functions to bitstream.h as requested by Anton. libavcodec/bitstream.h | 28 +++ libavcodec/dvdec.c | 94 ++ 2 files changed, 69

Re: [libav-devel] [PATCH 6/6] aarch64: vp9itxfm: Fix incorrect vertical alignment

On Thu, Feb 09, 2017 at 02:30:01PM +0200, Martin Storsjö wrote: > --- > libavcodec/aarch64/vp9itxfm_neon.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] configure: Correctly recurse in do_check_deps()

On Wed, Feb 08, 2017 at 08:56:56PM +0200, Martin Storsjö wrote: > On Wed, 8 Feb 2017, Diego Biurrun wrote: > > >Fixes all sorts of configuration problems introducec by dad7a9c7c0ae > >on non-Linux, non-vanilla configs. Also removes a line made redundant > >in that

[libav-devel] [PATCH] build: Fine-grained link-time dependency settings

Previously, all link-time dependencies were added for all libraries, resulting in bogus link-time dependencies since not all dependencies are shared across libraries. Also, in some cases like libavutil, not all dependencies were taken into account, resulting in some cases of underlinking. To

[libav-devel] [PATCH] configure: Correctly recurse in do_check_deps()

Fixes all sorts of configuration problems introducec by dad7a9c7c0ae on non-Linux, non-vanilla configs. Also removes a line made redundant in that commit. --- Improved log message, removed a (now) stray line. Nonetheless, please shoot me. configure | 3 +-- 1 file changed, 1 insertion(+), 2

[libav-devel] [PATCH] configure: Correctly recurse in do_check_deps()

Fixes all sorts of configuration problems on non-Linux, non-vanilla configs. --- Please shoot me. configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 7d39aca..6f2ab7b 100755 --- a/configure +++ b/configure @@ -627,7 +627,7 @@

[libav-devel] [PATCH] configure: Correctly recurse in do_check_deps()

--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 7d39aca..6f2ab7b 100755 --- a/configure +++ b/configure @@ -627,7 +627,7 @@ do_check_deps(){ eval dep_ifn="\$${cfg}_if_any" pushvar cfg dep_all dep_any dep_con dep_sel

Re: [libav-devel] [PATCH] asfdec: Account for different Format Data sizes

On Wed, Feb 08, 2017 at 12:51:37PM +0100, Alexandra Hájková wrote: > Some muxers may use the BMP_HEADER Format Data size instead > of the ASF-specific one. > > Bug-Id: 1020 > --- Again: CC: libav-sta...@libav.org > --- a/libavformat/asfdec.c > +++ b/libavformat/asfdec.c > @@ -691,20 +691,22 @@

Re: [libav-devel] [PATCH] asfdec: use the BMP_HEADER specific Format Data size instead of

On Tue, Feb 07, 2017 at 02:15:55PM +0100, Alexandra Hájková wrote: > the ASF specific Format Data size. Fixes video decoding problem > part of the bug 1020. See the other review for log message hints. > --- a/libavformat/asfdec.c > +++ b/libavformat/asfdec.c > @@ -691,16 +691,18 @@ static int

Re: [libav-devel] [PATCH] asfdec: use the BMP_HEADER specific Format Data size instead of

On Tue, Feb 07, 2017 at 02:46:45PM +0100, Luca Barbato wrote: > On 07/02/2017 14:15, Alexandra Hájková wrote: > > the ASF specific Format Data size. Fixes video decoding problem > > part of the bug 1020. > > asfdec: Account for different Format Data sizes > > Some muxers may use the BMP_HEADER

[libav-devel] [PATCH] configure: Add name parameter to require_pkg_config() helper function

This allows distinguishing between the internal variable name for external libraries and the pkg-config package name. Having both names available avoids special-casing outside the helper function when the two identifiers do not match. --- Moved the shift according to Janne's suggestion.

[libav-devel] [PATCH] configure: Rework dependency handling for conflicting components

This makes the feature more visible and obvious. --- Changed to use _conflict instead of _not as Janne suggested. configure | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/configure b/configure index 5701f99..0d1815f 100755 --- a/configure +++

[libav-devel] [PATCH] Use bitstream_init8() where appropriate

--- libavcodec/4xm.c | 6 +++--- libavcodec/adxdec.c | 2 +- libavcodec/asvdec.c | 2 +- libavcodec/atrac1.c | 2 +- libavcodec/atrac3.c | 10 +- libavcodec/avs.c | 2 +- libavcodec/cdxl.c

[libav-devel] [PATCH] build: Move cli tool sources to a separate subdirectory

This unclutters the top-level directory and groups related files together. --- Generates the binaries in the top-level dir now. Bah ... Makefile | 45 +++- avtools/Makefile | 56 ++

Re: [libav-devel] [PATCH 07/12] configure: Add name parameter to require_pkg_config() helper function

On Sun, Feb 05, 2017 at 11:41:40AM +0100, Janne Grunau wrote: > On 2017-01-24 18:12:47 +0100, Diego Biurrun wrote: > > This allows distinguishing between the internal variable name for > > external libraries and the pkg-config package name. Having both > > names available

[libav-devel] [PATCH] fate: Add another SVQ3 test to increase coverage

--- This covers a regression I introduced a long time ago. tests/fate/qt.mak | 10 -- tests/ref/fate/{svq3 => svq3-1} | 0 tests/ref/fate/svq3-2 | 20 3 files changed, 28 insertions(+), 2 deletions(-) rename tests/ref/fate/{svq3 => svq3-1}

Re: [libav-devel] [PATCH 07/12] configure: Add name parameter to require_pkg_config() helper function

On Sun, Feb 05, 2017 at 11:41:40AM +0100, Janne Grunau wrote: > On 2017-01-24 18:12:47 +0100, Diego Biurrun wrote: > > --- a/configure > > +++ b/configure > > @@ -4776,11 +4779,11 @@ if enabled libcdio; then > > fi > > > > if enabled libxcb; then &g

Re: [libav-devel] [PATCH] opus: Fix a typo

On Sat, Feb 04, 2017 at 03:09:35PM +0100, Luca Barbato wrote: > --- a/libavcodec/opus.c > +++ b/libavcodec/opus.c > @@ -327,7 +327,7 @@ av_cold int ff_opus_parse_extradata(AVCodecContext *avctx, > > channels = avctx->extradata ? extradata[9] : (avctx->channels == 1) ? 1 > : 2; > if

Re: [libav-devel] [PATCH] configure: Add stdlib.h #include to CPPFLAGS check helper functions

On Sat, Feb 04, 2017 at 01:56:25PM +0100, Luca Barbato wrote: > On 04/02/2017 13:40, Diego Biurrun wrote: > > This ensures that added CPPFLAGS are validated against libc headers. > > --- > > > > Forgot the host cppflags check function .. > > What's t

[libav-devel] [PATCH] configure: Add stdlib.h #include to CPPFLAGS check helper functions

This ensures that added CPPFLAGS are validated against libc headers. --- Forgot the host cppflags check function .. configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 555dc88..32ab732 100755 --- a/configure +++ b/configure @@ -872,7

[libav-devel] [PATCH 1/2] configure: Add stdlib.h #include to CPPFLAGS check helper function

This ensures that added CPPFLAGS are validated against libc headers. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 555dc88..ae63dcc 100755 --- a/configure +++ b/configure @@ -872,7 +872,7 @@ check_code(){ check_cppflags(){ log

[libav-devel] [PATCH 2/2] configure: Use cppflags check helper functions where appropriate

--- configure | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/configure b/configure index ae63dcc..3fdbe5a 100755 --- a/configure +++ b/configure @@ -3774,18 +3774,12 @@ add_cppflags -D_ISOC99_SOURCE # some compilers silently accept -std=c11, so we also need

Re: [libav-devel] [PATCH] Add Apple Pixlet decoder

On Fri, Feb 03, 2017 at 05:57:33PM +0100, Vittorio Giovara wrote: > --- /dev/null > +++ b/libavcodec/pixlet.c > @@ -0,0 +1,692 @@ > +static int read_high_coeffs(AVCodecContext *avctx, uint8_t *src, int16_t > *dst, > +int size, int c, int a, int d, > +

Re: [libav-devel] [PATCH] mov: Rework stsc index validation

On Fri, Feb 03, 2017 at 01:51:50PM +0100, Diego Biurrun wrote: > On Fri, Feb 03, 2017 at 01:05:27PM +0100, Vittorio Giovara wrote: > > In order to avoid potential integer overflow change the comparison > > andmake sure to use the same unsigned type for both elements. > &

Re: [libav-devel] [PATCH] mov: Rework stsc index validation

On Fri, Feb 03, 2017 at 01:05:27PM +0100, Vittorio Giovara wrote: > In order to avoid potential integer overflow change the comparison > andmake sure to use the same unsigned type for both elements. In order to avoid a potential integer overflow change the comparison and make sure to use the same

Re: [libav-devel] [PATCH] build: Ignore generated .version files

On Tue, Jan 31, 2017 at 03:47:06PM +0100, Diego Biurrun wrote: > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) OKed by Vittorio on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listi

Re: [libav-devel] [PATCH] asm: Consistently uppercase SECTION markers

On Fri, Feb 03, 2017 at 07:27:26AM +0100, Diego Biurrun wrote: > --- > libavcodec/x86/dnxhdenc.asm | 2 +- > libavcodec/x86/hevc_idct.asm | 2 +- > libavcodec/x86/vc1dsp.asm| 2 +- > libavutil/x86/x86inc.asm | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-)

[libav-devel] [PATCH] asm: Consistently uppercase SECTION markers

--- libavcodec/x86/dnxhdenc.asm | 2 +- libavcodec/x86/hevc_idct.asm | 2 +- libavcodec/x86/vc1dsp.asm| 2 +- libavutil/x86/x86inc.asm | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/x86/dnxhdenc.asm b/libavcodec/x86/dnxhdenc.asm index d39b07b..091f322

[libav-devel] x86-assembler-related build system improvements

This is the next iteration of a set I sent back in October. I simplified it considerably, fixed a few bugs and dropped some unnecessary bits. Apart from some general refactoring, this adds the ability to generate dependency files as a side-effect of assembling, which cuts build times in half. This

Re: [libav-devel] [PATCH] x86: Consistently use full path for assembly %includes everywhere

On Thu, Feb 02, 2017 at 06:51:37PM +0100, Diego Biurrun wrote: > On Wed, Oct 26, 2016 at 07:22:40PM +0200, Diego Biurrun wrote: > > On Wed, Oct 26, 2016 at 09:17:36AM +0300, Martin Storsjö wrote: > > > On Wed, 26 Oct 2016, Diego Biurrun wrote: > > > > > >

[libav-devel] [PATCH 3/4] build: Allow generating dependencies as a side-effect of assembling

--- Makefile | 4 ++-- configure | 8 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index aafa28e..16b68f1 100644 --- a/Makefile +++ b/Makefile @@ -42,6 +42,7 @@ endef COMPILE_C = $(call COMPILE,CC) COMPILE_S = $(call COMPILE,AS) COMPILE_M =

[libav-devel] [PATCH 4/4] build: Prefer NASM assembler over YASM

NASM is more actively maintained and permits generating dependency information as a sideeffect of assembling, thus cutting build times in half. --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index d31421a..0c70ad7 100755 ---

[libav-devel] [PATCH 1/4] x86: Consistently use full path for assembly %includes everywhere

We currently use a mix of full path and -I assembler command line flags. --- I sent this before. It helps with templatizing the recipe for generating object files from assembly files, so it makes my life easier... Makefile| 4 ++-- libavresample/x86/audio_convert.asm

[libav-devel] [PATCH 2/4] build: Generalize yasm/nasm-related variable names

None of them are specific to the YASM assembler. --- Better names for the following welcome: - --disable-yasm disable use of nasm/yasm assembly + --disable-assembler disable use of standalone assembly Plain "nasm" would be possible, the syntax is nasm after all. Or "x86-asm" or

Re: [libav-devel] [PATCH] x86: Consistently use full path for assembly %includes everywhere

On Wed, Oct 26, 2016 at 07:22:40PM +0200, Diego Biurrun wrote: > On Wed, Oct 26, 2016 at 09:17:36AM +0300, Martin Storsjö wrote: > > On Wed, 26 Oct 2016, Diego Biurrun wrote: > > > > >We currently use a mix of full path and -I asse

Re: [libav-devel] [PATCH 11/12] configure: Simplify dlopen check

On Wed, Feb 01, 2017 at 11:00:33AM +0100, Vittorio Giovara wrote: > On Tue, Jan 24, 2017 at 6:12 PM, Diego Biurrun <di...@biurrun.de> wrote: > > --- > > @@ -4452,11 +4448,8 @@ check_code cc arm_neon.h "int16x8_t test = > > vdupq_n_s16(0)" &&

Re: [libav-devel] [PATCH 03/12] configure: Use inline asm check helper function where appropriate

On Wed, Feb 01, 2017 at 01:12:47PM +0100, Vittorio Giovara wrote: > On Wed, Feb 1, 2017 at 12:23 PM, Diego Biurrun <di...@biurrun.de> wrote: > > On Wed, Feb 01, 2017 at 10:51:15AM +0100, Vittorio Giovara wrote: > >> On Tue, Jan 24, 2017 at 6:12 PM, Diego Biurrun

Re: [libav-devel] [PATCH 03/12] configure: Use inline asm check helper function where appropriate

On Wed, Feb 01, 2017 at 10:51:15AM +0100, Vittorio Giovara wrote: > On Tue, Jan 24, 2017 at 6:12 PM, Diego Biurrun <di...@biurrun.de> wrote: > > --- a/configure > > +++ b/configure > > @@ -4165,9 +4165,7 @@ EOF > > > > -check_cc < > -void foo

[libav-devel] [PATCH] svq3: Convert to the new bitstream reader

From: Alexandra Hájková --- Changed suspicious -AV_WL32(>gb_slice.buffer[1], header ^ s->watermark_key); +AV_WL32(>slice_buf[1], header ^ s->watermark_key); to -AV_WL32(>gb_slice.buffer[1], header ^ s->watermark_key); +

[libav-devel] [PATCH] build: Move cli tools to a separate subdirectory

This unclutters the top-level directory and groups related files together. --- Now everything is placed below "avtools" as discussed on IRC. .gitignore | 3 -- Makefile | 45 +++--- avtools/.gitignore

[libav-devel] [PATCH] svq3: Convert to the new bitstream reader

From: Alexandra Hájková --- Now without a suspicious added memset. libavcodec/svq3.c | 132 +++--- 1 file changed, 66 insertions(+), 66 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index

[libav-devel] [PATCH] build: Ignore generated .version files

--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index f6d97b0..1a08fd1 100644 --- a/.gitignore +++ b/.gitignore @@ -17,6 +17,7 @@ *.so.* *.swp *.ver +*.version /.config /.version /avconv -- 2.1.4 ___

Re: [libav-devel] [v3] fine-grained library dependencies for all components

On Tue, Jan 24, 2017 at 06:12:40PM +0100, Diego Biurrun wrote: > .. and along comes another iteration of my patch along with another > host of preliminaries .. > > This addresses the main concern of the last iteration that each > external library dependency added another

[libav-devel] [PATCH] golomb: Convert to the new bitstream reader

--- Dropped some rebasing mistakes and a suspicious cast. libavcodec/aic.c | 2 +- libavcodec/cavs.c| 2 +- libavcodec/cavsdec.c | 2 +- libavcodec/dirac.c | 2 +- libavcodec/ffv1dec.c

Re: [libav-devel] [PATCH 01/14] golomb: Convert to the new bitstream reader

On Thu, Jan 26, 2017 at 11:10:42AM +0100, Diego Biurrun wrote: > --- a/libavcodec/golomb.h > +++ b/libavcodec/golomb.h > @@ -50,26 +50,24 @@ extern const uint8_t > ff_interleaved_dirac_golomb_vlc_code[256]; > /** > * read unsigned exp golomb code. > */ > -static

Re: [libav-devel] [PATCH 01/14] golomb: Convert to the new bitstream reader

On Thu, Jan 26, 2017 at 11:10:42AM +0100, Diego Biurrun wrote: > From: Alexandra Hájková <alexan...@khirnov.net> > > --- > libavcodec/aic.c | 2 +- > libavcodec/cavs.c| 2 +- > libavcodec/cavsdec.c

Re: [libav-devel] [PATCH] mov: Avoid memcmp of uninitialised data

On Sun, Jan 29, 2017 at 07:59:22PM +, Mark Thompson wrote: > The string codec name need not be as long as the value we are > comparing it to, so memcmp may make decisions derived from > uninitialised data that valgrind then complains about (though the > overall result of the function will

[libav-devel] [PATCH 1/2] configure: Place all temporary files in one separate directory

educes TMPDIR pollution by keeping all test files in a single subdirectory. Signed-off-by: Diego Biurrun <di...@biurrun.de> --- This patch was lost during my hiatus from development. Resending now as a reminder, will push tomorrow or so. configure | 16 ++-- 1 file changed, 1

[libav-devel] [PATCH 2/2] configure: Clean up temporary files on interrupt

--- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 1336f3e..de91459 100755 --- a/configure +++ b/configure @@ -2974,6 +2974,7 @@ tmpfile(){ } trap 'rm -rf -- "$AVTMPDIR"' EXIT +trap 'exit 2' INT tmpfile TMPASM .asm tmpfile TMPC .c -- 2.1.4

Re: [libav-devel] [PATCH 12/14] jpeg: Convert to the new bitstream reader

On Thu, Jan 26, 2017 at 01:30:34PM +0100, Vittorio Giovara wrote: > On Thu, Jan 26, 2017 at 11:10 AM, Diego Biurrun <di...@biurrun.de> wrote: > > From: Alexandra Hájková <alexan...@khirnov.net> > > > > --- > > libavcodec/jpeglsdec.c | 48 +

[libav-devel] [PATCH 13/14] dv: Convert to the new bitreader

From: Luca Barbato --- Carried over from the last batch. libavcodec/dvdec.c | 122 ++--- 1 file changed, 69 insertions(+), 53 deletions(-) diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c index dc37a5e..616e187 100644

[libav-devel] [PATCH 14/14] wma: Convert to the new bitstream reader

From: Alexandra Hájková --- Carried over from the last batch. libavcodec/wma.c| 41 +++ libavcodec/wma.h| 8 +- libavcodec/wmadec.c | 64 +-- libavcodec/wmalosslessdec.c | 188 +++

[libav-devel] [PATCH 12/14] jpeg: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/jpeglsdec.c | 48 +- libavcodec/jpeglsenc.c | 14 +-- libavcodec/mjpegbdec.c | 44 - libavcodec/mjpegdec.c | 242 + libavcodec/mjpegdec.h | 5 +-

[libav-devel] [PATCH 10/14] ffv1: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/ffv1.h| 4 ++-- libavcodec/ffv1dec.c | 24 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index 34370fa..7e0465a 100644 --- a/libavcodec/ffv1.h +++

[libav-devel] [PATCH 11/14] h261dec: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/h261dec.c | 92 ++ libavcodec/mpegvideo.h | 3 ++ libavformat/h261dec.c | 11 +++--- 3 files changed, 56 insertions(+), 50 deletions(-) diff --git a/libavcodec/h261dec.c

[libav-devel] [PATCH 03/14] cavs: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/cavs.c| 8 +-- libavcodec/cavs.h| 4 +- libavcodec/cavsdec.c | 178 +-- 3 files changed, 95 insertions(+), 95 deletions(-) diff --git a/libavcodec/cavs.c

[libav-devel] [PATCH 05/14] fic: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/fic.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/fic.c b/libavcodec/fic.c index 1804104..a038af6 100644 --- a/libavcodec/fic.c +++ b/libavcodec/fic.c @@ -24,9 +24,9 @@ #include

[libav-devel] [PATCH 04/14] dirac: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/dirac.c | 89 +++--- 1 file changed, 45 insertions(+), 44 deletions(-) diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c index cce9439..5faf0a3 100644 --- a/libavcodec/dirac.c +++

[libav-devel] [PATCH 02/14] aic: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/aic.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/aic.c b/libavcodec/aic.c index 405ebf1..368b3bc 100644 --- a/libavcodec/aic.c +++ b/libavcodec/aic.c @@ -23,13

[libav-devel] [PATCH 06/14] loco: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/loco.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/loco.c b/libavcodec/loco.c index 8624ea8..fa4c5ed 100644 --- a/libavcodec/loco.c +++ b/libavcodec/loco.c @@ -25,8 +25,8 @@ */

[libav-devel] new bitstream reader 5th batch

The next set of bitstream reader patches, for (more or less) fringe stuff that does not require extensive benchmarking. This time pulling in golomb.h and dependent codecs. ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 07/14] ralf: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/ralf.c | 68 --- 1 file changed, 35 insertions(+), 33 deletions(-) diff --git a/libavcodec/ralf.c b/libavcodec/ralf.c index 6bc0f3f..1003b10 100644 --- a/libavcodec/ralf.c +++

[libav-devel] [PATCH 01/14] golomb: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/aic.c | 2 +- libavcodec/cavs.c| 2 +- libavcodec/cavsdec.c | 2 +- libavcodec/dirac.c | 2 +- libavcodec/ffv1dec.c

[libav-devel] [PATCH 08/14] shorten: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/shorten.c | 49 + 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/libavcodec/shorten.c b/libavcodec/shorten.c index 82fa2ab..e040b9c 100644 --- a/libavcodec/shorten.c

[libav-devel] [PATCH 09/14] svq3: Convert to the new bitstream reader

From: Alexandra Hájková --- libavcodec/svq3.c | 133 +++--- 1 file changed, 67 insertions(+), 66 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 8bbd331..ffb4b84 100644 --- a/libavcodec/svq3.c +++

Re: [libav-devel] [PATCH] fifo: Return the correct error

On Thu, Jan 26, 2017 at 12:06:56AM +0100, Luca Barbato wrote: > --- > libavutil/fifo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) fifo: Return the correct error code or fifo: Return the correct AVERROR value Diego ___ libav-devel

Re: [libav-devel] [PATCH] rtmp: Account bytes_read may wrap around

On Wed, Jan 25, 2017 at 09:48:33PM +0100, Luca Barbato wrote: > The servers seem to be happy to receive the wrapped around value as long > they receive a report, otherwise they would timeout. rtmp: Account for bytes_read wraparound Servers seem to be happy to receive the wrapped-around value

[libav-devel] [PATCH 2/2] build: Fine-grained link-time dependency settings

Previously, all link-time dependencies were added for all libraries, resulting in bogus link-time dependencies since not all dependencies are shared across libraries. Also, in some cases like libavutil, not all dependencies were taken into account, resulting in some cases of underlinking. To

[libav-devel] [PATCH 1/2] configure: Add proper weak dependency of avformat on network

--- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index e69b1b1..5b93e14 100755 --- a/configure +++ b/configure @@ -2499,6 +2499,7 @@ avcodec_select="null_bsf" avdevice_deps="avformat avcodec avutil" avfilter_deps="avutil" avformat_deps="avcodec avutil"

[libav-devel] [PATCH] build: Detect blocks C language extension and add it as VDA dependency

Newer versions of OS X use the blocks extension in VDA-related headers. --- configure | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 1fc83f9..e59790c 100755 --- a/configure +++ b/configure @@ -1673,6 +1673,7 @@ TOOLCHAIN_FEATURES="

<    3   4   5   6   7   8   9   10   11   12   >