Re: [libav-devel] [PATCH 2/2] fate: add some shorthands to run groups of tests

2012-01-11 Thread Diego Biurrun
On Wed, Jan 11, 2012 at 10:41:47AM -0500, Justin Ruggles wrote: On 01/11/2012 10:26 AM, Diego Biurrun wrote: On Wed, Jan 11, 2012 at 08:44:39AM -0500, Justin Ruggles wrote: --- a/tests/fate/dpcm.mak +++ b/tests/fate/dpcm.mak @@ -1,42 +1,44 @@ -FATE_TESTS += fate-adpcm-ea-r2

[libav-devel] FOSDEM accomodation

2012-01-11 Thread Diego Biurrun
Stefan Gehrer, Udo from Tryton and I will share a hostel room. Is there anybody else who wants to share the room with us? The more the merrier and cheaper :) http://www.sleepwell.be/ Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/2] golomb: cosmetics

2012-01-12 Thread Diego Biurrun
On Thu, Jan 12, 2012 at 06:29:46AM +0100, Luca Barbato wrote: From: Chris Berov chrisbe...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavcodec/golomb.h | 300 +-- 1 files changed, 172 insertions(+), 128 deletions(-)

Re: [libav-devel] [PATCH 2/2] asv1: cosmetics

2012-01-12 Thread Diego Biurrun
On Thu, Jan 12, 2012 at 06:29:47AM +0100, Luca Barbato wrote: From: Chris Berov chrisbe...@gmail.com Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavcodec/asv1.c | 459 +++-- 1 files changed, 269 insertions(+), 190 deletions(-)

Re: [libav-devel] [PATCH] 4xm, timefilter: KR formatting cosmetics

2012-01-12 Thread Diego Biurrun
On Wed, Jan 11, 2012 at 09:27:20PM +0200, Yordan Makariev wrote: --- libavcodec/4xm.c | 788 -- libavdevice/timefilter.c | 84 +++--- 2 files changed, 460 insertions(+), 412 deletions(-) This now applies to HEAD. However, you never

Re: [libav-devel] [PATCH] indeo4: add some missing static and const qualifiers

2012-01-12 Thread Diego Biurrun
On Thu, Jan 12, 2012 at 10:03:21AM +0100, Kostya Shishkov wrote: From the patch by Reimar Döffinger. --- libavcodec/indeo4.c |2 +- libavcodec/indeo4data.h | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) LGTM if it does not introduce any new warnings. Diego

[libav-devel] [PATCH 3/3] cabac: split cabac.h into declarations and function definitions

2012-01-12 Thread Diego Biurrun
This fixes standalone compilation of some decoders with --disable-optimizations. cabac.h defines some inline functions that use symbols from cabac.c. Without optimizations these inline functions are not eliminated and linking fails with references to non-existing symbols. Splitting the inline

[libav-devel] [PATCH 1/3] cabac: Remove ff_h264_lps_state array.

2012-01-12 Thread Diego Biurrun
It was only ever used in the cabac test program, but never initialized. --- libavcodec/cabac.c |2 -- libavcodec/cabac.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/libavcodec/cabac.c b/libavcodec/cabac.c index 54414fa..1de4584 100644 --- a/libavcodec/cabac.c +++

[libav-devel] [PATCH 2/3] cabac: Mark ff_h264_mps_state array as static, it is only used within cabac.c.

2012-01-12 Thread Diego Biurrun
--- libavcodec/cabac.c |2 +- libavcodec/cabac.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/libavcodec/cabac.c b/libavcodec/cabac.c index 1de4584..f23fd95 100644 --- a/libavcodec/cabac.c +++ b/libavcodec/cabac.c @@ -51,7 +51,7 @@ static const uint8_t

[libav-devel] [PATCH] cabac: Mark ff_h264_mps_state array as static, it is only used within cabac.c.

2012-01-12 Thread Diego Biurrun
--- libavcodec/cabac.c |8 libavcodec/cabac.h |1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/cabac.c b/libavcodec/cabac.c index 1de4584..11971f5 100644 --- a/libavcodec/cabac.c +++ b/libavcodec/cabac.c @@ -51,7 +51,7 @@ static const uint8_t

[libav-devel] [PATCH] cabac: split cabac.h into declarations and function definitions

2012-01-12 Thread Diego Biurrun
This fixes standalone compilation of some decoders with --disable-optimizations. cabac.h defines some inline functions that use symbols from cabac.c. Without optimizations these inline functions are not eliminated and linking fails with references to non-existing symbols. Splitting the inline

[libav-devel] [PATCH] cosmetics: Move static and inline attributes to more standard places.

2012-01-13 Thread Diego Biurrun
Fixes several ‘static’ is not at beginning of declaration warnings. --- libavcodec/g722.c|2 +- libavcodec/h264_loopfilter.c | 51 +++-- libavfilter/vf_fade.c|2 +- libswscale/utils.c |2 +- 4 files changed, 46

[libav-devel] [PATCH] swscale-test: Drop unused argc and argv arguments fro main().

2012-01-13 Thread Diego Biurrun
--- libswscale/colorspace-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libswscale/colorspace-test.c b/libswscale/colorspace-test.c index 10cee8a..135924c 100644 --- a/libswscale/colorspace-test.c +++ b/libswscale/colorspace-test.c @@ -33,7 +33,7 @@ #define

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-14 Thread Diego Biurrun
On Fri, Jan 13, 2012 at 07:18:39PM +0200, доналд овчаров wrote: My patch is ready to be reviewed. You are still using your broken mailer and breaking threads, which I very specifically told you not to do. Let me make this very clear, your task has two parts: 1) Creating a patch fit for

Re: [libav-devel] mov, mxfdec return value refactoring

2012-01-14 Thread Diego Biurrun
On Fri, Jan 13, 2012 at 02:25:15PM -0600, Daniel Huang wrote: --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -731,9 +733,11 @@ static int mov_read_mdhd(MOVContext *c, AVIOContext *pb, MOVAtom atom) version = avio_r8(pb); -if (version 1) -return -1; /* unsupported */

Re: [libav-devel] mov, mxfdec return value refactoring

2012-01-14 Thread Diego Biurrun
On Sat, Jan 14, 2012 at 04:21:05PM +0100, Diego Biurrun wrote: On Fri, Jan 13, 2012 at 02:25:15PM -0600, Daniel Huang wrote: --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -731,9 +733,11 @@ static int mov_read_mdhd(MOVContext *c, AVIOContext *pb, MOVAtom atom) version

Re: [libav-devel] [libav-commits] FATE: add tests for targa

2012-01-14 Thread Diego Biurrun
On Fri, Jan 13, 2012 at 09:28:35PM +, Paul B Mahol wrote: On 1/13/12, Maans Rullgaard m...@mansr.com wrote: Paul B Mahol one...@gmail.com writes: On 1/13/12, Maans Rullgaard m...@mansr.com wrote: Justin Ruggles g...@libav.org writes: +# fate-targa-conformance-CCM8: CMD =

Re: [libav-devel] [PATCH] swscale-test: Drop unused argc and argv arguments fro main().

2012-01-14 Thread Diego Biurrun
On Fri, Jan 13, 2012 at 09:05:37AM -0800, Ronald S. Bultje wrote: On Fri, Jan 13, 2012 at 8:01 AM, Diego Biurrun di...@biurrun.de wrote: ---  libswscale/colorspace-test.c |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) Why? I was trawling -Wextra output for sensible issues

[libav-devel] [PATCH 2/3] fate: split ADPCM and DPCM test references into separate files.

2012-01-14 Thread Diego Biurrun
--- tests/Makefile |1 + tests/fate/adpcm.mak | 40 tests/fate/dpcm.mak | 42 -- 3 files changed, 41 insertions(+), 42 deletions(-) create mode 100644 tests/fate/adpcm.mak diff --git a/tests/Makefile

[libav-devel] [PATCH 3/3] fate: add some shorthands to run groups of tests

2012-01-14 Thread Diego Biurrun
--- tests/fate/ac3.mak| 15 ++ tests/fate/adpcm.mak | 31 +++- tests/fate/amrnb.mak | 19 +++- tests/fate/amrwb.mak | 23 -- tests/fate/atrac.mak | 11 -- tests/fate/audio.mak |7

[libav-devel] [PATCH 1/3] fate: Give some tests more sensible names.

2012-01-14 Thread Diego Biurrun
--- tests/fate/demux.mak |6 -- tests/fate/dpcm.mak| 52 +++ tests/fate/lossless-audio.mak | 12 ++-- tests/fate/microsoft.mak |4 +- tests/fate/pcm.mak

[libav-devel] [PATCH 2/3] fate: split ADPCM and DPCM test references into separate files.

2012-01-14 Thread Diego Biurrun
--- tests/Makefile |1 + tests/fate/adpcm.mak | 40 tests/fate/dpcm.mak | 42 -- 3 files changed, 41 insertions(+), 42 deletions(-) create mode 100644 tests/fate/adpcm.mak diff --git a/tests/Makefile

[libav-devel] [PATCH 3/3] fate: add some shorthands to run groups of tests

2012-01-14 Thread Diego Biurrun
--- tests/fate/ac3.mak| 15 ++ tests/fate/adpcm.mak | 31 +++- tests/fate/amrnb.mak | 19 +++- tests/fate/amrwb.mak | 23 -- tests/fate/atrac.mak | 11 -- tests/fate/audio.mak |7

Re: [libav-devel] [PATCH 2/3] fate: split ADPCM and DPCM test references into separate files.

2012-01-14 Thread Diego Biurrun
On Sat, Jan 14, 2012 at 06:23:18PM +0100, Diego Biurrun wrote: --- tests/Makefile |1 + tests/fate/adpcm.mak | 40 tests/fate/dpcm.mak | 42 -- 3 files changed, 41 insertions(+), 42 deletions

Re: [libav-devel] [PATCH 3/3] fate: add some shorthands to run groups of tests

2012-01-14 Thread Diego Biurrun
On Sat, Jan 14, 2012 at 06:23:19PM +0100, Diego Biurrun wrote: --- tests/fate/ac3.mak| 15 ++ tests/fate/adpcm.mak | 31 +++- tests/fate/amrnb.mak | 19 +++- tests/fate/amrwb.mak | 23 -- tests/fate

Re: [libav-devel] [PATCH] Escape 130 decoder

2012-01-15 Thread Diego Biurrun
Mahol one...@gmail.com and Michael Niedermayer michae...@gmx.at and me. Signed-off-by: Diego Biurrun di...@biurrun.de You should add your s-o-b here. The patch looks fine in principle. If you consider fixing the artifacts too much work, so be it, we will have to live with it. Also have a look

Re: [libav-devel] [PATCH] sgidec: Use bytestream2 functions to prevent buffer overreads.

2012-01-15 Thread Diego Biurrun
On Fri, Jan 13, 2012 at 11:05:57PM +0530, Aneesh Dogra wrote: The patch also adds several bytestream macros to deal with native endian. --- libavcodec/bytestream.h | 37 + libavcodec/sgidec.c | 103 +++ 2 files changed, 88

Re: [libav-devel] mov, mxfdec return value refactoring

2012-01-15 Thread Diego Biurrun
On Sat, Jan 14, 2012 at 03:36:23PM -0600, Daniel Huang wrote: problem fixed. But you top-posted. This patch iteration rejected. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] mov, mxfdec return value refactoring

2012-01-15 Thread Diego Biurrun
On Sun, Jan 15, 2012 at 10:23:16AM -0600, Daniel Huang wrote: problem fixed. No, you are still top-posting. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] x86: conditionally compile H.264 QPEL optimizations

2012-01-15 Thread Diego Biurrun
--- configure| 15 --- libavcodec/x86/Makefile |4 ++-- libavcodec/x86/dsputil_mmx.c | 16 3 files changed, 22 insertions(+), 13 deletions(-) This is a fresh version of my previous patch for conditionally compiling the 10-bit H.264

Re: [libav-devel] mov, mxfdec return value refactoring

2012-01-15 Thread Diego Biurrun
On Sun, Jan 15, 2012 at 01:19:16PM -0600, Daniel Huang wrote: On Sat, Jan 14, 2012 at 10:52 AM, Diego Biurrun di...@biurrun.de wrote: On Sat, Jan 14, 2012 at 04:21:05PM +0100, Diego Biurrun wrote: On Fri, Jan 13, 2012 at 02:25:15PM -0600, Daniel Huang wrote: --- a/libavformat/mov.c

Re: [libav-devel] [PATCH 1/3] fate: Give some tests more sensible names.

2012-01-15 Thread Diego Biurrun
On Sat, Jan 14, 2012 at 01:03:20PM -0500, Justin Ruggles wrote: On 01/14/2012 12:32 PM, Diego Biurrun wrote: --- [...] rename tests/ref/fate/{truemotion1-15 = duck-tm1-15} (100%) rename tests/ref/fate/{truemotion1-24 = duck-tm1-24} (100%) the AVCodec name is truemotion1 so i would

Re: [libav-devel] [PATCH 1/3] fate: Give some tests more sensible names.

2012-01-15 Thread Diego Biurrun
On Sun, Jan 15, 2012 at 08:23:42PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: rename tests/ref/fate/{iff-pcm = pcm-iff} (100%) rename tests/ref/fate/{w64 = pcm-w64} (100%) these 2 are really more to test the demuxer, not pcm. they really should

Re: [libav-devel] [PATCH 1/3] fate: Give some tests more sensible names.

2012-01-15 Thread Diego Biurrun
On Sun, Jan 15, 2012 at 08:30:28PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Sun, Jan 15, 2012 at 08:23:42PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: rename tests/ref/fate/{iff-pcm = pcm-iff} (100%) rename tests/ref/fate

Re: [libav-devel] [PATCH 1/3] fate: Give some tests more sensible names.

2012-01-15 Thread Diego Biurrun
On Sun, Jan 15, 2012 at 08:47:13PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Sun, Jan 15, 2012 at 08:30:28PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Sun, Jan 15, 2012 at 08:23:42PM +, Måns Rullgård wrote: Diego Biurrun

[libav-devel] [PATCH 1/2] fate: Give some tests more sensible names.

2012-01-15 Thread Diego Biurrun
--- tests/fate/adpcm.mak | 46 +++- tests/fate/demux.mak |6 --- tests/fate/dpcm.mak|7 ++- tests/fate/lossless-audio.mak | 12 +++---

[libav-devel] [PATCH 2/2] fate: add some shorthands to run groups of tests

2012-01-15 Thread Diego Biurrun
--- tests/fate/ac3.mak| 15 ++ tests/fate/adpcm.mak | 31 -- tests/fate/amrnb.mak | 19 -- tests/fate/amrwb.mak | 23 +--- tests/fate/atrac.mak | 11 +--- tests/fate/audio.mak

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Diego Biurrun
On Mon, Jan 16, 2012 at 11:11:42PM +0200, Donald wrote: Patch attached here. From 0eea4ea1cd482941b4d8581e2b94a5729b928379 Mon Sep 17 00:00:00 2001 From: Donald Ovcharov dtt...@abv.bg Date: Sat, 17 Dec 2011 21:30:01 +0200 Subject: [PATCH] error_resilience:cosmetics So which is your official

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-16 Thread Diego Biurrun
On Mon, Jan 16, 2012 at 11:11:42PM +0200, Donald wrote: [...] Looks mostly good. Send a fresh patch with the changes I request below. I will queue it tomorrow. I'm OK with you getting your GCI points for sending that updated patch. --- a/libavcodec/error_resilience.c +++

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 03:23:01PM +0200, Laurentiu Cristian Ion wrote: --- a/libavcodec/dxa.c +++ b/libavcodec/dxa.c @@ -39,41 +40,57 @@ typedef struct DxaDecContext { -static int decode_13(AVCodecContext *avctx, DxaDecContext *c, uint8_t* dst, uint8_t *src, uint8_t *ref) -{ -uint8_t

Re: [libav-devel] [PATCH 1/2] threads: change the default for threads back to 1

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 11:46:36AM +0100, Janne Grunau wrote: Users of libavcodec could break if they do not threadsafe callbacks. Avconv and avplay still use -threads auto if not specified. .. could break if they do threadunsafe callbacks. Diego ___

Re: [libav-devel] [PATCH 01/11] aacenc: aac_encode_init() cleanup

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 01:39:48AM -0700, Nathan Caldwell wrote: Macroify sanity checks and check return values of allocs and other functions. --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c @@ -46,6 +46,12 @@ +#define ERROR_IF(cond, ...) \ +if (cond) { \ +av_log(avctx,

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 12:40:36PM +0100, Benjamin Larsson wrote: OK No, definitely not. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 07/11] aacenc: Move Q^3/4 calculation to it's own table

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 01:39:54AM -0700, Nathan Caldwell wrote: --- a/libavcodec/aac_tablegen.c +++ b/libavcodec/aac_tablegen.c @@ -32,6 +32,9 @@ int main(void) WRITE_ARRAY(const, float, ff_aac_pow2sf_tab); +#if CONFIG_AAC_ENCODER +WRITE_ARRAY(const, float,

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 05:01:49PM +0200, Laurentiu Cristian Ion wrote: --- a/libavcodec/dxa.c +++ b/libavcodec/dxa.c @@ -39,40 +40,56 @@ typedef struct DxaDecContext { -static int decode_13(AVCodecContext *avctx, DxaDecContext *c, uint8_t* dst, uint8_t *src, uint8_t *ref) -{ -

Re: [libav-devel] [PATCH] dxa: Use bytestream2 API to fix unsafe code

2012-01-18 Thread Diego Biurrun
This patch still contains stray changes, whoever pushes this, please fix or wait for an updated iteration. On Wed, Jan 18, 2012 at 05:58:07PM +0200, Laurentiu Cristian Ion wrote: --- a/libavcodec/dxa.c +++ b/libavcodec/dxa.c @@ -85,17 +102,16 @@ static int decode_13(AVCodecContext *avctx,

Re: [libav-devel] Patch error_resilience:cosmetics

2012-01-18 Thread Diego Biurrun
On Tue, Jan 17, 2012 at 03:48:39AM +0200, Donald wrote: The reply is over 100kb to send.Here is my patch. Pushed, thanks. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-18 Thread Diego Biurrun
--- libavcodec/motion_est.c |2 -- libavfilter/vf_hflip.c |2 -- libswscale/ppc/swscale_altivec.c | 10 -- 3 files changed, 0 insertions(+), 14 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c index c4512a9..be317b9 100644 ---

[libav-devel] [PATCH 1/5] fate: Employ modern and preferred avconv syntax.

2012-01-18 Thread Diego Biurrun
--- tests/codec-regression.sh | 124 ++-- tests/fate/demux.mak | 36 +++--- tests/fate/h264.mak |4 +- tests/fate/microsoft.mak |4 +- tests/fate/mp3.mak| 14 +++--- tests/fate/mpc.mak|4 +-

[libav-devel] [PATCH 2/5] avplay: Recommend modern, preferred syntax in error messages.

2012-01-18 Thread Diego Biurrun
--- avplay.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/avplay.c b/avplay.c index 4d21234..a90d066 100644 --- a/avplay.c +++ b/avplay.c @@ -1301,7 +1301,7 @@ static void alloc_picture(void *opaque) /* SDL allocates a buffer smaller than requested if the

[libav-devel] [PATCH 5/5] avconv: Document which command line options are preferred in (--help) output.

2012-01-18 Thread Diego Biurrun
--- avconv.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/avconv.c b/avconv.c index e2cc4b0..5766413 100644 --- a/avconv.c +++ b/avconv.c @@ -2313,7 +2313,7 @@ static int transcode_init(OutputFile *output_files, switch

[libav-devel] [PATCH 4/5] doc: Suggest modern and preferred command line syntax.

2012-01-18 Thread Diego Biurrun
--- doc/avconv.texi |2 +- doc/encoders.texi|2 +- doc/faq.texi | 12 +--- doc/filters.texi | 10 +- doc/libavfilter.texi |2 +- 5 files changed, 13 insertions(+), 15 deletions(-) diff --git a/doc/avconv.texi b/doc/avconv.texi index

[libav-devel] (no subject)

2012-01-18 Thread Diego Biurrun
This is entirely untested due to lack of non-x86 machines and even crosscompilers. Since Luca volunteered to test ppc, I'm sending this already and hoping for more volunteers :) ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH 1/4] swscale: KR formatting cosmetics for mlib code

2012-01-18 Thread Diego Biurrun
--- libswscale/mlib/yuv2rgb_mlib.c | 40 ++-- 1 files changed, 22 insertions(+), 18 deletions(-) diff --git a/libswscale/mlib/yuv2rgb_mlib.c b/libswscale/mlib/yuv2rgb_mlib.c index 526c975..f4cad55 100644 --- a/libswscale/mlib/yuv2rgb_mlib.c +++

[libav-devel] [PATCH 2/4] swscale: KR formatting cosmetics for SPARC code

2012-01-18 Thread Diego Biurrun
--- libswscale/sparc/yuv2rgb_vis.c | 251 1 files changed, 125 insertions(+), 126 deletions(-) diff --git a/libswscale/sparc/yuv2rgb_vis.c b/libswscale/sparc/yuv2rgb_vis.c index 2111ea8..bcd2081 100644 --- a/libswscale/sparc/yuv2rgb_vis.c +++

[libav-devel] [PATCH 3/4] swscale: KR formatting cosmetics for Blackfin code

2012-01-18 Thread Diego Biurrun
--- libswscale/bfin/internal_bfin.S | 968 +++--- libswscale/bfin/swscale_bfin.c | 48 +- libswscale/bfin/yuv2rgb_bfin.c | 91 ++-- 3 files changed, 556 insertions(+), 551 deletions(-) diff --git a/libswscale/bfin/internal_bfin.S

Re: [libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-18 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 06:25:15PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: --- libavcodec/motion_est.c |2 -- libavfilter/vf_hflip.c |2 -- libswscale/ppc/swscale_altivec.c | 10 -- 3 files changed, 0 insertions(+), 14

[libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-18 Thread Diego Biurrun
--- libavcodec/motion_est.c | 36 +--- libavfilter/vf_hflip.c |2 -- libswscale/ppc/swscale_altivec.c | 10 -- 3 files changed, 17 insertions(+), 31 deletions(-) diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c

Re: [libav-devel] [PATCH] cosmetics: KR reformatting for several files avprobe.c cmdutils.h tests/audiogen.c tests/rotozoom.c tests/tiny_psnr.c tests/videogen.c

2012-01-18 Thread Diego Biurrun
On Mon, Jan 02, 2012 at 02:19:00PM +0530, Gaurav Narula wrote: --- avprobe.c | 59 +++ cmdutils.h| 18 +-- tests/audiogen.c | 32 ++-- tests/base64.c|6 +- tests/rotozoom.c | 80 +++---

[libav-devel] [PATCH] cosmetics: Rename avsink to ffsink.

2012-01-18 Thread Diego Biurrun
--- It's not my fault! Mike trolled me! ;-p avconv.c |6 +++--- avplay.c |6 +++--- cmdutils.c | 20 ++-- cmdutils.h |4 ++-- ffmpeg.c |6 +++--- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/avconv.c b/avconv.c index 5766413..9861faf

[libav-devel] [PATCH] cosmetics: Rename ffsink to avsink.

2012-01-18 Thread Diego Biurrun
--- avconv.c |6 +++--- avplay.c |6 +++--- cmdutils.c | 20 ++-- cmdutils.h |4 ++-- ffmpeg.c |6 +++--- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/avconv.c b/avconv.c index 5766413..9861faf 100644 --- a/avconv.c +++ b/avconv.c @@

[libav-devel] [PATCH] fate: Employ modern and preferred avconv syntax.

2012-01-18 Thread Diego Biurrun
--- tests/codec-regression.sh | 124 ++-- tests/fate/demux.mak | 36 +++--- tests/fate/h264.mak |4 +- tests/fate/microsoft.mak |4 +- tests/fate/mp3.mak| 14 +++--- tests/fate/mpc.mak|4 +-

[libav-devel] [PATCH] doc: Mention that '-vf' is an alias for '-filter:v' in avplay documentation.

2012-01-18 Thread Diego Biurrun
--- doc/avplay.texi |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/avplay.texi b/doc/avplay.texi index 8fc3308..a597bef 100644 --- a/doc/avplay.texi +++ b/doc/avplay.texi @@ -61,7 +61,7 @@ Set window title (default is the input filename). Loops movie playback

[libav-devel] [PATCH 1/2] swscale: KR formatting cosmetics for Blackfin C code

2012-01-18 Thread Diego Biurrun
--- libswscale/bfin/swscale_bfin.c | 48 +++-- libswscale/bfin/yuv2rgb_bfin.c | 91 2 files changed, 72 insertions(+), 67 deletions(-) diff --git a/libswscale/bfin/swscale_bfin.c b/libswscale/bfin/swscale_bfin.c index 0c5f004..f9eba1e

Re: [libav-devel] [PATCH] gif: Some KR cosmetics and other cleanups for better readability.

2012-01-19 Thread Diego Biurrun
On Thu, Jan 19, 2012 at 07:40:12PM +0530, Aneesh Dogra wrote: --- a/libavcodec/gif.c +++ b/libavcodec/gif.c @@ -71,10 +71,10 @@ static int gif_image_write_header(AVCodecContext *avctx, /* the global palette */ -for(i=0;i256;i++) { +for(i = 0; i 256; i++) { for (

[libav-devel] [PATCH] swscale: KR formatting cosmetics for Blackfin code

2012-01-19 Thread Diego Biurrun
Also prettyprint some comments in Assembly code. --- libswscale/bfin/internal_bfin.S | 12 +++--- libswscale/bfin/swscale_bfin.c | 48 +++- libswscale/bfin/yuv2rgb_bfin.c | 91 --- 3 files changed, 78 insertions(+), 73 deletions(-) diff

Re: [libav-devel] [PATCH] cosmetics: Rename ffsink to avsink.

2012-01-19 Thread Diego Biurrun
On Thu, Jan 19, 2012 at 08:41:48AM +0100, Anton Khirnov wrote: On Wed, 18 Jan 2012 23:18:39 +0100, Diego Biurrun di...@biurrun.de wrote: --- avconv.c |6 +++--- avplay.c |6 +++--- cmdutils.c | 20 ++-- cmdutils.h |4 ++-- ffmpeg.c |6

[libav-devel] [PATCH] Drop unnecessary prefix from *sink* variable and struct names.

2012-01-19 Thread Diego Biurrun
--- avconv.c |6 +++--- avplay.c |6 +++--- cmdutils.c | 20 ++-- cmdutils.h |4 ++-- ffmpeg.c |6 +++--- 5 files changed, 21 insertions(+), 21 deletions(-) diff --git a/avconv.c b/avconv.c index 9861faf..172417b 100644 --- a/avconv.c +++ b/avconv.c @@

Re: [libav-devel] [PATCH] movenc: Reorder entries in the MOVIentry struct, for tigheter packing

2012-01-21 Thread Diego Biurrun
On Fri, Jan 20, 2012 at 02:24:18PM -0800, Luca Barbato wrote: On 20/01/12 13:49, Martin Storsjö wrote: On Fri, 20 Jan 2012, Luca Barbato wrote: On 20/01/12 11:00, Martin Storsjö wrote: Originally, sizeof(struct MOVIentry) was 48, after the reordering, it is 40 in my build

Re: [libav-devel] [PATCH 1/1] Fix a typo that broke writing (and reading) PAM files.

2012-01-21 Thread Diego Biurrun
On Sat, Jan 21, 2012 at 07:27:10PM +0100, Janne Grunau wrote: --- a/libavcodec/pnm.c +++ b/libavcodec/pnm.c @@ -93,7 +93,9 @@ int ff_pnm_decode_header(AVCodecContext *avctx, PNMContext * const s) } else if (!strcmp(buf1, MAXVAL)) { pnm_get(s, buf1,

Re: [libav-devel] [PATCH] movenc: Reorder entries in the MOVIentry struct, for tigheter packing

2012-01-23 Thread Diego Biurrun
On Sat, Jan 21, 2012 at 06:28:33PM +, Måns Rullgård wrote: Diego Biurrun di...@biurrun.de writes: On Fri, Jan 20, 2012 at 02:24:18PM -0800, Luca Barbato wrote: On 20/01/12 13:49, Martin Storsjö wrote: On Fri, 20 Jan 2012, Luca Barbato wrote: On 20/01/12 11:00, Martin Storsjö

Re: [libav-devel] valgrind lavf-mxfdec failure

2012-01-24 Thread Diego Biurrun
On Mon, Jan 23, 2012 at 04:13:39PM +, Sean McGovern wrote: Looking at this failure on the valgrind FATE runs, should mxfdec.c:1060 be an av_realloc() instead of an av_mallocz()? Have you tested the change? Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH] x86: conditionally compile H.264 QPEL optimizations

2012-01-25 Thread Diego Biurrun
On Sun, Jan 15, 2012 at 08:07:22PM +0100, Diego Biurrun wrote: --- configure| 15 --- libavcodec/x86/Makefile |4 ++-- libavcodec/x86/dsputil_mmx.c | 16 3 files changed, 22 insertions(+), 13 deletions(-) This is a fresh

Re: [libav-devel] [PATCH] doc: Mention that '-vf' is an alias for '-filter:v' in avplay documentation.

2012-01-25 Thread Diego Biurrun
On Fri, Jan 20, 2012 at 08:57:02AM +0100, Anton Khirnov wrote: On Wed, 18 Jan 2012 23:50:02 +0100, Diego Biurrun di...@biurrun.de wrote: --- a/doc/avplay.texi +++ b/doc/avplay.texi @@ -61,7 +61,7 @@ Set window title (default is the input filename). Loops movie playback number times. 0

Re: [libav-devel] [PATCH 5/5] avconv: Document which command line options are preferred in (--help) output.

2012-01-25 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 07:23:37PM +0100, Diego Biurrun wrote: --- avconv.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) .. ping .. Diego ___ libav-devel mailing list libav-devel@libav.org https

Re: [libav-devel] [PATCH] fate: Employ modern and preferred avconv syntax.

2012-01-25 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 11:32:25PM +0100, Diego Biurrun wrote: --- tests/codec-regression.sh | 124 ++-- tests/fate/demux.mak | 36 +++--- tests/fate/h264.mak |4 +- tests/fate/microsoft.mak |4 +- tests/fate/mp3.mak

Re: [libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-25 Thread Diego Biurrun
On Wed, Jan 18, 2012 at 08:26:55PM +0100, Diego Biurrun wrote: --- libavcodec/motion_est.c | 36 +--- libavfilter/vf_hflip.c |2 -- libswscale/ppc/swscale_altivec.c | 10 -- 3 files changed, 17 insertions(+), 31 deletions

Re: [libav-devel] [PATCH 2/2] pktdumper: Fix build for mingw

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 01:48:47PM +0200, Martin Storsjö wrote: Mingw doesn't have sleep, only _sleep (which is deprecated), Sleep (which is defined in winbase.h and not in the standard C headers) and usleep. nit: MinGW --- a/tools/pktdumper.c +++ b/tools/pktdumper.c @@ -26,6 +26,10 @@

Re: [libav-devel] [PATCH 1/2] ismindex: Fix build on mingw

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 01:48:46PM +0200, Martin Storsjö wrote: --- a/tools/ismindex.c +++ b/tools/ismindex.c @@ -35,6 +35,10 @@ #include stdio.h #include string.h #include sys/stat.h +#ifdef _WIN32 +#include io.h +#define mkdir(a, b) mkdir(a) +#endif #include

Re: [libav-devel] [PATCH] cosmetics: Remove some unnecessary block braces.

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 01:57:11PM +0200, Martin Storsjö wrote: On Wed, 18 Jan 2012, Diego Biurrun wrote: --- a/libswscale/ppc/swscale_altivec.c +++ b/libswscale/ppc/swscale_altivec.c @@ -99,7 +99,6 @@ yuv2planeX_altivec(const int16_t *filter, int filterSize, const uint8_t

Re: [libav-devel] [PATCH] swscale-test: Drop unused argc and argv arguments fro main().

2012-01-25 Thread Diego Biurrun
On Fri, Jan 13, 2012 at 05:01:43PM +0100, Diego Biurrun wrote: --- libswscale/colorspace-test.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) .. ping .. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org

Re: [libav-devel] [PATCH 2/2] pktdumper: Use usleep instead of sleep

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 02:05:27PM +0200, Martin Storsjö wrote: --- a/tools/pktdumper.c +++ b/tools/pktdumper.c @@ -120,7 +120,7 @@ int main(int argc, char **argv) while (donotquit) -sleep(60); +usleep(60*100); Add spaces around the operator and patch OK. Diego

Re: [libav-devel] [PATCH 2/2] pktdumper: Use usleep instead of sleep

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 02:23:40PM +0200, Martin Storsjö wrote: On Wed, 25 Jan 2012, Diego Biurrun wrote: On Wed, Jan 25, 2012 at 01:17:44PM +0100, Diego Biurrun wrote: On Wed, Jan 25, 2012 at 02:05:27PM +0200, Martin Storsjö wrote: --- a/tools/pktdumper.c +++ b/tools/pktdumper.c @@ -120,7

[libav-devel] [PATCH] build: Automatically include architecture-specific library Makefile snippets.

2012-01-25 Thread Diego Biurrun
--- Makefile |1 + libavcodec/Makefile |2 -- libavfilter/Makefile |2 -- 3 files changed, 1 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index d1b55ba..c9821b7 100644 --- a/Makefile +++ b/Makefile @@ -112,6 +112,7 @@ define DOSUBDIR $(foreach

[libav-devel] [PATCH] Ignore generated aviocat and ismindex tools.

2012-01-25 Thread Diego Biurrun
--- .gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 3508635..754051d 100644 --- a/.gitignore +++ b/.gitignore @@ -34,8 +34,10 @@ tests/tiny_psnr tests/videogen tests/vsynth1 tests/vsynth2 +tools/aviocat tools/cws2fws

[libav-devel] [PATCH] tools: KR reformatting cosmetics

2012-01-25 Thread Diego Biurrun
--- tools/aviocat.c|6 ++- tools/cws2fws.c| 56 +++-- tools/graph2dot.c | 36 ++-- tools/ismindex.c | 95 +++ tools/lavfi-showfiltfmts.c |6 ++- tools/pktdumper.c

Re: [libav-devel] [PATCH] tools: KR reformatting cosmetics

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 04:09:40PM +0200, Martin Storsjö wrote: On Wed, 25 Jan 2012, Diego Biurrun wrote: --- tools/aviocat.c|6 ++- tools/cws2fws.c| 56 +++-- tools/graph2dot.c | 36 ++-- tools/ismindex.c

[libav-devel] tests missing from FATE

2012-01-25 Thread Diego Biurrun
Recently the topic of adding some or all test programs to FATE that are not already part of FATE came up. Here's an overview of all those test programs not yet in FATE with some quick and superficial comments. This is not intended to be an in-depth analysis, just a way to get the ball rolling.

Re: [libav-devel] [PATCH] dsputil: SIMD for bswap_buf

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 06:40:17PM +0100, Christophe Gisquet wrote: 2012/1/25 Loren Merritt lor...@u.washington.edu: + mov %+ %1  m0, [r1 +  0] mov%1 Indeed. Also changed a bit the patch title. It would be nice to have x86 in the patch title. Diego

Re: [libav-devel] [PATCH] XWD regression testing

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 05:44:29PM +, Paul B Mahol wrote: --- a/tests/lavf-regression.sh +++ b/tests/lavf-regression.sh @@ -175,6 +175,10 @@ if [ -n $do_pcx ] ; then +if [ -n $do_xwd ] ; then +do_image_formats xwd +fi + --- /dev/null +++ b/tests/ref/lavf/xwd @@ -0,0 +1,3 @@

[libav-devel] [PATCH] tools: Remove some unnecessary #undefs.

2012-01-25 Thread Diego Biurrun
--- tools/graph2dot.c |1 - tools/pktdumper.c |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/tools/graph2dot.c b/tools/graph2dot.c index 15a9012..a52416d 100644 --- a/tools/graph2dot.c +++ b/tools/graph2dot.c @@ -20,7 +20,6 @@ #include unistd.h /*

Re: [libav-devel] [PATCH] tools: Remove some unnecessary #undefs.

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 08:34:41PM +0100, Janne Grunau wrote: On 2012-01-25 20:12:13 +0100, Diego Biurrun wrote: --- a/tools/graph2dot.c +++ b/tools/graph2dot.c @@ -20,7 +20,6 @@ #include unistd.h /* getopt */ -#undef HAVE_AV_CONFIG_H #include libavutil

Re: [libav-devel] [PATCH 1/2] ismindex: Fix build on mingw

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 11:49:28PM +0200, Martin Storsjö wrote: On Wed, 25 Jan 2012, Martin Storsjö wrote: On Wed, 25 Jan 2012, Diego Biurrun wrote: On Wed, Jan 25, 2012 at 01:48:46PM +0200, Martin Storsjö wrote: --- a/tools/ismindex.c +++ b/tools/ismindex.c @@ -35,6 +35,10

Re: [libav-devel] [PATCH 1/2] smacker: remove dead store

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 04:51:22PM -0800, Alex Converse wrote: --- libavcodec/smacker.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] XWD regression testing

2012-01-25 Thread Diego Biurrun
On Wed, Jan 25, 2012 at 08:15:34PM +, Paul B Mahol wrote: --- tests/lavf-regression.sh |4 tests/ref/lavf/xwd |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) create mode 100644 tests/ref/lavf/xwd Thanks, pushed. Diego

Re: [libav-devel] [PATCH 04/16] mxfdec: Sanity-check SampleRate

2012-01-26 Thread Diego Biurrun
On Thu, Jan 26, 2012 at 01:21:33PM +0100, Tomas Härdin wrote: This avoids a SIGFPE if SampleRate is missing or set to naughty values. --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1405,6 +1405,7 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)

Re: [libav-devel] [PATCH 13/16] mxfdec: change av_log formatting %lx to PRIx64 and %li to PRIi64

2012-01-26 Thread Diego Biurrun
On Thu, Jan 26, 2012 at 01:21:42PM +0100, Tomas Härdin wrote: From: Jean First jeanfi...@gmail.com Signed-off-by: Jean First jeanfi...@gmail.com Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavformat/mxfdec.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-)

[libav-devel] [PATCH 2/2] libavutil: Remove broken and pointless lzo test program.

2012-01-26 Thread Diego Biurrun
--- configure |2 -- libavutil/Makefile |3 --- libavutil/lzo.c| 44 3 files changed, 0 insertions(+), 49 deletions(-) diff --git a/configure b/configure index 1c96393..34d5850 100755 --- a/configure +++ b/configure @@ -1104,7

Re: [libav-devel] [PATCH 16/16] mxfdec: Fix files 2 GiB

2012-01-26 Thread Diego Biurrun
On Thu, Jan 26, 2012 at 01:21:45PM +0100, Tomas Härdin wrote: Accumulating into an int would cause overflow for files with essence containers larger than 2 GiB. --- libavformat/mxfdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Queued. Diego

Re: [libav-devel] [PATCH] Add a news entry for the 53-54 major bump.

2012-01-26 Thread Diego Biurrun
On Thu, Jan 26, 2012 at 12:51:19PM +0100, Anton Khirnov wrote: --- src/index | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/src/index b/src/index index a09615a..daa0d21 100644 --- a/src/index +++ b/src/index @@ -33,6 +33,30 @@ with the

<    4   5   6   7   8   9   10   11   12   13   >