[libav-devel] [PATCH] os_support: Don't try to return the service name as a string in getnameinfo

2015-10-28 Thread Martin Storsjö
Some systems may be lacking getservbyport; the previous ifdef wasn't quite enough since it still assumed that struct servent was defined. Simply remove the possibility to return non-numeric services in getnameinfo; no caller of getnameinfo within libavformat currently try to use getnameinfo for re

Re: [libav-devel] [PATCH] avutil/file_open: Print debug message if setting close on exec fails

2014-09-17 Thread Martin Storsjö
On Thu, 18 Sep 2014, Luca Barbato wrote: On 18/09/14 06:36, Reinhard Tartler wrote: What would be a better reporting mechanism in this case? Options: (void) cast to make apparent we do not care about the value pass the context to avpriv_open and use av_streerror to report _why_ it failed.

Re: [libav-devel] Libav compilation issue on Windows phone 8.1

2014-09-18 Thread Martin Storsjö
On Thu, 18 Sep 2014, Mirko Puliafito wrote: Adding gas-preprocessor.pl doesn't solve the configure issue: : ARM | THUMB | ARMCE check_gas using 'armasm' as AS check_as BEGIN ./ffconf.lwhMWour.S 1 .macro m n, y:vararg=0 2 \n: .int \y 3 .endm 4 m x END ./ffconf.lwhMWour.S armasm

Re: [libav-devel] Libav compilation issue on Windows phone 8.1

2014-09-18 Thread Martin Storsjö
On Thu, 18 Sep 2014, Mirko Puliafito wrote: Here it is: armasm -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_WIN32_WINNT=0x0502 -Dstrtod=avpriv_strtod -Dsnprintf=avpriv_snprintf -D_snprintf=avpriv_snprintf -Dvsnprintf=avpriv_vsnprintf -nologo -ignore 4509 -D_ARM_WINAPI_PARTITI

Re: [libav-devel] [PATCH] oss_audio: use a macro to simplify ioctl() error checking

2014-09-18 Thread Martin Storsjö
On Thu, 18 Sep 2014, Reinhard Tartler wrote: From: Timothy Gu Also add a note about SNDCTL_DSP_GETFMTS which may fail even if OSS is available. Fixes: CID 1238992 Signed-off-by: Timothy Gu Signed-off-by: Michael Niedermayer Reviewed-by: Luca Barbato Signed-off-by: Reinhard Tartler --- lib

Re: [libav-devel] [PATCH] Added parameter -hls_allow_cache

2014-09-18 Thread Martin Storsjö
On Wed, 17 Sep 2014, Joakim Roubert wrote: The -hls_allow_cache paramter enables explicitly setting the EXT-X-ALLOW-CACHE tag in the manifest file. That tag indicates whether the client MAY or MUST NOT cache downloaded media segments for later replay. Valid values are YES or NO and the EXT-X-AL

Re: [libav-devel] Libav compilation issue on Windows phone 8.1

2014-09-18 Thread Martin Storsjö
On Thu, 18 Sep 2014, Mirko Puliafito wrote: Martin, few updates: 2014-09-18 14:02 GMT+02:00 Martin Storsjö : On Thu, 18 Sep 2014, Mirko Puliafito wrote: Here it is: armasm -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_WIN32_WINNT=0x0502 -Dstrtod=avpriv_strtod

Re: [libav-devel] Libav compilation issue on Windows phone 8.1

2014-09-19 Thread Martin Storsjö
On Fri, 19 Sep 2014, Mirko Puliafito wrote: @Martin: my dynamic built was successful on VS but today trying to deploy to the Windows Phone I get problems on dll exporting. All the core dlls are signed as Content "True" but it keeps saying "A dependent dll was not found". I'm using Dependency Wal

Re: [libav-devel] [PATCH 1/2] configure: Place all temporary files in one separate directory

2014-09-21 Thread Martin Storsjö
On Sun, 21 Sep 2014, Diego Biurrun wrote: This reduces TMPDIR pollution and possibly avoids race conditions with temporary files that are not atomically created. Based on a patch from Michał Górny . --- Rewritten to be less intrusive. configure | 11 +++ 1 file changed, 7 insertions(+)

Re: [libav-devel] [PATCH] rtpdec_hevc: drop duplicated entry

2014-09-24 Thread Martin Storsjö
On Wed, 17 Sep 2014, Martin Storsjö wrote: On Wed, 17 Sep 2014, Vittorio Giovara wrote: --- libavformat/rtpdec.c | 1 - libavformat/rtpdec_formats.h | 1 - libavformat/rtpdec_hevc.c| 11 --- 3 files changed, 13 deletions(-) diff --git a/libavformat/rtpdec.c b/libavformat

[libav-devel] [PATCH] rtsp: Clear the session id on redirects

2014-09-24 Thread Martin Storsjö
This fixes handling redirects in case the server provided a session id within the redirect reply. --- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 23d7da1..646712e 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1

Re: [libav-devel] [PATCH] rtsp: Clear the session id on redirects

2014-09-24 Thread Martin Storsjö
On Wed, 24 Sep 2014, Luca Barbato wrote: On 24/09/14 10:33, Martin Storsjö wrote: This fixes handling redirects in case the server provided a session id within the redirect reply. --- libavformat/rtsp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtsp.c b/libavformat

Re: [libav-devel] [PATCH] fate: Switch ra4-288 test from framecrc() to pcm()

2014-09-24 Thread Martin Storsjö
On Wed, 24 Sep 2014, Katerina Barone-Adesi wrote: The decoder is float-based and the test needs to allow for some fuzz. --- tests/fate/real.mak | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/fate/real.mak b/tests/fate/real.mak index 2ad974c..f119ce9 100644 --- a/test

[libav-devel] [PATCH 1/2] libavformat: Move avc mp4 startcode parsing to a shared file

2014-09-24 Thread Martin Storsjö
--- libavformat/avc.c | 17 + libavformat/avc.h | 3 +++ libavformat/rtpenc_h264.c | 19 ++- 3 files changed, 22 insertions(+), 17 deletions(-) diff --git a/libavformat/avc.c b/libavformat/avc.c index 2fd5ac8..e639ed5 100644 --- a/libavformat/avc.c

[libav-devel] [PATCH 2/2] rtpenc: HEVC/H.265 support

2014-09-24 Thread Martin Storsjö
From: Thomas Volkert --- I did a few minor cleanups/changes on top of Thomas' original patches, that we've discussed off-list already, that Thomas agreed to. --- Changelog | 1 + libavformat/Makefile | 1 + libavformat/rtpenc.c | 9 libavformat/rtpenc.h

Re: [libav-devel] [PATCH 2/2] rtpenc: HEVC/H.265 support

2014-09-24 Thread Martin Storsjö
On Wed, 24 Sep 2014, Martin Storsjö wrote: From: Thomas Volkert --- I did a few minor cleanups/changes on top of Thomas' original patches, that we've discussed off-list already, that Thomas agreed to. --- Changelog | 1 + libavformat/Makefile | 1 + libavforma

Re: [libav-devel] [PATCH 2/2] rtpenc: HEVC/H.265 support

2014-09-24 Thread Martin Storsjö
On Wed, 24 Sep 2014, Luca Barbato wrote: On 24/09/14 14:24, Martin Storsjö wrote: +case AV_CODEC_ID_HEVC: +if (c->extradata_size) +av_log(NULL, AV_LOG_WARNING, "HEVC extradata not currently " + &qu

Re: [libav-devel] [PATCH 2/2] rtpenc: HEVC/H.265 support

2014-09-24 Thread Martin Storsjö
On Wed, 24 Sep 2014, Diego Biurrun wrote: On Wed, Sep 24, 2014 at 03:24:57PM +0300, Martin Storsjö wrote: --- a/Changelog +++ b/Changelog @@ -5,6 +5,7 @@ version : - aliases and defaults for Ogg subtypes (opus, spx) - HEVC/H.265 RTP payload format (draft v6) depacketizer - avplay now exits

[libav-devel] [PATCH] avcodec: Fix a doxy comment to refer to the right function

2014-09-24 Thread Martin Storsjö
CC: libav-sta...@libav.org --- libavcodec/avcodec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 253e45a..bc5f134 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -473,7 +473,7 @@ enum AVCodecID { /** * This

Re: [libav-devel] [PATCH 1/2] Enable Decoder Downmix including Downmix Metadata Support

2014-09-25 Thread Martin Storsjö
On Wed, 24 Sep 2014, Omer Osman wrote: Am 24.09.2014 17:07, schrieb Justin Ruggles: On 09/24/2014 10:48 AM, Omer Osman wrote: +switch (downmix_channels){ + case 2: + case 1: + if(aacDecoder_SetParam(s->handle, AAC_PCM_OUTPUT_CHANNELS, downmix_channels) !

Re: [libav-devel] [PATCH] sdp: Make opus declaration conform to the spec

2014-09-29 Thread Martin Storsjö
On Fri, 26 Sep 2014, Timothy B. Terriberry wrote: Err, trying again with an actual attached patch LGTM, thanks - pushed. // Martin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] rtmpproto: Add getStreamLength call to query duration

2014-09-29 Thread Martin Storsjö
Hi Uwe, On Mon, 29 Sep 2014, Uwe L. Korn wrote: In (non-live) streams with no metadata, the duration of a stream can be retrieved by calling the RTMP function getStreamLength with the playpath. The server will return a positive duration upon the request if the duration is known, otherwise eithe

Re: [libav-devel] [PATCH] Added parameter -hls_allow_cache

2014-10-01 Thread Martin Storsjö
Hi Joakim, On Thu, 2 Oct 2014, Joakim Roubert wrote: On 2014-09-19 10:01, Joakim Roubert wrote: The -hls_allow_cache parameter enables explicitly setting the [...] Just about 2 weeks since this latest patch was posted as a response to the last comments seen here. Is this ready for merge now?

Re: [libav-devel] [PATCH] Added parameter -hls_allow_cache

2014-10-03 Thread Martin Storsjö
On Thu, 2 Oct 2014, Joakim Roubert wrote: The -hls_allow_cache parameter enables explicitly setting the EXT-X-ALLOW-CACHE tag in the manifest file. That tag indicates whether the client MAY or MUST NOT cache downloaded media segments for later replay. Valid values are 1 (=YES) or 0 (=NO) and th

[libav-devel] [PATCH] sdp: Simplify parsing/conversion of H264 extradata

2014-10-03 Thread Martin Storsjö
By using ff_avc_write_annexb_extradata instead of the h264_mp4toannexb BSF, the code for doing the conversion itself is kept much shorter, there's less state to restore at the end, we don't risk leaving the AVCodecContext in an inconsistent state if returning early due to errors, etc. Also add a m

[libav-devel] [PATCH 2/2] sdp: Provide out of bound parameter sets for HEVC if extradata is set

2014-10-03 Thread Martin Storsjö
--- Only tested with libavformat's rtp depacketizer; testing/comparison against other implementations welcome. --- libavformat/sdp.c | 108 +- 1 file changed, 106 insertions(+), 2 deletions(-) diff --git a/libavformat/sdp.c b/libavformat/sdp.c i

[libav-devel] [PATCH 1/2] rtpdec_hevc: Parse out of band vps/sps/pps/sei from fmtp lines

2014-10-03 Thread Martin Storsjö
These are assembled into extradata in the order vps/sps/pps/sei. --- libavformat/rtpdec_hevc.c | 99 ++- 1 file changed, 97 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpdec_hevc.c b/libavformat/rtpdec_hevc.c index 0ff30e2..1bf3c1a 100644 --

[libav-devel] [PATCH] lavf: Set the stream time base hint properly for chained muxers

2014-10-06 Thread Martin Storsjö
This avoids warnings about using the codec time base as time base hint. --- libavformat/hdsenc.c | 1 + libavformat/hlsenc.c | 1 + libavformat/mpegtsenc.c | 1 + libavformat/segment.c| 1 + libavformat/smoothstreamingenc.c | 1 + 5 files changed, 5 ins

[libav-devel] [PATCH] lavf: Don't drop both pts and dts if timestamps are invalid

2014-10-06 Thread Martin Storsjö
From: Michael Niedermayer In these cases, only drop dts. Because if we drop both we have no timestamps at all for some files. This improves playback of HLS streams from GoPro cameras. --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c

Re: [libav-devel] [PATCH] rtpenc: Support streamcopy from AAC-LATM.

2014-10-07 Thread Martin Storsjö
On Tue, 7 Oct 2014, Josh Allmann wrote: May occur if trying to transmux from eg, MPEG2-TS to RTP. --- Untested with anything beyond SDP generation. libavformat/rtpenc.c | 4 libavformat/sdp.c| 6 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpenc.c

[libav-devel] [PATCH] ismindex: handle discontinuous streams better

2014-10-08 Thread Martin Storsjö
From: Mika Raento Read the fragment duration from the trun sample data, rather than assuming that there are no gaps. --- tools/ismindex.c | 96 ++-- 1 file changed, 86 insertions(+), 10 deletions(-) diff --git a/tools/ismindex.c b/tools/ismind

Re: [libav-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

2014-10-09 Thread Martin Storsjö
On Wed, 8 Oct 2014, James Almer wrote: Wrap the function calls in a similar fashion to how it's being done with the critical section API. Signed-off-by: James Almer --- compat/w32pthreads.h | 63 ++-- 1 file changed, 37 insertions(+), 26 deletions

[libav-devel] [PATCH] lavf: Don't drop both pts and dts if timestamps are invalid

2014-10-09 Thread Martin Storsjö
From: Michael Niedermayer In these cases, only drop dts. Because if we drop both we have no timestamps at all for some files. This improves playback of HLS streams from GoPro cameras. --- Now with updated fate refs as well. --- libavformat/utils.c| 2 +- tests/ref/fate/vc1-ism | 182 +

[libav-devel] [PATCH] movenc: Fix edit list for the case of negative pts

2014-10-09 Thread Martin Storsjö
From: Michael Niedermayer Previously we only wrote the edit list correctly if we had negative dts but pts == 0 (e.g. for video with B-frames). This makes sure that audio preroll for e.g. AAC is signaled correctly. --- libavformat/movenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a

Re: [libav-devel] [PATCH] sctp: Use AVERROR_BUG instead of abort()

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, Luca Barbato wrote: Trying to write to a stream id larger the the maximum requested is a programming error, still there is no reason to leave a reachable abort() in the codebase. CC: libav-sta...@libav.org --- libavformat/sctp.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [libav-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, James Almer wrote: On 09/10/14 5:03 AM, Martin Storsjö wrote: On Wed, 8 Oct 2014, James Almer wrote: Wrap the function calls in a similar fashion to how it's being done with the critical section API. Signed-off-by: James Almer --- compat/w32pthreads.h

Re: [libav-devel] [PATCH 2/2] compat/w32pthreads: use the condition variable API directly when targeting newer versions of Windows

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, James Almer wrote: Wrap the function calls in a similar fashion to how it's being done with the critical section API. Signed-off-by: James Almer --- compat/w32pthreads.h | 60 +--- 1 file changed, 38 insertions(+), 22 deletions

Re: [libav-devel] [PATCH 1/2] compat/w32pthreads: use the CONDITION_VARIABLE typedef if available

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, James Almer wrote: This silences warnings about passing arguments from incompatible pointer type when targeting Windows Vista or newer. Signed-off-by: James Almer --- compat/w32pthreads.h | 23 +-- configure| 2 ++ 2 files changed, 15 insertio

Re: [libav-devel] [PATCH] rtsp: Check for command strings without spaces

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, Luca Barbato wrote: Prevent a NULL-pointer dereference. CC: libav-sta...@libav.org --- libavformat/rtspdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index a14ec57..5442b7d 100644 --- a/libavformat/rtspdec.c +++ b/l

Re: [libav-devel] [PATCH 2/2] tcp: Add AVOption support

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, Luca Barbato wrote: --- libavformat/tcp.c | 40 +++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 27a0184..071c515 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -20,6

Re: [libav-devel] [PATCH 1/2] tls: Support passing old-style tcp options

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, Luca Barbato wrote: Make tcp and tls urls near-interchangeable. --- libavformat/tls.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavformat/tls.c b/libavformat/tls.c index 7c78fda..817aedc 100644 --- a/libavformat/tls.c +++ b/libavformat

Re: [libav-devel] Support rtsps

2014-10-09 Thread Martin Storsjö
On Thu, 9 Oct 2014, Luca Barbato wrote: Tested against wowza. All 4 seem ok to me // Martin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavf: Don't drop both pts and dts if timestamps are invalid

2014-10-10 Thread Martin Storsjö
On Thu, 9 Oct 2014, Martin Storsjö wrote: From: Michael Niedermayer In these cases, only drop dts. Because if we drop both we have no timestamps at all for some files. This improves playback of HLS streams from GoPro cameras. --- Now with updated fate refs as well. --- libavformat/utils.c

[libav-devel] [PATCH] smoothstreamingenc: Simplify code by removing a redundant variable

2014-10-11 Thread Martin Storsjö
--- Produced the patch with some extra content, to easier see why this is correct - with the normal amount of context the diff looked very suspicious. --- libavformat/smoothstreamingenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/smoothstreamingenc.c b/

[libav-devel] [PATCH 2/8] movenc: Add some comments explaining subtle details in writing the edit lists

2014-10-11 Thread Martin Storsjö
--- libavformat/movenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 09aded6..8be2fb1 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -1620,6 +1620,11 @@ static int mov_write_edts_tag(AVIOContext *pb, MOVTrack *trac

[libav-devel] [PATCH 1/8] movenc: Adjust edit lists to trim out parts of tracks with negative pts

2014-10-11 Thread Martin Storsjö
From: Michael Niedermayer This makes sure that audio preroll for e.g. AAC is signaled correctly. Previously we only wrote the edit list correctly if we had negative dts but started with pts == 0 (e.g. for video with B-frames). --- libavformat/movenc.c | 5 + 1 file changed, 5 insertions(+)

[libav-devel] [PATCH 7/8] movenc: Write tfdt atoms

2014-10-11 Thread Martin Storsjö
These allow getting the absolute start timestamp of a fragment without reading preceding timestamps. This fixes sync between tracks if starting from fragments in different streams that don't align exactly. This also is a prerequisite for producing DASH content. --- libavformat/movenc.c | 13 +

[libav-devel] [PATCH 4/8] movenc: Print a warning for an unhandled case of nonzero start dts with empty_moov

2014-10-11 Thread Martin Storsjö
--- When using empty_moov, the moov atom is written during the avformat_write_header call, when no packets have been fed to the muxer yet. (Delaying writing the moov to until the first packet has been received would make things much more complicated for users that want to use the muxer in a streami

[libav-devel] [PATCH 5/8] movenc: Simplify code by using an existing local pointer

2014-10-11 Thread Martin Storsjö
--- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index f0a4414..5387e64 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2977,7 +2977,7 @@ static int mov_flush_fragment(AVFormatContext *s)

[libav-devel] [PATCH 3/8] movenc: Write edit lists for fragmented files as well, if necessary

2014-10-11 Thread Martin Storsjö
This is necessary to get the right timestamp offset for content that starts with dts != 0. This currently only helps when writing fragmented files with a non-empty moov atom. When writing an empty moov atom, we don't have any packets yet, so we don't know the starting dts for the tracks. --- liba

[libav-devel] [PATCH 8/8] mov: Handle tfdt atoms

2014-10-11 Thread Martin Storsjö
--- libavformat/mov.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index d4281dc..2b64cbf 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2618,6 +2618,36 @@ static int mov_read_trex(MOVContext *c, AVIOContext

[libav-devel] [PATCH 6/8] movenc: Write correct presentation timestamps in tfra

2014-10-11 Thread Martin Storsjö
Previously we wrote decoding timestamps here, while the specs say it should be presentation timestamps. --- libavformat/movenc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 5387e64..4a690d0 100644 --- a/libavformat/movenc.c +++

Re: [libav-devel] [PATCH 1/8] movenc: Adjust edit lists to trim out parts of tracks with negative pts

2014-10-12 Thread Martin Storsjö
On Sun, 12 Oct 2014, Luca Barbato wrote: On 12/10/14 00:32, Martin Storsjö wrote: From: Michael Niedermayer This makes sure that audio preroll for e.g. AAC is signaled correctly. Previously we only wrote the edit list correctly if we had negative dts but started with pts == 0 (e.g. for

Re: [libav-devel] [PATCH 1/8] movenc: Adjust edit lists to trim out parts of tracks with negative pts

2014-10-12 Thread Martin Storsjö
On Sun, 12 Oct 2014, Luca Barbato wrote: On 12/10/14 12:46, Martin Storsjö wrote: On Sun, 12 Oct 2014, Luca Barbato wrote: On 12/10/14 00:32, Martin Storsjö wrote: From: Michael Niedermayer This makes sure that audio preroll for e.g. AAC is signaled correctly. Previously we only wrote

Re: [libav-devel] [PATCH 1/8] movenc: Adjust edit lists to trim out parts of tracks with negative pts

2014-10-12 Thread Martin Storsjö
On Sun, 12 Oct 2014, Yusuke Nakamura wrote: 2014-10-12 20:18 GMT+09:00 Martin Storsjö : On Sun, 12 Oct 2014, Luca Barbato wrote: On 12/10/14 12:46, Martin Storsjö wrote: On Sun, 12 Oct 2014, Luca Barbato wrote: On 12/10/14 00:32, Martin Storsjö wrote: From: Michael Niedermayer

Re: [libav-devel] [PATCH] mov: fix check for isom transfer conformance

2014-10-13 Thread Martin Storsjö
On Mon, 13 Oct 2014, Vittorio Giovara wrote: Introduced in 0d8a3656ba4c0ae8e4e0c91ff6b07d72a317f9f6. Reported-by: Ruoyu --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d4281dc..f767864 100644 --- a/libavform

Re: [libav-devel] [PATCH 1/3] lavc: deprecate the use of AVCodecContext.time_base for decoding

2014-10-13 Thread Martin Storsjö
On Mon, 13 Oct 2014, Vittorio Giovara wrote: On Wed, Oct 8, 2014 at 8:32 PM, Anton Khirnov wrote: diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index f0fa7a9..b6cd74d 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1170,7 +1170,8 @@ typedef struct AVCodecContext {

[libav-devel] [PATCH] ismindex: Remove a redundant variable

2014-10-15 Thread Martin Storsjö
--- As far as I can see, the extra variable wasn't ever really necessary. Or am I missing something, Mika? --- tools/ismindex.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tools/ismindex.c b/tools/ismindex.c index 53be5d6..496b729 100644 --- a/tools/ismindex.c +++

Re: [libav-devel] [PATCH] ismindex: Remove a redundant variable

2014-10-15 Thread Martin Storsjö
On Wed, 15 Oct 2014, Mika Raento wrote: This does change the logic: previously we returned a failure if any fragment failed, after your change we only return failure if the last fragment fails. Oh, right, that's what I missed. I had assumed that we'd break in case of an error - do you think w

Re: [libav-devel] [PATCH] ismindex: Remove a redundant variable

2014-10-15 Thread Martin Storsjö
On Wed, 15 Oct 2014, Mika Raento wrote: I think that depends on the use case: if you only have an ISMV and you want to use it, it's better to get all the fragments that are there out; if you have an alternative source for your video, then you want to know things didn't go well. It should be behi

Re: [libav-devel] [PATCH 1/3] rtmpproto: Add function to read a number response

2014-10-15 Thread Martin Storsjö
On Tue, 14 Oct 2014, Uwe L. Korn wrote: Packets that contain a number as a result to a rtmp function call are structured the same way (String, Number, Null, Number). This new method also includes more bounds checks to better handle packets that are not structured as expected. --- libavformat/rtm

Re: [libav-devel] [PATCH 2/3] rtmpproto: Add getStreamLength call to query duration

2014-10-15 Thread Martin Storsjö
On Tue, 14 Oct 2014, Uwe L. Korn wrote: In (non-live) streams with no metadata, the duration of a stream can I assume it doesn't hurt in case this is sent for a live stream, i.e. it's ignored and/or returns 0 in those cases as well? be retrieved by calling the RTMP function getStreamLength

Re: [libav-devel] [PATCH 3/3] rtmpproto: If stream is recorded or has a duration, we can seek

2014-10-15 Thread Martin Storsjö
On Tue, 14 Oct 2014, Uwe L. Korn wrote: --- libavformat/rtmpproto.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 6e90a9f..5a1e331 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -2784,6 +2784

[libav-devel] [PATCH] rtmpproto: Fix a typo

2014-10-15 Thread Martin Storsjö
--- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index ed6f80f..87d79bf 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -506,7 +506,7 @@ static int read_connect(URLContext *s, RTM

Re: [libav-devel] [PATCH 1/2] libfdk-aacdec: Enable Decoder Downmix including Downmix Metadata Support

2014-10-15 Thread Martin Storsjö
On Tue, 14 Oct 2014, Omer Osman wrote: The FDK decoder is capable of producing mono and stereo downmix from multichannel streams. These streams may contain metadata that control the downmix process. The decoder reqires an Ancillary Buffer in order to correctly apply downmix in streams containing

Re: [libav-devel] [PATCH 2/2] libfdk-aacdec: Enable Dynamic Range Control Metadata Support

2014-10-15 Thread Martin Storsjö
On Tue, 14 Oct 2014, Omer Osman wrote: For streams which contain DRC emtadata, the FDK decoder is able to control rendering of the decoded output. The rendering parameters are detailed in fdk_aac_dec_options []. The default behavior is left up to the decoder. Signed-off-by: Omer Osman --- lib

[libav-devel] [PATCH 1/2] libfdk-aacdec: Enable Decoder Downmix including Downmix Metadata Support

2014-10-15 Thread Martin Storsjö
From: Omer Osman The FDK decoder is capable of producing mono and stereo downmix from multichannel streams. These streams may contain metadata that control the downmix process. The decoder reqires an Ancillary Buffer in order to correctly apply downmix in streams containing downmix Metadata. The

[libav-devel] [PATCH 2/2] libfdk-aacdec: Enable Dynamic Range Control Metadata Support

2014-10-15 Thread Martin Storsjö
From: Omer Osman For streams which contain DRC emtadata, the FDK decoder is able to control rendering of the decoded output. The rendering parameters are detailed in fdk_aac_dec_options []. The default behavior is left up to the decoder. Signed-off-by: Omer Osman --- libavcodec/libfdk-aacdec.

Re: [libav-devel] [PATCH 1/2] libfdk-aacdec: Enable Decoder Downmix including Downmix Metadata Support

2014-10-15 Thread Martin Storsjö
On Wed, 15 Oct 2014, Luca Barbato wrote: On 15/10/14 13:40, Martin Storsjö wrote: From: Omer Osman The FDK decoder is capable of producing mono and stereo downmix from multichannel streams. These streams may contain metadata that control the downmix process. The decoder reqires an Ancillary

[libav-devel] [PATCH 2/2] rtpdec_hevc: Use av_realloc instead of av_malloc+memcpy

2014-10-15 Thread Martin Storsjö
--- libavformat/rtpdec_hevc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavformat/rtpdec_hevc.c b/libavformat/rtpdec_hevc.c index 72bf775..49789b0 100644 --- a/libavformat/rtpdec_hevc.c +++ b/libavformat/rtpdec_hevc.c @@ -124,24 +124,20 @@ static av_cold

[libav-devel] [PATCH 1/2] rtpdec_hevc: Rename a variable for clarity

2014-10-15 Thread Martin Storsjö
--- This was requested by Thomas. --- libavformat/rtpdec_hevc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/rtpdec_hevc.c b/libavformat/rtpdec_hevc.c index 1bf3c1a..72bf775 100644 --- a/libavformat/rtpdec_hevc.c +++ b/libavformat/rtpdec_hevc.c @

[libav-devel] [PATCH] rtsp: Check a memory allocation

2014-10-15 Thread Martin Storsjö
From: Michael Lynch CC: libav-sta...@libav.org --- libavformat/rtsp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index d574797..52f52a1 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1146,6 +1146,8 @@ start: if (content_length

Re: [libav-devel] [PATCH v3] configure: Force mingw's ld to keep the reloc section

2014-10-15 Thread Martin Storsjö
On Sat, 11 Oct 2014, Alex Smith wrote: Binutils will always strip the relocation information from executable files even if it needs it (dynamicbase/ASLR). We can work around this by using the pic-executable flag combined with setting the correct entry point since apparently ld forgets what that

Re: [libav-devel] [PATCH 1/2] configure: Support for HEASLR on mingw targets

2014-10-15 Thread Martin Storsjö
On Sat, 11 Oct 2014, Alex Smith wrote: The appropriate flag for HEASLR (--high-entropy-va) is scheduled for inclusion in the next version of binutils (2.25), doesn't hurt to include it a little early. Also set the image base >4GB so higher entropy gets applied to image base randomization when u

Re: [libav-devel] [PATCH 2/2] configure: Disable automatic image base calculation

2014-10-15 Thread Martin Storsjö
On Sat, 11 Oct 2014, Alex Smith wrote: There's no reason for it. ASLR will rebase it regardless so "preventing collisions" isn't really relevant. This also brings it in line with what a msvc produced dll will have (an image base of 0x1000). Signed-off-by: Alex Smith --- configure | 2 +-

Re: [libav-devel] [PATCH] ismindex: use tfhd default duration if no sample duration

2014-10-15 Thread Martin Storsjö
On Thu, 16 Oct 2014, Mika Raento wrote: --- tools/ismindex.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/tools/ismindex.c b/tools/ismindex.c index 53be5d6..fc0a2ca 100644 --- a/tools/ismindex.c +++ b/tools/ismindex.c @@ -225,7 +225,8 @@ fail: retu

Re: [libav-devel] [PATCH] ismindex: use tfhd default duration if no sample duration

2014-10-15 Thread Martin Storsjö
On Thu, 16 Oct 2014, Mika Raento wrote: --- tools/ismindex.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/tools/ismindex.c b/tools/ismindex.c index 53be5d6..1d1aa26 100644 --- a/tools/ismindex.c +++ b/tools/ismindex.c @@ -225,7 +225,8 @@ fail:

Re: [libav-devel] [PATCH 1/2] configure: Support for HEASLR on mingw targets

2014-10-15 Thread Martin Storsjö
On Sat, 11 Oct 2014, Alex Smith wrote: The appropriate flag for HEASLR (--high-entropy-va) is scheduled for inclusion in the next version of binutils (2.25), doesn't hurt to include it a little early. Also set the image base >4GB so higher entropy gets applied to image base randomization when u

Re: [libav-devel] [PATCH 2/3] rtmpproto: Add getStreamLength call to query duration

2014-10-16 Thread Martin Storsjö
On Thu, 16 Oct 2014, Uwe L. Korn wrote: On 15/10/14 12:06, Martin Storsjö wrote: On Tue, 14 Oct 2014, Uwe L. Korn wrote: In (non-live) streams with no metadata, the duration of a stream can I assume it doesn't hurt in case this is sent for a live stream, i.e. it's ignored and/or

Re: [libav-devel] [PATCH 1/2] libfdk-aacdec: Enable Decoder Downmix including Downmix Metadata Support

2014-10-16 Thread Martin Storsjö
On Fri, 17 Oct 2014, Tim Walker wrote: On 15 Oct 2014, at 13:40, Martin Storsjö wrote: When downmixing multichannel streams, the decoder requires the output buffer in aacDecoder_DecodeFrame call to be of fixed size in order to hold the actual number of channels contained in the stream. For

Re: [libav-devel] [PATCH 1/2] libfdk-aacdec: Enable Decoder Downmix including Downmix Metadata Support

2014-10-17 Thread Martin Storsjö
On Fri, 17 Oct 2014, Tim Walker wrote: On 17 Oct 2014, at 08:32, Martin Storsjö wrote: - if a downmix is requested, the 6-channel buffer allocated during init gets used - if no downmix is requested, the 6-channel buffer allocated during init is freed and a buffer large enough only for the

Re: [libav-devel] [PATCH 2/2] rtmpproto: Add pause support

2014-10-17 Thread Martin Storsjö
On Fri, 17 Oct 2014, Uwe L. Korn wrote: --- libavformat/rtmpproto.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 830e4b7..55987b7 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpp

Re: [libav-devel] [PATCH 02/10] rtpproto: Free the addrinfo pointer on failure

2014-10-19 Thread Martin Storsjö
On Sat, 18 Oct 2014, Vittorio Giovara wrote: From: Luca Barbato CC: libav-sta...@libav.org Bug-Id: CID 1238797 --- libavformat/rtpproto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/rtpproto.c b/libavformat/rtpproto.c index 0f31539..d5ecfc8 100644 --- a/li

Re: [libav-devel] [PATCH 05/10] rtmpproto: remove dead code

2014-10-19 Thread Martin Storsjö
On Sat, 18 Oct 2014, Vittorio Giovara wrote: Expression already evaluated before, redundant since 053386864219eccbcca1886c55f902f9555428a5. Bug-Id: CID 732199 --- libavformat/rtmpproto.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index

Re: [libav-devel] [PATCH 01/10] hdsenc: Check rename() return value

2014-10-19 Thread Martin Storsjö
On Sat, 18 Oct 2014, Vittorio Giovara wrote: From: Michael Niedermayer CC: libav-sta...@libav.org Bug-Id: CID 1135748 --- libavformat/hdsenc.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavformat/hdsenc.c b/libavformat/hdsenc.c index 53fef33..f41381d

Re: [libav-devel] [PATCH 04/10] rtpenc: check mb_info return value before using it

2014-10-19 Thread Martin Storsjö
On Sat, 18 Oct 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1035715 --- libavformat/rtpenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 647a807..63b76f9 100644 --- a/libavformat/rtpenc.c ++

Re: [libav-devel] [PATCH 04/10] rtpenc: check mb_info return value before using it

2014-10-20 Thread Martin Storsjö
On Mon, 20 Oct 2014, Vittorio Giovara wrote: On Sun, Oct 19, 2014 at 7:18 PM, Martin Storsjö wrote: On Sat, 18 Oct 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1035715 --- libavformat/rtpenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [libav-devel] [PATCH 2/5] smoothstreamingenc: explict cast to avoid overflow

2014-10-20 Thread Martin Storsjö
On Mon, 20 Oct 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 732248 --- libavformat/smoothstreamingenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c index beea73d..3180ea9 100644 ---

Re: [libav-devel] [PATCH 1/5] smoothstreamingenc: check ffurl_open return value

2014-10-20 Thread Martin Storsjö
On Mon, 20 Oct 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 732187 --- libavformat/smoothstreamingenc.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/smoothstreamingenc.c b/libavformat/smoothstreamingenc.c index a6d0a36..beea73d 100

Re: [libav-devel] [PATCH 4/5] flvdec: avoid unitialized use of a struct member

2014-10-20 Thread Martin Storsjö
On Mon, 20 Oct 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 718141 --- libavformat/flvdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 9d45ebd..2d5e50e 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @

Re: [libav-devel] [PATCH 3/5] flvdec: make sure to check create_stream and report the same error

2014-10-20 Thread Martin Storsjö
On Mon, 20 Oct 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 732242 --- libavformat/flvdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 56c932c..9d45ebd 100644 --- a/libavformat/flvdec.c +++ b

Re: [libav-devel] [PATCH 5/5] mov: fix assigment check

2014-10-20 Thread Martin Storsjö
On Mon, 20 Oct 2014, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1197050 --- libavformat/mov.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 0e29bf3..b8d9f4c 100644 --- a/libavformat/mov.c +++ b/libavformat/

Re: [libav-devel] [PATCH 1/1] fate-mpeg4: use TARGET_SAMPLES for resize tests

2014-10-21 Thread Martin Storsjö
On Tue, 21 Oct 2014, Janne Grunau wrote: --- tests/fate/mpeg4.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/mpeg4.mak b/tests/fate/mpeg4.mak index 1565247..f9b94e6 100644 --- a/tests/fate/mpeg4.mak +++ b/tests/fate/mpeg4.mak @@ -1,7 +1,7 @@ MPEG4_RESOLUTION_C

[libav-devel] [PATCH 2/8] lavu: Add an offset to the fallback path in av_gettime_relative

2014-10-22 Thread Martin Storsjö
On platform where no monotonic clock is available, the difference between the two av_gettime functions is not clear, and one could mistakenly use the relative clock where an absolute one is required. Therefore add an offset, to make it evident that the time returned from av_gettime_relative never i

[libav-devel] [PATCH 4/8] tools: Use av_gettime_relative

2014-10-22 Thread Martin Storsjö
From: Olivier Langlois Whenever av_gettime() is used to measure relative period of time, av_gettime_relative() is prefered as it guarantee monotonic time on supported platforms. --- tools/aviocat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/aviocat.c b/tools/av

[libav-devel] [PATCH 1/8] lavu: Add av_gettime_relative

2014-10-22 Thread Martin Storsjö
Since av_gettime() is used in a number of places where actual real time clock is required, the monotonic clock introduced in ebef9f5a5 would have consequences that are hard to handle. Instead split it into a separate function that can be used in the cases where only relative time is desired. Based

[libav-devel] [PATCH 3/8] lavc: Use av_gettime_relative

2014-10-22 Thread Martin Storsjö
From: Olivier Langlois Whenever av_gettime() is used to measure relative period of time, av_gettime_relative() is prefered as it guarantee monotonic time on supported platforms. --- libavcodec/dct-test.c | 8 libavcodec/fft-test.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(

[libav-devel] [PATCH 5/8] avplay: Use av_gettime_relative

2014-10-22 Thread Martin Storsjö
--- avplay.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/avplay.c b/avplay.c index 58da984..9148c04 100644 --- a/avplay.c +++ b/avplay.c @@ -101,7 +101,7 @@ typedef struct PacketQueue { typedef struct VideoPicture { double pts;

[libav-devel] [PATCH 7/8] lavd: Use av_gettime_relative

2014-10-22 Thread Martin Storsjö
The one occurrance of av_gettime in libavdevice that I didn't change was in pulseaudio, for the wallclock option. --- libavdevice/bktr.c | 6 +++--- libavdevice/fbdev.c | 4 ++-- libavdevice/jack_audio.c| 4 ++-- libavdevice/oss_audio_dec.c | 2 +- libavdevice/sndio_dec.c

[libav-devel] [PATCH 6/8] avconv: Use av_gettime_relative

2014-10-22 Thread Martin Storsjö
--- avconv.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/avconv.c b/avconv.c index dc21aff..23f69cb 100644 --- a/avconv.c +++ b/avconv.c @@ -876,7 +876,7 @@ static void print_report(int is_last_report, int64_t timer_start) if (!is_last_report) {

<    2   3   4   5   6   7   8   9   10   11   >