Re: [libav-devel] [PATCH] qsvenc: AV_PIX_FMT_QSV path should release frame

svenc: AV_PIX_FMT_QSV path should > > release frame > > > > On 18/09/2018 09:54, Maxym Dmytrychenko wrote: > > > Fixes high memory usage, now is back to normal. > > > > > > Can be checked as: > > > -hwaccel qsv -c:v h264_qsv -i ../h264-conformance

[libav-devel] [PATCH] qsvenc: AV_PIX_FMT_QSV path should release frame

Fixes high memory usage, now is back to normal. Can be checked as: -hwaccel qsv -c:v h264_qsv -i ../h264-conformance/CANL2_Sony_E.jsv -c:v h264_qsv -b:v 2000k -y qsv.mp4 --- libavcodec/qsvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index

Re: [libav-devel] [PATCH v7] qsvvpp: Fix to perform full init only when needed

On Mon, Sep 3, 2018 at 11:20 AM Li, Zhong wrote: > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > > Maxym Dmytrychenko > > Sent: Monday, September 3, 2018 2:07 AM > > To: libav-devel@libav.org > > Subject: [libav-devel] [PATCH v7] qsvvpp:

[libav-devel] [PATCH v7] qsvvpp: Fix to perform full init only when needed

From: Joe Olivas Removing unused VPP sessions by initializing only when used in order to help reduce CPU utilization. Thanks to Maxym for the guidance. Signed-off-by: Joe Olivas Signed-off-by: Maxym Dmytrychenko --- libavutil/hwcontext_qsv.c | 83

Re: [libav-devel] [PATCH v6] qsvvpp: Fix to perform full init only when needed

axym for the guidance. > > > > Signed-off-by: Joe Olivas > Please, add: > Cc: Maxym Dmytrychenko > Cc: Dmitry Rogozhkin > > To keep us in the review loop. > > --- > > libavutil/hwcontext_qsv.c | 78 - > > -- > > 1 file

Re: [libav-devel] [PATCH v5] qsvvpp: Fix to perform full init only when needed

On Wed, Jul 18, 2018 at 2:07 PM Maxym Dmytrychenko wrote: > Not used VPP sessions, like for hwupload/hwdownload handling, > can increase CPU utilization and this patch fixes it. > thank you,Joe, for the contribution. > > Signed-off-by: Maxym Dmytrychenko > --- > libavutil

Re: [libav-devel] [PATCH 1/3] lavf/qsv: return an error if getting session handle failed

On Wed, Aug 22, 2018 at 1:21 PM Luca Barbato wrote: > On 21/08/2018 09:15, Li, Zhong wrote: > > Thank you. Luca. Will be applied? > > I was waiting for Maxym's feedback, but sure, it can. > > I'll push it this evening. > > lu > ___ > libav-devel

Re: [libav-devel] [PATCH v2] qsv: enforcing continuous memory layout

On Mon, Jul 30, 2018 at 6:15 PM Luca Barbato wrote: > On 30/07/2018 18:02, Maxym Dmytrychenko wrote: > > we need to make sure that memory allocation for Y/UV planes is > continuous and re-used from a > > pool > > --- > > I'm afraid this would break the already-prop

Re: [libav-devel] [PATCH] frame: Simplify the video allocation

On Sat, Jul 28, 2018 at 7:19 AM Luca Barbato wrote: > And reduce the memory fragmentation. > > --- > > libavutil/frame.c | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index db3897c299..f16b1d4d52

Re: [libav-devel] [PATCH] qsv: enforcing continuous memory layout

On Sun, Jul 29, 2018 at 7:38 PM Diego Biurrun wrote: > On Sun, Jul 29, 2018 at 12:50:42AM +0200, Maxym Dmytrychenko wrote: > > On Sat, Jul 28, 2018 at 12:20 PM Diego Biurrun wrote: > > > On Sat, Jul 28, 2018 at 10:53:54AM +0200, maxim_d33 wrote: > > > > --- >

[libav-devel] [PATCH v2] qsv: enforcing continuous memory layout

we need to make sure that memory allocation for Y/UV planes is continuous and re-used from a pool --- libavcodec/qsvenc.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index e349a075f..c74b3ae31 100644 ---

Re: [libav-devel] [PATCH] qsv: enforcing continuous memory layout

Hi Diego! On Sat, Jul 28, 2018 at 12:20 PM Diego Biurrun wrote: > On Sat, Jul 28, 2018 at 10:53:54AM +0200, maxim_d33 wrote: > > --- > > libavcodec/qsvenc.c | 34 -- > > 1 file changed, 24 insertions(+), 10 deletions(-) > > Looks like your Git is not set up

Re: [libav-devel] [PATCH v2] avcodec/qsv: fix async support

Y > and polling > loop. This change address this misbehaviour. > > Signed-off-by: Dmitry Rogozhkin > Cc: Maxym Dmytrychenko > Cc: Zhong Li > --- > libavcodec/qsvdec.c | 15 --- > libavcodec/qsvdec_h2645.c | 4 ++-- > libavcodec/qsvdec_othe

Re: [libav-devel] [PATCH] avcodec/qsv: fix async support

On Thu, Jul 26, 2018 at 7:55 AM Li, Zhong wrote: > > -Original Message- > > From: Rogozhkin, Dmitry V > > Sent: Wednesday, July 25, 2018 1:36 AM > > To: libav-devel@libav.org > > Cc: Rogozhkin, Dmitry V ; Maxym > > Dmytrychenko ; Li, Zhong > &g

Re: [libav-devel] [PATCH] avcodec/qsv: fix async support

On Wed, Jul 25, 2018 at 10:24 PM Luca Barbato wrote: > On 25/07/2018 19:39, Rogozhkin, Dmitry V wrote: > > So, I encourage to embrace this change and understand that there are > > some changes in performance associated with it which aligns the > > behavior with the expected usage models. > > I

Re: [libav-devel] [PATCH] avcodec/qsv: fix async support

. This change address this misbehaviour. > > Signed-off-by: Dmitry Rogozhkin > Cc: Maxym Dmytrychenko > Cc: Zhong Li > --- > libavcodec/qsvdec.c | 15 --- > libavcodec/qsvenc.c | 17 + > 2 files changed, 25 insertions(+), 7 deletions(-) > > dif

[libav-devel] [PATCH v5] qsvvpp: Fix to perform full init only when needed

Not used VPP sessions, like for hwupload/hwdownload handling, can increase CPU utilization and this patch fixes it. thank you,Joe, for the contribution. Signed-off-by: Maxym Dmytrychenko --- libavutil/hwcontext_qsv.c | 72 +-- 1 file changed, 64

Re: [libav-devel] [PATCH v4] qsvvpp: Fix to perform full init only when needed

On Wed, Jul 18, 2018 at 1:34 AM Mark Thompson wrote: > On 18/07/18 00:25, Maxym Dmytrychenko wrote: > > On Wed, Jul 18, 2018 at 12:48 AM Mark Thompson wrote: > > > >> On 17/07/18 17:07, Maxym Dmytrychenko wrote: > >>> Not used VPP sessions, like for hwu

Re: [libav-devel] [PATCH v4] qsvvpp: Fix to perform full init only when needed

On Wed, Jul 18, 2018 at 12:48 AM Mark Thompson wrote: > On 17/07/18 17:07, Maxym Dmytrychenko wrote: > > Not used VPP sessions, like for hwupload/hwdownload handling, > > can increase CPU utilization and this patch fixes it. > > thank you,Joe, for the contribution. > &g

[libav-devel] [PATCH v4] qsvvpp: Fix to perform full init only when needed

Not used VPP sessions, like for hwupload/hwdownload handling, can increase CPU utilization and this patch fixes it. thank you,Joe, for the contribution. Signed-off-by: Maxym Dmytrychenko --- libavutil/hwcontext_qsv.c | 38 +- 1 file changed, 29 insertions

Re: [libav-devel] [PATCH v3] qsvvpp: Fix to perform full init only when needed

On Tue, Jul 17, 2018 at 12:00 AM Mark Thompson wrote: > On 16/07/18 14:26, Maxym Dmytrychenko wrote: > > Not used VPP sessions, like for hwupload/hwdownload handling, > > can increase CPU utilization and this patch fixes it. > > thank you,Joe, for the contribution. > &g

[libav-devel] [PATCH v3] qsvvpp: Fix to perform full init only when needed

Not used VPP sessions, like for hwupload/hwdownload handling, can increase CPU utilization and this patch fixes it. thank you,Joe, for the contribution. Signed-off-by: Maxym Dmytrychenko --- libavutil/hwcontext_qsv.c | 35 ++- 1 file changed, 26 insertions(+), 9

[libav-devel] [PATCH v2] qsvvpp: Fix to perform full init only when needed

Not used VPP sessions, like for hwupload/hwdownload handling, can increase CPU utilization and this patch fixes it. thank you,Joe, for the contribution. Signed-off-by: Maxym Dmytrychenko --- libavutil/hwcontext_qsv.c | 31 --- 1 file changed, 24 insertions(+), 7

[libav-devel] [PATCH] qsvvpp: Fix to perform full init only when needed

Not used VPP sessions, like for hwupload/hwdownload handling, can increase CPU utilization and this patch fixes it. thank you,Joe, for the contribution. Signed-off-by: Maxym Dmytrychenko --- libavutil/hwcontext_qsv.c | 31 --- 1 file changed, 24 insertions(+), 7

[libav-devel] [PATCH] qsvvpp: Fix to perform full init only when needed

Not used VPP sessions, like for hwupload/hwdownload handling, can increase CPU utilization and this patch fixes it. Signed-off-by: Maxym Dmytrychenko --- libavutil/hwcontext_qsv.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/libavutil

Re: [libav-devel] [PATCH] lavc/qsv_overlay: suppress code scan complain

should it be AV_PIX_FMT_NONE ? On Tue, Jul 3, 2018 at 9:53 AM Zhong Li wrote: > Suppress the complain "variables 'pix_fmt' is used but maybe > uninitialized". > > Signed-off-by: Zhong Li > --- > libavfilter/vf_overlay_qsv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [libav-devel] [PATCH] qsvenc: remove vcm option on Linux

agree, Luca. will close it shortly. On Thu, Jun 7, 2018 at 5:04 PM, Luca Barbato wrote: > On 07/06/2018 10:51, Zhong Li wrote: > > 1. vcm mode is only available for H264. > > 2. vcm is not supported on Linux, but it is shown when run "./avconv -h > > encoder=h264_qsv |grep vcm". This shouldn't

Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable MFE mode

thanks Luca, this patch should be reasonable On Mon, May 21, 2018 at 9:58 AM, Luca Barbato wrote: > On 21/05/2018 08:33, Zhong Li wrote: > > Not convenient if using numerals to set MFE mode. It is ambiguous > > and misleading (e.g: user may misunderstand setting mfmode to 1

Re: [libav-devel] [PATCH 2/2] lavc/qsvenc: add mf_max_num option for MFE

looks ok for me as well On Sat, May 5, 2018 at 12:06 AM, Zhong Li wrote: > Maximum number of frames to be used for combining. > Each encoder in joined sessions has to be initialized with the same value. > > Signed-off-by: Zhong Li > --- >

Re: [libav-devel] [PATCH v2] qsv: adding Multi Frame Encode support

org> wrote: > On 02/04/2018 15:17, Maxym Dmytrychenko wrote: > > +if (QSV_RUNTIME_VERSION_ATLEAST(ver, 1, 25)) { > > Maybe use QSV_HAVE_MF ? > > The rest looks fine to me. > > lu > ___ > libav-devel maili

[libav-devel] [PATCH v2] qsv: adding Multi Frame Encode support

Starting from API 1.25 helps to improve performance of the simultaneous encode, 1:N scenario, like: ./avconv -y -hwaccel qsv -c:v h264_qsv -r 3/1001 -i ~/bbb_sunflower_1080p_60fps_normal.mp4 -vframes 600 -an \ -filter_complex "split=2[s1][s2]; [s1]scale_qsv=1280:720[o1];

Re: [libav-devel] [PATCH] qsv: adding Multi Frame Encode support

thanks for the feedbacks , below some answers and v2 is upcoming. On Thu, Mar 29, 2018 at 1:03 AM, Mark Thompson <s...@jkqxz.net> wrote: > On 27/03/18 23:07, Maxym Dmytrychenko wrote: > > On Tue, Mar 27, 2018 at 12:47 AM, Mark Thompson <s...@jkqxz.net> wrote: > > &g

Re: [libav-devel] [PATCH V2 2/3] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

how about second option : temporary frame with the stricter alignment and copy to that before uploading but with log/INFO message included ? On Mon, Apr 2, 2018 at 2:45 PM, Mark Thompson wrote: > On 02/04/18 10:32, Li, Zhong wrote: > >>> diff --git a/libavutil/hwcontext_qsv.c

Re: [libav-devel] [PATCH 2/2] lavf/qsvvpp: bypass vpp if not needed.

going to the right direction, can we see more details about " specific case." ? On Thu, Mar 29, 2018 at 4:01 PM, Zhong Li wrote: > It is benefit to performance for specific case. > > Signed-off-by: Zhong Li > --- > libavfilter/vf_vpp_qsv.c | 28

Re: [libav-devel] [PATCH V2 2/3] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

should be ok, will take care of it shotly On Thu, Mar 29, 2018 at 4:05 PM, Li, Zhong wrote: > Ping? > > > -Original Message- > > From: Li, Zhong > > Sent: Thursday, March 22, 2018 10:42 PM > > To: libav-devel@libav.org > > Cc: Li, Zhong ; Liu,

Re: [libav-devel] [PATCH] qsv: adding Multi Frame Encode support

On Tue, Mar 27, 2018 at 11:55 AM, Li, Zhong wrote: > > diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h index > > 975c8de44..516994a64 100644 > > --- a/libavcodec/qsv_internal.h > > +++ b/libavcodec/qsv_internal.h > > @@ -36,6 +36,9 @@ > >

Re: [libav-devel] [PATCH] qsv: adding Multi Frame Encode support

On Tue, Mar 27, 2018 at 12:47 AM, Mark Thompson <s...@jkqxz.net> wrote: > On 26/03/18 21:18, Maxym Dmytrychenko wrote: > > Starting from API 1.25 helps to improve performance of the simultaneous > encode, > > 1:N scenario, like: > > > > ./avconv -y -hwacce

[libav-devel] [PATCH] qsv: adding Multi Frame Encode support

Starting from API 1.25 helps to improve performance of the simultaneous encode, 1:N scenario, like: ./avconv -y -hwaccel qsv -c:v h264_qsv -r 3/1001 -i ~/bbb_sunflower_1080p_60fps_normal.mp4 -vframes 600 -an \ -filter_complex "split=2[s1][s2]; [s1]scale_qsv=1280:720[o1];

Re: [libav-devel] [PATCH V3 3/3] lavc/qsvdec: expose frame pic_type

aside of intend points at frame->surface..., should be ok On Thu, Mar 22, 2018 at 3:41 PM, Zhong Li wrote: > Currently pict_type are unset. > Add an extra param to fetch the picture type from qsv decoder > > v2: fix the compile error since AV_PICTURE_TYPE_NONE is not

Re: [libav-devel] [PATCH 2/2] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

Clean and specific patch is always good, agree with you on removal here. On Tue, Mar 20, 2018 at 9:18 AM, Li, Zhong <zhong...@intel.com> wrote: > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > > Maxym Dmytrychenko > > Sent: Monday, March 19, 20

Re: [libav-devel] [PATCH 2/2] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

indentation can be adjusted , AV_PIX_FMT_YUYV422 - we add it but dont use? On Mon, Mar 19, 2018 at 10:33 AM, Zhong Li wrote: > And support nv12/yuyv422/rgb32 formats for qsv_transfer_data > > Signed-off-by: ChaoX A Liu > Signed-off-by: Zhong Li

Re: [libav-devel] [PATCH 1/2] lavc/qsvdec: set complete_frame flags for non-interlaced frames.

MFX_BITSTREAM_COMPLETE_FRAME support can be added as a param or can be only such if() conditions sufficient for all cases and streams ? On Mon, Mar 19, 2018 at 10:33 AM, Zhong Li wrote: > Set the flag MFX_BITSTREAM_COMPLETE_FRAME when it is a completed frame. > This can

Re: [libav-devel] AV1 support through libaom

looks very promising, Luca ! On Thu, Mar 8, 2018 at 9:50 PM, Luca Barbato wrote: > [PATCH 1/3] ivf: Support VP9 and AV1 as well > Unchanged > > [PATCH 2/3] Add AV1 video decoding support through libaom > Now copies the 8bit highbitdepth variant to normal planar yuv

Re: [libav-devel] [PATCH] lavc/qsvenc: provide detail error message if parameters invalid

The same :) > 2 марта 2018 г., в 5:11, Luca Barbato написал(а): > >> On 02/03/2018 04:26, Zhong Li wrote: >> Currently always shows "Selected ratecontrol mode is not supported by >> the QSV runtime. Choose a different mode", but sometimes it is not >> accurate. >>

Re: [libav-devel] [PATCH 6/8] vf_hwupload/hwmap: Support setting a fixed pool size

On Mon, Feb 12, 2018 at 12:30 AM, wm4 wrote: > On Sun, 11 Feb 2018 23:09:51 + > Mark Thompson wrote: > > > On 11/02/18 07:21, Song, Ruiling wrote: > > > I have run some test against the patches. It works as described. > > > > Great - there is general

Re: [libav-devel] [PATCH] lavc/qsv: default la_ds to MFX_LOOKAHEAD_DS_UNKNOWN

looks reasonable. On Sun, Feb 11, 2018 at 8:43 AM, Ruiling Song wrote: > MFX_LOOKAHEAD_DS_UNKNOWN means auto. > -1 is not a valid value. > > Signed-off-by: Ruiling Song > --- > libavcodec/qsvenc.h | 5 +++-- > 1 file changed, 3 insertions(+), 2

Re: [libav-devel] [PATCH] qsvenc: AVBR is not supported on non-windows OS

it actually should fail-down to VBR but we have VBR already exposed. LGTM , no other objection(s) ? On Tue, Jan 30, 2018 at 11:07 AM, Zhong Li wrote: > AVBR is supported from API 1.3 but only available for Windows > > Signed-off-by: Zhong Li > --- >

Re: [libav-devel] [PATCH] lavc/qsvdec: expose frame pic_type and key_frame

LGTM as well, will take care of it this week. On Mon, Jan 29, 2018 at 9:20 AM, Luca Barbato wrote: > On 29/01/2018 08:31, Zhong Li wrote: > >> Currently key_frame and pict_type are unset. >> Add an extra param to fetch the picture type from qsv decoder >> >> Signed-off-by:

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

great conclusion and let's have the patches re-viewed. On Fri, Jan 26, 2018 at 6:56 PM, Luca Barbato wrote: > On 26/01/2018 16:15, Li, Zhong wrote: > >> Thank you all for the comments! Currently I am inclined to keep >> current libavcodec parser (i.e; just like wm4's

Re: [libav-devel] [PATCH] qsvdec: fix vp8 decoding failure issues

LGTM as well On Fri, Jan 26, 2018 at 9:37 AM, Luca Barbato wrote: > On 25/01/2018 11:19, Zhong Li wrote: > >> many vp8 clips decoding will be failed if hw_frames_ctx is enabled, >> reporting "Error during QSV decoding.: incompatible video parameters >> (-14)". >> It is due

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

+ as sort of default value is 32 I would check why frames_ctx->initial_pool_size or NumFrameSuggested cannot be used log message as a warning is a good idea. On Fri, Jan 26, 2018 at 9:42 AM, Luca Barbato wrote: > On 26/01/2018 02:16, Ruiling Song wrote: > >> +

Re: [libav-devel] [PATCH V2] lavc/qsv: skip the packet if decoding failure.

just fine, thanks On Thu, Jan 25, 2018 at 8:59 AM, Luca Barbato wrote: > On 25/01/2018 02:21, Song, Ruiling wrote: > >> >> >> -Original Message- From: libav-devel >>> [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca Barbato Sent: >>> Wednesday, January 24,

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

Mark, libmfx supported D3D11 array textures too - approved for implementation and should be there soon On Mon, Jan 22, 2018 at 2:19 PM, Mark Thompson wrote: > On 22/01/18 11:20, Li, Zhong wrote: > > MSDK provides an API (MFXVideoDECODE_DecodeHeader) to parse video >

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

IMHO - good reason(s) plus : it will be more consistent approach to rely on QSV's API/DecodeHeader functionality. would not expect many regression(s), so patches would be good to have for review. On Mon, Jan 22, 2018 at 12:20 PM, Li, Zhong wrote: > MSDK provides an API

Re: [libav-devel] [PATCH] lavc/qsv: skip the packet if decoding failure.

would be av_packet_unref() more appropriate ? On Mon, Jan 22, 2018 at 9:53 AM, Ruiling, Song wrote: > MediaSDK may fail to decode some frame, just skip it. > Otherwise, it will keep decoding the failure packet repeatedly > without processing any packet afterwards. > >

[libav-devel] [PATCH] qsv: better to use alignment by 16 and HEVC 10b requires alignment by 32

--- libavcodec/qsvdec.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index c74ec6836..9741f3310 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -475,6 +475,7 @@ int

[libav-devel] [PATCH] qsv: HW HEVC10b decode requires 32 bytes alignment

--- libavcodec/qsvdec.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index c74ec6836..9741f3310 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -475,6 +475,7 @@ int

Re: [libav-devel] [PATCH 1/2] lavu/qsv: add log message for libmfx version

Just fine as well > 28 дек. 2017 г., в 11:59, Luca Barbato написал(а): > >> On 28/12/2017 10:38, Zhong Li wrote: >> It is benefit to diagnose issues related to different libmfx version. >> Signed-off-by: Zhong Li >> --- >> libavutil/hwcontext_qsv.c | 4

Re: [libav-devel] [PATCH] qsv: Support explicit lookahead downscaling

comment: :) patch:OK On Tue, Dec 12, 2017 at 4:04 PM, Diego Biurrun wrote: > On Tue, Dec 12, 2017 at 02:27:56PM +, Luca Barbato wrote: > > --- > > libavcodec/qsvenc.c | 4 > > libavcodec/qsvenc.h | 13 + > > 2 files changed, 17 insertions(+) > >

Re: [libav-devel] [PATCH 1/6] qsvenc_hevc: Replace ad-hoc VPS writing with CBS implementation

if tested - LGTM On Mon, Dec 11, 2017 at 1:44 AM, Mark Thompson wrote: > This copies more information which should be present from the SPS. > It also fixes the value of vps_temporal_id_nesting_flag, which was > previously incorrect for a single-layer stream (the standard states

Re: [libav-devel] [PATCH V2] lavc/qsvenc: set HRD buffer size

will check it shortly On Fri, Dec 1, 2017 at 9:48 AM, Zhong Li wrote: > Hypothetical Reference Decoding (HRD) model assumes that data flows > into a buffer of the fixed size BufferSizeInKB with a constant bitrate. > Smaller BufferSizeInKB means smaller frame size variations,

Re: [libav-devel] [PATCH] lavc/qsvenc: set HRD buffer size

good point about CBR... and this would require to get BufferSizeInKB adjusted at the proper place, with InitialDelayInKB On Tue, Nov 28, 2017 at 11:41 PM, Mark Thompson wrote: > On 01/12/17 20:04, Zhong Li wrote: > > Hypothetical Reference Decoding (HRD) model assumes that data

Re: [libav-devel] [PATCH v2 2/2] qsv/h264enc: fix cavlc option setting useless issue

this looks clear and touches only relevant implementation, will take care shortly. On Mon, Nov 27, 2017 at 5:19 PM, Zhong Li wrote: > No matter cavlc option is set to 0 or 1, the output bitstream is always > cabac mode. > Reproduce: -y -s widthxheight -i widthxheight.yuv

Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

of common >> option >> >>> On Mon, Nov 13, 2017 at 02:03:47PM +0100, Maxym Dmytrychenko wrote: >>>> On Mon, Nov 13, 2017 at 8:54 AM, Zhong Li <zhong...@intel.com> wrote: >>>> >>>> CAVLC option is only available for h264 encoding. >&g

Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

I would leave it as it is now On Wed, Nov 15, 2017 at 4:09 PM, Li, Zhong <zhong...@intel.com> wrote: > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > > Maxym Dmytrychenko > > Sent: Monday, November 13, 2017 9:04 PM > > To: libav deve

Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

correct fix On Mon, Nov 13, 2017 at 8:54 AM, Zhong Li wrote: > CAVLC option is only available for h264 encoding. > CABAC is the only entropy coding way for hevc. > > Signed-off-by: Zhong Li > --- > libavcodec/qsvenc.h | 3 +-- >

Re: [libav-devel] [PATCH] qsv/hevcdec: Load hw plugin by default on non-windows os

agree, will commit it shortly On Fri, Nov 10, 2017 at 7:43 PM, Luca Barbato wrote: > On 10/11/2017 09:03, Zhong Li wrote: > >> Software plugin is not available on Linux, Only works on Windows. >> Similar changes have been applied to qsv hevc encoder by >>

Re: [libav-devel] [PATCH] qsv: Make the hevc idr_interval consistent with the h264 one

technical aspect(s) should be ok thanks, Luca On Wed, Oct 18, 2017 at 3:29 AM, Diego Biurrun wrote: > On Tue, Oct 17, 2017 at 11:49:57AM +, Luca Barbato wrote: > > According to the MediaSDK documentation the idr_interval value has > > a different meaning depending on the

Re: [libav-devel] [PATCH] qsv: Expose idr_interval for hevc as well

LGTM and helps to have the proper control. thanks, Luca ! On Sat, Oct 14, 2017 at 1:22 AM, Luca Barbato wrote: > --- > libavcodec/qsvenc_hevc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > index

Re: [libav-devel] [PATCH 2/2 V3] libavfilter/vf_vpp: Add common filters of the qsv vpp

seems to be fine, if no other objections will commit shortly On Wed, Aug 30, 2017 at 3:41 PM, Luca Barbato wrote: > On 24/08/2017 04:16, Huang, Zhengxu wrote: > >> --- >> Changes from v2: >> * Modify the configure file and fix some resources release issues as per >> Anton's

Re: [libav-devel] [PATCH] qsv: Load the hw hevc plugin by default on Linux

should be so, Luca On Fri, Sep 8, 2017 at 6:26 AM, Luca Barbato wrote: > On 07/09/2017 22:14, Mark Thompson wrote: > >> In principle I'm very much in favour, except last time I looked at >> this there >> was>

Re: [libav-devel] [PATCH] qsv: Load the hw hevc plugin by default on Linux

old Media SDK might be considered as outdated, it would be good to support the latest one, at first. On Thu, Sep 7, 2017 at 10:14 PM, Mark Thompson wrote: > On 06/09/17 14:07, Luca Barbato wrote: > > Only on Windows the software plugin is available. > > --- > > > >

Re: [libav-devel] [PATCH 08/14] vf_scale_qsv: Support modifying hardware frame pool sizes

should be ok, can try it next week, if you didnt. On Wed, Sep 6, 2017 at 12:59 AM, Mark Thompson wrote: > The deinterlacer does not change, because it does not allocate any new > frames (for output it uses the same pool as the input). > --- > libavfilter/vf_scale_qsv.c | 26

Re: [libav-devel] [PATCH 2/2] libavfilter/vf_vpp: Add common filters of the qsv vpp

ok, it seems that ./configure related deps change are missing. as you did for overlay: _filter_deps= _filter_select= On Tue, Aug 1, 2017 at 7:58 AM, Huang, Zhengxu <zhengxu.maxw...@gmail.com> wrote: > > > On 2017/8/1 3:22, Maxym Dmytrychenko wrote: > > LGTM, seems to

Re: [libav-devel] [PATCH 1/2 V3] libavfilter/overlay_qsv: Add QSV overlay vpp filter

about configure changes >+overlay_qsv_filter_deps="libmfx qsv" why not simply "libmfx" ? On Thu, Aug 3, 2017 at 11:30 AM, Luca Barbato wrote: > On 03/08/2017 04:24, Huang, Zhengxu wrote: > > --- > > Changes from v2: > > * Add "SKIPHEADERS" and modify some

Re: [libav-devel] [PATCH 1/2] libavfilter/overlay_qsv: Add QSV overlay vpp filter

seems to be working. about: >enum QSVMemMode would it be possible to avoid such for the favour of MFX_MEMTYPE_* ? On Tue, Aug 1, 2017 at 8:10 AM, Huang, Zhengxu wrote: > On 2017/7/31 19:41, Luca Barbato wrote: > > On 31/07/2017 03:25, Huang, Zhengxu wrote: >> After

Re: [libav-devel] [PATCH] lavf/vf_deinterlace_qsv: Enable the qsv deinterlace vpp

the same and seems to be working just fine On Fri, Jul 21, 2017 at 12:36 PM, Luca Barbato wrote: > On 21/07/2017 08:35, Huang, Zhengxu wrote: > > > > Looks good. The documentation should be updated as well, but can happen > on a second time. > > lu > >

Re: [libav-devel] [PATCH V3] libavcodec/mjpeg_qsv: Add QSV MJPEG encoder

besides some syntax issues: align the = It seems to be working with default input as well as from hwaccel qsv: -hwaccel qsv -c:v h264_qsv -i input_file -vcodec mjpeg_qsv -r 30 -f mjpeg output On Fri, Jul 21, 2017 at 6:12 AM, Huang, Zhengxu wrote: > --- > Changes from

Re: [libav-devel] [PATCH 6/6] hwaccel: QSV H264 support using libmfx

On Mon, Oct 6, 2014 at 4:07 PM, Luca Barbato lu_z...@gentoo.org wrote: On 29/09/14 12:35, Luca Barbato wrote: On 02/09/14 12:08, Luca Barbato wrote: On 02/09/14 11:35, Gwenole Beauchesne wrote: I like mfx because this clearly represents the name of the supporting library too, so this

Re: [libav-devel] [PATCH] Intel Media SDK, Quick Sync Video/QSV: Initial add of H.264 decoder infrastructure

, Diego Biurrun di...@biurrun.de wrote: On Wed, Feb 27, 2013 at 11:46:45PM +0100, Maxym Dmytrychenko wrote: On 13-02-27 19:50:51, Diego Biurrun wrote: On Wed, Feb 27, 2013 at 06:39:57PM +0100, maxd wrote: On 13-02-21 16:03:30, Diego Biurrun wrote: On Mon, Feb 04

[libav-devel] [PATCH 2/2] Intel Media SDK, Quick Sync Video/QSV: Initial add of H.264 decoder infrastructure

--- Changelog |1 + configure |7 +++ libavcodec/Makefile|2 ++ libavcodec/allcodecs.c |1 + libavcodec/qsv.h |2 +- libavcodec/qsv_h264.c |9 - libavcodec/version.h |2 +- libavutil/pixfmt.h |1 + 8 files

[libav-devel] [PATCH 2/2] Intel Media SDK, Quick Sync Video/QSV: Initial add of H.264 decoder infrastructure

From: Maxym Dmytrychenko maxim@gmail.com --- Changelog |1 + configure |7 +++ libavcodec/Makefile|2 ++ libavcodec/allcodecs.c |1 + libavcodec/qsv.h |2 +- libavcodec/qsv_h264.c |9 - libavcodec/version.h |2

Re: [libav-devel] [PATCH] Intel Media SDK, Quick Sync Video/QSV: Initial add of H.264 decoder infrastructure

On 13-02-27 19:50:51, Diego Biurrun wrote: On Wed, Feb 27, 2013 at 06:39:57PM +0100, maxd wrote: On 13-02-21 16:03:30, Diego Biurrun wrote: On Mon, Feb 04, 2013 at 08:49:35PM +0100, Maxym Dmytrychenko wrote: From: Maxym Dmytrychenko maxym.dmytryche...@intel.com Does your patch