Re: [libav-devel] [PATCH 4/8] lavc: add support for filtering packets before decoding

On 30/11/2016 14:04, Anton Khirnov wrote: > --- > configure | 1 + > libavcodec/avcodec.h | 6 ++ > libavcodec/decode.c | 163 > ++ > libavcodec/decode.h | 2 + > libavcodec/internal.h | 6 ++ > libavcodec/utils.c| 3

Re: [libav-devel] [PATCH] qsv: Increase the surface pool

On 30/11/2016 10:56, Anton Khirnov wrote: > I think at this point we should just add an avconv option for setting > the pool size (that would apply to all the hwaccels) rather than > hardcoding random numbers everywhere. I'm not against that, but the problem of having a default that shouldn't

Re: [libav-devel] [PATCH 6/8] lavc: add a bitstream filter for splitting VP9 superframes

On 30/11/2016 14:04, Anton Khirnov wrote: > Partially based on code by Ronald S. Bultje . > --- > doc/bitstream_filters.texi| 4 + > libavcodec/Makefile | 1 + > libavcodec/bitstream_filters.c| 1 + >

Re: [libav-devel] [PATCH 1/3] arm: vp9itxfm: Only reload the idct coeffs for the iadst_idct combination

On 2016-11-28 11:26:00 +0200, Martin Storsjö wrote: > This avoids reloading them if they haven't been clobbered, if the > first pass also was idct. > > This is similar to what was done in the aarch64 version. > --- > libavcodec/arm/vp9itxfm_neon.S | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [libav-devel] [PATCH] mmaldec: initialize refcount using atomic_init().

I also noticed that |refcount| is declared as atomic_int in libavcodec/mmaldec.c but declared as atomic_uint in libavutil/buffer_internal.h. It would be nice to be consistent. Wan-Teh Chang ___ libav-devel mailing list libav-devel@libav.org

[libav-devel] [PATCH] mmaldec: initialize refcount using atomic_init().

This is how we initialize refcount in libavutil/buffer.c. Signed-off-by: Wan-Teh Chang --- libavcodec/mmaldec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c index 924bfb2..e64ddba 100644 ---

Re: [libav-devel] [PATCH 12/13] build: Fine-grained link-time dependency settings

On 29/11/2016 19:34, Diego Biurrun wrote: > Previously, all link-time dependencies were added for all libraries, > resulting in bogus link-time dependencies since not all dependencies > are shared across libraries. Also, in some cases like libavutil, not > all dependencies were taken into account,

Re: [libav-devel] [PATCH] vp9dsp: add DC only versions for idct/idct.

On 2016-11-29 14:55:41 +0200, Martin Storsjö wrote: > From: Clément Bœsch > > before: > > time ./avconv -v 0 -nostats -threads 1 -i sintel_vp9_500kbps.webm -f null - > real0m11.125s > user0m11.059s > sys 0m0.050s > > time ./avconv -v 0 -nostats -threads 1 -i

Re: [libav-devel] [PATCH] pthread_frame: use better memory orders for frame progress

Quoting Wan-Teh Chang (2016-11-30 21:33:37) > This improves commit 59c70227405c214b29971e6272f3a3ff6fcce3d0. > > In ff_thread_report_progress(), the fast code path can load > progress[field] with the relaxed memory order, and the slow code path > can store progress[field] with the release memory

Re: [libav-devel] [PATCH 2/2] pnm: Drop inappropriate const qualifier

Quoting Diego Biurrun (2016-11-30 22:02:37) > libavcodec/pnmdec.c:41:19: warning: assignment discards ‘const’ qualifier > from pointer target type [-Wdiscarded-qualifiers] > libavcodec/pnmdec.c:42:23: warning: assignment discards ‘const’ qualifier > from pointer target type

Re: [libav-devel] [PATCH] compat/atomics: use the alternate GCC keyword __typeof__

Hi Rémi, On Wed, Nov 30, 2016 at 1:46 PM, Rémi Denis-Courmont wrote: > > I´d hazard a guess that in C11 mode, you should use the compiler´s > , rather than libav´s variant of my compatibility wrapper. > > At least, I did not intend it to be used in C11 mode. I am using gcc

Re: [libav-devel] [PATCH 2/3] arm: vp9itxfm: Skip empty slices in the first pass of idct_idct 16x16 and 32x32

On 2016-11-28 11:26:01 +0200, Martin Storsjö wrote: > This work is sponsored by, and copyright, Google. > > Previously all subpartitions except the eob=1 (DC) case ran with > the same runtime: > > vp9_inv_dct_dct_16x16_sub16_add_neon: 3188.1 2435.4 2499.0 1969.0 >

Re: [libav-devel] [PATCH 1/1] fate: report ignored tests but ignore the test result

On Wed, Nov 23, 2016 at 08:51:16PM +0100, Janne Grunau wrote: > On 2016-11-23 11:58:38 +0100, Diego Biurrun wrote: > > On Tue, Nov 22, 2016 at 08:39:26PM +0100, Janne Grunau wrote: > > > On 2016-11-22 16:43:50 +0100, Diego Biurrun wrote: > > > > On Mon, Nov 21, 2016 at 12:31:24AM +0100, Janne

[libav-devel] [PATCH] compat/atomics: use the alternate GCC keyword __typeof__

When compiling with -std=c11, the typeof keyword in compat/atomics/gcc/stdatomic.h generates a compiler warning: implicit declaration of function ‘typeof’. Using __typeof__ instead of typeof is recommended in https://gcc.gnu.org/onlinedocs/gcc/Typeof.html

Re: [libav-devel] [PATCH] pthread_frame: use better memory orders for frame progress

Hi Anton, On Wed, Nov 30, 2016 at 1:03 PM, Anton Khirnov wrote: > > Did you see any measurable change in performance after this patch? This patch is intended to avoid confusion when one inspects the source code. ff_thread_report_progress() and ff_thread_await_progress() form

Re: [libav-devel] [PATCH 3/3] aarch64: vp9itxfm: Skip empty slices in the first pass of idct_idct 16x16 and 32x32

On 2016-11-28 11:26:02 +0200, Martin Storsjö wrote: > This work is sponsored by, and copyright, Google. > > Previously all subpartitions except the eob=1 (DC) case ran with > the same runtime: > > vp9_inv_dct_dct_16x16_sub16_add_neon: 1373.2 > vp9_inv_dct_dct_32x32_sub32_add_neon: 8089.0 >

[libav-devel] [PATCH 1/2] rangecoder: Drop incorrect const from ff_init_range_decoder

libavcodec/rangecoder.c:57:30: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual] --- libavcodec/rangecoder.c | 6 ++ libavcodec/rangecoder.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/rangecoder.c b/libavcodec/rangecoder.c

[libav-devel] [PATCH 2/2] pnm: Drop inappropriate const qualifier

libavcodec/pnmdec.c:41:19: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] libavcodec/pnmdec.c:42:23: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] --- libavcodec/pnmdec.c | 2 +- 1 file changed,

[libav-devel] [PATCH 1/2] lavc: Validate color properties without using out-of-ABI elements

The color properties enumerations may contain gaps, and lavc should not rely on lavu ABI in this way. Signed-off-by: Vittorio Giovara --- Following discussion on IRC. A better wording for either commit log is welcome. Cheers, Vittorio libavcodec/h264_ps.c | 8

[libav-devel] [PATCH 2/2] options_table: Do not rely on enum size as option bound

Signed-off-by: Vittorio Giovara --- libavcodec/options_table.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 9fff50d..4deb223 100644 --- a/libavcodec/options_table.h +++

Re: [libav-devel] [PATCH 09/13] build: Drop support for old versions of libdc1394

On Tue, Nov 29, 2016 at 03:29:17PM -0500, Vittorio Giovara wrote: > On Tue, Nov 29, 2016 at 1:34 PM, Diego Biurrun wrote: > > --- a/libavdevice/libdc1394.c > > +++ b/libavdevice/libdc1394.c > > @@ -104,9 +79,6 @@ struct dc1394_frame_rate { > > #define OFFSET(x)

Re: [libav-devel] [PATCH 1/2] rangecoder: Drop incorrect const from ff_init_range_decoder

Quoting Diego Biurrun (2016-11-30 22:02:36) > libavcodec/rangecoder.c:57:30: warning: cast discards ‘const’ qualifier from > pointer target type [-Wcast-qual] > --- > libavcodec/rangecoder.c | 6 ++ > libavcodec/rangecoder.h | 2 +- > 2 files changed, 3 insertions(+), 5 deletions(-) > >

Re: [libav-devel] [PATCH 2/3] vaapi_encode: Pass framerate parameters to driver

Quoting Mark Thompson (2016-11-29 23:51:06) > This is required by both the VP8 and VP9 encoders and is harmless to > others, so add it to the common code. > --- > The VP9 encoder just loses the appropriate fragment, with no other change > (not resent here). > > > libavcodec/vaapi_encode.c | 25

Re: [libav-devel] [PATCH 3/3] vaapi_encode: Add VP8 support

Quoting Mark Thompson (2016-11-30 00:01:21) > --- > I was avoiding this one until I could do VP9 at the same time because the > headers and probability stuff looked nasty. Turns out that was entirely > unfounded, because the i965 driver doesn't actually support any of those > things, and

Re: [libav-devel] [PATCH] qsv: Increase the surface pool

Quoting Luca Barbato (2016-11-29 16:41:05) > Otherwise is not possible to decode, deinterlace and encode at the same > time. > --- > > Even if I make it user-tunable I'd rather have a default pool large enough. > > Alternatively we could use separate pools for encoding, decoding and >

Re: [libav-devel] [PATCH 3/3] vaapi_encode: Add VP8 support

Quoting Mark Thompson (2016-11-30 00:01:21) > --- > I was avoiding this one until I could do VP9 at the same time because > the headers and probability stuff looked nasty. Turns out that was > entirely unfounded, because the i965 driver doesn't actually support > any of those things, and

Re: [libav-devel] [PATCH] lavfi: Add VAAPI deinterlacer

Quoting Mark Thompson (2016-11-29 23:48:19) > --- > On 29/11/16 11:50, Anton Khirnov wrote: > > Either one is fine with me. I guess picking the higher numbered might be > > a little safer since it will also work in implementations that don't > > support motion-adaptive, if they happen to exist. >

Re: [libav-devel] [PATCH 1/3] vaapi_h265: Fix CFR mode with framerate set in AVCodecContext

Quoting Mark Thompson (2016-11-29 23:49:44) > Same issue as 17a0f9481cf07af0feb3838ca315b970117e8000. > --- > libavcodec/vaapi_encode_h265.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c > index

Re: [libav-devel] [PATCH 12/13] build: Fine-grained link-time dependency settings

On 29/11/2016 19:34, Diego Biurrun wrote: > +vda_extralibs="-framework CoreFoundation -framework VideoDecodeAcceleration > -framework QuartzCore pthreads_extralibs" +vda_extralibs='"-framework CoreFoundation" "-framework VideoDecodeAcceleration" "-framework QuartzCore" $pthreads_extralibs' This

Re: [libav-devel] [PATCH 2/3] vp9: Add bsf to recombine frames/superframes

On 30/11/16 03:37, Ronald S. Bultje wrote: > Hi, > > On Mon, Nov 28, 2016 at 6:50 PM, Mark Thompson wrote: > >> --- >> Incomplete, but enough to work with the encoder in patch 3. >> >> Todo: >> * Superframe splitting. >> > > From what I understand, Anton ported the vp9 parser

[libav-devel] [PATCH 2/8] decode: be more explicit about storing the last packet properties

The current code stores a pointer to the packet passed to the decoder, which is then used during get_buffer() for timestamps and side data passthrough. However, since this is a pointer to user data which we do not own, storing it is potentially dangerous. It is also ill defined for the new

[libav-devel] [PATCH 5/8] qsvdec_h2645: switch to the new generic filtering mechanism

Drop the internal manual conversion from the MP4 format to Annex B. --- libavcodec/qsvdec_h2645.c | 74 +++ 1 file changed, 11 insertions(+), 63 deletions(-) diff --git a/libavcodec/qsvdec_h2645.c b/libavcodec/qsvdec_h2645.c index a26f150..8ac403b

[libav-devel] [PATCH 7/8] vp9: split superframes in the filtering stage before actual decoding

Significantly increases the efficiency of frame threading, since individual frames in a superframe can now be decoded in parallel. --- configure| 2 +- libavcodec/vp9.c | 74 ++-- 2 files changed, 14 insertions(+), 62 deletions(-) diff

[libav-devel] [PATCH 1/8] lavc: add a null bitstream filter

It is useful for testing/debugging and will also be used as the default filter in the following commit adding pre-decode filtering to avoid having a separate non-filtered codepath. --- doc/bitstream_filters.texi | 3 +++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c |

[libav-devel] [PATCH 3/8] decode: restructure the core decoding code

Currently, the new decoding API is pretty much just a wrapper around the old deprecated one. This is problematic, since it interferes with making full use of the flexibility added by the new API. The old API should also be removed at some future point. Reorganize the code so that the new

[libav-devel] [PATCH 4/8] lavc: add support for filtering packets before decoding

--- configure | 1 + libavcodec/avcodec.h | 6 ++ libavcodec/decode.c | 163 ++ libavcodec/decode.h | 2 + libavcodec/internal.h | 6 ++ libavcodec/utils.c| 3 + 6 files changed, 169 insertions(+), 12 deletions(-)

[libav-devel] [PATCH 8/8] binkaudio: switch to the new send/receive API

It is more natural for this codec and allows to avoid awkward constructs like "consuming 0 bytes from input". Also, keep a reference to the input packet to avoid unnecessary copying. --- libavcodec/binkaudio.c | 58 -- 1 file changed, 32

[libav-devel] [PATCH 6/8] lavc: add a bitstream filter for splitting VP9 superframes

Partially based on code by Ronald S. Bultje . --- doc/bitstream_filters.texi| 4 + libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c| 1 + libavcodec/vp9_superframe_split_bsf.c | 146 ++ 4

[libav-devel] [PATCH v2] Decoding core rewrite

Hi, new version of the core decoding code changes. The main patch (3/8) now changes the internal lavc-to-decoders API, which has allowed me to significantly simplify the code. See the commit message in that patch for details. The vp9 bsf now uses the new bitstream reading API. I've also

Re: [libav-devel] [PATCH 2/3] vp9: Add bsf to recombine frames/superframes

Hi, On Wed, Nov 30, 2016 at 6:48 AM, Mark Thompson wrote: > On 30/11/16 03:37, Ronald S. Bultje wrote: > > Hi, > > > > On Mon, Nov 28, 2016 at 6:50 PM, Mark Thompson wrote: > > > >> --- > >> Incomplete, but enough to work with the encoder in patch 3. > >> > >>

[libav-devel] [PATCH] fate: Add spherical and stereo3d mov tests

--- I added an entry and gave this a better commit title. Vittorio tests/fate/mov.mak | 10 ++ tests/ref/fate/mov-spherical | 4 tests/ref/fate/mov-stereo3d | 1 + 3 files changed, 15 insertions(+) create mode 100644 tests/ref/fate/mov-spherical create mode 100644

[libav-devel] [PATCH 5/5 v4] fate: Add a spherical probe test

--- Everybody loves testing! Vittorio tests/fate/mov.mak | 7 +++ tests/ref/fate/mov-spherical | 4 2 files changed, 11 insertions(+) create mode 100644 tests/ref/fate/mov-spherical diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 909e438..939b5a7 100644 ---

[libav-devel] [PATCH] mov: Export spherical information

This implements Spherical Video V1 and V2, as described in the spatial-media collection by Google. Signed-off-by: Vittorio Giovara --- Dropped a set of unused variables. Vittorio Changelog | 1 + libavformat/isom.h | 6 ++ libavformat/mov.c | 262

[libav-devel] [PATCH 1/5 v4] lavu: Add a video section to Doxygen documentation

Fill it with AVStereo3D and AVDisplayMatrix documentation. Apply the necessary changes to make verbatim code look good in doxygen. Signed-off-by: Vittorio Giovara --- No changes, already approved. Vittorio libavutil/avutil.h | 6 ++ libavutil/display.h | 27

[libav-devel] [PATCH 2/5 v4] lavu: Add AVSphericalMapping type and frame side data

While no decoder currently exports spherical information, this type represents a frame property that has to be passed through from container to frames. Signed-off-by: Vittorio Giovara --- I removed the bounding rectangle section as on second read of the spec it does

[libav-devel] [PATCH 3/5 v4] lavc: Add spherical packet side data API

Signed-off-by: Vittorio Giovara --- Minor cosmetic changes. Vittorio avprobe.c| 21 + doc/APIchanges | 4 libavcodec/avcodec.h | 6 ++ libavcodec/utils.c | 1 + libavcodec/version.h | 4 ++-- libavformat/dump.c |

[libav-devel] [PATCH 4/5 v4] mov: Export spherical information

This implements Spherical Video V1 and V2, as described in the spatial-media collection by Google. Signed-off-by: Vittorio Giovara --- No changes. Vittorio Changelog | 1 + libavformat/isom.h | 6 ++ libavformat/mov.c | 263

Re: [libav-devel] [PATCH 1/2] rangecoder: Drop incorrect const from ff_init_range_decoder

On 30/11/2016 22:02, Diego Biurrun wrote: > libavcodec/rangecoder.c:57:30: warning: cast discards ‘const’ qualifier from > pointer target type [-Wcast-qual] > --- > libavcodec/rangecoder.c | 6 ++ > libavcodec/rangecoder.h | 2 +- > 2 files changed, 3 insertions(+), 5 deletions(-) > The

Re: [libav-devel] [PATCH] fate: Add spherical and stereo3d mov tests

On Thu, Dec 1, 2016 at 1:37 AM, Diego Biurrun wrote: > On Wed, Nov 30, 2016 at 06:28:29PM -0500, Vittorio Giovara wrote: >> --- a/tests/fate/mov.mak >> +++ b/tests/fate/mov.mak >> @@ -10,6 +10,16 @@ fate-mov-rotation: CMD = probestream rotation >>

[libav-devel] [PATCH 2/2] build: Add separate flags for checkheaders targets

This allows filtering out some warning noise. --- common.mak | 1 + configure | 9 + 2 files changed, 10 insertions(+) diff --git a/common.mak b/common.mak index 8f6a61f..3724648 100644 --- a/common.mak +++ b/common.mak @@ -33,6 +33,7 @@ ALLHEADERS := $(subst

[libav-devel] [PATCH 1/2] build: Add -Wpedantic and -Wextra to extra warning flags

Also drop -Winline from set of warning flags as it only produces noise. --- configure | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 71141c2..f2f96e5 100755 --- a/configure +++ b/configure @@ -4834,8 +4834,12 @@ check_cflags -Wtype-limits

Re: [libav-devel] [PATCH] fate: Add spherical and stereo3d mov tests

On Wed, Nov 30, 2016 at 06:28:29PM -0500, Vittorio Giovara wrote: > --- a/tests/fate/mov.mak > +++ b/tests/fate/mov.mak > @@ -10,6 +10,16 @@ fate-mov-rotation: CMD = probestream rotation > $(TARGET_SAMPLES)/mov/displaymatri > > +FATE_MOV += fate-mov-spherical > +fate-mov-spherical: \ > +CMD

Re: [libav-devel] [PATCH] fate: Add spherical and stereo3d mov tests

On Thu, Dec 01, 2016 at 02:13:00AM -0500, Vittorio Giovara wrote: > On Thu, Dec 1, 2016 at 1:37 AM, Diego Biurrun wrote: > > On Wed, Nov 30, 2016 at 06:28:29PM -0500, Vittorio Giovara wrote: > >> --- a/tests/fate/mov.mak > >> +++ b/tests/fate/mov.mak > >> @@ -10,6 +10,16 @@

Re: [libav-devel] [PATCH] mpeg4audio: correctly propagate meaningful error values

On Wed, Nov 30, 2016 at 11:12:40AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > Needed since 45d199d5 because av_bsf_init() should return actual > AVERROR values. > > libavcodec/mpeg4audio.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-)

Re: [libav-devel] [PATCH 2/4] cabac: x86: Give optimizations header a more meaningful name

On Tue, Nov 29, 2016 at 01:24:59PM +0100, Diego Biurrun wrote: > --- > libavcodec/h264_cabac.c | 2 +- > libavcodec/x86/{h264_i386.h => h264_cabac.c} | 6 +- > 2 files changed, 2 insertions(+), 6 deletions(-) > rename libavcodec/x86/{h264_i386.h => h264_cabac.c} (98%) >

[libav-devel] [PATCH] mpeg4audio: correctly propagate meaningful error values

Signed-off-by: James Almer --- Needed since 45d199d5 because av_bsf_init() should return actual AVERROR values. libavcodec/mpeg4audio.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/mpeg4audio.c b/libavcodec/mpeg4audio.c index