Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

evel] [PATCH 1/2] qsvenc: move cavlc out of common > option > > Patch is just fine, nothing else required. > Busy days and should be finished these days > > > 22 нояб. 2017 г., в 2:56, Li, Zhong <zhong...@intel.com> написал(а): > > > > Ping? Any dependency to a

Re: [libav-devel] [PATCH] lavc/qsvenc: set HRD buffer size

> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Wednesday, November 29, 2017 6:14 PM > To: libav development > Subject: Re: [libav-devel] [PATCH] lavc/qsvenc: set HRD buffer size > > good

Re: [libav-devel] [PATCH] lavc/qsvenc: set HRD buffer size

> The Intel documentation says "BufferSizeInKB represents the maximum > possible size of any compressed frames.". Is that just confused? Some of > the surrounding text does suggest that it's the right thing. > > Probably fine, but are you sure it should be set when in non-bitrate-targetted >

Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

ption > > I would leave it as it is now Yeah, it is not high priority since FF_API_CODER_TYPE hasn't been removed now. > > On Wed, Nov 15, 2017 at 4:09 PM, Li, Zhong <zhong...@intel.com> wrote: > > > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf >

Re: [libav-devel] [PATCH] qsv/hevcdec: Load hw plugin by default on non-windows os

gt;> Software plugin is not available on Linux, Only works on Windows. > >> Similar changes have been applied to qsv hevc encoder by > >> b05128f3c953bd66483e697d60a2e7e45ee9cfa0. > >> > >> Signed-off-by: Zhong Li <zhong...@intel.com> > >> --- &g

Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

av-devel@libav.org> > Subject: Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common > option > > On Mon, Nov 13, 2017 at 02:03:47PM +0100, Maxym Dmytrychenko wrote: > > On Mon, Nov 13, 2017 at 8:54 AM, Zhong Li <zhong...@intel.com> wrote: > > > > > C

Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Monday, November 13, 2017 9:04 PM > To: libav development > Subject: Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common > option > > correct fix I have an idea

Re: [libav-devel] [PATCH] qsv/vp8dec: fix memory leak issue

17 08:26, Zhong Li wrote: > > Signed-off-by: Zhong Li <zhong...@intel.com> > > --- > > libavcodec/qsvdec_other.c | 5 + > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_other.c > > ind

Re: [libav-devel] [PATCH V2] lavc/qsvenc: set HRD buffer size

> will check it shortly > Got it, thanks. : ) > On Fri, Dec 1, 2017 at 9:48 AM, Zhong Li <zhong...@intel.com> wrote: > > > Hypothetical Reference Decoding (HRD) model assumes that data flows > > into a buffer of the fixed size BufferSizeInKB with a constant bitra

Re: [libav-devel] [PATCH] qsv: Support explicit lookahead downscaling

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Tuesday, December 12, 2017 10:28 PM > To: libav-devel@libav.org > Subject: [libav-devel] [PATCH] qsv: Support explicit lookahead downscaling > > --- > libavcodec/qsvenc.c | 4 >

Re: [libav-devel] [PATCH 1/2] vaapi_h264: Add workaround for bad SEI in old Intel drivers

> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Mark > Thompson > Sent: Wednesday, October 25, 2017 7:29 AM > To: libav development > Subject: [libav-devel] [PATCH 1/2] vaapi_h264: Add workaround for bad SEI > in old

Re: [libav-devel] [PATCH 2/2] lavc/qsvenc: add mf_max_num option for MFE

[PATCH 2/2] lavc/qsvenc: add mf_max_num option > for MFE > > looks ok for me as well > > On Sat, May 5, 2018 at 12:06 AM, Zhong Li <zhong...@intel.com> wrote: > > > Maximum number of frames to be used for combining. > > Each encoder in joined sessions h

Re: [libav-devel] [PATCH 1/2] lavc/qsvenc: add detail options for MFE mode

Thanks for review. : ) Do you need me to update it, or you can help to add the alias when you merge it? > -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Friday, May 4, 2018 5:26 PM > To: libav-devel@libav.org > Subject:

Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable MFE mode

gt; On Wed, May 23, 2018 at 03:15:14AM +, Li, Zhong wrote: > > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf > > > Of Diego Biurrun > > > Sent: Tuesday, May 22, 2018 6:30 PM > > > To: libav development <libav-devel@libav.org>

Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable MFE mode

; > Not convenient if using numerals to set MFE mode. It is ambiguous > > > and misleading (e.g: user may misunderstand setting mfmode to 1 is > > > to enable MFE but actually it is to disable MFE, and set it to be 5 > > > or > > above is meaningless). > >

Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable MFE mode

On Tue, May 22, 2018 at 08:03:00AM +, Li, Zhong wrote: > > > -Original Message- > > > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf > > > Of Diego Biurrun > > > Sent: Monday, May 21, 2018 11:17 PM > > > To: libav developme

Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable MFE mode

> -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Diego Biurrun > Sent: Monday, May 21, 2018 11:17 PM > To: libav development > Subject: Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable > MFE mode > >

Re: [libav-devel] [PATCH] lavf/qsv: suppress code scan complain

Sure. Will update it. Thanks for review. > -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Wednesday, July 4, 2018 5:39 AM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] lavf/qsv: suppress code scan

Re: [libav-devel] [PATCH] lavc/qsv_overlay: suppress code scan complain

IMHO, if link format is QSV, should pass from sw_format, else should pass from link->format direct. Initializing it to be AV_PIX_FMT_NONE is approximate to un-initialization for non QSV format case. > -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On

Re: [libav-devel] [PATCH] qsv: better to use alignment by 16 and HEVC 10b requires alignment by 32

LGTM > -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Tuesday, January 9, 2018 4:35 AM > To: libav-devel@libav.org > Subject: [libav-devel] [PATCH] qsv: better to use alignment by 16 and HEVC > 10b requires alignment

[libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

MSDK provides an API (MFXVideoDECODE_DecodeHeader) to parse video parameters. Currently it hasn't been used. Instead, software parsers are used. It works well for h264 decoder, and basically works well for hevc decoder (some issues found by Mayxm due to width/height are unaligned, I also

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Mark > Thompson > Sent: Monday, January 22, 2018 9:19 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] qsv: How about replace software parsers with > MFXVideoDECODE_DecodeHeader > > On 2

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

> wm4 wrote: > > > > Appreciated for any comment. If we are agree with that, patches will > be sent soon (about following next two weeks). > > > > I don't know how qsvdec works in particular (doesn't it pretty much > > parse all the codec stream in MFX?). If you check

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Ruiling Song > Sent: Friday, January 26, 2018 9:17 AM > To: libav-devel@libav.org > Subject: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue > > From: "Ruiling, Song" > > 1.)

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Tuesday, January 23, 2018 5:42 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] qsv: How about replace software parsers with > MFXVideoDECODE_DecodeHeader > > On 22/

Re: [libav-devel] [PATCH] hwcontext_qsv: Fix qsv hwupload failure issue

H] hwcontext_qsv: Fix qsv hwupload > >> failure issue > >> > >> On Fri, 26 Jan 2018 05:56:46 + > >> "Li, Zhong" <zhong...@intel.com> wrote: > >> > >>>> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf

Re: [libav-devel] [PATCH V2] lavc/qsvdec: expose frame pic_type and key_frame

> > @@ -416,6 +421,8 @@ FF_ENABLE_DEPRECATION_WARNINGS > > outsurf->Info.PicStruct & MFX_PICSTRUCT_FIELD_TFF; > > frame->interlaced_frame = > > !(outsurf->Info.PicStruct & > MFX_PICSTRUCT_PROGRESSIVE); > > +frame->pict_type = >

Re: [libav-devel] [PATCH V2] lavc/qsvdec: expose frame pic_type and key_frame

Sorry it is interrupted, I mean could you specify which hevc clip should be tested? As your comment, maybe we need to find a HEVC clip with CRA frames to test. From: Li, Zhong Sent: Wednesday, January 31, 2018 4:11 PM To: libav-devel@libav.org Subject: RE: [libav-devel] [PATCH V2] lavc/qsvdec

Re: [libav-devel] [PATCH V2] lavc/qsvdec: expose frame pic_type and key_frame

> On 31/01/18 08:16, Li, Zhong wrote: > > As your comment, maybe we need to find a HEVC clip with CRA frames to > test. > > Try the conformance sample RAP_A_docomo_4.bit (you can find it in > fate/hevc-conformance). That contains CRA and RASL frames (and no IDR > fra

Re: [libav-devel] [PATCH V2] lavc/qsvdec: expose frame pic_type and key_frame

> From: Li, Zhong > Sent: Tuesday, January 30, 2018 5:52 PM > To: libav-devel@libav.org > Cc: Li, Zhong <zhong...@intel.com>; Liu, ChaoX A <chaox.a@intel.com> > Subject: [PATCH V2] lavc/qsvdec: expose frame pic_type and key_frame AV_PICTURE_TYPE_NONE is not

Re: [libav-devel] [PATCH] avcodec/qsv: fix async support

> -Original Message- > From: Rogozhkin, Dmitry V > Sent: Wednesday, July 25, 2018 1:36 AM > To: libav-devel@libav.org > Cc: Rogozhkin, Dmitry V ; Maxym > Dmytrychenko ; Li, Zhong > Subject: [PATCH] avcodec/qsv: fix async support > > Current implementations of

Re: [libav-devel] [PATCH] qsv: enforcing continuous memory layout

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Saturday, July 28, 2018 5:55 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] qsv: enforcing continuous memory layout > > On 28/07/2018 10:53, maxim_d33 wrote: > > --- > >

Re: [libav-devel] [PATCH 1/3] lavf/qsv: return an error if getting session handle failed

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Thursday, August 16, 2018 7:18 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH 1/3] lavf/qsv: return an error if getting > session handle failed > > On 15/08/2018 11:39, Zhong Li

Re: [libav-devel] [PATCH 1/3] lavf/qsv: return an error if getting session handle failed

ed, Aug 22, 2018 at 1:21 PM Luca Barbato > wrote: > > > On 21/08/2018 09:15, Li, Zhong wrote: > > > Thank you. Luca. Will be applied? > > > > I was waiting for Maxym's feedback, but sure, it can. > > > > I'll push it this evening. > > > > lu

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Tuesday, January 23, 2018 5:45 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] qsv: How about replace software parsers with > MFXVideoDECODE_DecodeHeader > > On 23/

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

> Its best if decoders rely as little as possible on information passed to them > externally like this. If you have extradata, you should decode that to > determine the stream properties, and not rely on information set anywhere > else. > You should always keep in mind that a user application

Re: [libav-devel] qsv: How about replace software parsers with MFXVideoDECODE_DecodeHeader

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Tuesday, January 23, 2018 9:53 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] qsv: How about replace software parsers with > MFXVideoDECODE_DecodeHeader > > On 23/01/2018 12:15, Mark

Re: [libav-devel] [libav-commits] qsvenc: Provide a detailed error message if the parameters are invalid

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Mark > Thompson > Sent: Tuesday, March 6, 2018 8:17 AM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [libav-commits] qsvenc: Provide a detailed error > message if the parameters are invalid > """ > $

Re: [libav-devel] [PATCH 2/2] lavf/qsvvpp: bypass vpp if not needed.

to the right direction, can we see more details about " specific case." > ? The "specific case" means "if vpp not needed case". For example, add the option "vpp_qsv=w=1280:h=720" for an input with native resolution 1280x720. I am happy to update it if e

Re: [libav-devel] [PATCH] qsv: adding Multi Frame Encode support

> diff --git a/libavcodec/qsv_internal.h b/libavcodec/qsv_internal.h index > 975c8de44..516994a64 100644 > --- a/libavcodec/qsv_internal.h > +++ b/libavcodec/qsv_internal.h > @@ -36,6 +36,9 @@ > (MFX_VERSION_MAJOR > (MAJOR) || \ > MFX_VERSION_MAJOR == (MAJOR) &&

Re: [libav-devel] [PATCH V3 3/3] lavc/qsvdec: expose frame pic_type

ame pic_type > > aside of intend points at frame->surface..., should be ok > > On Thu, Mar 22, 2018 at 3:41 PM, Zhong Li <zhong...@intel.com> wrote: > > > Currently pict_type are unset. > > Add an extra param to fetch the picture type from qsv decoder > &

Re: [libav-devel] [PATCH] lavc/qsvdec: expose frame pic_type

Resend it since forgot to remove AV_PICTURE_TYPE_NONE in v3. Please let me know if still have any problem to accept this patch, and I'm glad to update it. > -Original Message- > From: Li, Zhong > Sent: Wednesday, March 28, 2018 4:50 PM > To: libav-devel@libav.org > Cc: L

Re: [libav-devel] [PATCH] qsv: adding Multi Frame Encode support

> > > a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index > > > f6b1a0d67..a8b446c5b > > > 100644 > > > --- a/libavcodec/qsvenc.c > > > +++ b/libavcodec/qsvenc.c > > > @@ -135,7 +135,7 @@ static void dump_video_param(AVCodecContext > > > *avctx, QSVEncContext *q, #if QSV_HAVE_CO2 > > >

Re: [libav-devel] [PATCH V2 2/3] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

> Please write BGRA rather than RGB32. I doubt this will ever run on a > big-endian machine, but it would be clearer. Agree, will update. > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c > > index 5018a05..0db446b 100644 > > --- a/libavutil/hwcontext_qsv.c > > +++

Re: [libav-devel] [PATCH V2 2/3] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Mark > Thompson > Sent: Monday, April 2, 2018 8:45 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH V2 2/3] lavu/hwcontext_qsv: Add support > for pix_fmt RGB32. > > On 02/04/1

Re: [libav-devel] [PATCH] lavf/qsvvpp: bypass vpp is not needed.

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Diego Biurrun > Sent: Thursday, March 29, 2018 12:56 AM > To: libav development > Subject: Re: [libav-devel] [PATCH] lavf/qsvvpp: bypass vpp is not needed. > > On Wed, Mar 28, 2018 at 05:40:07PM

Re: [libav-devel] [PATCH] lavc/qsvdec: expose frame pic_type

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Diego Biurrun > Sent: Thursday, March 29, 2018 12:55 AM > To: libav development > Subject: Re: [libav-devel] [PATCH] lavc/qsvdec: expose frame pic_type > > On Wed, Mar 28, 2018 at 04:50:10PM +0800,

Re: [libav-devel] [PATCH V2 1/3] lavc/qsvdec: set complete_frame flags for progressive picture

Ping? > -Original Message- > From: Li, Zhong > Sent: Thursday, March 22, 2018 10:42 PM > To: libav-devel@libav.org > Cc: Li, Zhong <zhong...@intel.com> > Subject: [PATCH V2 1/3] lavc/qsvdec: set complete_frame flags for > progressive picture > > Set the

Re: [libav-devel] [PATCH V2 2/3] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

Ping? > -Original Message- > From: Li, Zhong > Sent: Thursday, March 22, 2018 10:42 PM > To: libav-devel@libav.org > Cc: Li, Zhong <zhong...@intel.com>; Liu, ChaoX A <chaox.a@intel.com> > Subject: [PATCH V2 2/3] lavu/hwcontext_qsv: Add support for pix_

Re: [libav-devel] [PATCH v2] qsv: adding Multi Frame Encode support

LGTM > -Original Message- > From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Monday, April 2, 2018 9:17 PM > To: libav-devel@libav.org > Subject: [libav-devel] [PATCH v2] qsv: adding Multi Frame Encode support > > Starting from API 1.25

Re: [libav-devel] [PATCH 1/2] lavc/qsvdec: set complete_frame flags for non-interlaced frames.

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Monday, March 19, 2018 5:59 PM > To: libav development > Subject: Re: [libav-devel] [PATCH 1/2] lavc/qsvdec: set complete_frame flags > for non-interlaced frames. > >

Re: [libav-devel] [PATCH 2/2] lavu/hwcontext_qsv: Add support for pix_fmt RGB32.

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Monday, March 19, 2018 5:56 PM > To: libav development > Cc: Liu, ChaoX A > Subject: Re: [libav-devel] [PATCH 2/2] lavu/hwcontext_qsv: Add support

Re: [libav-devel] [PATCH] lavc/qsvenc: provide detail error message if parameters invalid

"Selected ratecontrol mode is not supported by > >> the QSV runtime. Choose a different mode", but sometimes it is not > >> accurate. > >> Signed-off-by: Zhong Li <zhong...@intel.com> > >> --- > >> libavcode

Re: [libav-devel] [libav-commits] qsvenc: Provide a detailed error message if the parameters are invalid

age if the parameters are invalid > > On 05/03/18 09:40, Zhong Li wrote: > > Module: libav > > Branch: master > > Commit: 2d6b3f3a9dce409ca51d70ef4b85c0593bb4b109 > > > > Author:Zhong Li <zhong...@intel.com> > > Committer: Luca Barbato <lu_z...@

Re: [libav-devel] [PATCH] lavu/qsv: fix a random hwupload failure regression

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Thursday, October 4, 2018 5:36 AM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] lavu/qsv: fix a random hwupload failure > regression > > On 03/10/2018 18:59, Rogozhkin, Dmitry V

Re: [libav-devel] [PATCH 1/2] lavc/qsvenc_jpeg: add async_depth support

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Thursday, October 11, 2018 5:34 PM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH 1/2] lavc/qsvenc_jpeg: add async_depth > support > > On 11/10/2018 11:26, Zhong Li wrote: > > Currently

Re: [libav-devel] [PATCH v7] qsvvpp: Fix to perform full init only when needed

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Monday, September 3, 2018 2:07 AM > To: libav-devel@libav.org > Subject: [libav-devel] [PATCH v7] qsvvpp: Fix to perform full init only when > needed > > From: Joe Olivas > > Removing unused VPP

Re: [libav-devel] [PATCH] qsvenc: AV_PIX_FMT_QSV path should release frame

> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Luca > Barbato > Sent: Wednesday, September 19, 2018 12:11 AM > To: libav-devel@libav.org > Subject: Re: [libav-devel] [PATCH] qsvenc: AV_PIX_FMT_QSV path should > release frame > > On 18/09/2018 09:54, Maxym Dmytrychenko