Re: [libav-devel] [PATCH 1/2] hevc: x86: Add add_residual optimizations

2016-10-21 Thread Diego Biurrun
On Fri, Oct 21, 2016 at 09:41:28AM +0200, Alexandra Hájková wrote: > --- /dev/null > +++ b/libavcodec/x86/hevc_add_res.asm > @@ -0,0 +1,371 @@ > +%macro ADD_RES_MMX_4_8 0 > +mova m0, [r1] > +mova m2, [r1+8] > +pxor m1, m1 > +pxor m

[libav-devel] [PATCH 1/2] hevc: x86: Add add_residual optimizations

2016-10-21 Thread Alexandra Hájková
From: Pierre Edouard Lepere Initially written by Pierre Edouard Lepere , extended by James Almer . Signed-off-by: Alexandra Hájková Signed-off-by: Diego Biurrun --- Applied review comments from Henrink and Diego (more consistent naming). libavcodec/x86/Makefile | 7 +- libavcodec/

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-17 Thread Luca Barbato
On 13/10/2016 20:04, Diego Biurrun wrote: > This does not match the conditions in the .asm file. Something along those lines seems to work on x86_32 according to checkasm. Folded in my github tree. diff --git a/libavcodec/x86/hevcdsp_init.c b/libavcodec/x86/hevcdsp_init.c index 73279c2..d60ae5e 1

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-17 Thread Diego Biurrun
On Mon, Oct 17, 2016 at 09:18:19PM +0200, Luca Barbato wrote: > On 10/16/16 14:00, Luca Barbato wrote: > >On 10/13/16 16:02, Alexandra Hájková wrote: > >>From: Pierre Edouard Lepere > > If nobody has a say I'd push it with the mentioned changes. This is much too fuzzy IMO. If you have updated pa

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-17 Thread Luca Barbato
On 10/16/16 14:00, Luca Barbato wrote: On 10/13/16 16:02, Alexandra Hájková wrote: From: Pierre Edouard Lepere If nobody has a say I'd push it with the mentioned changes. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-16 Thread Luca Barbato
On 10/13/16 16:02, Alexandra Hájková wrote: From: Pierre Edouard Lepere Initially written by Pierre Edouard Lepere , extended by James Almer . Signed-off-by: Alexandra Hájková --- libavcodec/x86/Makefile | 3 +- libavcodec/x86/hevc_res_add.asm | 391 +++

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-13 Thread Diego Biurrun
On Thu, Oct 13, 2016 at 04:02:34PM +0200, Alexandra Hájková wrote: > From: Pierre Edouard Lepere > > Initially written by Pierre Edouard Lepere > , > extended by James Almer . > > Signed-off-by: Alexandra Hájková > --- > libavcodec/x86/Makefile | 3 +- > libavcodec/x86/hevc_res_add.

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-13 Thread Diego Biurrun
On Thu, Oct 13, 2016 at 04:02:34PM +0200, Alexandra Hájková wrote: > --- a/libavcodec/x86/hevcdsp_init.c > +++ b/libavcodec/x86/hevcdsp_init.c > @@ -278,17 +297,24 @@ void ff_hevc_dsp_init_x86(HEVCDSPContext *c, const int > bit_depth) > +c->add_residual[1] = ff_hevc_add_residual_8_8_ss

[libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-13 Thread Alexandra Hájková
From: Pierre Edouard Lepere Initially written by Pierre Edouard Lepere , extended by James Almer . Signed-off-by: Alexandra Hájková --- libavcodec/x86/Makefile | 3 +- libavcodec/x86/hevc_res_add.asm | 391 libavcodec/x86/hevcdsp_init.c |

Re: [libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-12 Thread Diego Biurrun
On Wed, Oct 12, 2016 at 06:24:39PM +0200, Alexandra Hájková wrote: > --- /dev/null > +++ b/libavcodec/x86/hevc_res_add.asm > @@ -0,0 +1,391 @@ > +; /* Drop the /, this is not C. > +; * Provide SIMD optimizations for add_residual functions for HEVC decoding s/Provide// > +; * Copyright (c) 2014

[libav-devel] [PATCH 1/2] hevc/x86: Add add_residual

2016-10-12 Thread Alexandra Hájková
From: Pierre Edouard Lepere Initially written by Pierre Edouard Lepere , extended by James Almer . Signed-off-by: Alexandra Hájková --- libavcodec/x86/Makefile | 3 +- libavcodec/x86/hevc_res_add.asm | 391 libavcodec/x86/hevcdsp_init.c |