On 19/09/16 17:32, Luca Barbato wrote:
> On 19/09/16 12:59, Diego Biurrun wrote:
>> On Mon, Sep 19, 2016 at 12:53:33PM +0200, Alexandra Hájková wrote:
> %if HAVE_AVX2_EXTERNAL
> INIT_YMM avx2
> IDCT_DC16, 2, 8
> @@ -100,6 +804,12 @@ IDCT_DC_NL 8, 10
> IDCT_DC1
Not a super-thorough review by any means, but anyway...
On Sun, Sep 18, 2016 at 7:35 PM, Alexandra Hájková
wrote:
[...]
> +SECTION_RODATA
Check if any of the constants are duplicates of already existing ones.
[...]
> +%macro TR_4x4 2
> +; interleaves src0 with src2 to m0
> +;
On 19/09/16 12:59, Diego Biurrun wrote:
> On Mon, Sep 19, 2016 at 12:53:33PM +0200, Alexandra Hájková wrote:
%if HAVE_AVX2_EXTERNAL
INIT_YMM avx2
IDCT_DC16, 2, 8
@@ -100,6 +804,12 @@ IDCT_DC_NL 8, 10
IDCT_DC16, 4, 10
IDCT_DC32, 16, 10
On Mon, Sep 19, 2016 at 12:53:33PM +0200, Alexandra Hájková wrote:
> >> %if HAVE_AVX2_EXTERNAL
> >> INIT_YMM avx2
> >> IDCT_DC16, 2, 8
> >> @@ -100,6 +804,12 @@ IDCT_DC_NL 8, 10
> >> IDCT_DC16, 4, 10
> >> IDCT_DC32, 16, 10
> >>
> >> +INIT_XMM avx
> >> +IDCT_4x4 10
> >> +IDC
>> %if HAVE_AVX2_EXTERNAL
>> INIT_YMM avx2
>> IDCT_DC16, 2, 8
>> @@ -100,6 +804,12 @@ IDCT_DC_NL 8, 10
>> IDCT_DC16, 4, 10
>> IDCT_DC32, 16, 10
>>
>> +INIT_XMM avx
>> +IDCT_4x4 10
>> +IDCT_8x8 10
>> +IDCT_16x16 10
>> +IDCT_32x32 10
>
> It seems rather silly to duplicate all
Quoting Alexandra Hájková (2016-09-18 19:35:25)
> ---
> libavcodec/x86/hevc_idct.asm | 710
> ++
> libavcodec/x86/hevcdsp_init.c | 21 ++
> 2 files changed, 731 insertions(+)
>
> diff --git a/libavcodec/x86/hevc_idct.asm b/libavcodec/x86/hevc_idct.asm
>
---
libavcodec/x86/hevc_idct.asm | 710 ++
libavcodec/x86/hevcdsp_init.c | 21 ++
2 files changed, 731 insertions(+)
diff --git a/libavcodec/x86/hevc_idct.asm b/libavcodec/x86/hevc_idct.asm
index d662aa9..848812b 100644
--- a/libavcodec/x86/hevc_idct.asm
