Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB

2018-07-12 Thread Thomas Schmitt
Hi, Rocky Bernstein wrote: > create a branch and commit to that and let me know the name of the branch. The branch name is ts-private-problem As the code is now, a run of "make" fails for me with iso9660_private.h:84:42: error: unknown type name 'iso_rock_statbuf_t' bool iso9660_rock_st

Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB

2018-07-12 Thread Thomas Schmitt
Hi, Rocky Bernstein: > Try pulling ts-private-problem now and I think the problems you were > encountering are now fixed. Yes. Putting #ifndef CDIO_ISO9660_H_ around #include seems to have done the trick. But i do not understand why this works better than the already existing #ifndef CDIO_ISO96

Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB

2018-07-12 Thread Thomas Schmitt
Hi, the decisive trigger for the include problem with iso9660_private.h is that is included after . This gesture in iso9660_private.h reproduces the problem: #include #ifdef HAVE_STDBOOL_H # include #endif and this does not: #include and this does not either: #ifdef HAVE_S

Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB

2018-07-12 Thread Rocky Bernstein
On Thu, Jul 12, 2018 at 12:25 PM, Thomas Schmitt wrote: > Hi, > > the decisive trigger for the include problem with iso9660_private.h > is that is included after . > > This gesture in iso9660_private.h reproduces the problem: > > #include > > #ifdef HAVE_STDBOOL_H > # include > #endif

Re: [Libcdio-devel] [RFC] New API iso9660_statv2_t as API/ABI compatible way to read files >= 4 GiB

2018-07-12 Thread Thomas Schmitt
Hi, Rocky Bernstein wrote: > The definition of bool in types.h comes from an era decades ago when > stdbool.h wasn't so std or rather didn't exist. I found it on my system only as /usr/include/c++/4.9/tr1/stdbool.h which only does #include which exists as /usr/include/c++/4.9/tr1/cstdbool

[Libcdio-devel] RFC: libcdio to remove it's version of bool and require ?

2018-07-12 Thread Rocky Bernstein
stdbool.h is POSIX. See http://pubs.opengroup.org/onlinepubs/9699919799/ Thoughts?