Re: [Libcdio-devel] Proposal for fix of cd-info on MSWindows driver

2020-05-22 Thread Pete Batard
Hi Thomas, On 2020.05.22 16:21, Thomas Schmitt wrote: Pete Batard wrote: That's called squashing. You should be able to find plenty of help on how to do that using git rebase, such as https://gist.github.com/jbub/5766366 Ok. I'm now squashed at git push. Question is whether i should push

Re: [Libcdio-devel] Proposal for fix of cd-info on MSWindows driver

2020-05-22 Thread Thomas Schmitt
Hi, Pete Batard wrote: > That's called squashing. You should be able to find plenty of help on how to > do that using git rebase, such as https://gist.github.com/jbub/5766366 Ok. I'm now squashed at git push. Question is whether i should push with --force or --force-with-lease.

Re: [Libcdio-devel] Proposal for fix of cd-info on MSWindows driver

2020-05-22 Thread Pete Batard
On 2020.05.22 17:24, Rocky Bernstein wrote: Sure - push directly to master. Thanks. Done. Thanks. /Pete

Re: [Libcdio-devel] Proposal for fix of cd-info on MSWindows driver

2020-05-22 Thread Thomas Schmitt
Hi, Pete Batard wrote: > it doesn't look like the repo is configured to allow force Indeed. Now that my branch is useless, i tried git push --force-with-lease and got remote: error: denying non-fast-forward refs/heads/win32_first_tno_fix (you should pull first) So i finally ran another

[Libcdio-devel] Hindsight is 2020 - Let's sort multiextents at last

2020-05-22 Thread Pete Batard
Hi, Now that we are at a stage where that can happen, please be aware that I have created new branch 'pragmatic-multiextent-2020', in the hope that it can be merged into master. If you recall the discussions from a couple years ago, there was debate about what approach we wanted to go with,

Re: [Libcdio-devel] Hindsight is 2020 - Let's sort multiextents at last

2020-05-22 Thread Thomas Schmitt
Hi, Pete Batard wrote: > 'pragmatic-multiextent-2020' branch that I am kindly asking to review I had to dig out my final statements from summer 2018. Yes. I'm fully in support of old pragmatic-multiextent and thus of its tested adoption in pragmatic-multiextent-2020. >From all proposals for

Re: [Libcdio-devel] Proposal for fix of cd-info on MSWindows driver

2020-05-22 Thread Pete Batard
On 2020.05.22 18:52, Thomas Schmitt wrote: remote: error: denying non-fast-forward refs/heads/win32_first_tno_fix (you should pull first) Yeah, that error is typical of git repos where you can't use force to push changes. On one hand, not allowing force ensures that people who cloned

Re: [Libcdio-devel] Hindsight is 2020 - Let's sort multiextents at last

2020-05-22 Thread Thomas Schmitt
Hi, Pete Batard wrote: > And yeah, what's missing from the proposal would be an actual test with a > multiextent image, I meanwhile read up to the test plan of my overly complicated branch ts-multiextent which i sent as part of its announcement. Date: Fri, 06 Jul 2018 20:09:19 +0200

Re: [Libcdio-devel] Hindsight is 2020 - Let's sort multiextents at last

2020-05-22 Thread Pete Batard
On 2020.05.22 19:26, Thomas Schmitt wrote: Now i should look for the tests which i did with pragmatic-multiextent (in part while it was much like pbatard-multiextent2). Hopefully i can give some report until sunday evening. Sounds good, thanks for doing that. Considering that we've waited a