Re: [Libcg-devel] question: cgred can't control thread after restart?

2014-11-07 Thread Weng Meiling
ping On 2014/10/14 10:20, Weng Meiling wrote: > hi Ivana, Dhaval > > What do you think about this problem? > > On 2014/10/8 8:50, Weng Meiling wrote: >> >> On 2014/10/2 2:51, Balbir Singh wrote: >>> Do you have any debug logs with traces of what cgred

[Libcg-devel] question about cgexec stall

2014-10-28 Thread Weng Meiling
Hi guys?? We meet a situation: When we use cgexec command to move task, the command stall. It seems the connect() stall in cgroup_register_unchanged_process(): int cgroup_register_unchanged_process(pid_t pid, int flags) { ... if (connect(sk, (struct sockaddr *)&addr, sizeof(addr.su

Re: [Libcg-devel] question: cgred can't control thread after restart?

2014-10-13 Thread Weng Meiling
hi Ivana, Dhaval What do you think about this problem? On 2014/10/8 8:50, Weng Meiling wrote: > > On 2014/10/2 2:51, Balbir Singh wrote: >> Do you have any debug logs with traces of what cgred is doing? My best >> guess is cgred will need to be enhanced, feel free to send a

Re: [Libcg-devel] question: cgred can't control thread after restart?

2014-09-29 Thread Weng Meiling
cs() to get the task group id contained in cgroups.procs, but this is not enough fot the situation mentioned in former mail, am I missing something? We used cgred in debug mode, and found the running threads which match the rules could not be controlled by cgred. Thanks! Weng Meiling > On Mon

Re: [Libcg-devel] question: cgred can't control thread after restart?

2014-09-28 Thread Weng Meiling
Hi, what do you think about this situation? Thanks! Weng Meiling On 2014/9/24 9:02, Weng Meiling wrote: > ping... > > On 2014/9/22 17:32, Weng Meiling wrote: >> On 2014/9/20 17:13, Weng Meiling wrote: >>> Hi guys, >>> In our environment, we found the following p

Re: [Libcg-devel] question: cgred can't control thread after restart?

2014-09-23 Thread Weng Meiling
ping... On 2014/9/22 17:32, Weng Meiling wrote: > On 2014/9/20 17:13, Weng Meiling wrote: >> Hi guys, >> In our environment, we found the following problem: >> >> we have a process and it has some threads with the same name: >> >> # ps -L -eo comm

Re: [Libcg-devel] question: cgred can't control thread after restart?

2014-09-22 Thread Weng Meiling
On 2014/9/20 17:13, Weng Meiling wrote: > Hi guys, > In our environment, we found the following problem: > > we have a process and it has some threads with the same name: > > # ps -L -eo comm,pid,lwp,args,start |grep Test > Testd 4489 4489 /usr/bin/Testd

[Libcg-devel] question: cgred can't control thread after restart?

2014-09-20 Thread Weng Meiling
Hi guys, In our environment, we found the following problem: we have a process and it has some threads with the same name: # ps -L -eo comm,pid,lwp,args,start |grep Test Testd 4489 4489 /usr/bin/Testd 09:03:39 Testd 4489 4582 /usr/bin/Testd 09:03:39 Test

Re: [Libcg-devel] [PATCH] cgdelete:fix the display problem

2014-07-28 Thread Weng Meiling
Reviewed-by: Weng Meiling On 2014/7/3 16:55, Ivana Hutarova Varekova wrote: > When multi subsystems mounted on one place like this: > > $ lssubsys -m > cpu,cpuacct /cgroup/cpu > > $ lscgroup > cpu,cpuacct:/ > cpu,cpuacct:/test > > if we delete the cgroup with t

Re: [Libcg-devel] [PATCH] cgdelete:fix the display problem

2014-07-09 Thread Weng Meiling
On 2014/7/9 19:14, Ivana Varekova wrote: > > > - Original Message - >> From: "Weng Meiling" >> To: "Ivana Hutarova Varekova" , >> libcg-devel@lists.sourceforge.net >> Sent: Thursday, 3 July, 2014 1:49:44 PM >> Subject: Re: [P

Re: [Libcg-devel] [PATCH] cgdelete:fix the display problem

2014-07-03 Thread Weng Meiling
> v4 -> v5 (Ivana Hutarova Varekova) > - make cgdelete -g cpuacct:test -g cpu:test -g cpu:test failed > - join extended cgroup list variables to one record, do the list dynamic > (static version can exceed the given limit and the safe static limit is

Re: [Libcg-devel] [PATCH] cgclear: clear the mount info

2014-07-03 Thread Weng Meiling
ns type fusectl (rw) securityfs on /sys/kernel/security type securityfs (rw) cgroup on /cgroup type cgroup (rw) > - Original Message - >> From: "Weng Meiling" >> To: libcg-devel@lists.sourceforge.net >> Cc: "libo chen" >> Sent: Friday, August 2, 201

Re: [Libcg-devel] [PATCH v4] cgdelete:fix the display problem

2014-06-27 Thread Weng Meiling
On 2014/6/27 19:19, Ivana Varekova wrote: > > > - Original Message - >> From: "Weng Meiling" >> To: "Ivana Varekova" >> Cc: "libo chen" , "Huang Qiang" >> , "Libcg Development list" >> , "

Re: [Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-06-27 Thread Weng Meiling
ping... On 2014/5/19 10:16, Weng Meiling wrote: > Hi Jan, Ivana, Vivek, Balbir, > > What do you think about the problem? > > On 2014/5/2 3:26, Dhaval Giani wrote: >> On Mon, Apr 28, 2014 at 10:05 PM, Weng Meiling >> wrote: >>> On 2014/4/29 3:05, Dhaval Gi

[Libcg-devel] [PATCH v4] cgdelete:fix the display problem

2014-06-27 Thread Weng Meiling
test -g cpu:test -g cpuacct:test failed. - add some comments - fix the uninitialized warning Signed-off-by: Weng Meiling --- src/tools/cgdelete.c | 87 ++-- 1 file changed, 78 insertions(+), 9 deletions(-) diff --git a/src/tools/cgdelete.c b/src/too

Re: [Libcg-devel] [PATCH v3] cgdelete:fix the display problem

2014-06-27 Thread Weng Meiling
Thanks for review, I'll send the v4 patch. Thanks! Weng Meiling On 2014/6/27 12:10, Ivana Varekova wrote: > > > - Original Message ----- >> From: "Weng Meiling" >> To: "Ivana Varekova" >> Cc: "Libcg Development list" , &qu

Re: [Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-05-28 Thread Weng Meiling
ping... On 2014/5/19 10:16, Weng Meiling wrote: > Hi Jan, Ivana, Vivek, Balbir, > > What do you think about the problem? > > On 2014/5/2 3:26, Dhaval Giani wrote: >> On Mon, Apr 28, 2014 at 10:05 PM, Weng Meiling >> wrote: >>> On 2014/4/29 3:05, Dhaval Gi

Re: [Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-05-18 Thread Weng Meiling
Hi Jan, Ivana, Vivek, Balbir, What do you think about the problem? On 2014/5/2 3:26, Dhaval Giani wrote: > On Mon, Apr 28, 2014 at 10:05 PM, Weng Meiling > wrote: >> On 2014/4/29 3:05, Dhaval Giani wrote: >>> Hi Weng, >>> >>> I apologize for our tardiness

Re: [Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-05-04 Thread Weng Meiling
On 2014/5/2 3:26, Dhaval Giani wrote: > > So this idea sounds really racy to me. The only sure way it can be > ensured is *if* the child runs before the parent exits. I know there > is a kernel tunable for that, but I am not sure if it is a good idea. > But just for fun, could you try > (as root

Re: [Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-04-28 Thread Weng Meiling
On 2014/4/29 3:05, Dhaval Giani wrote: > Hi Weng, > > I apologize for our tardiness is responding back! > > On Sun, Apr 27, 2014 at 9:09 PM, Weng Meiling > wrote: >> Hi Ivana, >> What do you think about this problem? >> >> Weng Meiling >> Than

Re: [Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-04-27 Thread Weng Meiling
Hi Ivana, What do you think about this problem? Weng Meiling Thanks! On 2014/4/22 11:06, Weng Meiling wrote: > ping... > On 2014/4/10 16:09, Weng Meiling wrote: >> Cgred just migrate forked process when the parent's cgroup is changed, >> so that the forked process can

Re: [Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-04-21 Thread Weng Meiling
ping... On 2014/4/10 16:09, Weng Meiling wrote: > Cgred just migrate forked process when the parent's cgroup is changed, > so that the forked process can stay in the same cgroup which match the > cgred rules with it's parent. But there is a situation when parent process > for

[Libcg-devel] [RFC]cgred: fix cgred migrate forked process

2014-04-10 Thread Weng Meiling
other way(just remove the cgre_was_parent_changed_when_forking() for forked processes) will affect cgclassify --sticky. But this way is not which I have done some test. Signed-off-by: Weng Meiling --- src/daemon/cgrulesengd.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/daemon/cgru

Re: [Libcg-devel] [PATCH v3] cgconfigparser:fix the memory swap limit set

2013-11-07 Thread Weng Meiling
On 2013/11/8 11:27, Dhaval Giani wrote: > On Thu, Nov 7, 2013 at 9:01 PM, Weng Meiling > wrote: >> On 2013/11/8 5:55, Dhaval Giani wrote: >> Hi Dhaval, >>> Hi Weng, >>> >>> On Thu, Oct 24, 2013 at 10:58 PM, Dhaval Giani >>> wrote: >>&

Re: [Libcg-devel] [PATCH v3] cgconfigparser:fix the memory swap limit set

2013-11-07 Thread Weng Meiling
On 2013/11/8 5:55, Dhaval Giani wrote: Hi Dhaval, > Hi Weng, > > On Thu, Oct 24, 2013 at 10:58 PM, Dhaval Giani wrote: >> On Thu, Oct 24, 2013 at 10:52 PM, Weng Meiling >> wrote: >>> On 2013/10/24 21:04, Dhaval Giani wrote: >>>> On Thu, Oct 24,

[Libcg-devel] [PATCH v3] cgdelete:fix the display problem

2013-11-06 Thread Weng Meiling
From: Weng Meiling When multi subsystems mounted on one place like this: $ lssubsys -m cpu,cpuacct /cgroup/cpu $ lscgroup cpu,cpuacct:/ cpu,cpuacct:/test if we delete the cgroup with the cgdelete -g, and specifying multi controllers like this: $ cgdelete -g cpu,cpuacct:test or $ cgdelete

Re: [Libcg-devel] [PATCH v3] cgconfigparser:fix the memory swap limit set

2013-10-24 Thread Weng Meiling
On 2013/10/24 21:04, Dhaval Giani wrote: > On Thu, Oct 24, 2013 at 3:50 AM, Weng Meiling > wrote: >> On 2013/10/24 1:04, Dhaval Giani wrote: >>> Hi Weng, >>> >>> Would something similar to the attached patch help you? This of course >>> is complete

Re: [Libcg-devel] [PATCH v3] cgconfigparser:fix the memory swap limit set

2013-10-24 Thread Weng Meiling
goto loop +} after add check "i < cgroup->index" before goto loop, the cg_sort_mem_values() still doesn't resort the memory.memsw.limit_in_bytes and memort.limit_in_bytes. The cgconfigparser still failed for same reason: cgconfi

Re: [Libcg-devel] [PATCH v3] cgconfigparser:fix the memory swap limit set

2013-10-22 Thread Weng Meiling
On 2013/10/23 10:58, Dhaval Giani wrote: > Hi, > > Sorry for the delay in getting back. > > On Wed, Oct 16, 2013 at 5:35 AM, Weng Meiling > wrote: >> >> From: Weng Meiling >> >> After setting memory.limit_in_bytes and memory.memsw.limit_in_bytes, >&

Re: [Libcg-devel] [PATCH v2] cgconfigparser:fix the memory swap limit set

2013-10-16 Thread Weng Meiling
d send the third version patch, can that satisfy what you mentioned in 1? Thanks! Weng Meiling -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore ti

[Libcg-devel] [PATCH v3] cgconfigparser:fix the memory swap limit set

2013-10-16 Thread Weng Meiling
From: Weng Meiling After setting memory.limit_in_bytes and memory.memsw.limit_in_bytes, use cgsnapshot -f to save the current cgroup configure, then use cgconfigparser to resume it according the configure file, but it failed. The steps: $ cgsnapshot -s memory -f config $ cat config mount

[Libcg-devel] [PATCH v2] cgconfigparser:fix the memory swap limit set

2013-10-15 Thread Weng Meiling
From: Weng Meiling After setting memory.limit_in_bytes and memory.memsw.limit_in_bytes, use cgsnapshot -f to save the current cgroup configure, then use cgconfigparser to resume it according the configure file, but it failed. The steps: $ cgsnapshot -s memory -f config $ cat config mount

Re: [Libcg-devel] [patch] cgconfigparser:fix the memory swap limit set

2013-10-15 Thread Weng Meiling
On 2013/10/15 15:30, Libo Chen wrote: > On 2013/10/12 16:35, Weng Meiling wrote: >> >> From: Weng Meiling >> >> After setting memory.limit_in_bytes and memory.memsw.limit_in_bytes, >> use cgsnapshot -f to save the current cgroup configure, then use >> cg

[Libcg-devel] [PATCH] cgdelete:display help info when cgroup not mounted

2013-10-14 Thread Weng Meiling
From: Weng Meiling All commands except cgdelete can display help info when cgroup is not mounted. cgdelete command display like this: $ lssubsys -m $ $cgdelete -h /usr/bin/cgdelete: libcgroup initialization failed: Cgroup is not mounted This patch makes cgdelete command can display help info

Re: [Libcg-devel] [patch] cgconfigparser:fix the memory swap limit set

2013-10-12 Thread Weng Meiling
On 2013/10/12 16:35, Weng Meiling wrote: > > From: Weng Meiling > > After setting memory.limit_in_bytes and memory.memsw.limit_in_bytes, > use cgsnapshot -f to save the current cgroup configure, then use > cgconfigparser to resume it according the configure file, but it fail

[Libcg-devel] [patch] cgconfigparser:fix the memory swap limit set

2013-10-12 Thread Weng Meiling
From: Weng Meiling After setting memory.limit_in_bytes and memory.memsw.limit_in_bytes, use cgsnapshot -f to save the current cgroup configure, then use cgconfigparser to resume it according the configure file, but it failed. The steps: $ cgsnapshot -s memory -f config $ cat config mount

Re: [Libcg-devel] [PATCH v2] cgdelete:fix the display problem

2013-10-11 Thread Weng Meiling
Hi Ivana, what do you think about the second version patch about cgdelete problem? On 2013/10/8 14:31, Weng Meiling wrote: > > From: Weng Meiling > > When multi subsystems mounted on one place like this: > > $ lssubsys -m > cpu,cpuacct /cgroup/cpu > > $ lsc

[Libcg-devel] [PATCH v2] cgdelete:fix the display problem

2013-10-07 Thread Weng Meiling
From: Weng Meiling When multi subsystems mounted on one place like this: $ lssubsys -m cpu,cpuacct /cgroup/cpu $ lscgroup cpu,cpuacct:/ cpu,cpuacct:/test if we delete the cgroup with the cgdelete -g, and specifying multi controllers like this: $ cgdelete -g cpu,cpuacct:test or $ cgdelete

Re: [Libcg-devel] [PATCH] cgdelete:fix the display problem

2013-09-27 Thread Weng Meiling
On 2013/9/27 14:32, Ivana Varekova wrote: > > > - Original Message - >> From: "Weng Meiling" >> To: "Ivana Varekova" >> Cc: "Huang Qiang" huangqi...@huawei.com>, "libo chen" >> , "Libcg Development li

Re: [Libcg-devel] [RFC] cgred: parse the character '#' in cgrules.conf correctlly

2013-09-26 Thread Weng Meiling
On 2013/9/27 11:57, Dhaval Giani wrote: > > Clearly this rule is invalid. So yes, I would expect cgrules to fail. > (What to do with all processes for all users). I think the behavior is > just fine. > > Dhaval > > yeah, but what do you think the different behav

Re: [Libcg-devel] [RFC] cgred: parse the character '#' in cgrules.conf correctlly

2013-09-26 Thread Weng Meiling
On 2013/9/27 11:50, Steve Olivieri wrote: > > >> On 2013/9/27 10:13, Dhaval Giani wrote: >>> On Thu, Sep 26, 2013 at 9:43 PM, Weng Meiling >>> wrote: >>>> On 2013/9/27 9:20, Dhaval Giani wrote: >>>>> On Thu, Sep 26, 20

Re: [Libcg-devel] [PATCH] cgconfig:cgconfig service should start when the cgconfig.conf is empty

2013-09-26 Thread Weng Meiling
On 2013/9/27 9:17, Dhaval Giani wrote: > Hi weng, > > On Thu, Sep 26, 2013 at 9:09 PM, Weng Meiling > wrote: >> Hi Dhaval, >> >> what do you think about this patch ? >> > > Sorry about this. It totally slipped my filters. > It doesn't

Re: [Libcg-devel] [RFC] cgred: parse the character '#' in cgrules.conf correctlly

2013-09-26 Thread Weng Meiling
On 2013/9/27 10:13, Dhaval Giani wrote: > On Thu, Sep 26, 2013 at 9:43 PM, Weng Meiling > wrote: >> On 2013/9/27 9:20, Dhaval Giani wrote: >>> On Thu, Sep 26, 2013 at 9:05 PM, Weng Meiling >>> wrote: >>>> Hi Ivana, >>>> >>>&g

Re: [Libcg-devel] [RFC] cgred: parse the character '#' in cgrules.conf correctlly

2013-09-26 Thread Weng Meiling
On 2013/9/27 9:20, Dhaval Giani wrote: > On Thu, Sep 26, 2013 at 9:05 PM, Weng Meiling > wrote: >> Hi Ivana, >> >>what do you think about this question ? >> >> Thanks! >> Weng Meiling >> >> On 2013/9/3 9:25, Weng Meiling wrote: >

Re: [Libcg-devel] [PATCH] cgconfig:cgconfig service should start when the cgconfig.conf is empty

2013-09-26 Thread Weng Meiling
Hi Dhaval, what do you think about this patch ? Thanks! Weng Meiling On 2013/9/10 16:12, Ivana Varekova wrote: > Hello, > I'm not sure about this change. >>From my point of view cgconfig should work, when the file is empty (it is >>equivalent to file which

Re: [Libcg-devel] [RFC] cgred: parse the character '#' in cgrules.conf correctlly

2013-09-26 Thread Weng Meiling
Hi Ivana, what do you think about this question ? Thanks! Weng Meiling On 2013/9/3 9:25, Weng Meiling wrote: > Hi Ivana, > > what do you think about this question ? > > Thanks! > Weng Meiling > > On 2013/8/9 9:54, Weng Meiling wrote: >> >>

[Libcg-devel] Fwd: [PATCH] cgdelete:fix the display problem

2013-09-26 Thread Weng Meiling
Hi Ivana, what do you think about this patch ? Thanks! Weng Meiling Original Message Subject: [PATCH] cgdelete:fix the display problem Date: Sat, 14 Sep 2013 15:15:04 +0800 From: Weng Meiling CC: Ivana Varekova , Huang Qiang , Libcg Development list , libo chen

[Libcg-devel] [PATCH] cgcreate: fix the wrong uid/gid set.

2013-09-14 Thread Weng Meiling
From: Weng Meiling When setting the cgconfig.conf as follow: mount { memory = /cgroup/memory; } group . { perm { task { gid = w00227741; uid = w00227741; fperm =755

[Libcg-devel] [PATCH] cgdelete:fix the display problem

2013-09-14 Thread Weng Meiling
From: Weng Meiling When multi subsystems mounted on one place like this: # lssubsys -m cpu,cpuacct /cgroup/cpu # lscgroup cpu,cpuacct:/ cpu,cpuacct:/test if we delete the cgroup with the cgdelete -g, and specifying multi controllers like this: # cgdelete -g cpu,cpuacct:test or # cgdelete

Re: [Libcg-devel] question about cgdelete

2013-09-10 Thread Weng Meiling
On 2013/9/10 15:23, Weng Meiling wrote: > On 2013/9/10 15:00, Ivana Varekova wrote: >> Hello, >> it is a bug. Error message should not be returned. Do you want to create a >> patch for this problem? If not I will write it to my TODO list, but it is >> really full now.

Re: [Libcg-devel] question about cgdelete

2013-09-10 Thread Weng Meiling
o it and send the patch later. Thanks! Weng Meiling > - Original Message ----- >> From: "Weng Meiling" >> To: "Libcg Development list" >> Sent: Friday, August 30, 2013 10:02:36 AM >> Subject: [Libcg-devel] question about cgdelete >> >>

Re: [Libcg-devel] [PATCH] cgclear: clear the mount info

2013-09-04 Thread Weng Meiling
On 2013/9/4 20:25, Dhaval Giani wrote: > On Tue, Sep 3, 2013 at 9:43 PM, Weng Meiling > wrote: >> On 2013/9/3 20:05, Dhaval Giani wrote: >>> On Fri, Aug 2, 2013 at 4:24 AM, Weng Meiling >>> wrote: >>>> >>>> From: Weng Meiling >>>

Re: [Libcg-devel] [PATCH] cgclear: clear the mount info

2013-09-03 Thread Weng Meiling
On 2013/9/3 20:05, Dhaval Giani wrote: > On Fri, Aug 2, 2013 at 4:24 AM, Weng Meiling > wrote: >> >> From: Weng Meiling >> >> When we use cgclear to unload the cgroup filesystem, we still can >> see the umounted cgroup by using mount command. So fix the p

Re: [Libcg-devel] [PATCH] cgred:cgred should start when cgroup is mounted.

2013-09-02 Thread Weng Meiling
On 2013/9/3 9:23, Weng Meiling wrote: > Hi Ivana, > > what do you think about this patch ? > > Thanks! > Weng Meiling > > sorry, please review the second version: http://sourceforge.net/mailarchive/forum.php?thread_name=52022AB3.20509%40huawei.com&forum_nam

Re: [Libcg-devel] [PATCH] cgclear: clear the mount info

2013-09-02 Thread Weng Meiling
Hi Ivana, what do you think about this question ? Weng Meiling Thanks! On 2013/8/2 16:24, Weng Meiling wrote: > > From: Weng Meiling > > When we use cgclear to unload the cgroup filesystem, we still can > see the umounted cgroup by using mount command. So fix the pr

[Libcg-devel] cgclear: deal with error message when specifying config

2013-09-02 Thread Weng Meiling
From: Weng Meiling Unloading the cgroup filesystem with cgclear -l config, if there is an umount subsystem in the mount section. The error message is "cgclear failed with Success". This is broken. So fix it, replace the error message with "cgclear failed with Cgroup invalid op

Re: [Libcg-devel] question about cgdelete

2013-09-02 Thread Weng Meiling
Hi Ivana, what do you think about this question ? Thanks! Weng Meiling On 2013/8/30 16:02, Weng Meiling wrote: > Hi, > > When multi subsystems mounted on one place like this: > > # lssubsys -m > cpu,cpuacct /cgroup/cpu > > # lscgroup > cpu,cpuacct:/ >

Re: [Libcg-devel] [PATCH] cgconfig:cgconfig service should start when the cgconfig.conf is empty

2013-09-02 Thread Weng Meiling
Hi Ivana, what do you think about this patch ? Thanks! Weng Meiling On 2013/8/30 14:50, Weng Meiling wrote: > From: Weng Meiling > > cgconfig service could start successfully when /etc/cgconfig.conf > only contains comments. But failed when /etc/cgconfig.conf is empty

Re: [Libcg-devel] [PATCH] cgset: giving the apposite error messages

2013-09-02 Thread Weng Meiling
Hi Ivana, what do you think about this question ? Thanks! Weng Meiling On 2013/8/14 14:37, Weng Meiling wrote: > On 2013/8/14 11:32, Dhaval Giani wrote: >> On Tue, Aug 13, 2013 at 10:07 PM, Weng Meiling >> wrote: >>> On 2013/8/14 4:38, Dhaval Giani wrote: >&g

Re: [Libcg-devel] [RFC] cgred: parse the character '#' in cgrules.conf correctlly

2013-09-02 Thread Weng Meiling
Hi Ivana, what do you think about this question ? Thanks! Weng Meiling On 2013/8/9 9:54, Weng Meiling wrote: > > From: Weng Meiling > > Any line starting with '#' in cgconfig.conf is considered a comment > and is ignored. But in cgrules.conf, no matter whe

Re: [Libcg-devel] [PATCH] cgred:cgred should start when cgroup is mounted.

2013-09-02 Thread Weng Meiling
Hi Ivana, what do you think about this patch ? Thanks! Weng Meiling On 2013/8/6 15:39, Weng Meiling wrote: > > From: Weng Meiling > > If we mount the cgroup without the name cgroup like the following: > > #mount > cpu on /cgroup/cpu type cgroup (rw,cpu) >

[Libcg-devel] question about cgdelete

2013-08-30 Thread Weng Meiling
n one place? Thanks! Weng Meiling -- Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incred

[Libcg-devel] [PATCH] cgconfig:cgconfig service should start when the cgconfig.conf is empty

2013-08-29 Thread Weng Meiling
From: Weng Meiling cgconfig service could start successfully when /etc/cgconfig.conf only contains comments. But failed when /etc/cgconfig.conf is empty or missing. The behavior of cgconfig service should be consistent with cgred service. This patch allows the cgconfig service start even when

Re: [Libcg-devel] [PATCH]add the value check before set the control file value

2013-08-22 Thread Weng Meiling
On 2013/8/22 20:38, Dhaval Giani wrote: > On Thu, Aug 22, 2013 at 8:32 AM, Ivana Varekova wrote: >> >> >> - Original Message - >>> From: "Weng Meiling" >>> To: libcg-devel@lists.sourceforge.net >>> Cc: "libo chen" &g

Re: [Libcg-devel] [PATCH] cgset: giving the apposite error messages

2013-08-13 Thread Weng Meiling
On 2013/8/14 11:32, Dhaval Giani wrote: > On Tue, Aug 13, 2013 at 10:07 PM, Weng Meiling > wrote: >> On 2013/8/14 4:38, Dhaval Giani wrote: >>> Hi, >>> >>> On Tue, Aug 13, 2013 at 6:24 AM, Weng Meiling >>> wrote: >>>> >>>>

Re: [Libcg-devel] [PATCH] cgset: giving the apposite error messages

2013-08-13 Thread Weng Meiling
On 2013/8/14 4:38, Dhaval Giani wrote: > Hi, > > On Tue, Aug 13, 2013 at 6:24 AM, Weng Meiling > wrote: >> >> From: Weng Meiling >> >> When setting the value of cgroup's control file by cgset -r, it's more >> appositely to yield an error wh

[Libcg-devel] [PATCH] cgset: giving the apposite error messages

2013-08-13 Thread Weng Meiling
From: Weng Meiling When setting the value of cgroup's control file by cgset -r, it's more appositely to yield an error when user try to set a read-only file or set a file not existed. So fix this by copying the dirty value in function cgroup_copy_controller_values(). Signed-of

[Libcg-devel] [RFC] cgred: parse the character '#' in cgrules.conf correctlly

2013-08-08 Thread Weng Meiling
From: Weng Meiling Any line starting with '#' in cgconfig.conf is considered a comment and is ignored. But in cgrules.conf, no matter where the character '#' is, it will be replace with '\0'. So the similar rules get different results as following: the rule: *%

[Libcg-devel] [PATCH v2] cgred:cgred should start when cgroup is mounted

2013-08-07 Thread Weng Meiling
From: Weng Meiling If we mount the cgroup without the name cgroup like the following: cpu on /cgroup/cpu type cgroup (rw,cpu) the cgred service will start failed, because it just check the name. So changing cgred to check the mounted system's type instead of the name. v1 -> v2 Using t

[Libcg-devel] [PATCH] cgred:cgred should start when cgroup is mounted.

2013-08-06 Thread Weng Meiling
From: Weng Meiling If we mount the cgroup without the name cgroup like the following: #mount cpu on /cgroup/cpu type cgroup (rw,cpu) the cgred service will start failed, because it just check the name. So changing cgred to check the mounted system's type instead of the name. Signed-o

[Libcg-devel] [PATCH]add the value check before set the control file value

2013-08-02 Thread Weng Meiling
From: Weng Meiling When we use memory subsystem, the memory.oom_control value we get like this: oom_kill_disable 0 under_oom 0 but we set the value just by writing a value(0 or 1) like this: #echo 1 > memory.oom_control so setting the value memory.oom_control by cgset --copy-from or

[Libcg-devel] [PATCH] cgclear: clear the mount info

2013-08-02 Thread Weng Meiling
From: Weng Meiling When we use cgclear to unload the cgroup filesystem, we still can see the umounted cgroup by using mount command. So fix the problem by call system. From: Weng Meiling --- src/config.c | 18 -- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git

[Libcg-devel] question about cgclear

2013-07-19 Thread Weng Meiling
Hi, when I test cgclear command with -l, I got a error report like this: "cgclear failed with Success" the following is my operation: # lssubsys -m cpu /cgroup/cpu # lscgroup cpu:/ cpu:/test # cgclear -l config cgclear failed with Success the config context is: # cat config # Configuration fi

[Libcg-devel] [PATCH] cgclassify: use the error message instead of error number

2013-07-16 Thread Weng Meiling
From: Weng Meiling It's more readable and friendly to use the detailed error message instead of error number as other places. Signed-off-by: Weng Meiling --- src/tools/cgclassify.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/tools/cgclassify.c b/src/

[Libcg-devel] [PATCH] cgget: use the enum value instead of number

2013-07-15 Thread Weng Meiling
From: Weng Meiling It's more readable and friendly to use the enum value instead of number. Signed-off-by:Weng Meiling --- src/tools/cgget.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/tools/cgget.c b/src/tools/cgget.c index 49a447c..e1e1d60 1

[Libcg-devel] question about lscgroup

2013-07-15 Thread Weng Meiling
Hi, When we use lscgroup with -g to specify more then one controllers, the result just display one controllers, such as: # lssubsys -m cpuset /cgroup/cpuset cpu /cgroup/cpu # lscgroup cpu:/ cpu:/test cpuset:/ cpuset:/test # lscgroup -g cpu,cpuset:test cpu:/test/ there is no message about cpuse

[Libcg-devel] [PATCH] cgsnapshot: fix the display message of the given controllers

2013-07-15 Thread Weng Meiling
From: Weng Meiling Date: Mon, 15 Jul 2013 04:08:20 -0400 Subject: [PATCH] cgsnapshot: fix the display message of the given controllers when we use cgsnapshot with the given controller, the result always displays the last mounted controller which is not specified, so fix it. Example: # lssubsys

Re: [Libcg-devel] [PATCH] cgsnapshot: fix the print message when use cgsnapshot with -f

2013-06-24 Thread Weng Meiling
On 2013/6/21 9:49, Weng Meiling wrote: > > From: Weng Meiling > ping When use cgsnapshot with -f to save current configuration of cgroups, the mount section is missing, so fix it. the example as following: # cgsnapshot -s -f config cpu = /cgroup/cpu; # cat config # Configura

[Libcg-devel] [PATCH] cgsnapshot: fix the print message when use cgsnapshot with -f

2013-06-20 Thread Weng Meiling
From: Weng Meiling Signed-off-by: Weng Meiling --- src/tools/cgsnapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/cgsnapshot.c b/src/tools/cgsnapshot.c index 324f93b..8217798 100644 --- a/src/tools/cgsnapshot.c +++ b/src/tools/cgsnapshot.c @@ -610,9