On Tue, Aug 08, 2017 at 06:57:53PM +0200, Pino Toscano wrote:
> c) I guess a switch to PCRE is planned?
Yes, I've done that already - will post it in the next version.
It actually simplifies the patches because the regexps are
identical to the C code.
> d) regarding the CD stuff (patch #1), can
On Tue, Aug 08, 2017 at 06:57:46PM +0200, Pino Toscano wrote:
> TBH, since both parse_os_release and parse_lsb_release are rewritten
> in OCaml, I'd try a better approach for them: add an helper function
> that read such kind of files (ignoring empty lines, and those starting
> with '#'), split
On Tue, Aug 08, 2017 at 06:57:33PM +0200, Pino Toscano wrote:
> On Monday, 31 July 2017 17:40:51 CEST Richard W.M. Jones wrote:
> > This commit embeds the ocaml-augeas library (upstream here:
> > http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical
> > to the upstream version and
On Monday, 31 July 2017 17:40:49 CEST Richard W.M. Jones wrote:
> v10: https://www.redhat.com/archives/libguestfs/2017-July/msg00245.html
>
> No actual change here, but I rebased and retested. Also this series
> now does not depend on any other patch series since everything else
> needed is
On Monday, 31 July 2017 17:40:58 CEST Richard W.M. Jones wrote:
> Mostly a line-for-line translation of the C inspection code.
> ---
> daemon/Makefile.am| 2 +
> daemon/inspect_fs.ml | 6 +
> daemon/inspect_fs_windows.ml | 491
>
On Monday, 31 July 2017 17:40:51 CEST Richard W.M. Jones wrote:
> This commit embeds the ocaml-augeas library (upstream here:
> http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical
> to the upstream version and should remain so.
>
> We can work towards using system ocaml-augeas,
On Monday, 31 July 2017 17:40:52 CEST Richard W.M. Jones wrote:
> +let unix_canonical_path path =
> + let is_absolute = String.length path > 0 && path.[0] = '/' in
> + let path = String.nsplit "/" path in
> + let path = List.filter ((<>) "") path in
> + (if is_absolute then "/" else "") ^
On Monday, 31 July 2017 17:40:57 CEST Richard W.M. Jones wrote:
> +(* Parse a os-release file.
> + *
> + * Only few fields are parsed, falling back to the usual detection if we
> + * cannot read all of them.
> + *
> + * For the format of os-release, see also:
> + *
These are generated in many different ways in the various
subdirectories, and sometimes not generated correctly. Introduce a
script to do this in one place, and hopefully correctly.
This is mostly simple refactoring, but I got rid of a couple of
things:
(1) The ‘make depend’ rule doesn't appear
On Tue, Aug 08, 2017 at 02:32:23PM +0200, Pino Toscano wrote:
> On Thursday, 3 August 2017 19:13:48 CEST Richard W.M. Jones wrote:
> > + fprintf (stderr, "mode = %o\n", statbuf.st_mode);
> > + if (S_ISBLK (statbuf.st_mode))
> > +/* continue */;
> > + else if (S_ISDIR (statbuf.st_mode)) {
>
On Tuesday, 8 August 2017 14:32:55 CEST Pino Toscano wrote:
> On Thursday, 3 August 2017 14:59:22 CEST Richard W.M. Jones wrote:
> > This patch series fixes several problems in the way that supermin
> > handles kernels. The most pressing problem is that supermin doesn't
> > handle bogus vmlinuz
On Thursday, 3 August 2017 19:13:45 CEST Richard W.M. Jones wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1477623
>
> The first two patches are cleanups.
>
> The third patch changes the way that we handle Device and Dev_or_Path
> parameters so that a parameter marked as such can really
On Thursday, 3 August 2017 14:59:22 CEST Richard W.M. Jones wrote:
> This patch series fixes several problems in the way that supermin
> handles kernels. The most pressing problem is that supermin doesn't
> handle bogus vmlinuz files which aren't actual kernels. Along the way
> there is a lot of
On Thursday, 3 August 2017 19:13:48 CEST Richard W.M. Jones wrote:
> + fprintf (stderr, "mode = %o\n", statbuf.st_mode);
> + if (S_ISBLK (statbuf.st_mode))
> +/* continue */;
> + else if (S_ISDIR (statbuf.st_mode)) {
> +fprintf (stderr, "S_ISDIR\n");
The two unconditional fprintf()
Thanks Rich,
Setting the OCAMLPATH and redoing the configure, make and make install
seemed to work.
I installed opam after I couldn't get hivex to install initially, was
hoping that hivex was a package managed by opam I guess.
Chris
On 7 August 2017 at 08:54, Richard W.M. Jones
15 matches
Mail list logo
