Mostly a line-for-line translation of the C inspection code.
---
daemon/Makefile.am| 2 +
daemon/inspect_fs.ml | 6 +
daemon/inspect_fs_windows.ml | 480 ++
daemon/inspect_fs_windows.mli | 24 +++
4 files changed, 512 insertions(+)
After we move inspection code to the daemon, the library will no
longer have access to ‘struct inspect_fs’, and so we won't be able to
prefix downloads with the "root filesystem number".
Just remove this prefix (it's internal only). However it does mean
that this function can no longer cache down
This fixes almost everything. Note that it adds an extra commit which
fixes the whole utf8/iconv business.
It's probably better to list what isn't fixed:
(1) I didn't leave the osinfo code around because I'm still haven't
looked too closely at virt-builder-repository. Can't we just fetch
this c
Implement returning these two types from OCaml daemon functions.
---
daemon/daemon-c.c | 52
daemon/daemon-c.h | 2 ++
generator/daemon.ml | 13 +++--
3 files changed, 65 insertions(+), 2 deletions(-)
diff --git a/daemon/daemon-c.c
This commit bundles the ocaml-augeas library (upstream here:
http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical
to the upstream version and should remain so.
We can work towards using system ocaml-augeas, when it's more widely
available.
---
.gitignore| 1
Define the types which will be used to communicate between the
different parts of the inspection code. The main types are:
fscorresponds to ‘struct inspect_fs’ in C code
root no direct correspondence with the C code, but in the C
code, ‘inspect_fs’ was overloaded to
hivex has a function hivex_value_string. We were not calling it under
the mistaken belief that because hivex implements this using iconv,
the function wouldn't work inside the daemon. Instead we
reimplemented the functionality in the library.
This commit deprecates hivex_value_utf8 and removes t
These utility functions will be used in the OCaml inspection code.
---
daemon/daemon_utils_tests.ml | 10 ++
daemon/utils.ml | 17 +
daemon/utils.mli | 11 +++
3 files changed, 38 insertions(+)
diff --git a/daemon/daemon_utils_tests.ml b/da
This just duplicated libosinfo information, and because it was never
tested it didn't work most of the time.
---
docs/C_SOURCE_FILES| 2 -
generator/actions_inspection.ml| 67 ---
generator/actions_inspection_deprecated.ml | 61 +++
inspector/Makefile.am
Unlike previous ‘daemon: Reimplement ...’ patches, this does not
reimplement the umount_all API completely (yet, but this
implementation could be completed in future and then replace the C
one). However it is necessary to have a version of umount_all which
we can call from the OCaml inspection cod
This is essentially a line-for-line translation of the C inspection
code.
---
daemon/Makefile.am | 8 +
daemon/inspect.ml| 396 +
daemon/inspect.mli | 41 +++
daemon/inspect_fs.ml | 363 +++
daemon/inspe
On Wed, Aug 09, 2017 at 03:40:54PM +0200, Pino Toscano wrote:
> BTW, unrelated to this patch, just because I'm noticing them: what are
> all the "docs" dependencies in .PHONY? At least for newer Makefile's
> I guess they were just copied from existing ones, but I did not find
> any reference/reaso
]: Entering directory '/var/tmp/tmpAS0SwB/libguestfs/erlang'
make[3]: Entering directory '/var/tmp/tmpAS0SwB/libguestfs/erlang'
PASS: tests/010-load.erl
PASS: tests/030-config.erl
PASS: run-bindtests
PASS: tests/070-optargs.erl
PASS: tests/050-lvcreate.erl
PASS: tests/060-readdir.erl
==
On Tuesday, 8 August 2017 16:34:49 CEST Richard W.M. Jones wrote:
> These are generated in many different ways in the various
> subdirectories, and sometimes not generated correctly. Introduce a
> script to do this in one place, and hopefully correctly.
>
> This is mostly simple refactoring, but
Good idea, ACK series.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Li
Add sort of "headers" to split most of the logical sections of the
configure, so it is easier to get feedback on the progress of configure.
---
configure.ac | 46 ++
1 file changed, 46 insertions(+)
diff --git a/configure.ac b/configure.ac
index 7f9c1da
Output each path where we attempt to find 'java', so it is easier to
spot whether the location for the current OS is missing. This also
removes the need to print the location next to the version, since the
location was already printed above.
---
m4/guestfs_java.m4 | 6 +-
1 file changed, 5 in
17 matches
Mail list logo