Re: [Libguestfs] can not get the virt-sparsify code in libguestfs ?

2022-09-23 Thread Richard W.M. Jones
On Fri, Sep 23, 2022 at 03:19:47PM +0100, Richard W.M. Jones wrote: > On Fri, Sep 23, 2022 at 02:03:45PM +, Li, Feng F wrote: > > The log output from command " ./virt-sparsify --inplace -v -x > > /home/intel/imgStore/POS_DATA.qcow2" > > Thanks. This is actually a bug in libguestfs. In the

Re: [Libguestfs] can not get the virt-sparsify code in libguestfs ?

2022-09-23 Thread Richard W.M. Jones
On Fri, Sep 23, 2022 at 02:03:45PM +, Li, Feng F wrote: > The log output from command " ./virt-sparsify --inplace -v -x > /home/intel/imgStore/POS_DATA.qcow2" Thanks. This is actually a bug in libguestfs. In the following function which is called from virt-sparsify early on:

Re: [Libguestfs] can not get the virt-sparsify code in libguestfs ?

2022-09-23 Thread Li, Feng F
The log output from command " ./virt-sparsify --inplace -v -x /home/intel/imgStore/POS_DATA.qcow2" -Original Message- From: Richard W.M. Jones Sent: 2022年9月23日 20:07 To: Li, Feng F Cc: libguestfs@redhat.com Subject: Re: can not get the virt-sparsify code in libguestfs ? On Fri, Sep

Re: [Libguestfs] redhat 7.6 on intel ice lake sp kvm got error

2022-09-23 Thread Richard W.M. Jones
On Fri, Sep 23, 2022 at 09:31:40PM +0800, mark wrote: > virt-host-validate show like this: > > QEMU: Checking for hardware virtualization : > PASS > QEMU: Checking if device /dev/kvm exists : > PASS > QEMU: Checking if device

Re: [Libguestfs] redhat 7.6 on intel ice lake sp kvm got error

2022-09-23 Thread Richard W.M. Jones
On Fri, Sep 23, 2022 at 09:05:31PM +0800, mark wrote: > Dear >On redhat 7.6 OS with intel ice lake cpu like : > _ > [root@localhost ~]# lscpu > Architecture: x86_64 > CPU op-mode(s):32-bit, 64-bit > Byte

[Libguestfs] redhat 7.6 on intel ice lake sp kvm got error

2022-09-23 Thread mark
Dear On redhat 7.6 OS with intel ice lake cpu like : _ [root@localhost ~]# lscpu Architecture: x86_64 CPU op-mode(s):32-bit, 64-bit Byte Order: Little Endian CPU(s):96 On-line CPU(s) list: 0-95 Thread(s)

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 14:36, Laszlo Ersek wrote: > On 09/23/22 12:14, Laszlo Ersek wrote: >> On 09/23/22 11:54, Richard W.M. Jones wrote: > >>> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v >>> to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk 2.10, >>> which even for

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Richard W.M. Jones
On Fri, Sep 23, 2022 at 02:36:14PM +0200, Laszlo Ersek wrote: > On 09/23/22 12:14, Laszlo Ersek wrote: > > On 09/23/22 11:54, Richard W.M. Jones wrote: > > >> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v > >> to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 12:14, Laszlo Ersek wrote: > On 09/23/22 11:54, Richard W.M. Jones wrote: >> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v >> to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk 2.10, >> which even for Gtk 2 is an old version. Those RHEL releases had

Re: [Libguestfs] can not get the virt-sparsify code in libguestfs ?

2022-09-23 Thread Richard W.M. Jones
On Fri, Sep 23, 2022 at 11:37:01AM +, Li, Feng F wrote: > We download the guestfs-tools from below git and compile a local version . > > But when we did the test , please see below: > > 1. In the Windows the Drive D:\ , the real disk usage is about 19.9-17.7 = > 2.2G. > > [cid] > >

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 12:14, Laszlo Ersek wrote: > On 09/23/22 11:54, Richard W.M. Jones wrote: >> ACK series, but see my comment about patch 14. > > Thanks, I'll adjust patch 14 before pushing (I believe I now understand > the borders in the docs). Commit range aa36551e515f..28d7ce8c9db9. I added the

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 11:54, Richard W.M. Jones wrote: > ACK series, but see my comment about patch 14. Thanks, I'll adjust patch 14 before pushing (I believe I now understand the borders in the docs). > > A couple of other general points: > > (1) You could copy the vector type from nbdkit if that would

Re: [Libguestfs] [p2v PATCH 14/15] create_conversion_dialog(): add button to refresh disks & removables

2022-09-23 Thread Laszlo Ersek
On 09/23/22 11:42, Richard W.M. Jones wrote: > On Mon, Sep 19, 2022 at 03:35:10PM +0200, Laszlo Ersek wrote: >> +At the bottom of the dialog, the C button instructs >> +virt-p2v to re-enumerate the fixed hard disks and the removable media >> +drives. (Note that the button will also reset the

Re: [Libguestfs] [p2v PATCH 4/4] ssh.c: fix crash in "v2v_version" lifecycle management

2022-09-23 Thread Laszlo Ersek
On 09/23/22 11:20, Richard W.M. Jones wrote: > > ACK series... Thanks! Commit range 6f1adeba1aab..aa36551e515f. > Although if I was going to quibble, GNU code tends to use *_p to > indicate a predicate (following the LISP convention [1]), whereas I > think your meaning is "private to

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Richard W.M. Jones
ACK series, but see my comment about patch 14. A couple of other general points: (1) You could copy the vector type from nbdkit if that would help with handling lists of strings. (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v to be compiled on RHEL <= 6. RHEL 5 in

Re: [Libguestfs] [p2v PATCH 14/15] create_conversion_dialog(): add button to refresh disks & removables

2022-09-23 Thread Richard W.M. Jones
On Mon, Sep 19, 2022 at 03:35:10PM +0200, Laszlo Ersek wrote: > +At the bottom of the dialog, the C button instructs > +virt-p2v to re-enumerate the fixed hard disks and the removable media > +drives. (Note that the button will also reset the currently active > +selections in both of those

Re: [Libguestfs] [p2v PATCH 08/15] set_config_defaults(): clean up some warts

2022-09-23 Thread Richard W.M. Jones
On Mon, Sep 19, 2022 at 03:35:04PM +0200, Laszlo Ersek wrote: > The statement > > if (!test_disk) { /* block A */ } else { /* block B */ } > > is needlessly complex; drop the logical negation in exchange for > reordering the branches: > > if (test_disk) { /* block B */ } else { /* block A

Re: [Libguestfs] [p2v PATCH 4/4] ssh.c: fix crash in "v2v_version" lifecycle management

2022-09-23 Thread Richard W.M. Jones
ACK series... Although if I was going to quibble, GNU code tends to use *_p to indicate a predicate (following the LISP convention [1]), whereas I think your meaning is "private to function", so maybe that's confusing to some. Rich. [1]