Re: [Libguestfs] [PATCH] Skip vsock-related checks if AF_VSOCK is not supported.

* Richard W.M. Jones: > Thanks Hilko, I've pushed it. > > Out of interest, where are you running that doesn't have AF_VSOCK > support? Does Debian not compile it into the kernel? It's there on my machines, but apparently Debian's buildd's don't have it enabled, see

[Libguestfs] [PATCH] Skip vsock-related checks if AF_VSOCK is not supported.

--- tests/functions.sh.in| 10 ++ tests/test-ip-filter-anyvsock.sh | 1 + tests/test-nbd-vsock.sh | 1 + tests/test-vsock.sh | 1 + 4 files changed, 13 insertions(+) diff --git a/tests/functions.sh.in b/tests/functions.sh.in index 403fa56e..d6c4255c

[Libguestfs] [PATCH] appliance: Fix searching for shared libraries on usr-merged Debian systems

If /lib is a symlink to usr/lib, paths to shared libraries as determined by ld.so may differ from dpkg's file lists. We turn the filename search pattern into a glob expression by prefixing it with a '*', so the required packages are found again: $ dpkg -S /lib/x86_64-linux-gnu/libpcre2-8.so.0

Re: [Libguestfs] [libguestfs] Problem building appliance/guestfsd.deps on debian

* Richard W.M. Jones: > We have a report of a problem with building appliance/guestfsd.deps on > Debian 10. This code which you contributed: > > https://github.com/libguestfs/libguestfs/commit/133a49167778195f0cf043a1d380c60956aa46b1 > > seems to cause problems with certain libraries which are

[Libguestfs] [PATCH] Use guestfsd binary to auto-generate library dependencies for appliance

The ELF NEEDED are used to determine guestfsd's library dependencies with help from the dynamic linker and the package manager. This was prompted by Debian bug #972241 which was caused by a libtirpc package renaming in Debian/unstable because the SONAME had been changed. ---

[Libguestfs] [PATCH v2] Link .mli files corresponding to autorgenerated .ml files into builddir

This avoids occasional build failures in builddir != srcdir situations: , | ocamlfind ocamlc -package str,unix -I . -a guestfs_config.cmo stringMap.cmo stringSet.cmo std_utils.cmo -o mlstdutils.cma | ar cr libmlstdutils.a libmlstdutils_a-dummy.o | ranlib libmlstdutils.a | File "_none_", line

[Libguestfs] [PATCH] Link .mli files corresponding to autorgenerated .ml files into builddir

This avoids build failures in separate builds such as this one: , | ocamlfind ocamlc -package str,unix -I . -a guestfs_config.cmo stringMap.cmo stringSet.cmo std_utils.cmo -o mlstdutils.cma | ar cr libmlstdutils.a libmlstdutils_a-dummy.o | ranlib libmlstdutils.a | File "_none_", line 1: |

Re: [Libguestfs] [PATCH] java: support OpenJDK 10+

* Richard W.M. Jones: > Thanks hillu, would you mind just pushing a quick fix? Done. Cheers, -Hilko ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH] java: support OpenJDK 10+

* Pino Toscano: > @@ -163,6 +161,7 @@ if test "x$with_java" != "xno"; then > AC_SUBST(JAR_INSTALL_DIR) > AC_SUBST(JNI_INSTALL_DIR) > AC_SUBST(JNI_VERSION_INFO) > +AM_CONDITIONAL([HAVE_JAVAH],[test -n "$JAVAH"]) > fi > > AM_CONDITIONAL([HAVE_JAVA],[test "x$with_java" !=

[Libguestfs] [PATCH] Fix out-of-tree builds of OCaml components

- Add $(srcdir), $(builddir) to Makefiles where required - Post-process ocamldep output - generate ocaml/.depends Gbp-Pq: Name 0012-Fix-out-of-tree-builds-of-OCaml-components.patch --- builder/Makefile.am | 7 --- common/mlgettext/Makefile.am | 2 +- common/mlpcre/Makefile.am

[Libguestfs] [PATCH] Fix out-of-tree builds of OCaml components

- Add $(srcdir), $(builddir) to Makefiles where required - Post-process ocamldep output - generate ocaml/.depends --- builder/Makefile.am | 7 --- common/mlgettext/Makefile.am | 2 +- common/mlpcre/Makefile.am | 2 +- common/mlprogress/Makefile.am | 2 +-

[Libguestfs] [PATCH] Add a cache for iconv_t handles to hive_t

It was brought to my attention that dumping a registry hive causes a lot of time spent in disk I/O activity because iconv_open() and iconv_close() are called for every key. Every iconv_open() call causes /usr/lib/.../gconv/$ENCODING.so to be opened and mapped. The iconv_t handles are now cached

[Libguestfs] [PATCH] Add a cache for iconv_t handles to hive_t

It was brought to my attention that dumping a registry hive causes a lot of time spent in disk I/O activity because iconv_open() and iconv_close() are called for every key. Every iconv_open() call causes /usr/lib/.../gconv/$ENCODING.so to be opened and mapped. The iconv_t handles are now cached

[Libguestfs] nbdkit 1.1.15 -- test-python failure

Hi, when I tested building nbdkit 1.1.15 in a current Debian chroot, I ran into the following test failure. A repeated build went fine through the tests and so far I have not been able to reproduce it with the previous version. The failing build was done using a clean Debian/sid, amd64 chroot

Re: [Libguestfs] building virt-builder still seems to fail.

* Hilko Bengen: > commit df5bd5741b37da9cf97d7a76ac2805557aa630db > Author: Richard W.M. Jones <rjo...@redhat.com> > Date: Tue Apr 29 15:43:20 2014 +0100 > > builder: Fix parallel builds of index-parse.o. > > there is a small chance that a build may go wrong

[Libguestfs] [PATCH] builder: Fix problem about index-parse.h not being generated

If configured with --without-ocaml, the build might fail because the fix added in df5bd5741b37da9cf97d7a76ac2805557aa630db was not active. According to the automake documentation, it should be enough to set BUILT_SOURCES. --- builder/Makefile.am | 10 +- 1 file changed, 1 insertion(+), 9

[Libguestfs] building virt-builder still seems to fail.

Hi, it seems that even after commit df5bd5741b37da9cf97d7a76ac2805557aa630db Author: Richard W.M. Jones Date: Tue Apr 29 15:43:20 2014 +0100 builder: Fix parallel builds of index-parse.o. there is a small chance that a build may go wrong with the described symtom,

[Libguestfs] [PATCH] Fix determining release date for builddir != srcdir

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 188bed76f..1ab54500d 100644 --- a/configure.ac +++ b/configure.ac @@ -94,7 +94,7 @@ dnl Find the release date for this version. This is used in dnl the website 'index.html'

Re: [Libguestfs] [PATCH] run.in: Quote contents of @VAR@ substitutions

* Richard W.M. Jones: > I believe this has already been applied upstream > (commit eecb1d81777219113f7e5434829aca6f93a92b9a) so it's not necessary. Sorry, I should have indicated that this patch was for hivex. The quotes are still missing there. Cheers, -Hilko

[Libguestfs] [PATCH] run.in: Quote contents of @VAR@ substitutions

--- run.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/run.in b/run.in index 0d10983..0f23a7c 100755 --- a/run.in +++ b/run.in @@ -62,7 +62,7 @@ export PERL_VALGRIND=1 export PERL_DESTRUCT_LEVEL=2 # For Python. -export PYTHON=@PYTHON@ +export PYTHON="@PYTHON@"

[Libguestfs] [PATCH] hivexsh: Add missing documentation for -u switch

--- sh/hivexsh.pod | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sh/hivexsh.pod b/sh/hivexsh.pod index 7d7fc0a..8b10a6a 100644 --- a/sh/hivexsh.pod +++ b/sh/hivexsh.pod @@ -61,6 +61,13 @@ script, use: #!/usr/bin/hivexsh -f +=item B<-u> + +Use heuristics to tolerate certain

[Libguestfs] [PATCH] hivexml: Add -u flag for HIVEX_OPEN_UNSAFE

--- xml/hivexml.c | 5 - xml/hivexml.pod | 7 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/xml/hivexml.c b/xml/hivexml.c index b496bb6..8ba6594 100644 --- a/xml/hivexml.c +++ b/xml/hivexml.c @@ -95,7 +95,7 @@ main (int argc, char *argv[]) int open_flags = 0;

[Libguestfs] [PATCH] Add hppa, hppa64, ppc64el architectures

--- src/kernel.ml | 2 ++ src/utils.ml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/kernel.ml b/src/kernel.ml index 356ac4b..9b0e8a2 100644 --- a/src/kernel.ml +++ b/src/kernel.ml @@ -30,6 +30,8 @@ let patt_of_cpu host_cpu = | "ppc" | "powerpc" | "powerpc64" -> ["ppc";

[Libguestfs] [PATCH] run.in: Quote contents of @VAR@ substitutions

--- run.in | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/run.in b/run.in index 8fdf454..438a68c 100755 --- a/run.in +++ b/run.in @@ -140,15 +140,15 @@ export PERL_VALGRIND=1 export PERL_DESTRUCT_LEVEL=2 # For Python. -export PYTHON=@PYTHON@ +export

Re: [Libguestfs] libguestfs-tools missing implicit dependency in ubuntu

* Richard W.M. Jones: On Fri, May 29, 2015 at 06:50:21PM -0500, Andrew Pennebaker wrote: When I install libguestfs-tools in ubuntu (latest docker base image, 14.04 trusty tahr) and run virt-builder --list, it complains of a missing curl dependency. We should probably make curl an explicit

[Libguestfs] sfdisk: No more Cylinder / Head / Sector support in util-linux 2.26 and later

Hi, it was brought to my attention that sfdisk has lost the ability to deal with C/H/S addressing as of util-linux 2.26, so the -C ,-H, -S command line parameters are no longer supported. Should there be a compile-time check based on sfdisk -h output that would cause daemon/sfdisk.c to be

Re: [Libguestfs] sfdisk: No more Cylinder / Head / Sector support in util-linux 2.26 and later

* Richard W.M. Jones: I think a compile-time check would just cause the API to fail in a different way, so I don't think it would help users very much, unless I'm misunderstanding what you mean. I think you are right. Cheers, -Hilko ___ Libguestfs

[Libguestfs] [PATCH] Fix out-of-tree build: Don't create empty .y file in builddir

--- builder/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index a0d139b..29f7556 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -309,7 +309,7 @@ CLEANFILES += \ if HAVE_OCAML # Automake-generated makefile

[Libguestfs] [PATCH] Fix, simplify out-of-tree build/install for bash completions

--- bash/Makefile.am | 54 +++--- 1 file changed, 15 insertions(+), 39 deletions(-) diff --git a/bash/Makefile.am b/bash/Makefile.am index 10f0861..780da64 100644 --- a/bash/Makefile.am +++ b/bash/Makefile.am @@ -21,6 +21,10 @@ scripts = \

Re: [Libguestfs] missing symbol

* Hilko Bengen: when pushing libguestfs 1.27.53 (1:1.27.53-1) through my build setup befor uploading it to Debian, I noticed that guestfs_internal_lstatlist@Base, a symbol that has been there since 1.20, is now missing. This causes dpkg-gensymbols(1) whose job it is to compare the symbols

[Libguestfs] missing symbol

Hi, when pushing libguestfs 1.27.53 (1:1.27.53-1) through my build setup befor uploading it to Debian, I noticed that guestfs_internal_lstatlist@Base, a symbol that has been there since 1.20, is now missing. This causes dpkg-gensymbols(1) whose job it is to compare the symbols from the

Re: [Libguestfs] [PATCH] FAQ: Note that update-guestfs-appliance is not needed with

* Richard W.M. Jones: I think this is correct -- Hilko? Yes. According to my git history, I removed update-guestfs-appliance in 1:1.25.43-2. Cheers, -Hilko ___ Libguestfs mailing list Libguestfs@redhat.com

[Libguestfs] [PATCH] appliance: Add libsystemd0 (and systemd as an alternative for sysvinit) on Debian-based systems

--- appliance/packagelist.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 3e028e3..418c574 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -80,6 +80,7 @@ dnl iproute has been renamed to iproute2 libcap2

[Libguestfs] [PATCH] Generate *.cmx targets only if a native OCaml compiler exists

--- builder/Makefile.am | 2 ++ customize/Makefile.am | 2 ++ mllib/Makefile.am | 2 ++ ocaml/Makefile.am | 4 resize/Makefile.am| 2 ++ sparsify/Makefile.am | 2 ++ sysprep/Makefile.am | 2 ++ v2v/Makefile.am | 2 ++ 8 files changed, 18 insertions(+) diff --git

Re: [Libguestfs] [hivex] Segfault for an integer value to node_set_value

* Peter Wu: When an integer argument is passed as value, node_set_value segfaults. Reproducer is at the end of this message Uh-oh. It looks like the handling of values is broken for non-string cases. bytes = PyUnicode_AsUTF8String (obj); with obj derived from the numeric 1234 causes

[Libguestfs] [hivex] python: Check type of variable passed into set_value.

The following code, reported by Peter Wu pe...@lekensteyn.nl, broke on x86_64 with different symptoms on Python2 and Python3 (malloc() failure and segmentation fault, respectively): r = h.node_set_value(h.root(), { 'key': 'broken', 't': 4, 'value': 1234 }) --- generator/generator.ml

Re: [Libguestfs] Adventures in building libguestfs on non-x86 architectures for Debian

* Richard W.M. Jones: Apparently, qemu-system-arm 2.0 as currently available through Debian/unstable doesn't want to tell us anything about available devices unless we specify a machine type. The patch below works around that issue, but I haven't been able to run qemu-system-arm with a

[Libguestfs] [libldm 1/3] relax uuid, zlib version requirements

--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 469ea96..0e7e2ea 100644 --- a/configure.ac +++ b/configure.ac @@ -85,14 +85,14 @@ PKG_CHECK_MODULES([GIO_UNIX], [gio-unix-2.0 = 2.32.0], ] )

[Libguestfs] [libldm 2/3] easy fix for compiling with -Werror=format-security

error: format not a string literal and no format arguments [-Werror=format-security] --- src/ldm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ldm.c b/src/ldm.c index 4897de9..539c562 100644 --- a/src/ldm.c +++ b/src/ldm.c @@ -2762,7 +2762,7 @@

[Libguestfs] [PATCH] Make test-execstack recognize SKIP_ variable

--- tests/test-execstack.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/test-execstack.sh b/tests/test-execstack.sh index a9cb5e0..a02803b 100755 --- a/tests/test-execstack.sh +++ b/tests/test-execstack.sh @@ -18,6 +18,11 @@ set -e +if [ -n $SKIP_TEST_EXECSTACK ]; then +

[Libguestfs] [PATCH] appliance: update Debian-specific package list

--- appliance/packagelist.in | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index d241ec9..27106c8 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -60,11 +60,13 @@ ifelse(DEBIAN,1,

[Libguestfs] Adventures in building libguestfs on non-x86 architectures for Debian

Hi, things are progressing slowly, but I feel that eventually I'll be getting there: supermin can be built on all Linux-based architectures that are part of Debian/unstable[1] -- (except for sparc, but I'll ignore that for now.) libguestfs on the other hand currently fails launching the appliance

Re: [Libguestfs] [supermin] Be smarter about finding suitable kernel images

* Richard W.M. Jones: On Sat, Apr 26, 2014 at 02:27:07PM +0200, Hilko Bengen wrote: --- src/kernel.ml | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/src/kernel.ml b/src/kernel.ml index ed5aea3..436b1b0 100644 --- a/src

[Libguestfs] [supermin] Be smarter about finding suitable kernel images and device trees

--- src/kernel.ml | 58 ++ 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/src/kernel.ml b/src/kernel.ml index ed5aea3..7076aa5 100644 --- a/src/kernel.ml +++ b/src/kernel.ml @@ -23,6 +23,19 @@ open Utils open Ext2fs open

[Libguestfs] [supermin] Be smarter about finding suitable kernel images

--- src/kernel.ml | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/src/kernel.ml b/src/kernel.ml index ed5aea3..436b1b0 100644 --- a/src/kernel.ml +++ b/src/kernel.ml @@ -23,6 +23,19 @@ open Utils open Ext2fs open Fnmatch +let

[Libguestfs] [PATCH] Fix qemu version check

--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ab072c3..9c398e0 100644 --- a/configure.ac +++ b/configure.ac @@ -777,7 +777,7 @@ working. fi AC_MSG_CHECKING([for $QEMU version = 1]) -if $QEMU

Re: [Libguestfs] [PATCH pkg-libvirt/libguestfs] Split off ZFS support from libguestfs0.

* Richard W.M. Jones: about the zfs-fuse dependency being a problem. Is it possible you can include a patch to split off libguestfs-zfs as a subpackage? Working on it; I'll do an upload of 1.27.x to experimental once I actually get the modified package built. -Hilko

[Libguestfs] [PATCH] appliance: Not all of Grub is needed, only grub-install

--- appliance/packagelist.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 6533a2a..d241ec9 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -62,7 +62,7 @@ ifelse(DEBIAN,1, genisoimage

Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

* Richard W.M. Jones: On Fri, Feb 28, 2014 at 02:35:56PM +0100, Hilko Bengen wrote: diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index 5dd2c9b..708b2e7 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am [...] +# Tell version 3.79 and up of GNU make to not build goals

Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

* Richard W.M. Jones: I think that an extra target (mlguestfs.cmxa: mlguestfs.cma) would make the .NOTPARALLEL unnecessary. Right, I remember this was a problem now. It was fixed by: https://github.com/libguestfs/libguestfs/commit/dce94f3e266ed3f1fc634a1ef6953f2db1510963 Do you think we

Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

* Richard W.M. Jones: Wouldn't a rule without commands such as mlguestfs.cmxa: mlguestfs.cma also prevent make from building the two targets in parallel? Doesn't that mean that if mlguestfs.cmxa is out of date, simply running the mlguestfs.cma rule will build it (which it won't)? Not

[Libguestfs] [supermin 2/2] tests: Add --use-installed variants

--- tests/Makefile.am| 11 +++ tests/test-binaries-exist-network.sh | 2 ++ tests/test-binaries-exist.sh | 4 +++- tests/test-build-bash-network.sh | 3 +++ tests/test-build-bash.sh | 4 +++- tests/test-harder-network.sh | 3 +++

[Libguestfs] [supermin 1/2] chroot: Fix corner case introduced with dpkg-divert support

--- src/chroot.ml | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/chroot.ml b/src/chroot.ml index b5c1e53..9e522d9 100644 --- a/src/chroot.ml +++ b/src/chroot.ml @@ -26,7 +26,9 @@ let build_chroot debug files outputdir = List.iter ( fun file - try -

[Libguestfs] [supermin 3/4] dpkg: Determine primary architecture on initialization

This eliminates the need for multiple dpkg --print-architecture calls --- src/dpkg.ml | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index 1dfb92c..2e3a198 100644 --- a/src/dpkg.ml +++ b/src/dpkg.ml @@ -30,18 +30,19 @@ let dpkg_detect

[Libguestfs] [supermin 1/4] dpkg: Gather information about all installed packages on demand

This eliminates the need for multiple dpkg-query --show calls --- src/dpkg.ml | 77 +++-- 1 file changed, 19 insertions(+), 58 deletions(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index efc8123..c4a4316 100644 --- a/src/dpkg.ml +++

[Libguestfs] [supermin 2/4] dpkg: Gather dependency information about all installed packages on demand

This is done using one dpkg-query call --- src/dpkg.ml | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index c4a4316..1dfb92c 100644 --- a/src/dpkg.ml +++ b/src/dpkg.ml @@ -94,16 +94,31 @@ let

[Libguestfs] A few easy dpkg optimizations for supermin

I have done some printf profiling and found that supermin's calls to dpkg for individual packages are quite expensive. Here are some patches that gather all information on demand where possible. On my Debian/unstable-based workstation at home, preparing a minimal appliance using $ ./supermin

Re: [Libguestfs] [PATCH pkg-libvirt/libguestfs] Remove update-guestfs-appliance

* Richard W.M. Jones: [First attempt to send this using git send-email didn't work because of SMTP routing problems] I did actually get the first mail. This is my experimental patch to remove update-guestfs-appliance from Debian. With this patch, libguestfs builds with a supermin [version

[Libguestfs] [supermin 2/3] Add file.source_path, no functional changes

--- src/dpkg.ml | 2 +- src/package_handler.ml | 1 + src/package_handler.mli | 4 src/pacman.ml | 2 +- src/rpm.ml | 2 +- 5 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index c28354a..234bb63 100644 ---

Re: [Libguestfs] [supermin 2/3] Add file.source_path, no functional changes

* Richard W.M. Jones: There must be a mistake here because this always sets ft_source_path = ft_path = path. That was intentional: No functional changes Cheers -Hilko ___ Libguestfs mailing list Libguestfs@redhat.com

[Libguestfs] supermin and dpkg-divert, take 2

I fixed a corner case (diversion only registered, not taken) and cleaned up the patches. Cheers, -Hilko ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [supermin 1/3] Recognize dpkg-divert

--- configure.ac | 1 + src/config.ml.in | 1 + src/dpkg.ml | 1 + 3 files changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 5a92034..f7e0402 100644 --- a/configure.ac +++ b/configure.ac @@ -92,6 +92,7 @@ AC_PATH_PROG(APT_GET,[apt-get],[no])

[Libguestfs] [supermin 2/3] Add file.source_path

--- src/dpkg.ml | 6 +- src/package_handler.ml | 1 + src/package_handler.mli | 4 src/pacman.ml | 2 +- src/rpm.ml | 2 +- 5 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index c28354a..22c4f16 100644 ---

[Libguestfs] [supermin 3/3] Use the file tuple up to the point where files are copied into the filesystem / chroot

--- src/build.ml | 39 +++ src/chroot.ml | 13 +++-- src/dpkg.ml | 14 -- src/ext2.ml | 5 - 4 files changed, 46 insertions(+), 25 deletions(-) diff --git a/src/build.ml b/src/build.ml index 9225184..3d4ecad 100644 ---

[Libguestfs] [supermin 1/3] Recognize dpkg-divert

--- configure.ac | 1 + src/config.ml.in | 1 + src/dpkg.ml | 1 + 3 files changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 5a92034..f7e0402 100644 --- a/configure.ac +++ b/configure.ac @@ -92,6 +92,7 @@ AC_PATH_PROG(APT_GET,[apt-get],[no])

[Libguestfs] supermin and dpkg-divert

While trying to run libguestfs tests after building with --enable-appliance --with-supermin-extra-options=--use-installed, I ran into a peculiar error message in the c-api test: , | libguestfs: error: strings: /abssymlink: strings: error while loading | shared libraries:

Re: [Libguestfs] [PATCH] Disable gnulib tests by default

* Richard W.M. Jones: From: Hilko Bengen ben...@debian.org Please use ben...@hilluzination.de. Cheers, -Hilko ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH] supermin: Handle FTSENT.fts_info correctly -- it is not a bitmask.

Found by trying to build a simple appliance using $ supermin --prepare -o supermin.d dash and adding a tarball containing a symbolic link (/init - /bin/sh). This symbolic link was not transferred to the filesystem. --- src/ext2fs-c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Libguestfs] [PATCH] supermin: dpkg: Handle multiarch setups correctly

--- src/dpkg.ml | 39 +-- 1 file changed, 25 insertions(+), 14 deletions(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index c0d3292..2662465 100644 --- a/src/dpkg.ml +++ b/src/dpkg.ml @@ -29,6 +29,10 @@ let dpkg_detect () = Config.apt_get no

[Libguestfs] [PATCH] Do not ship test-qemu-drive-libvirt.xml with tarball as it is generated by configure

--- tests/disks/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/disks/Makefile.am b/tests/disks/Makefile.am index 2a94279..ec95e82 100644 --- a/tests/disks/Makefile.am +++ b/tests/disks/Makefile.am @@ -29,5 +29,4 @@ TESTS_ENVIRONMENT = \ EXTRA_DIST = \

[Libguestfs] [PATCH] Debian: Add systemd-related libraries (for guestfsd) to packagelist

--- appliance/packagelist.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index b93cd09..5e2a1aa 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -69,6 +69,8 @@ ifelse(DEBIAN,1, libcap2 libhivex0 libpcre3

[Libguestfs] [PATCH] supermin: Fix build with bytecode compiler

--- src/Makefile.am | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 7f99b8a..932881b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -104,17 +104,18 @@ supermin_CFLAGS = \ BOBJECTS = $(SOURCES_ML:.ml=.cmo) XOBJECTS =

Re: [Libguestfs] [PATCH] supermin: Fix build with bytecode compiler

* Richard W.M. Jones: Also: I found a nasty thinko in the code yesterday which has the potential to cause random appliance corruption. The fix is: https://github.com/libguestfs/supermin/commit/1b53e2850e45a6e7bd6b4f75e865b59dcaf7971e and I also released 5.1.2 last night which contains the

[Libguestfs] [PATCH 3/4] Fixes for various tests in out-of-tree builds

--- builder/test-config/virt-builder/repos.d/test-index.conf.in | 2 +- tests/9p/Makefile.am| 3 ++- tests/9p/test-9p.sh | 2 +- tests/disks/Makefile.am | 1 +

[Libguestfs] [PATCH 4/4] Fix out-of-tree build: Do not accidentally build mllib components in srcdir

--- builder/Makefile.am | 2 +- resize/Makefile.am | 2 +- sparsify/Makefile.am | 2 +- sysprep/Makefile.am | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index b3de967..387913c 100644 --- a/builder/Makefile.am +++

[Libguestfs] [PATCH 1/4] More fixes for situations where ocamlopt is not available

- run bindtests.opt only if available - use ocamlc -custom - Don't try to install native code if it hasn't been built (Thanks to Olaf Hering) --- mllib/Makefile.am | 2 +- ocaml/Makefile.am | 7 ++- ocaml/examples/Makefile.am | 11 --- ocaml/run-bindtests|

[Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

--- builder/Makefile.am| 18 +- configure.ac | 2 ++ mllib/Makefile.am | 60 +++--- ocaml/Makefile.am | 28 +++--- ocaml/examples/Makefile.am | 13 ++ resize/Makefile.am |

Re: [Libguestfs] OT: nbdkit packaging in debian

* Richard W.M. Jones: I was looking at this bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=725504 There's a related issue with the Debian packaging, which is that the package as a whole requires big dependencies (eg. libguestfs0). However these are not needed by the base package,

[Libguestfs] [PATCH] podwrapper: Recognize git-style dates in ChangeLog

--- podwrapper.pl.in | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/podwrapper.pl.in b/podwrapper.pl.in index 9bceec3..61d5e12 100755 --- a/podwrapper.pl.in +++ b/podwrapper.pl.in @@ -235,9 +235,17 @@ my $date; my $filename = $abs_top_srcdir/ChangeLog; if (-r

[Libguestfs] [PATCH 2/2] nbdkit: Retrieve libperl linking information from ExtUtils::Embed

perl -MConfig -e 'print $Config{ldflags}' gave me -lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt with Perl 5.18 as configured on Debian/unstable. --- configure.ac | 15 +-- plugins/perl/Makefile.am | 4 +--- 2 files changed, 6 insertions(+), 13

[Libguestfs] [PATCH 1/2] nbdkit: Work around what seems like an bug in automake 1.14

AM_INIT_AUTOMAKE(foreign) dnl ... seems to trigger Debian bug#738716 --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ee9d377..df31014 100644 --- a/configure.ac +++ b/configure.ac @@ -35,7 +35,8 @@ AC_CONFIG_MACRO_DIR([m4])

[Libguestfs] [PATCH 1/2] hivex: Use correct constant in diagnostic error message

--- lib/value.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/value.c b/lib/value.c index c4e21ec..f222b41 100644 --- a/lib/value.c +++ b/lib/value.c @@ -334,7 +334,7 @@ hivex_value_value (hive_h *h, hive_value_h value, /* Arbitrarily limit the length that we will

[Libguestfs] [PATCH 2/2] hivex: Bump value size limit

I actually encountered a binary value with 1033680 bytes. --- lib/hivex-internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hivex-internal.h b/lib/hivex-internal.h index 7f4cc3c..bfd24c8 100644 --- a/lib/hivex-internal.h +++ b/lib/hivex-internal.h @@ -321,7 +321,7

[Libguestfs] [PATCH] hivex: python: value_value no longer generates Unicode strings

This fixes Github issue #2 reported by kupiakos. https://github.com/libguestfs/hivex/issues/2 --- generator/generator.ml | 2 +- python/t/210-setvalue.py | 26 +- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/generator/generator.ml

[Libguestfs] [PATCH] hivex: ruby: Support 'make INSTALLDIRS=vendor install' for Ruby

(This is the same change as 87c9ec881cb695724e01d9f6fc9df996d4c67cb6 in libguestfs.) --- ruby/Makefile.am | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ruby/Makefile.am b/ruby/Makefile.am index e78ab59..7a5fe42 100644 --- a/ruby/Makefile.am +++

[Libguestfs] [PATCH] hivex: ruby: Minor fix for building with Ruby 1.8

--- ruby/Rakefile.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ruby/Rakefile.in b/ruby/Rakefile.in index 204e37c..5ad1502 100644 --- a/ruby/Rakefile.in +++ b/ruby/Rakefile.in @@ -22,7 +22,7 @@ require 'rake/testtask' # Used to be rake/rdoctask. Now it's rdoc/task.

[Libguestfs] hivex -- time for 1.3.9?

* Richard W.M. Jones: ACK, same as this libguestfs fix: It looks like I might be able to ship the Debian package for the next version without any specific patches. Hooray! I believe that I have pushed all the changes that I needed in the hivex library itself. How about doing another release?

[Libguestfs] [PATCH 1/4] hivex: Python 2.6 does not have sysconfig.

--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 6785037..203f34f 100644 --- a/configure.ac +++ b/configure.ac @@ -329,8 +329,8 @@ AS_IF([test x$enable_python != xno], AC_MSG_CHECKING([for Python extension

[Libguestfs] [PATCH 2/4] hivex: python: Fix encoding for special test script

Hopefully. Python's unicode history is a mess. --- python/t/130-special.py | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/python/t/130-special.py b/python/t/130-special.py index 7adb9d5..f0ac008 100755 --- a/python/t/130-special.py +++

[Libguestfs] [PATCH 1/2] hivex: ruby: find files to install in correct directories when building out-of-tree

--- ruby/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ruby/Makefile.am b/ruby/Makefile.am index b6654d3..e78ab59 100644 --- a/ruby/Makefile.am +++ b/ruby/Makefile.am @@ -51,7 +51,7 @@ RUBY_SITEARCH := $(shell $(RUBY) -rrbconfig -e puts

[Libguestfs] [PATCH 1/3] ruby: Fix tests for out-of-tree build, simplify test scripts

--- configure.ac | 1 + ruby/run-ruby-tests| 27 --- ruby/run-ruby-tests.in | 27 +++ ruby/tests/tc_010_load.rb | 2 -- ruby/tests/tc_021_close.rb | 2 -- ruby/tests/tc_120_rlenvalue.rb | 4 +---

[Libguestfs] [PATCH 3/3] ruby: Add test for special keys and values

--- ruby/tests/tc_130_special.rb | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 ruby/tests/tc_130_special.rb diff --git a/ruby/tests/tc_130_special.rb b/ruby/tests/tc_130_special.rb new file mode 100644 index 000..0623f4d --- /dev/null +++

[Libguestfs] [PATCH 2/7 take 2] lib: Use vk-len for string conversion

--- lib/value.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/value.c b/lib/value.c index 65404d7..7b2e9d3 100644 --- a/lib/value.c +++ b/lib/value.c @@ -207,14 +207,14 @@ hivex_value_key (hive_h *h, hive_value_h value) struct ntreg_vk_record *vk =

Re: [Libguestfs] [PATCH 2/7] lib: Use vk-len for string conversion

* Richard W.M. Jones: On Mon, Jan 13, 2014 at 01:17:52PM +, Richard W.M. Jones wrote: Is there a reason for this patch? It seems like just an optimization. OK, I see that the reason is to avoid calling _hivex_utf8_strlen which would fail for the name containing a \0 character. However

Re: [Libguestfs] [PATCH 5/7] perl: Properly decode node names, value keys from UTF-8

* Richard W.M. Jones: I wonder what happens if the registry contains a garbage string (one which is not valid utf-8)? This should not happen because libhivex passes those strings through iconv. Cheers, -Hilko ___ Libguestfs mailing list

Re: [Libguestfs] [PATCH] Add a minimal hive with special keys and values

* Richard W.M. Jones: So there's no problem with adding this test data, but are you planning to also add some tests :-? Sure. Working on it. Good that you asked for tests, btw. Another bugfix patch or two will be on the way. :-) Cheers, -Hilko ___

[Libguestfs] [PATCH 2/7] lib: Use vk-len for string conversion

--- lib/value.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/value.c b/lib/value.c index 65404d7..e700c84 100644 --- a/lib/value.c +++ b/lib/value.c @@ -207,14 +207,8 @@ hivex_value_key (hive_h *h, hive_value_h value) struct ntreg_vk_record *vk = (struct

[Libguestfs] [PATCH 4/7] python: Add test for special keys and values

--- python/t/130-special.py | 28 1 file changed, 28 insertions(+) create mode 100755 python/t/130-special.py diff --git a/python/t/130-special.py b/python/t/130-special.py new file mode 100755 index 000..7adb9d5 --- /dev/null +++ b/python/t/130-special.py @@

[Libguestfs] [PATCH 1/7] Add a minimal hive with special keys and values

+ character) +- A key 'asdf_äöüß' containing a REG_DWORD value 'asdf_äöüß' +- A key 'weird™' containing a REG_DWORD value 'symbols $£₤₧€' (SMALL + DOLLAR SIGN, FULLWIDTH POUND SIGN, PESETA SIGN, EURO SIGN) + +- Hilko Bengen 2014-01-10. diff --git a/images/mkzero/Makefile b/images/mkzero/Makefile new file

[Libguestfs] [PATCH 3/7] perl: Add test for special keys and values

--- perl/t/130-special.t | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 perl/t/130-special.t diff --git a/perl/t/130-special.t b/perl/t/130-special.t new file mode 100644 index 000..c25af7e --- /dev/null +++ b/perl/t/130-special.t @@ -0,0 +1,34

  1   2   >