Re: [Libguestfs] regression: file does not understand the -S option

2023-09-21 Thread Olaf Hering
Thu, 21 Sep 2023 10:21:41 +0200 Laszlo Ersek : > Does your error output contain > file: invalid option -- 'S' > ? Yes, it looks like this: # /usr/bin/env -i /usr/bin/file -S /usr/bin/file: invalid option -- 'S' Usage: file [-bcEhikLlNnprsvzZ0] [--apple] [--extension] [--mime-encoding]

[Libguestfs] regression: file does not understand the -S option

2023-09-20 Thread Olaf Hering
Recently a commit was added to call 'file -zSb' instead of 'file -zb'. This causes a regression on Leap 15 (but not on Tumbleweed), because file 5.32 does not understand the -S option. How can this be fixed properly, to handle both cases either at runtime or at buildtime? Thanks, Olaf

Re: [Libguestfs] [PATCH v1] docs: domain: document legacy audio for qemu

2022-01-12 Thread Olaf Hering
Wed, 12 Jan 2022 13:32:23 +0100 Laszlo Ersek : > should have been sent to the libvirt mailing list Indeed, sorry for not paying attention. Olaf pgpjwlKFqkQUP.pgp Description: Digitale Signatur von OpenPGP ___ Libguestfs mailing list

[Libguestfs] [PATCH v1] docs: domain: document legacy audio for qemu

2022-01-12 Thread Olaf Hering
Adding a blurb like this was forgotten in 2009. Signed-off-by: Olaf Hering --- docs/formatdomain.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index d4f30bb8af..f07ea34232 100644 --- a/docs/formatdomain.rst +++ b/docs

[Libguestfs] [PATCH v1] appliance: reorder mounting of special filesystems in init

2021-09-15 Thread Olaf Hering
Make sure proc and dev are available early. No change in behavior intended. Signed-off-by: Olaf Hering --- appliance/init | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) diff --git a/appliance/init b/appliance/init index cdc39c3b9..7076821d2 100755

[Libguestfs] [PATCH v1] appliance: enable bash's Process Substitution feature

2021-09-15 Thread Olaf Hering
in Leap 15.3, the symlink is not created anymore. As a result scripts, such as /sbin/dhclient-script, fail to work properly. This symlink should have been created in version 1 of this variant of /init. https://bugzilla.opensuse.org/show_bug.cgi?id=1190501 Signed-off-by: Olaf Hering --- appliance

[Libguestfs] [PATCH v1] appliance: add reboot and netconfig for SUSE

2021-09-14 Thread Olaf Hering
with --network, dhclient will run /usr/sbin/dhclient-script, which in turn may call /sbin/netconfig to update /etc/resolv.conf. Install sysconfig-netconfig to make sure DNS resolving actually works. Signed-off-by: Olaf Hering --- appliance/packagelist.in | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Libguestfs] [PATCH 0/2] daemon: Replace GUESTFSD_EXT_CMD with --print-external-commands.

2017-07-27 Thread Olaf Hering
On Thu, Jul 27, Richard W.M. Jones wrote: > Shall we just remove all this? If there is no usecase anymore, go ahead. Olaf signature.asc Description: PGP signature ___ Libguestfs mailing list Libguestfs@redhat.com

Re: [Libguestfs] [PATCH 0/2] daemon: Replace GUESTFSD_EXT_CMD with --print-external-commands.

2017-07-27 Thread Olaf Hering
On Thu, Jul 27, Richard W.M. Jones wrote: > It is used: > https://build.opensuse.org/package/view_file/openSUSE:Factory/libguestfs/libguestfs.spec?rev=7 This is rev#7, which is not the latest. Olaf signature.asc Description: PGP signature ___

Re: [Libguestfs] [PATCH] listfs: ignore the default btrfs subvolume

2016-02-25 Thread Olaf Hering
On Thu, Feb 25, Richard W.M. Jones wrote: > Was there an RHBZ# for this? Can't seem to find it ... Maybe it helps to improve btrfs support. As stated earlier, btrfs is a container of things instead of a plain filesystem. Its unfortunate that the default subvolume was invented, its perhaps just

Re: [Libguestfs] [PATCH] inspect: try to use /etc/os-release on Linux guests

2015-09-09 Thread Olaf Hering
Just poked around in my =libguestfs folder... On Wed, Sep 09, Pino Toscano wrote: > +if (STRPREFIX (line, "ID=")) { This is not handled: NAME="SLES" VERSION="12" VERSION_ID="12" PRETTY_NAME="SUSE Linux Enterprise Server 12" ID="sles" ANSI_COLOR="0;32" CPE_NAME="cpe:/o:suse:sles:12" Olaf

Re: [Libguestfs] [PATCH] inspect: try to use /etc/os-release on Linux guests

2015-09-09 Thread Olaf Hering
On Wed, Sep 09, Pino Toscano wrote: > - the content of /etc/SuSE-release SUSE Linux Enterprise Server 12 (x86_64) VERSION = 12 PATCHLEVEL = 0 # This file is deprecated and will be removed in a future service pack or release. # Please check /etc/os-release for details about this release. > -

Re: [Libguestfs] missing btrfs subvol support

2015-09-09 Thread Olaf Hering
On Fri, Oct 10, Olaf Hering wrote: > Is btrfs subvol support failing just for me? This is an old thread, and it seems the underlying bug is not fixed because guestfs takes the wrong approach, IMO. >From how I understand btrfs, it has the concept of subvolumes. Each one is an entry

Re: [Libguestfs] make install of ocaml libs fails

2014-10-21 Thread Olaf Hering
On Mon, Oct 20, Richard W.M. Jones wrote: I can understand why this happens: ocamlfind install will see that /usr/lib64/ocaml/guestfs already contains the installed package, and refuse to install it on top. One day I will try to understand what the ocaml folks think when they do

Re: [Libguestfs] missing btrfs subvol support

2014-10-17 Thread Olaf Hering
On Thu, Oct 16, Olaf Hering wrote: I can probably add a check somewhere to catch the whatever==@. A better fix would be to check if a given subvolume is for the entire partition. So after talking to David Sterba there is no way to tell if a given subvolume is for the entire partition. Also my

Re: [Libguestfs] missing btrfs subvol support

2014-10-17 Thread Olaf Hering
On Fri, Oct 17, Pino Toscano wrote: On Friday 17 October 2014 11:25:03 Olaf Hering wrote: On Thu, Oct 16, Olaf Hering wrote: I can probably add a check somewhere to catch the whatever==@. A better fix would be to check if a given subvolume is for the entire partition. So after

[Libguestfs] make install of ocaml libs fails

2014-10-16 Thread Olaf Hering
Today I did it, for the very first time: Did not build a package. Just ran make install. Twice! ... ocamlfind install \ -ldconf ignore -destdir /usr/lib64/ocaml \ guestfs \ META *.so *.a *.cma *.cmi ./*.mli *.cmx *.cmxa ocamlfind: Package guestfs is already installed - (file

Re: [Libguestfs] missing btrfs subvol support

2014-10-16 Thread Olaf Hering
On Fri, Oct 10, Mike Latimer wrote: On Friday, October 10, 2014 03:07:51 PM Olaf Hering wrote: Thanks for the pointers. I will poke around. At least augtool on the host seems to behave correctly: I don't think this is related to Augeas. Instead, I think it's the naming convention SUSE

[Libguestfs] [PATCH] btrfs: list only subvolumes below path

2014-10-16 Thread Olaf Hering
mount -osubvol=boot/grub2/i386-pc $dev /sysroot will fail, while mount -osubvol=@/boot/grub2/i386-pc $dev /sysroot will succeed. Signed-off-by: Olaf Hering o...@aepfle.de --- daemon/btrfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index

Re: [Libguestfs] missing btrfs subvol support

2014-10-13 Thread Olaf Hering
On Fri, Oct 10, Richard W.M. Jones wrote: We use Augeas to parse the /etc/fstab btrfs entries, see src/inspect-fs-unix.c: check_fstab: https://github.com/libguestfs/libguestfs/blob/master/src/inspect-fs-unix.c#L1089 And we then pass the subvol back to the mount command in daemon/mount.c

[Libguestfs] missing btrfs subvol support

2014-10-10 Thread Olaf Hering
Is btrfs subvol support failing just for me? Looks like nothing adds the required '@/' string. virt-ls uses the first variant of the command: rescue mount -vo subvol=var/spool,ro /dev/sda2 /sysroot/ [ 113.852047] BTRFS info (device sda2): disk space caching is enabled [ 113.852869] BTRFS: has

Re: [Libguestfs] missing btrfs subvol support

2014-10-10 Thread Olaf Hering
On Fri, Oct 10, Richard W.M. Jones wrote: My guess is that the last one (opt/value) will be different for you. Thanks for the pointers. I will poke around. At least augtool on the host seems to behave correctly: olaf@bax:~ $ cd /dev/shm/$$ bash: cd: /dev/shm/3570: Datei oder Verzeichnis nicht

Re: [Libguestfs] Plan for libguestfs 1.28

2014-10-09 Thread Olaf Hering
On Tue, Oct 07, Richard W.M. Jones wrote: It has been an amazing 6½ months since the last stable release of libguestfs. I'd like to plan a new 1.28 release soon. Please follow-up if there are features / blockers / bugs that need to be addressed for 1.28. I see master failing in my SLE11

Re: [Libguestfs] Plan for libguestfs 1.28

2014-10-09 Thread Olaf Hering
On Thu, Oct 09, Olaf Hering wrote: I see master failing in my SLE11 builds since some time. Currently it fails with a syntax error. Are bison-2.3 of flex-2.5.35 too old? The last successful build was 1.27.9, next commit was 1.27.46. Olaf

Re: [Libguestfs] Plan for libguestfs 1.28

2014-10-09 Thread Olaf Hering
On Thu, Oct 09, Richard W.M. Jones wrote: Is there a chance of using a newer version of bison? The alternative might be to see if reverting that patch still works, and carrying the revert as a downstream patch. I will try to build a copy of bison before starting libguestfs, that should cure

Re: [Libguestfs] [PATCH v2 1/4] appliance: Use dhclient instead of hard-coding IP address of appliance.

2014-10-02 Thread Olaf Hering
On Thu, Oct 02, Richard W.M. Jones wrote: +if grep -sq guestfs_network=1 /proc/cmdline; then +dhclient +fi dhclient will be missing at least in openSUSE. Not an issue now, does the script fail if the command fails to execute due to ENOENT? Olaf

Re: [Libguestfs] [PATCH v2 1/4] appliance: Use dhclient instead of hard-coding IP address of appliance.

2014-10-02 Thread Olaf Hering
On Thu, Oct 02, Richard W.M. Jones wrote: The script won't fail, but the network won't work. What's the alternative on SuSE? I think that would be dhcpcd, which is also used by NetworkManager. Olaf ___ Libguestfs mailing list Libguestfs@redhat.com

Re: [Libguestfs] [PATCH v2 1/4] appliance: Use dhclient instead of hard-coding IP address of appliance.

2014-10-02 Thread Olaf Hering
On Thu, Oct 02, Richard W.M. Jones wrote: It seems as if it would, from reading the dhcpcd man page .. Looks like the syntax is 'dhcpcd interface'. Olaf ___ Libguestfs mailing list Libguestfs@redhat.com

Re: [Libguestfs] [PATCH v2 1/4] appliance: Use dhclient instead of hard-coding IP address of appliance.

2014-10-02 Thread Olaf Hering
On Thu, Oct 02, Richard W.M. Jones wrote: I'm mainly worried that we won't know how interfaces are named, although the old code assumed eth0 and appeared to work until now. Yes. And if the appliance is booted with net.ifnames=0, or whatever keeps systemd out of the picture, the name will be

Re: [Libguestfs] [PATCH v2 1/4] appliance: Use dhclient instead of hard-coding IP address of appliance.

2014-10-02 Thread Olaf Hering
On Thu, Oct 02, Olaf Hering wrote: On Thu, Oct 02, Richard W.M. Jones wrote: The script won't fail, but the network won't work. What's the alternative on SuSE? I think that would be dhcpcd, which is also used by NetworkManager. Scratch that. At least in SLED12 dhclient comes from dhcp

Re: [Libguestfs] Xen drivers for virt-builder images

2014-06-12 Thread Olaf Hering
On Thu, Jun 12, Richard W.M. Jones wrote: dracut --add-drivers some list of xen kmods ... Whatever you do: please use modaliases like 'xen:vbd xen:vif' or whatever the actual name is. Olaf ___ Libguestfs mailing list Libguestfs@redhat.com

[Libguestfs] new warnings in hivex-1.3.10

2014-05-13 Thread Olaf Hering
hivex-1.3.10 does not pass the sles11sp3 post-build-checks anymore, 1.3.8 was still ok. The relevant output is: ... [ 57s] Hivex.xs: In function 'XS_Win__Hivex_node_name': [ 57s] Hivex.xs:236: warning: implicit declaration of function 'newSVpvn_utf8' [ 57s] Hivex.xs:236: warning:

Re: [Libguestfs] [PATCH supermin v4] Supermin 5 rewrite.

2014-03-28 Thread Olaf Hering
On Tue, Feb 25, Richard W.M. Jones wrote: configure.ac | 27 +- Commit breaks expectations during pkg build. Before commit 29eb7d6a0 (configure: Use AC_PATH_PROG for package manager binaries.) it was possible to pass an executable via environment like env ZYPPER=zypper

Re: [Libguestfs] [PATCH supermin v4] Supermin 5 rewrite.

2014-03-28 Thread Olaf Hering
On Fri, Mar 28, Richard W.M. Jones wrote: I guess the question from me is why the user would want to use zypper from $PATH, instead of zypper which supermin had been configured and tested against? Is it common that SUSE users want to try different versions of zypper? It might be a corner

Re: [Libguestfs] ANNOUNCE: libguestfs 1.26 released

2014-03-28 Thread Olaf Hering
On Thu, Mar 27, Richard W.M. Jones wrote: I'm pleased to announce libguestfs 1.26, a library and set of tools This fails to link at least in sles11sp3, 1.25.37 was still ok: ... [ 288s] virt_index_validate-index-validate.o: In function `main': [ 288s] index-validate.c:(.text+0x94): undefined

Re: [Libguestfs] ANNOUNCE: libguestfs 1.26 released

2014-03-28 Thread Olaf Hering
On Fri, Mar 28, Richard W.M. Jones wrote: I'd say this is a gnulib problem, although why gnulib has decided to use replacement functions is a mystery. My understanding is that getopt_long is part of glibc, so gnulib shouldn't need to replace it. Did ./configure output mention getopt*? If

Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

2014-03-11 Thread Olaf Hering
On Fri, Feb 28, Richard W.M. Jones wrote: I can't test if it will specifically break this because I don't have access to any machines that don't have ocamlopt, but it's something to watch out for. In any case, I have pushed this since it works fine for me. Any chance this can be backported

Re: [Libguestfs] enable build for ocaml bytecode

2014-02-28 Thread Olaf Hering
On Fri, Feb 28, Richard W.M. Jones wrote: I believe this patch has now been superseded by Hilko's commit here: I'm backporting it right now, will send my version once it actually builds. Olaf ___ Libguestfs mailing list Libguestfs@redhat.com

Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available

2014-02-28 Thread Olaf Hering
On Fri, Feb 28, Hilko Bengen wrote: --- builder/Makefile.am| 18 +- configure.ac | 2 ++ mllib/Makefile.am | 60 +++--- ocaml/Makefile.am | 28 +++--- Something like this is

Re: [Libguestfs] enable build for ocaml bytecode

2014-02-26 Thread Olaf Hering
On Thu, Jan 17, Richard W.M. Jones wrote: On Wed, Jan 16, 2013 at 05:51:53PM +0100, Olaf Hering wrote: On Mon, Jan 14, Olaf Hering wrote: This is a first attempt to build libguestfs with just a ocaml bytecode compiler. The three tools written in ocaml will be build only when

[Libguestfs] progress output during guestfish sh commands

2014-02-04 Thread Olaf Hering
Is there any way to flush the output of a long running 'guestfish sh cmd.sh' call? It seems to me that output is only shown once cmd.sh has finished. I already split cmd.sh into smaller pieces to see overall progress. But output from a verbose, long running single command within cmd.sh is not

Re: [Libguestfs] progress output during guestfish sh commands

2014-02-04 Thread Olaf Hering
On Tue, Feb 04, Richard W.M. Jones wrote: It seems to me that output is only shown once cmd.sh has finished. I already split cmd.sh into smaller pieces to see overall progress. But output from a verbose, long running single command within cmd.sh is not shown. Verbose output is carried

[Libguestfs] [PATCH] appliance: Disable ipv6 in the appliance because qemu usernet is ipv4 only

2014-01-23 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de --- Untested in this environment. appliance/init | 4 1 file changed, 4 insertions(+) diff --git a/appliance/init b/appliance/init index b25ea26..cc8c978 100755 --- a/appliance/init +++ b/appliance/init @@ -71,6 +71,10 @@ for f in /sys/block/{h,s

Re: [Libguestfs] [PATCH] appliance: Disable ipv6 in the appliance because qemu usernet is ipv4 only

2014-01-23 Thread Olaf Hering
On Thu, Jan 23, Olaf Hering wrote: +++ b/appliance/init # Update the system clock. hwclock -u -s Why is that needed? Just wondering... Olaf ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] mke2fs fails due to wipefs --force

2014-01-20 Thread Olaf Hering
On Sun, Jan 19, Richard W.M. Jones wrote: How about the attached patch (only compile-tested)? This patch works for me. Thanks. Olaf ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] guestfish and luks-format

2014-01-20 Thread Olaf Hering
On Mon, Jan 20, Richard W.M. Jones wrote: For example: $ echo 123456 | guestfish -x --keys-from-stdin -N part luks-format /dev/sda1 0 thanks, I changed my code like this: ( echo 123456 echo 123456 ) | \ guestfish \ -x \ --keys-from-stdin \ \ luks-format $part 0 : \

Re: [Libguestfs] newlines with write-append

2014-01-20 Thread Olaf Hering
On Mon, Jan 20, Richard W.M. Jones wrote: Have you considered using a real programming language, like Perl + Sys::Guestfs, Python + guestfs etc.? Whenever I bump into the limits of guestfish, I usually turn to Perl. For my hackery I will use guestfish because I'm used to it. Olaf

[Libguestfs] mke2fs fails due to wipefs --force

2014-01-19 Thread Olaf Hering
My wipefs has no --force option, as a result mke2fs command in guestfish fails. Looks like 72dd398679cd0bb803daf306d12558369615ba70 needs an adjustment to make use of do_wipefs? Also str_wipefs is not used in that file. Olaf ___ Libguestfs mailing

[Libguestfs] [PATCH] daemon: add missing GUESTFSD_EXT_CMD usage

2014-01-19 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de --- Not even compile tested, against 1.24 branch. daemon/btrfs.c | 2 +- daemon/command.c | 3 ++- daemon/debug.c | 3 ++- daemon/ldm.c | 4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index

Re: [Libguestfs] [PATCH] sysprep: handle distro specific sysv scripts

2013-12-12 Thread Olaf Hering
On Thu, Dec 12, Pino Toscano wrote: What do you think? I think that your Should-Start handling is broken. Required means the given file can not properly work without the listed servers, insserv will error out. Should means it can very well work without them if they are not present or enabled.

[Libguestfs] augeas changes in stable branches

2013-10-18 Thread Olaf Hering
commit f59b87f7f18d9df89ff9940a317ff1fb452cbd28 breaks compile with older augeas (0.7.4). AFAIK there is no requirement for augeas 1.0 until 1.24. augeas.c: In function 'do_aug_init': augeas.c:102:38: error: 'AUG_NO_ERR_CLOSE' undeclared (first use in this function) Olaf

Re: [Libguestfs] augeas changes in stable branches

2013-10-18 Thread Olaf Hering
On Fri, Oct 18, Richard W.M. Jones wrote: On Fri, Oct 18, 2013 at 11:15:54AM +0200, Olaf Hering wrote: commit f59b87f7f18d9df89ff9940a317ff1fb452cbd28 breaks compile with older augeas (0.7.4). AFAIK there is no requirement for augeas 1.0 until 1.24. augeas.c: In function

[Libguestfs] --disable-appliance creates supermin.d files

2013-08-22 Thread Olaf Hering
Why does the toplevel Makefile process appliance/, and creates supermin.d during make install, whith configure --disable-appliance? I have to double check what actually happens, it seems it causes startup failures if the resulting binary packages are started on a host that happens to have

Re: [Libguestfs] missing mount cmd confuses guestfish

2013-08-22 Thread Olaf Hering
On Sun, Aug 18, Olaf Hering wrote: I think calling sh before mount should not confuse guestfish like that: # guestfish (1.20.4 on sles11sp3) Doing the same, by accident, with 1.22.5 causes a crash: # guestfish -r -v --network fs add-drive /work/kvm/images/opensuse12.3/disk0.raw fs

[Libguestfs] [PATCH] daemon: fix build without systemd-journal

2013-08-20 Thread Olaf Hering
Fix typo in OPTGROUP_JOURNAL_NOT_AVAILABLE Define empty journal_finalize, called by mount.c Signed-off-by: Olaf Hering o...@aepfle.de --- daemon/journal.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/daemon/journal.c b/daemon/journal.c index 0cb50e3..97e1874 100644

[Libguestfs] [PATCH] lib: avoid pragma usage in journal.c

2013-08-20 Thread Olaf Hering
]: *** [libguestfs_la-journal.lo] Error 1 Signed-off-by: Olaf Hering o...@aepfle.de --- Not compiled. src/journal.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/journal.c b/src/journal.c index cac8040..61ab352 100644 --- a/src/journal.c +++ b/src/journal.c @@ -117,10 +117,8

[Libguestfs] OPTGROUP_SD_JOURNAL_NOT_AVAILABLE

2013-08-19 Thread Olaf Hering
Current master fails to build if certain systemd functionality is not available at build time, daemon/journal.c has OPTGROUP_SD_JOURNAL_NOT_AVAILABLE at the end of the file. Is this a typo, what should be done in that case? ___ Libguestfs mailing list

[Libguestfs] [PATCH] tests: change noinst to check

2013-08-19 Thread Olaf Hering
This change avoids the hard requirement for qemu-tools during package build. Signed-off-by: Olaf Hering o...@aepfle.de --- The current OPTGROUP_SD_JOURNAL_NOT_AVAILABLE failure blocks a complete build for me, I think the build got past the point of the failure fixed by this patch. tests/data

Re: [Libguestfs] missing chdir before chroot in guestfsd

2013-08-19 Thread Olaf Hering
On Mon, Aug 19, Richard W.M. Jones wrote: If you look at the upstream code, this has been fixed, or at least, the code is quite different. See: commit 2aa731e7c441581f0d72bcd06e9431b92931466a It does not happen with 1.23.17. Thanks. Olaf ___

[Libguestfs] missing mount cmd confuses guestfish

2013-08-18 Thread Olaf Hering
I think calling sh before mount should not confuse guestfish like that: # guestfish (1.20.4 on sles11sp3) Welcome to guestfish, the libguestfs filesystem interactive shell for editing virtual machine filesystems. Type: 'help' for help on commands 'man' to read the manual 'quit' to

[Libguestfs] [PATCH / RFC] Handle --packager-config in zypp_rpm

2013-06-04 Thread Olaf Hering
in various distributions, copies of the original sources can be found via google. This patch has received some light testing, I sent it out to the list for further comments. Particular about the new inifiles dependency.. Signed-off-by: Olaf Hering o...@aepfle.de --- src/Makefile.am | 2

[Libguestfs] [PATCH] Set DISTRO to SUSE if /etc/SuSE-release exists

2013-06-04 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de --- not compile-tested. configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure.ac b/configure.ac index 71f7b06..2db9593 100644 --- a/configure.ac +++ b/configure.ac @@ -519,6 +519,9 @@ fi if test -f /etc/arch-release

Re: [Libguestfs] [PATCH] Set DISTRO to SUSE if /etc/SuSE-release exists

2013-06-04 Thread Olaf Hering
On Tue, Jun 04, Richard W.M. Jones wrote: Looks fine. ACKed and pushed. Of course it'll need corresponding adjustments to appliance/packagelist.in, as I'm sure you're aware :-) Yes. Hopefully there will be a generic set of package names to support everything from SLES to Factory. Might be

Re: [Libguestfs] ATTN: Denial of service attack possible on libguestfs 1.21.x, libguestfs.1.22.0

2013-05-31 Thread Olaf Hering
On Fri, May 31, Richard W.M. Jones wrote: I don't see a problem in parse_lsb_release however. Do you have a stack trace from that? parse_lsb_release is fine, I was wrong. Olaf ___ Libguestfs mailing list Libguestfs@redhat.com

[Libguestfs] [PATCH] Change fallback name for external supermin helper

2013-05-31 Thread Olaf Hering
of supermin (if they are in PATH) with a given libguestfs binary package. Signed-off-by: Olaf Hering o...@aepfle.de --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 30af871..8f025d0 100644 --- a/configure.ac +++ b/configure.ac

Re: [Libguestfs] [PATCH] Change fallback name for external supermin helper

2013-05-31 Thread Olaf Hering
On Fri, May 31, Richard W.M. Jones wrote: On Fri, May 31, 2013 at 01:38:06PM +0200, Olaf Hering wrote: But this requires that febootstrap or supermin is in BuildRequires:, while this change removes the hard dependency of BuildRequires:. But I see, if the appliance is enabled then it would

[Libguestfs] Usage of 'no' as external helper

2013-05-30 Thread Olaf Hering
libguestfs and supermin use 'no' instead of either the basename of the desired application, or 'false', as helper string. This happens when configure does not find things like rpm or supermin during build. Wouldnt it be more logical to use the basename instead of 'no' so that at runtime one has

Re: [Libguestfs] Usage of 'no' as external helper

2013-05-30 Thread Olaf Hering
On Thu, May 30, Richard W.M. Jones wrote: On Thu, May 30, 2013 at 10:02:10PM +0200, Olaf Hering wrote: libguestfs and supermin use 'no' instead of either the basename of the desired application, or 'false', as helper string. This happens when configure does not find things like rpm

Re: [Libguestfs] ATTN: Denial of service attack possible on libguestfs 1.21.x, libguestfs.1.22.0

2013-05-30 Thread Olaf Hering
On Tue, May 28, Richard W.M. Jones wrote: There's a denial of service attack possible from guests on any program that does inspection (eg. virt-inspector, many other virt-* tools, virt-v2v, OpenStack). The attack causes the host process to crash because of a double free. It's probably

Re: [Libguestfs] [PATCH] handle --use-installed in zypp driver

2013-04-29 Thread Olaf Hering
On Thu, Apr 11, Olaf Hering wrote: + -m \stream/install-summary/to-install/solvable[%@type='package']\ \ + -c \string(%@name)\ -n This is supposed to be [@type='package'] and string(@name). Some of the ocaml printf docs made me believe that %@ is the way to print a single @. Now I see

[Libguestfs] [PATCH] always work with empty --root in zypp driver

2013-04-11 Thread Olaf Hering
the getuid check to force an empty root directory and use the configured system repositories. This works for root and non-root users. Signed-off-by: Olaf Hering o...@aepfle.de --- src/supermin_zypp_rpm.ml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/supermin_zypp_rpm.ml

[Libguestfs] [PATCH] handle --use-installed in zypp driver

2013-04-11 Thread Olaf Hering
An attempt to use installed files in zypp driver. Add also a comment about the theory of operation. Enable set -x in shell only in verbose mode. This adds a dependency to xmlstarlet, which is required to parse zypper output. Signed-off-by: Olaf Hering o...@aepfle.de --- src/supermin_zypp_rpm.ml

[Libguestfs] [PATCH] skip unreadable files in zypp_rpm_list_files

2013-04-11 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de --- src/supermin_zypp_rpm.ml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/supermin_zypp_rpm.ml b/src/supermin_zypp_rpm.ml index 720f50a..1c6243d 100644 --- a/src/supermin_zypp_rpm.ml +++ b/src/supermin_zypp_rpm.ml

[Libguestfs] [PATCH] add --with-supermin-extra-options configure option

2013-04-11 Thread Olaf Hering
Useful to pass --use-installed and other options to supermin. Signed-off-by: Olaf Hering o...@aepfle.de --- Not even compile tested!! Just copypaste from SUPERMIN_PACKAGER_CONFIG appliance/make.sh.in | 3 +++ configure.ac | 13 + 2 files changed, 16 insertions(+) diff

[Libguestfs] [PATCH 1/2] add run_shell helper

2013-04-09 Thread Olaf Hering
The new run_shell helper is a copy of run_python, and will be used by upcoming changes. Signed-off-by: Olaf Hering o...@aepfle.de --- src/supermin_utils.ml | 9 + src/supermin_utils.mli | 5 + 2 files changed, 14 insertions(+) diff --git a/src/supermin_utils.ml b/src

[Libguestfs] build failures due to missing rpl_optarg

2013-02-25 Thread Olaf Hering
For some reason 1.20.2 fails to link in openSuSE 11.4 and older, 1.20.1 did not have this issue. ... CCLD libguestfs-test-tool libguestfs_test_tool-test-tool.o: In function `main': test-tool.c:(.text+0x11f): undefined reference to `rpl_getopt_long' test-tool.c:(.text+0x170): undefined

Re: [Libguestfs] [PATCH] daemon: copy entire lvm directory

2013-01-18 Thread Olaf Hering
On Fri, Jan 18, Richard W.M. Jones wrote: On Thu, Jan 17, 2013 at 02:14:00PM +, Richard W.M. Jones wrote: On Wed, Jan 02, 2013 at 04:13:06PM +0100, Olaf Hering wrote: cp will fail if /etc/lvm is an empty directory. Copy the entire directory and adjust environment variable

Re: [Libguestfs] [PATCH] ruby: add -DGUESTFS_PRIVATE_FUNCTIONS=1 to CFLAGS

2013-01-17 Thread Olaf Hering
On Thu, Jan 17, Richard W.M. Jones wrote: On Wed, Jan 02, 2013 at 07:27:54PM +0100, Olaf Hering wrote: - #{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 + #{$CFLAGS} @CFLAGS@ -DGUESTFS_PRIVATE_FUNCTIONS=1 -DGUESTFS_PRIVATE_FUNCTIONS=1 @WARN_CFLAGS@ @WERROR_CFLAGS@ I may

Re: [Libguestfs] enable build for ocaml bytecode

2013-01-17 Thread Olaf Hering
On Thu, Jan 17, Richard W.M. Jones wrote: On Wed, Jan 16, 2013 at 05:51:53PM +0100, Olaf Hering wrote: On Mon, Jan 14, Olaf Hering wrote: This is a first attempt to build libguestfs with just a ocaml bytecode compiler. The three tools written in ocaml will be build only when

Re: [Libguestfs] enable build for ocaml bytecode

2013-01-16 Thread Olaf Hering
On Mon, Jan 14, Olaf Hering wrote: This is a first attempt to build libguestfs with just a ocaml bytecode compiler. The three tools written in ocaml will be build only when an ocamlopt compiler is available. Here is a more complete change which covers also resize, sysprep and sparsify. ocaml

[Libguestfs] enable build for ocaml bytecode

2013-01-14 Thread Olaf Hering
This is a first attempt to build libguestfs with just a ocaml bytecode compiler. The three tools written in ocaml will be build only when an ocamlopt compiler is available. Olaf --- Makefile.am |5 - configure.ac |2 ++ ocaml/Makefile.am| 20

[Libguestfs] rb_alloc_func_t undeclared in ruby 1.8

2013-01-03 Thread Olaf Hering
ruby bindings fail to build with ruby 1.8.7 because rb_alloc_func_t does not exist in this version of ruby. This happens due to commit 448a02373df95dafc0d4b3e4db0e77c96a09074d Olaf ___ Libguestfs mailing list Libguestfs@redhat.com

[Libguestfs] [PATCH] daemon: copy entire lvm directory

2013-01-02 Thread Olaf Hering
cp will fail if /etc/lvm is an empty directory. Copy the entire directory and adjust environment variable. Signed-off-by: Olaf Hering o...@aepfle.de --- daemon/lvm-filter.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/daemon/lvm-filter.c b/daemon/lvm-filter.c

[Libguestfs] [PATCH] ruby: add -DGUESTFS_PRIVATE_FUNCTIONS=1 to CFLAGS

2013-01-02 Thread Olaf Hering
Signed-off-by: Olaf Hering o...@aepfle.de --- This, and the CFLAGS change it depends on should be backported to 1.20.x ruby/ext/guestfs/extconf.rb.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ruby/ext/guestfs/extconf.rb.in b/ruby/ext/guestfs/extconf.rb.in index 15259ea

Re: [Libguestfs] febootstrap and zypper

2012-11-30 Thread Olaf Hering
On Fri, Nov 30, Richard W.M. Jones wrote: On Thu, Nov 29, 2012 at 10:24:54PM +0100, Olaf Hering wrote: On Thu, Nov 29, Richard W.M. Jones wrote: On Thu, Nov 29, 2012 at 09:02:34PM +, Richard W.M. Jones wrote: zypper \ --verbose \ --verbose

[Libguestfs] febootstrap and zypper

2012-11-29 Thread Olaf Hering
On Mon, Oct 08, Richard W.M. Jones wrote: On Mon, Oct 08, 2012 at 08:50:47PM +0200, Olaf Hering wrote: On Mon, Oct 08, Richard W.M. Jones wrote: But out of interest, how are you creating this appliance? I thought we'd ripped out support for old-style appliances from the rest

[Libguestfs] [PATCH] lua: fix build error due to LUA_GLOBALSINDEX usage

2012-11-23 Thread Olaf Hering
lua 5.2 changed API, LUA_GLOBALSINDEX is no longer available. http://www.lua.org/manual/5.2/manual.html#8.3 Signed-off-by: Olaf Hering o...@aepfle.de --- Fix is only compile tested. generator/lua.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generator/lua.ml b

Re: [Libguestfs] [PATCH] sysprep: remove crash data generated by kexec-tools

2012-11-21 Thread Olaf Hering
On Wed, Nov 21, Wanlong Gao wrote: + heading = s_Remove the crash data generated by kexec-tools; + pod_description = Some (s_\ +Remove the automatically generated kdump kernel crash data in +C/var/crash/.); Is that the standard location? At least in SLES its /var/log/dump/ Olaf

Re: [Libguestfs] Notes on compiling libguestfs 1.19.59 on Debian 7 (Wheezy) beta

2012-11-14 Thread Olaf Hering
61db8e97180efa70243d8b7b116f11ca1f36b375 Mon Sep 17 00:00:00 2001 # From: Olaf Hering o...@aepfle.de # Date: Mon, 3 Sep 2012 19:50:44 +0200 # Subject: [PATCH] force virtio_blk in old guest kernel Signed-off-by: Olaf Hering o...@aepfle.de --- df/output.c| 13 + fish/options.c | 8 +++- src

Re: [Libguestfs] building resize fails due to lack of Unix module

2012-10-22 Thread Olaf Hering
On Mon, Oct 22, Richard W.M. Jones wrote: This is actually a bug in resize/Makefile.am introduced by a0722c7a. It was masked if you had the optional ocaml-gettext package installed because that implicitly depends on Unix. Try the attached patch. Thanks, this patch fixes the build failures.

[Libguestfs] building resize fails due to lack of Unix module

2012-10-19 Thread Olaf Hering
Building 1.9.53 fails for me with ocaml 3.10.2 and 3.12.1, likely due to commit a0722c7ad846960be54978a31ebe73b76e119203: [ 318s] ocamlfind ocamlopt -g -warn-error CDEFLMPSUVYZX -package str -I ../src/.libs -I ../ocaml \ [ 318s] mlguestfs.cmxa -linkpkg ../fish/guestfish-progress.o

[Libguestfs] cdrom device handling

2012-10-12 Thread Olaf Hering
Is there a way for the tools to provide a configured cdrom as cdrom to the temporary guest? Right now both disk and cdrom retrived from libvirt will showup as disks in the temporary guest. This happens for bus ide and scsi. It seems on my test system the guest can not start from a scsi disk, but

Re: [Libguestfs] [PATCH] launch: show hint to resolve authentication failure from libvirt

2012-10-12 Thread Olaf Hering
On Wed, Oct 10, Richard W.M. Jones wrote: libguestfs use of libvirt is a bit of a mess at the moment, since we end up opening two connections if you use the -d option ... this is something I'm intending to fix. Nevertheless, it should be using NULL everywhere, so depending on whether you

Re: [Libguestfs] [PATCH] launch: show hint to resolve authentication failure from libvirt

2012-10-12 Thread Olaf Hering
On Fri, Oct 12, Richard W.M. Jones wrote: On Fri, Oct 12, 2012 at 04:20:50PM +0200, Olaf Hering wrote: On Wed, Oct 10, Richard W.M. Jones wrote: libguestfs use of libvirt is a bit of a mess at the moment, since we end up opening two connections if you use the -d option

Re: [Libguestfs] cdrom device handling

2012-10-12 Thread Olaf Hering
On Fri, Oct 12, Richard W.M. Jones wrote: virt-rescue should come up with the disk and CD-ROM as /dev/sda and /dev/sdb respectively. This should be enough to read the data off the CD (/dev/sdb). What else would you want to do? I have not tried it, but I can imagine the following can happen:

Re: [Libguestfs] [PATCH] launch: show hint to resolve authentication failure from libvirt

2012-10-11 Thread Olaf Hering
On Wed, Oct 10, Daniel P. Berrange wrote: It depends on what instance of libvirtd you are connecting to. - The system instance, runs as root and requirs non-root users to auth with policykit - The session instance, runs as the same user id as the client app and does not require

Re: [Libguestfs] [PATCH] launch: show hint to resolve authentication failure from libvirt

2012-10-11 Thread Olaf Hering
On Thu, Oct 11, Daniel P. Berrange wrote: Hmm, on Fedora non-root is able to use KVM just fine. If you have a new enough libvirt, you should have a 'virt-host-validate' command. Can you run that as both root and non-root and provide the output for each case. The issue is that a user is not

Re: [Libguestfs] [PATCH] launch: show hint to resolve authentication failure from libvirt

2012-10-11 Thread Olaf Hering
On Thu, Oct 11, Daniel P. Berrange wrote: On Thu, Oct 11, 2012 at 01:10:16PM +0200, Olaf Hering wrote: However, adding 'olaf' into group 'kvm' does not help to run libguestfs-test-tool, its still a 'qemu' guest. Did you login + logout and restart libvirtd after adding yourself to the kvm

Re: [Libguestfs] [PATCH] launch: show hint to resolve authentication failure from libvirt

2012-10-11 Thread Olaf Hering
On Thu, Oct 11, Olaf Hering wrote: On Thu, Oct 11, Daniel P. Berrange wrote: On Thu, Oct 11, 2012 at 01:10:16PM +0200, Olaf Hering wrote: However, adding 'olaf' into group 'kvm' does not help to run libguestfs-test-tool, its still a 'qemu' guest. Did you login + logout and restart

Re: [Libguestfs] [PATCH] launch: show hint to resolve authentication failure from libvirt

2012-10-11 Thread Olaf Hering
On Thu, Oct 11, Daniel P. Berrange wrote: Ah interesting. So this machine only has the qemu-kvm binary installed, none of the other non-KVM binaries. What is the version of libvirt that you have ? Until fairly recently libvirt would not detect the fact that /usr/bin/qemu-kvm was able to

  1   2   >