Re: [Libguestfs] [PATCH libnbd 4/5] generator: Check that more parameters are not NULL

2022-09-27 Thread Eric Blake
On Tue, Sep 27, 2022 at 03:46:20PM +0100, Richard W.M. Jones wrote: > We previously checked only that String parameters are not NULL, > returning an error + EFAULT if so. > > However we did not check Bytes*, SockAddrAndLen, Path or StringList > parameters, also never NULL. > > I'm not sure if we

[Libguestfs] [PATCH libnbd 4/5] generator: Check that more parameters are not NULL

2022-09-27 Thread Richard W.M. Jones
We previously checked only that String parameters are not NULL, returning an error + EFAULT if so. However we did not check Bytes*, SockAddrAndLen, Path or StringList parameters, also never NULL. I'm not sure if we ought to be checking parameters for NULL like this at all (preferring instead to