Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 14:36, Laszlo Ersek wrote: > On 09/23/22 12:14, Laszlo Ersek wrote: >> On 09/23/22 11:54, Richard W.M. Jones wrote: > >>> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v >>> to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk 2.10, >>> which even for

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Richard W.M. Jones
On Fri, Sep 23, 2022 at 02:36:14PM +0200, Laszlo Ersek wrote: > On 09/23/22 12:14, Laszlo Ersek wrote: > > On 09/23/22 11:54, Richard W.M. Jones wrote: > > >> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v > >> to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 12:14, Laszlo Ersek wrote: > On 09/23/22 11:54, Richard W.M. Jones wrote: >> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v >> to be compiled on RHEL <= 6. RHEL 5 in particular needs Gtk 2.10, >> which even for Gtk 2 is an old version. Those RHEL releases had

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 12:14, Laszlo Ersek wrote: > On 09/23/22 11:54, Richard W.M. Jones wrote: >> ACK series, but see my comment about patch 14. > > Thanks, I'll adjust patch 14 before pushing (I believe I now understand > the borders in the docs). Commit range aa36551e515f..28d7ce8c9db9. I added the

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Laszlo Ersek
On 09/23/22 11:54, Richard W.M. Jones wrote: > ACK series, but see my comment about patch 14. Thanks, I'll adjust patch 14 before pushing (I believe I now understand the borders in the docs). > > A couple of other general points: > > (1) You could copy the vector type from nbdkit if that would

Re: [Libguestfs] [p2v PATCH 15/15] virt-p2v.pod: explain how to bring iSCSI LUNs to the disk selection dialog

2022-09-23 Thread Richard W.M. Jones
ACK series, but see my comment about patch 14. A couple of other general points: (1) You could copy the vector type from nbdkit if that would help with handling lists of strings. (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v to be compiled on RHEL <= 6. RHEL 5 in