[Libguestfs] [PATCH v12 05/11] daemon: Implement umount_all in OCaml.

2017-08-09 Thread Richard W.M. Jones
Unlike previous ‘daemon: Reimplement ...’ patches, this does not reimplement the umount_all API completely (yet, but this implementation could be completed in future and then replace the C one). However it is necessary to have a version of umount_all which we can call from the OCaml inspection

[Libguestfs] [PATCH v12 09/11] daemon: Implement inspection of Linux and other Unix-like operating systems.

2017-08-09 Thread Richard W.M. Jones
This is essentially a line-for-line translation of the C inspection code. --- daemon/Makefile.am | 8 + daemon/inspect.ml| 396 + daemon/inspect.mli | 41 +++ daemon/inspect_fs.ml | 363 +++

[Libguestfs] [PATCH v12 04/11] New API: Deprecate hivex_value_utf8 and replace with hivex_value_string.

2017-08-09 Thread Richard W.M. Jones
hivex has a function hivex_value_string. We were not calling it under the mistaken belief that because hivex implements this using iconv, the function wouldn't work inside the daemon. Instead we reimplemented the functionality in the library. This commit deprecates hivex_value_utf8 and removes

[Libguestfs] [PATCH v12 01/11] inspection: Deprecate APIs and remove support for inspecting installer CDs.

2017-08-09 Thread Richard W.M. Jones
This just duplicated libosinfo information, and because it was never tested it didn't work most of the time. --- docs/C_SOURCE_FILES| 2 - generator/actions_inspection.ml| 67 --- generator/actions_inspection_deprecated.ml | 61 +++ inspector/Makefile.am

[Libguestfs] [PATCH v12 07/11] lib: inspect: Remove ‘fs’ parameter from ‘guestfs_int_download_to_tmp’.

2017-08-09 Thread Richard W.M. Jones
After we move inspection code to the daemon, the library will no longer have access to ‘struct inspect_fs’, and so we won't be able to prefix downloads with the "root filesystem number". Just remove this prefix (it's internal only). However it does mean that this function can no longer cache

[Libguestfs] [PATCH v12 00/11] Reimplement inspection in the daemon.

2017-08-09 Thread Richard W.M. Jones
This fixes almost everything. Note that it adds an extra commit which fixes the whole utf8/iconv business. It's probably better to list what isn't fixed: (1) I didn't leave the osinfo code around because I'm still haven't looked too closely at virt-builder-repository. Can't we just fetch this

[Libguestfs] [PATCH v12 06/11] generator: daemon: Implement RStringList (RMountable, _) and RHashtable (RPlainString, RMountable, _).

2017-08-09 Thread Richard W.M. Jones
Implement returning these two types from OCaml daemon functions. --- daemon/daemon-c.c | 52 daemon/daemon-c.h | 2 ++ generator/daemon.ml | 13 +++-- 3 files changed, 65 insertions(+), 2 deletions(-) diff --git

[Libguestfs] [PATCH v12 02/11] common: Bundle the ocaml-augeas library for use by the daemon.

2017-08-09 Thread Richard W.M. Jones
This commit bundles the ocaml-augeas library (upstream here: http://git.annexia.org/?p=ocaml-augeas.git;a=summary). It's identical to the upstream version and should remain so. We can work towards using system ocaml-augeas, when it's more widely available. --- .gitignore|

[Libguestfs] [PATCH v12 03/11] daemon: utils: New functions and tests.

2017-08-09 Thread Richard W.M. Jones
These utility functions will be used in the OCaml inspection code. --- daemon/daemon_utils_tests.ml | 10 ++ daemon/utils.ml | 17 + daemon/utils.mli | 11 +++ 3 files changed, 38 insertions(+) diff --git a/daemon/daemon_utils_tests.ml

[Libguestfs] [PATCH v12 08/11] daemon: Implement inspection types and utility functions.

2017-08-09 Thread Richard W.M. Jones
Define the types which will be used to communicate between the different parts of the inspection code. The main types are: fscorresponds to ‘struct inspect_fs’ in C code root no direct correspondence with the C code, but in the C code, ‘inspect_fs’ was overloaded to

[Libguestfs] [PATCH v12 10/11] daemon: Implement inspection of Windows.

2017-08-09 Thread Richard W.M. Jones
Mostly a line-for-line translation of the C inspection code. --- daemon/Makefile.am| 2 + daemon/inspect_fs.ml | 6 + daemon/inspect_fs_windows.ml | 480 ++ daemon/inspect_fs_windows.mli | 24 +++ 4 files changed, 512

[Libguestfs] check-release success (was: Re: [PATCH] build: Add a common script for generating OCaml dependencies correctly.)

2017-08-09 Thread Richard Jones
]: Entering directory '/var/tmp/tmpAS0SwB/libguestfs/erlang' make[3]: Entering directory '/var/tmp/tmpAS0SwB/libguestfs/erlang' PASS: tests/010-load.erl PASS: tests/030-config.erl PASS: run-bindtests PASS: tests/070-optargs.erl PASS: tests/050-lvcreate.erl PASS: tests/060-readdir.erl

Re: [Libguestfs] [PATCH] build: Add a common script for generating OCaml dependencies correctly.

2017-08-09 Thread Pino Toscano
On Tuesday, 8 August 2017 16:34:49 CEST Richard W.M. Jones wrote: > These are generated in many different ways in the various > subdirectories, and sometimes not generated correctly. Introduce a > script to do this in one place, and hopefully correctly. > > This is mostly simple refactoring, but

Re: [Libguestfs] [PATCH] build: Add a common script for generating OCaml dependencies correctly.

2017-08-09 Thread Richard W.M. Jones
On Wed, Aug 09, 2017 at 03:40:54PM +0200, Pino Toscano wrote: > BTW, unrelated to this patch, just because I'm noticing them: what are > all the "docs" dependencies in .PHONY? At least for newer Makefile's > I guess they were just copied from existing ones, but I did not find > any

[Libguestfs] [PATCH 1/2] configure: visually split the blocks of checks

2017-08-09 Thread Pino Toscano
Add sort of "headers" to split most of the logical sections of the configure, so it is easier to get feedback on the progress of configure. --- configure.ac | 46 ++ 1 file changed, 46 insertions(+) diff --git a/configure.ac b/configure.ac index

[Libguestfs] [PATCH 2/2] configure: output paths where java is searched in

2017-08-09 Thread Pino Toscano
Output each path where we attempt to find 'java', so it is easier to spot whether the location for the current OS is missing. This also removes the need to print the location next to the version, since the location was already printed above. --- m4/guestfs_java.m4 | 6 +- 1 file changed, 5

Re: [Libguestfs] [PATCH 2/2] configure: output paths where java is searched in

2017-08-09 Thread Richard W.M. Jones
Good idea, ACK series. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports