On Wed, Sep 28, 2022 at 12:47:24PM +0200, Laszlo Ersek wrote:
> On 09/28/22 11:30, Richard W.M. Jones wrote:
> > We previously checked only that String parameters are not NULL,
> > returning an error + EFAULT if so.
> >
> > However we did not check Bytes*, SockAdd
On Wed, Sep 28, 2022 at 02:01:11PM +0200, Laszlo Ersek wrote:
> (this reproduces at commit 0687cea6a86e; IOW the regression is not from
> the recent GTK-related patches, but due to building p2v with GTK3. as
> opposed to GTK2)
>
> In the first dialog, when the Test Connection button is clicked, a
Change check into an assertion, and add detailed comments explaining
our assumptions.
Updates: commit d0fbb769286a97728b0d1358e7accc2eb708d795
---
lib/utils.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/lib/utils.c b/lib/utils.c
index
For API parameters that are pointers and must not be NULL, add the
appropriate GCC annotations. These are only enabled in very recent
GCC (>= 12) because we have concerns with earlier versions, see for
example: https://bugzilla.redhat.com/show_bug.cgi?id=1041336
---
generator/C.ml | 53
We previously checked only that String parameters are not NULL,
returning an error + EFAULT if so.
However we did not check Bytes*, SockAddrAndLen, Path or StringList
parameters, also never NULL. Be consistent about checks.
Thanks: Eric Blake for help and an earlier version of the patch
---
In the C API documentation mention the potential problems of calling
non-nullable parameters with NULL. Usually an error is returned, but
warnings and worse might happen too.
Thanks: Eric Blake
---
docs/libnbd.pod | 18 ++
generator/C.ml | 21 +
2 files
v1 was:
https://listman.redhat.com/archives/libguestfs/2022-September/029982.html
This series is actually quite a bit different from v1 because it is
rebased on top of Eric's series and takes that into account.
Generally this heads down the return error instead of asserting route,
hoping that
n-place operation completed with no errors
> root@weibupos:/home/intel/guestfs-tools/sparsify# du -sh
> /home/intel/imgStore/POS_DATA.qcow2
> 55M /home/intel/imgStore/POS_DATA.qcow2
>
>
> -----Original Message-
> From: Richard W.M. Jones
> Sent: 2022年9月27日 23:04
> To:
On Tue, Sep 27, 2022 at 01:25:55PM -0500, Eric Blake wrote:
> On Tue, Sep 27, 2022 at 03:46:19PM +0100, Richard W.M. Jones wrote:
> > For API parameters that are pointers and must not be NULL, add the
> > appropriate GCC annotations. These are only enabled in very recent
> >
I have pushed the two patches to various places ...
https://github.com/libguestfs/libguestfs/commit/c2dd84b2635bb2d9f7fb0b4ecf1e0274bfd553b1
https://github.com/libguestfs/libguestfs-common/commit/4b4a5b84647b1496d034bcdff910930ca5f5c486
On Tue, Sep 27, 2022 at 04:42:00PM +0200, Laszlo Ersek wrote:
> On 09/26/22 10:50, Daniel P. Berrangé wrote:
> > On Mon, Sep 26, 2022 at 10:18:06AM +0200, Laszlo Ersek wrote:
> >> gcc reports:
> >>
> >>> gui.c:1795:3: error: missing initializer for field ‘padding’ of
> >>> ‘GActionEntry’ {aka
I have pushed the fix to libguestfs & guestfs-tools, so you
should just be able to 'git pull' & recompile.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows
On Tue, Sep 27, 2022 at 10:11:24PM +0800, Ming Lei wrote:
> On Tue, Sep 27, 2022 at 10:42:45AM +0100, Richard W.M. Jones wrote:
> > On Wed, Sep 14, 2022 at 09:47:49AM +0800, Ming Lei wrote:
> > > FYI, I plan to stabilize libublksrv's API in 1.0 release, which
> &g
This function generates C function decls so name it accordingly.
---
generator/C.ml | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/generator/C.ml b/generator/C.ml
index f4d24b650d..013f81edf4 100644
--- a/generator/C.ml
+++ b/generator/C.ml
@@ -213,7 +213,7 @@ let
Eric found that passing a zero length array to nbd_connect_command or
nbd_connect_systemd_socket_activation results in a segfault. This can
be triggered through Python as follows:
$ nbdsh -c 'h.connect_command([])'
nbdsh: generator/states-connect.c:247: enter_STATE_CONNECT_COMMAND_START:
We previously checked only that String parameters are not NULL,
returning an error + EFAULT if so.
However we did not check Bytes*, SockAddrAndLen, Path or StringList
parameters, also never NULL.
I'm not sure if we ought to be checking parameters for NULL like this
at all (preferring instead to
This patch series adds nonnull annotations for parameters which should
be non-NULL.
There was much discussion on IRC about whether this is a good idea,
pointing in particular to the bug below which is still present in
modern GCC. It's better to have these discussions on list so they're
archived.
For API parameters that are pointers and must not be NULL, add the
appropriate GCC annotations. These are only enabled in very recent
GCC (>= 12) because we have concerns with earlier versions, see for
example: https://bugzilla.redhat.com/show_bug.cgi?id=1041336
---
generator/C.ml | 52
No change, just make the layout consistent with similar functions
above.
---
generator/C.ml | 45 +++--
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/generator/C.ml b/generator/C.ml
index b2d46f985a..f4d24b650d 100644
--- a/generator/C.ml
If the LVM ("lvm2") feature is not available, these calls would fail.
Really they ought to be part of the "lvm2" optgroup which would cause
the generator to call reply_with_unavailable_feature and generate the
correct ENOTSUP error. When vgscan was originally added in 2010 it
was not added to the
Since we added support for transparent decryption of LUKS in
commit a232e62dcf ("fish: '-i' option automatically handles whole-disk
encryption") we have always assumed that the "lvm2" feature is
available and so we could call guestfs_vg_activate_all. That API
would have failed in the unlikely
On Tue, Sep 27, 2022 at 11:27:34AM +, Li, Feng F wrote:
> Any steps to get detail trace log to see why the LVM2 is not
> available in the libguestfs?
It's looking for a program called "lvm" (not the library).
On Red Hat distributions this is provided by the lvm2 package, but it
might be a
For 14-18:
Acked-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
On Mon, Sep 26, 2022 at 05:05:56PM -0500, Eric Blake wrote:
[...]
> @@ -102,6 +99,16 @@ main (int argc, char *argv[])
> exit (EXIT_FAILURE);
>}
>
> + /* info on something not present fails */
> + if (nbd_set_export_name (nbd, "a") == -1) {
> +fprintf (stderr, "%s\n", nbd_get_error
(export_name);
> if (!new_name) {
> set_error (errno, "strdup");
> @@ -240,6 +243,7 @@ nbd_unlocked_set_export_name (struct nbd_handle *h, const
> char *export_name)
>
>free (h->export_name);
>h->export_name = new_name;
> + nbd_internal_rese
For patches 3-12:
Acked-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows
On Mon, Sep 26, 2022 at 05:05:43PM -0500, Eric Blake wrote:
> nbd_connect_command (h, (char **) { NULL }) triggers SIGABRT when
> preparing to exec a NULL command name (during
> enter_STATE_CONNECT_COMMAND_START in v1.0).
>
> nbd_connect_command (h, NULL) in newer releases triggers SIGSEGV by
>
On Tue, Sep 27, 2022 at 10:42:45AM +0100, Richard W.M. Jones wrote:
> On Wed, Sep 14, 2022 at 09:47:49AM +0800, Ming Lei wrote:
> > FYI, I plan to stabilize libublksrv's API in 1.0 release, which
> > shouldn't take long.
> >
> > And recently I did some API change
On Wed, Sep 14, 2022 at 09:47:49AM +0800, Ming Lei wrote:
> FYI, I plan to stabilize libublksrv's API in 1.0 release, which
> shouldn't take long.
>
> And recently I did some API changes, so suggest you to update with
> it in both nbdublk and libublksrv.
Just got around to looking at the changes
Apart from Dan's suggestions in patch 1, the series looks good to me.
FWIW RHEL 7 (the earliest distro with PCRE 2) has glib2 2.56.1 &
gtk3 3.22.30, so supporting any earlier versions also seems pointless,
so that might be another thing to review. We could make USE_POPOVERS
unconditional, and
On Mon, Sep 26, 2022 at 09:50:48AM +0100, Daniel P. Berrangé wrote:
> On Mon, Sep 26, 2022 at 10:18:06AM +0200, Laszlo Ersek wrote:
> > gcc reports:
> >
> > > gui.c:1795:3: error: missing initializer for field ‘padding’ of
> > > ‘GActionEntry’ {aka ‘const struct _GActionEntry’}
> > >
On Sun, Sep 25, 2022 at 08:21:19AM +0200, Laszlo Ersek wrote:
> On 09/23/22 16:19, Richard W.M. Jones wrote:
> > From 98f0b3565457c08d14e1f9ab2acecea003ebf6e1 Mon Sep 17 00:00:00 2001
> > From: "Richard W.M. Jones"
> > Date: Fri, 23 Sep 2022 15:18:43 +0100
>
On Fri, Sep 23, 2022 at 03:19:47PM +0100, Richard W.M. Jones wrote:
> On Fri, Sep 23, 2022 at 02:03:45PM +, Li, Feng F wrote:
> > The log output from command " ./virt-sparsify --inplace -v -x
> > /home/intel/imgStore/POS_DATA.qcow2"
>
> Thanks. This
tch to libguestfs/common ?
Rich.
>
> -Original Message-
> From: Richard W.M. Jones
> Sent: 2022年9月23日 20:07
> To: Li, Feng F
> Cc: libguestfs@redhat.com
> Subject: Re: can not get the virt-sparsify code in libguestfs ?
>
> On Fri, Sep 23, 2022 at 11:37:01AM
: Checking for cgroup 'blkio' controller mount-point :
> PASS
>LXC: Checking if device /sys/fs/fuse/connections exists :
> FAIL (Load the 'fuse' module to enable /proc/ overrides)
>
> same X86 server with redhat 8.4 has no problem.
That's th
On Fri, Sep 23, 2022 at 09:05:31PM +0800, mark wrote:
> Dear
>On redhat 7.6 OS with intel ice lake cpu like :
> _
> [root@localhost ~]# lscpu
> Architecture: x86_64
> CPU op-mode(s):32-bit, 64-bit
> Byte
On Fri, Sep 23, 2022 at 02:36:14PM +0200, Laszlo Ersek wrote:
> On 09/23/22 12:14, Laszlo Ersek wrote:
> > On 09/23/22 11:54, Richard W.M. Jones wrote:
>
> >> (2) Should we drop Gtk2 support? I kept this around to allow virt-p2v
> >> to be compiled on RHEL <= 6
?
Difficult to say. What is the complete output from
virt-sparsify -v -x ?
Rich.
>
>
> [cid]
>
>
>
>
>
> Thanks a lot !
>
> lifeng
>
>
>
> -Original Message-
> From: Richard W.M. Jones
> Sent: 2022年9月22日 21:00
>
ACK series, but see my comment about patch 14.
A couple of other general points:
(1) You could copy the vector type from nbdkit if that would help with
handling lists of strings.
(2) Should we drop Gtk2 support? I kept this around to allow virt-p2v
to be compiled on RHEL <= 6. RHEL 5 in
On Mon, Sep 19, 2022 at 03:35:10PM +0200, Laszlo Ersek wrote:
> +At the bottom of the dialog, the C button instructs
> +virt-p2v to re-enumerate the fixed hard disks and the removable media
> +drives. (Note that the button will also reset the currently active
> +selections in both of those
On Mon, Sep 19, 2022 at 03:35:04PM +0200, Laszlo Ersek wrote:
> The statement
>
> if (!test_disk) { /* block A */ } else { /* block B */ }
>
> is needlessly complex; drop the logical negation in exchange for
> reordering the branches:
>
> if (test_disk) { /* block B */ } else { /* block A
ACK series...
Although if I was going to quibble, GNU code tends to use *_p to
indicate a predicate (following the LISP convention [1]), whereas I
think your meaning is "private to function", so maybe that's confusing
to some.
Rich.
[1]
On Thu, Sep 22, 2022 at 11:48:17AM +, Li, Feng F wrote:
> 2) https://libguestfs.org/virt-sparsify.1.html
>
> we downloaded the libguestfs (1.48-stable) library ,but after the
> configure and make, we did not found the virt-sparsify source code
> and binary file, would you please help see where
e's any easy way around this.
Rich.
> On Tue, 13 Sep, 2022, 8:37 pm Richard W.M. Jones, wrote:
>
> On Tue, Sep 13, 2022 at 08:26:26PM +0530, Jevin Gala wrote:
> > Hi,
> >
> > Using latest libguestfs won't be possible since I want NTFS support too.
>
n will pick it up.
Rich.
>
> On Tue, 13 Sep, 2022, 8:19 pm Richard W.M. Jones, wrote:
>
> On Tue, Sep 13, 2022 at 07:50:35PM +0530, Jevin Gala wrote:
> > Hi,
> >
> >
> > Thank you for your response.
> >
> > You mean
As an aside, we'll soon be adding the feature to use nbdkit plugins as
Linux ublk (userspace block) devices. The API is nearly the same so
there's just a bit of code needed to let nbdkit plugins be loaded by
ubdsrv. Watch this space.
Of course it may not (probably will not) fix other problems
using file : hostfiles ?
If there are particular files that you want to copy to the appliance
you might do something like:
# cat > /usr/lib64/supermin.d/guestfs/zz-extra-files <
> On Tue, Sep 13, 2022 at 7:20 PM Richard W.M. Jones wrote:
>
> On Mon, Sep 12, 2022 at 06:52:3
On Mon, Sep 12, 2022 at 06:52:34PM +0530, Jevin Gala wrote:
> Hi,
>
>
> I wanted to use a higher version of e2fsprogs (1.45) with libguestfs 1.28.
> Can I get some information on how I can proceed or use the one compiled on the
> server separately ?
Supermin just uses whatever version of
On Fri, Sep 09, 2022 at 02:53:11PM +0200, Laszlo Ersek wrote:
> On 09/09/22 13:51, Richard W.M. Jones wrote:
> > On Fri, Sep 09, 2022 at 11:10:47AM +0200, Laszlo Ersek wrote:
> >> On 09/08/22 18:27, Laszlo Ersek wrote:
> >>> Bugzilla: https://bugzilla.redhat.com/sh
On Tue, Sep 06, 2022 at 04:08:20AM -0500, Eric Blake wrote:
> If we later find ourselves needing an actual 64-bit unsigned value,
> unrelated to counters, we can add RCounter at that point and
> repurpose RUInt64 to the new purpose. We've done that sort of enum
> splitting before; the enum names
On Fri, Sep 09, 2022 at 11:10:47AM +0200, Laszlo Ersek wrote:
> On 09/08/22 18:27, Laszlo Ersek wrote:
> > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1590721
> > v1:
> > https://listman.redhat.com/archives/libguestfs/2022-September/029806.html
> >
> > Please see the Notes
(Adding Dan for input)
On Thu, Sep 08, 2022 at 03:23:41PM +0200, Laszlo Ersek wrote:
> On 09/08/22 10:03, Richard W.M. Jones wrote:
> > On Mon, Sep 05, 2022 at 01:25:27PM +0200, Laszlo Ersek wrote:
> >> + "p2v.vcpu.dense_topo" => manual_entry->new(
&
On Mon, Sep 05, 2022 at 01:25:31PM +0200, Laszlo Ersek wrote:
> This lets us exercise both states of the "p2v.vcpu.dense_topo" switch
> sensibly via the in-VM GUI.
>
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1590721
> Signed-off-by: Laszlo Ersek
> ---
> Makefile.am | 2 ++
> 1
On Mon, Sep 05, 2022 at 01:25:27PM +0200, Laszlo Ersek wrote:
> + "p2v.vcpu.dense_topo" => manual_entry->new(
> +shortopt => "", # ignored for booleans
> +description => "
> +Copy the physical machine's CPU topology, densely populated, to the
> +guest. Disabled by default. If disabled,
@ -1577,6 +1613,12 @@ vcpus_or_memory_check_callback (GtkWidget *w, gpointer
> data)
> gtk_label_set_text (GTK_LABEL (target_warning_label), "");
> }
>
> +static bool
> +get_dense_topo_from_conv_dlg (void)
> +{
> + return gtk_toggle_button_get
0, 1, 3, 4, GTK_FILL, GTK_FILL, 1, 1);
> +0, 1, row, GTK_FILL, GTK_FILL, 1, 1);
>set_alignment (of_label, 1., 0.5);
>of_entry = gtk_entry_new ();
>gtk_label_set_mnemonic_widget (GTK_LABEL (of_label), of_entry);
> @@ -854,11 +868,12 @@ create_con
element ("model") {
> + attribute ("fallback", "allow");
> + string (config->cpu.model);
> +} end_element ();
> + }
> + start_element ("topology") {
> +attribute_format ("sockets&q
On Tue, Sep 06, 2022 at 04:19:40AM -0500, Eric Blake wrote:
> > > + assert (cr3 = (Int64.add cr2 fudge))
>
> Not so in OCaml, where + isn't even polymorphic to int64, so I have to
> break out manual calls to Int64.XXX methods. Here, I went with a
> helper variable 'fudge'.
No implicit type
On Mon, Sep 05, 2022 at 02:41:57PM -0500, Eric Blake wrote:
> On Sun, Sep 04, 2022 at 05:44:33PM +0100, Richard W.M. Jones wrote:
> >
> > So my feeling about this patch series:
> >
> > I don't understand why the first patch is necessary, _and_ I think it
> >
On Mon, Sep 05, 2022 at 02:12:24PM +0200, Laszlo Ersek wrote:
> On 09/03/22 18:30, Richard W.M. Jones wrote:
> > On Fri, Sep 02, 2022 at 05:14:24PM -0500, Eric Blake wrote:
> >> I was trying to write a test that determined whether a failure was due
> >> to a short-circ
On Mon, Sep 05, 2022 at 08:06:24PM +0800, Ming Lei wrote:
> On Fri, Sep 02, 2022 at 09:06:27AM +0100, Richard W.M. Jones wrote:
> > On Thu, Sep 01, 2022 at 12:14:40PM +0100, Richard W.M. Jones wrote:
> > > On Thu, Sep 01, 2022 at 04:01:39PM +0800, Ming Lei wrote:
> > >
On Mon, Sep 05, 2022 at 11:01:52AM +0200, Laszlo Ersek wrote:
> On 09/02/22 21:53, Eric Blake wrote:
> > On Fri, Sep 02, 2022 at 06:58:53PM +0100, Richard W.M. Jones wrote:
> >> On Fri, Sep 02, 2022 at 10:25:38AM -0500, Eric Blake wrote:
> >>> dd writ
So my feeling about this patch series:
I don't understand why the first patch is necessary, _and_ I think it
might be "dangerous" (for small values of dangerous).
What happens if in future we add a new RStaticString API which returns
a string that does need to be escaped? It should at least
Ran libguestfs-test-tool and got lots of output, the pertinent line
being:
15:55 < Scamdotnet> guestfsd: error while loading shared libraries:
libgcrypt.so.20: cannot open shared object file: No such file or directory
(https://pastebin.com/9PgqEPuq)
16:17 < rwmjones> Scamdotnet: ok I see
So the patch series is OK, modulo my comments.
But I think it'd be better not to bind our future selves to
complicated guarantees about what are basically internal details of
the library and protocol.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read
On Fri, Sep 02, 2022 at 05:14:24PM -0500, Eric Blake wrote:
> I was trying to write a test that determined whether a failure was due
> to a short-circuit test on the client side or an actual failure
> returned by the server. Such a test is a lot easier if we can watch
> status counters increase
On Fri, Sep 02, 2022 at 05:14:22PM -0500, Eric Blake wrote:
> #ifdef DUMP_PACKETS
> - if (h->rbuf != NULL)
> -nbd_internal_hexdump (h->rbuf, r, stderr);
> + nbd_internal_hexdump (h->rbuf, r, stderr);
Should this be a separate patch? I guess the assertion here is that
h->rbuf is set to an
On Fri, Sep 02, 2022 at 10:25:38AM -0500, Eric Blake wrote:
> dd writes progress messages to stderr, with no complaints. Having
> nbdcopy open /dev/tty instead of reusing stderr to write messages
> litters the output of a terminal during an interactive 'make check',
> which is rather distracting,
FYI, nbdublk is now available in Fedora Rawhide, along with the
dependencies liburing 2.2 and ubdsrv.
https://koji.fedoraproject.org/koji/buildinfo?buildID=2056223
Thanks for your help.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming
On Thu, Sep 01, 2022 at 12:14:40PM +0100, Richard W.M. Jones wrote:
> On Thu, Sep 01, 2022 at 04:01:39PM +0800, Ming Lei wrote:
> > Maybe you should use one nbd disk, which has the closest code path
> > with nbdublk.
>
> Good idea - I have started a heavy test using nb
On Thu, Sep 01, 2022 at 03:38:34PM -0500, Eric Blake wrote:
> On Thu, Sep 01, 2022 at 05:29:21PM +0100, Richard W.M. Jones wrote:
> > On Wed, Aug 31, 2022 at 09:39:20AM -0500, Eric Blake wrote:
> > > Add a new control knob nbd_set_request_meta_context(), modeled after
On Thu, Sep 01, 2022 at 02:55:45PM -0500, Eric Blake wrote:
> On Thu, Sep 01, 2022 at 05:17:14PM +0100, Richard W.M. Jones wrote:
> > >
> > > [*]It's easier to skip on server failure than to try and write an
> > > nbdkit patch to add yet another --config feature pro
stem, this returns true if there is compile-time
> support, but you may still need runtime support for some aspects
> of AF_VSOCK usage; for example, use of C as the
> server name requires that the I kernel module is
> loaded.
You can use paragraphs (and even subheadings) in the POD
here if
On Wed, Aug 31, 2022 at 09:39:20AM -0500, Eric Blake wrote:
> Add a new control knob nbd_set_request_meta_context(), modeled after
> the existing nbd_set_request_structured_replies(), to make it possible
> to skip the NBD_OPT_SET_META_CONTEXT half of the two-command sequence
> currently performed
On Thu, Sep 01, 2022 at 11:21:38AM +0200, Laszlo Ersek wrote:
> On 08/31/22 16:39, Eric Blake wrote:
> > Upstream NBD clarified (see NBD commit 13a4e33a8) that since
> > NBD_OPT_LIST_META_CONTEXT is stateless on the server side, it is
> > acceptable (but not mandatory) for servers to accept it
On Wed, Aug 31, 2022 at 09:39:19AM -0500, Eric Blake wrote:
> Upstream NBD clarified (see NBD commit 13a4e33a8) that since
> NBD_OPT_LIST_META_CONTEXT is stateless on the server side, it is
> acceptable (but not mandatory) for servers to accept it without the
> client having pre-negotiated
On Thu, Sep 01, 2022 at 04:01:39PM +0800, Ming Lei wrote:
> Maybe you should use one nbd disk, which has the closest code path
> with nbdublk.
Good idea - I have started a heavy test using nbd.ko as the
backing. Let's see what happens after 12 hours or more.
Rich.
--
Richard Jones,
On Thu, Sep 01, 2022 at 11:26:10AM +0800, Ming Lei wrote:
> On Wed, Aug 31, 2022 at 04:06:16PM +0100, Richard W.M. Jones wrote:
> > I have also added the changes to Fedora:
> >
> > https://koji.fedoraproject.org/koji/taskinfo?taskID=91468555
> >
> > Please consi
On Wed, Aug 31, 2022 at 11:22:04AM +0100, Richard W.M. Jones wrote:
>
> After running those tests for an hour or two I got a nasty kernel
> memory corruption issue in the test VM, see attached.
Another one from running overnight.
Rich.
--
Richard Jones, Virtualization Group, Red
On Wed, Aug 31, 2022 at 10:49:42PM +0800, Ming Lei wrote:
> On Wed, Aug 31, 2022 at 5:41 PM Richard W.M. Jones wrote:
> >
> > On Wed, Aug 31, 2022 at 05:29:13PM +0800, Ming Lei wrote:
> > > I can reproduce it, please try the top patch in aio branch, which fixed
>
On Wed, Aug 31, 2022 at 08:59:15AM +0200, Laszlo Ersek wrote:
> Now, whether this kills "set -e" for me for good... I'm not so sure. I'm
> trying to think up a shell function that I would want to (a) call from
> an outer conditional context, and at the same time (b) cause the whole
> script to
On Wed, Aug 31, 2022 at 06:33:25PM +0800, Ming Lei wrote:
> On Wed, Aug 31, 2022 at 11:22:04AM +0100, Richard W.M. Jones wrote:
> >
> > After running those tests for an hour or two I got a nasty kernel
> > memory corruption issue in the test VM, see attached.
>
> >
After running those tests for an hour or two I got a nasty kernel
memory corruption issue in the test VM, see attached.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets
On Wed, Aug 31, 2022 at 05:29:13PM +0800, Ming Lei wrote:
> I can reproduce it, please try the top patch in aio branch, which fixed
> hang in my reproducer with your test setting.
>
> https://github.com/ming1/ubdsrv/commits/aio
On Wed, Aug 31, 2022 at 09:45:45AM +0800, Ming Lei wrote:
> On Tue, Aug 30, 2022 at 05:13:46PM +0100, Richard W.M. Jones wrote:
> > On Tue, Aug 30, 2022 at 11:29:26PM +0800, Ming Lei wrote:
> > > On Tue, Aug 30, 2022 at 03:38:50PM +0100, Richard W.M. Jones wrote:
> > > &
On Tue, Aug 30, 2022 at 11:29:26PM +0800, Ming Lei wrote:
> On Tue, Aug 30, 2022 at 03:38:50PM +0100, Richard W.M. Jones wrote:
> > On Tue, Aug 30, 2022 at 03:12:23PM +0800, Ming Lei wrote:
> > > The patch sent in last email may cause io hang on MQ, and follows the
> &g
On Tue, Aug 30, 2022 at 01:43:17PM +0200, Laszlo Ersek wrote:
> On 08/27/22 19:40, Richard W.M. Jones wrote:
> > Alright, so final version for now is here:
> >
> > https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
>
> I'm slightly interested to review this, but
On Tue, Aug 30, 2022 at 03:12:23PM +0800, Ming Lei wrote:
> The patch sent in last email may cause io hang on MQ, and follows the fixed
> version:
I split this into two commits and cleaned them up and posted them here:
https://gitlab.com/rwmjones/libnbd/-/commits/nbdublk/
Unfortunately this
On Tue, Aug 30, 2022 at 01:16:02PM +0200, Laszlo Ersek wrote:
> Thanks for the explanation. I didn't expect these two principles to have
> driven the design (generability, and long-term convenience calls). I
> think the more usual (albeit likely less programmer-friendly) approach
> is to (a)
Series looks good, thanks.
Reviewed-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build
On Fri, Aug 26, 2022 at 07:39:31AM -0500, Eric Blake wrote:
> On Fri, Aug 26, 2022 at 01:39:05PM +0200, Laszlo Ersek wrote:
> > Extract and somewhat generalize the recipe for the $(PHYSICAL_MACHINE)
> > target to a separate shell script. In preparation for the multiple steps
> > we're going to
On Tue, Aug 30, 2022 at 05:38:35PM +0800, Ming Lei wrote:
> nbd work thread is created by nbd target code just like before, but
> the thread is changed to the following way, basically bound with one
> aio_ctx:
> while (!ublksrv_aio_ctx_dead(aio_ctx)) {
> struct aio_list compl;
>
>
On Tue, Aug 30, 2022 at 04:30:40PM +0800, Ming Lei wrote:
> On Tue, Aug 30, 2022 at 09:04:07AM +0100, Richard W.M. Jones wrote:
> > On Tue, Aug 30, 2022 at 10:32:02AM +0800, Ming Lei wrote:
> > > Hi Jones,
> > >
> > > On Thu, Aug 25, 2022 at 01:10:
On Tue, Aug 30, 2022 at 10:32:02AM +0800, Ming Lei wrote:
> Hi Jones,
>
> On Thu, Aug 25, 2022 at 01:10:55PM +0100, Richard W.M. Jones wrote:
> > This patch adds simple support for a ublk-based NBD client.
> > It is also available here:
> > https://gitlab.com/rwmjones
nbdublk is marginally faster than nbd.ko, although the difference is
small enough to probably be measurement error:
nbdublk
real18m20.767s
user114m57.705s
sys 20m29.502s
nbd.ko
real18m52.872s
user117m0.274s
sys 21m35.187s
Rich.
--
Richard Jones, Virtualization Group,
On Sun, Aug 28, 2022 at 04:39:07PM +0100, Richard W.M. Jones wrote:
> Performance was within 25% of disk access over virtio-scsi, which I
> think is pretty good.
BTW we had a GSoC student last summer who was supposed to work on
adding io_uring support to libnbd. Unfortunately they
On Sun, Aug 28, 2022 at 04:39:07PM +0100, Richard W.M. Jones wrote:
> On Sun, Aug 28, 2022 at 11:21:25PM +0800, Ming Lei wrote:
> > On Sat, Aug 27, 2022 at 06:40:29PM +0100, Richard W.M. Jones wrote:
> > > Alright, so final version for now is here:
> > >
> > >
On Sun, Aug 28, 2022 at 11:21:25PM +0800, Ming Lei wrote:
> On Sat, Aug 27, 2022 at 06:40:29PM +0100, Richard W.M. Jones wrote:
> > Alright, so final version for now is here:
> >
> > https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
>
> Just clone the above bran
Alright, so final version for now is here:
https://gitlab.com/rwmjones/libnbd/-/tree/nbdublk/ublk
I resolved the data corruption problem once I realised that
->handle_event must only retire commands which are on the same queue
(obvious in hindsight). I ran a parallel job overnight where I did
On Fri, Aug 26, 2022 at 07:29:34AM -0500, Eric Blake wrote:
> On Thu, Aug 25, 2022 at 02:35:47PM +0100, Richard W.M. Jones wrote:
> > On Thu, Aug 25, 2022 at 03:32:15PM +0200, Laszlo Ersek wrote:
> > > Hi,
> > >
> > > most shell scripts in the v2
801 - 900 of 10948 matches
Mail list logo
