Re: [Libguestfs] ANNOUNCE: libguestfs 1.26 released

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 10:00:49AM +0100, Olaf Hering wrote: > Does your build have "working GNU getopt function... yes"? Seems so: $ rm config.cache $ ./configure |& grep getopt checking getopt.h usability... yes checking getopt.h presence... yes checking for getopt.h... yes checking for getopt.

Re: [Libguestfs] ANNOUNCE: libguestfs 1.26 released

2014-03-28 Thread Richard W.M. Jones
On Fri, Mar 28, 2014 at 10:44:16AM +0100, Olaf Hering wrote: > Index: libguestfs-1.26.0/builder/Makefile.am > === > --- libguestfs-1.26.0.orig/builder/Makefile.am > +++ libguestfs-1.26.0/builder/Makefile.am > @@ -278,6 +278,9 @@ virt_i

[Libguestfs] [PATCH supermin 3/5] kernel: Refactor code to use single function to check if modules.dep exists.

2014-03-28 Thread Richard W.M. Jones
And don't use file_exists. --- src/kernel.ml | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/kernel.ml b/src/kernel.ml index 0287983..ed5aea3 100644 --- a/src/kernel.ml +++ b/src/kernel.ml @@ -195,17 +195,21 @@ and find_modpath debug kernel_version = and has_modpat

[Libguestfs] [PATCH supermin 5/5] Remove generic 'file_exists' function from utils.ml.

2014-03-28 Thread Richard W.M. Jones
--- src/utils.ml | 4 src/utils.mli | 3 --- 2 files changed, 7 deletions(-) diff --git a/src/utils.ml b/src/utils.ml index 55f6754..5f0d24c 100644 --- a/src/utils.ml +++ b/src/utils.ml @@ -28,10 +28,6 @@ let (//) = Filename.concat let quote = Filename.quote let quoted_list names = String

[Libguestfs] [PATCH supermin 2/5] Add function to get file source from file struct, and use it instead of file_exists.

2014-03-28 Thread Richard W.M. Jones
--- src/chroot.ml | 8 ++-- src/ext2.ml | 9 - src/package_handler.ml | 9 + src/package_handler.mli | 3 +++ 4 files changed, 18 insertions(+), 11 deletions(-) diff --git a/src/chroot.ml b/src/chroot.ml index 9e522d9..63a5a79 100644 --- a/src/chroot.ml

[Libguestfs] [PATCH supermin 0/5] CentOS 6.4: Supermin fails to detect distro.

2014-03-28 Thread Richard W.M. Jones
See: https://bugzilla.redhat.com/show_bug.cgi?id=1082044 ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] Coverity scan on libguestfs 1.25.49

2014-03-28 Thread Richard W.M. Jones
On Wed, Mar 26, 2014 at 07:59:21PM +, Richard W.M. Jones wrote: > http://oirase.annexia.org/tmp/libguestfs-1.25.49-1.fc21.html To save anyone else going through these, I have now finished going through them and have pushed a few minor commits to fix things. Rich. -- Richard Jo

Re: [Libguestfs] ANNOUNCE: libguestfs 1.26 released

2014-03-28 Thread Richard W.M. Jones
On Thu, Mar 27, 2014 at 10:26:42PM +, Richard W.M. Jones wrote: > I'm pleased to announce libguestfs 1.26, a library and set of tools > for accessing and modifying virtual machine disk images. This release > took more than 6 months of work by a considerable number of people,

[Libguestfs] [PATCH supermin 1/5] dpkg: Don't use OCaml 4-ism when creating a struct.

2014-03-28 Thread Richard W.M. Jones
Prevents us compiling on OCaml 3.11.2 in RHEL 6. --- src/dpkg.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index 8f92f7f..f96105f 100644 --- a/src/dpkg.ml +++ b/src/dpkg.ml @@ -64,7 +64,8 @@ let dpkg_package_of_string str = fun line ->

[Libguestfs] [PATCH supermin 4/5] package handlers: Remove use of file_exists function (RHBZ#1082044).

2014-03-28 Thread Richard W.M. Jones
Use equivalent code using stat. On CentOS this should detect /etc/redhat-release symlink. --- src/dpkg.ml | 2 +- src/pacman.ml | 2 +- src/rpm.ml| 9 ++--- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/dpkg.ml b/src/dpkg.ml index f96105f..1bb3f7f 100644 --- a/src/d

Re: [Libguestfs] [PATCH 1/3] builder: make the C index parser reentrant

2014-03-29 Thread Richard W.M. Jones
On Wed, Mar 19, 2014 at 05:53:09PM +0100, Pino Toscano wrote: > Switch the lex/yacc parser into reentrant mode, to ease the handling of > parsing-specific data; introduce a new parser_context struct for that, > which is added as extra data to the parser. > > This should cause no behaviour changes

Re: [Libguestfs] [PATCH 1/3] builder: make the C index parser reentrant

2014-03-29 Thread Richard W.M. Jones
On Sat, Mar 29, 2014 at 12:31:24PM +, Richard W.M. Jones wrote: > On Wed, Mar 19, 2014 at 05:53:09PM +0100, Pino Toscano wrote: > > Switch the lex/yacc parser into reentrant mode, to ease the handling of > > parsing-specific data; introduce a new parser_context struct for tha

Re: [Libguestfs] [PATCH] Add the now mandatory arch=ARCH field to the index file examples.

2014-03-31 Thread Richard W.M. Jones
On Mon, Mar 31, 2014 at 04:52:31PM +0100, lyarw...@redhat.com wrote: > From: Lee Yarwood > > 61323fa introduced a mandatory arch field within index files to > identify the architecture of the OS installed within a given template. > This change simply documents the requirement within the relevant

Re: [Libguestfs] [PATCH] src/launch: improve the addition of the no-hpet option

2014-04-01 Thread Richard W.M. Jones
On Tue, Apr 01, 2014 at 06:37:40PM +0200, Pino Toscano wrote: > Since HPET is specific to x86, we can safely add it its option only on > x86 and x86_64 when creating the libvirt XML (no more hitting the > launching failures due to that on other architectures). > > Regarding the direct qemu launch,

[Libguestfs] [PATCH 0/3] builder: Add test of virt-index-validate.

2014-04-03 Thread Richard W.M. Jones
Somewhat ineffective test of virt-index-validate. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH] builder: better handle some index parsing errors

2014-04-03 Thread Richard W.M. Jones
On Wed, Apr 02, 2014 at 06:13:59PM +0200, Pino Toscano wrote: > Add a new lexer token, unused in the grammar, for the unknown lines in > index files; this should allow to better handle such kind of parsing > errors, removing the need to exit() directly (and leave things in an > unclean state). See

[Libguestfs] [PATCH 1/3] builder: Don't use configure to generate test-index file.

2014-04-03 Thread Richard W.M. Jones
The file contained no replacement patterns so generating it with configure did nothing. --- .gitignore| 1 - builder/Makefile.am | 1 + builder/test-index| 66 +++ builder/test-index.in | 66 ---

[Libguestfs] [PATCH 2/3] builder: Rearrange EXTRA_DIST in alphabetical order.

2014-04-03 Thread Richard W.M. Jones
No functional change. --- builder/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index 92a09bc..56e8929 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -30,11 +30,11 @@ EXTRA_DIST = \ $(SOURCES)

[Libguestfs] [PATCH 3/3] builder: Add test of virt-index-validate.

2014-04-03 Thread Richard W.M. Jones
--- builder/Makefile.am | 8 +++- builder/test-virt-index-validate-bad-1 | 8 builder/test-virt-index-validate-good-1 | 0 builder/test-virt-index-validate-good-2 | 2 ++ builder/test-virt-index-validate.sh | 24 5 files changed, 4

Re: [Libguestfs] [PATCH 0/3] builder: Add test of virt-index-validate.

2014-04-03 Thread Richard W.M. Jones
On Thu, Apr 03, 2014 at 10:56:49AM +0200, Pino Toscano wrote: > On Thursday 03 April 2014 08:59:45 Richard W.M. Jones wrote: > > Somewhat ineffective test of virt-index-validate. > > LGTM. I have pushed these patches + your patch. > Are you also planning to remove builder/w

Re: [Libguestfs] [PATCH] builder: better handle some index parsing errors

2014-04-03 Thread Richard W.M. Jones
On Thu, Apr 03, 2014 at 10:59:29AM +0200, Pino Toscano wrote: > On Thursday 03 April 2014 09:00:43 Richard W.M. Jones wrote: > > On Wed, Apr 02, 2014 at 06:13:59PM +0200, Pino Toscano wrote: > > > Add a new lexer token, unused in the grammar, for the unknown lines > > >

[Libguestfs] [PATCH v1 NOT TO BE APPLIED] New tool: virt-v2v.

2014-04-03 Thread Richard W.M. Jones
This incomplete patch is the beginning of a translation of virt-v2v & virt-p2v, including them as part of the libguestfs tree. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH v1 NOT TO BE APPLIED] New tool: virt-v2v.

2014-04-03 Thread Richard W.M. Jones
ite + +A list of features is printed, one per line, and the program exits +with status 0. + +Secondly use the option in conjunction with other options to make the +regular program output more machine friendly. + +At the moment this means: + +=over 4 + +=item 1. + +Progress bar messages can be parsed f

Re: [Libguestfs] [PATCH] appliance: exclude pkg-config, doc-base, and reportbug stuff

2014-04-03 Thread Richard W.M. Jones
On Thu, Apr 03, 2014 at 03:29:53PM +0200, Pino Toscano wrote: > Exclude the arch-independent pkg-config files (no pkg-config available > in the appliance). > > Exclude also the doc-base and reportbug files, typically found in Debian > systems. ACK. FWIW we used to go further and remove all perl*

[Libguestfs] [PATCH] appliance: Avoid touching appliance/supermin.d directory.

2014-04-03 Thread Richard W.M. Jones
This code is subtle, to say the least. When using 'supermin --build --if-newer', supermin will check if appliance/supermin.d is newer than tmp/.guestfs-UID/appliance.d, and only rebuild the full appliance if so. So we need to avoid touching appliance/supermin.d unless there's an actual change. U

[Libguestfs] [PATCH] appliance: Avoid touching appliance/supermin.d directory.

2014-04-03 Thread Richard W.M. Jones
We must avoid touching appliance/supermin.d unless it is necessary, so that we avoid unnecessary rebuilds of the full appliance. Unfortunately since we created temporary files there, even if we didn't decide to keep those temporary files they would still end up touching supermin.d. To stop this, m

[Libguestfs] [PATCH v2 NOT TO BE APPLIED 1/2] mllib: utils: Add mapi function.

2014-04-03 Thread Richard W.M. Jones
This is List.mapi from the stdlib. RHEL 6 did not have this function. --- mllib/common_utils.ml | 8 1 file changed, 8 insertions(+) diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml index 094ef10..3b15868 100644 --- a/mllib/common_utils.ml +++ b/mllib/common_utils.ml @@ -174,6

Re: [Libguestfs] [PATCH] customize: add the chmod command

2014-04-04 Thread Richard W.M. Jones
On Fri, Apr 04, 2014 at 04:17:00PM +0200, Pino Toscano wrote: > + > +The mode actually set is affected by the umask."; > + }; I think you can remove this sentence, since I don't think it is true. ACK w/o that. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.

Re: [Libguestfs] Problem with virt-sysprep

2014-04-08 Thread Richard W.M. Jones
On Mon, Apr 07, 2014 at 10:12:05PM -0700, Stuart Young wrote: > Hi there, > > I was wondering if you could help me with a problem I'm having with > virt-sysprep. It's a recurrent problem running virt-sysprep: > >Examining the guest ... >Fatal error: exception Guestfs.Error("guestfs_launch

[Libguestfs] [PATCH] sparsify: Use automake to build and link virt-sparsify binary.

2014-04-09 Thread Richard W.M. Jones
There are two observations which make this possible: (1) virt-sparsify contains at least one C unit, so automake thinks it is compiling a C program. (2) Automake lets us add a *_LINK rule to override linking. We list the C sources of virt-sparsify as virt_sparsify_SOURCES, so automake thinks it i

[Libguestfs] [PATCH] build: Remove code coverage and code profiling options.

2014-04-09 Thread Richard W.M. Jones
This reverts commit 5a2e320ec9390b2146feea6d7b3b8c36a34d0a90. --- .gitignore| 4 align/Makefile.am | 1 - builder/Makefile.am | 2 -- cat/Makefile.am | 3 --- configure.ac | 24 customize/Mak

Re: [Libguestfs] [PATCH 1/8] sysprep: remove systemd journals

2014-04-09 Thread Richard W.M. Jones
On Wed, Apr 09, 2014 at 01:58:29PM +0200, Pino Toscano wrote: > --- > sysprep/sysprep_operation_logfiles.ml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sysprep/sysprep_operation_logfiles.ml > b/sysprep/sysprep_operation_logfiles.ml > index cf525c2..bb35daf 100644 > --- a/sysprep/

Re: [Libguestfs] [PATCH] listfs: If LDM not available, don't inhibit partition detection (RHBZ#1079182).

2014-04-09 Thread Richard W.M. Jones
On Wed, Apr 09, 2014 at 03:12:59PM +0200, Pino Toscano wrote: > On Friday 21 March 2014 15:24:01 Richard W.M. Jones wrote: > > If a disk has type 0x42 partition (which would indicate LDM), but LDM > > is not available then try parsing the partition anyway. It might be > > p

Re: [Libguestfs] libguestfs powerpc package

2014-04-11 Thread Richard W.M. Jones
On Fri, Apr 11, 2014 at 10:01:57AM +0200, Roberto Innocenti wrote: > Dear Rich, > Now I'm testing qemu 2.0 on G4 , now with the last libguestfs it could > successfully work with powerpc 32 bit ( G4) ? It should do, but you can report bugs on this mailing list if you find any. Rich. -- Richard J

Re: [Libguestfs] [PATCH] sysprep: remove also hidden files/dirs in temporary dirs

2014-04-14 Thread Richard W.M. Jones
On Mon, Apr 14, 2014 at 02:29:15PM +0200, Pino Toscano wrote: > List manually and remove the content left (hidden files/directories) in > temporary directories after the glob listing & removal. > --- > sysprep/sysprep_operation_tmp_files.ml | 13 ++--- > 1 file changed, 10 insertions(+), 3

Re: [Libguestfs] [PATCH] builder: add per-repository proxy configuration

2014-04-15 Thread Richard W.M. Jones
ACK. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines in

[Libguestfs] [PATCH] disk-create: Fix this API so it works correctly with block devices (RHBZ#1088262).

2014-04-16 Thread Richard W.M. Jones
When you call guestfs_disk_create on a block device with format=raw then it will try to discard the blocks on the device. --- configure.ac | 1 + daemon/blkdiscard.c | 3 +++ generator/actions.ml | 4 src/create.c | 46 +++--- 4 file

Re: [Libguestfs] [PATCH pkg-libvirt/libguestfs] Split off ZFS support from libguestfs0.

2014-04-22 Thread Richard W.M. Jones
On Sat, Mar 15, 2014 at 10:29:08PM +, Richard W.M. Jones wrote: > Hilko, > > This is an experimental patch showing how to split libguestfs into > subpackages, so the main libguestfs0 doesn't depend on everything. > > Splitting packages only works for packages which are

Re: [Libguestfs] libguestfs powerpc package

2014-04-22 Thread Richard W.M. Jones
On Sat, Apr 19, 2014 at 11:20:44PM +0200, Roberto Innocenti wrote: > I have successfully compiled on G4 powerpc libguestfs ( last stable version > 1.26.0 ) and supermin 5.1.7 but > > supermin doesn't recognise a suitable kernel ( vmlinuz*) to build the > appliance, looking on the kernel.ml code (l

Re: [Libguestfs] [PATCH 1/2] ruby: tests: isolate boilerplate in common file

2014-04-22 Thread Richard W.M. Jones
Looks good, ACK to both. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 l

Re: [Libguestfs] [PATCH] daemon: parted: part-get-name: switch from sgdisk to parted (RHBZ#1088424).

2014-04-22 Thread Richard W.M. Jones
On Thu, Apr 17, 2014 at 11:38:27AM +0200, Pino Toscano wrote: > Use parted to get the name of partitions in GPT layouts instead of > sgdisk, to reduce the possible discrepancy between output of tools. > > The actual case here is that recent parted versions fixed/improved their > UTF-16 handling of

Re: [Libguestfs] [PATCH 2/2] builder: add "[ignored]" to parsing errors for .conf files

2014-04-22 Thread Richard W.M. Jones
On Tue, Apr 22, 2014 at 05:41:44PM +0200, Pino Toscano wrote: > Parsing sources .conf files is not a fatal error (that file would just > be ignored), so explicitly state that such parsing errors are ignored. > > This should address the last bit in RHBZ#1077817. > --- > builder/sources.ml | 2 +- >

Re: [Libguestfs] [PATCH] Fix qemu version check

2014-04-22 Thread Richard W.M. Jones
On Tue, Apr 22, 2014 at 09:21:17PM +0200, Hilko Bengen wrote: > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index ab072c3..9c398e0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -777,7 +777,7 @@ working. >

Re: [Libguestfs] [PATCH] builder: isolate all the cache handling to a new Cache module

2014-04-23 Thread Richard W.M. Jones
Looks like simple code motion, ACK! Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PX

Re: [Libguestfs] [HIVEX] port ruby tests to MiniTest (#1090407)

2014-04-23 Thread Richard W.M. Jones
Thanks for doing this, ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk

Re: [Libguestfs] [PATCH] virt-v2v: Catch invalid initrd path

2014-04-25 Thread Richard W.M. Jones
On Thu, Apr 24, 2014 at 04:43:59PM -0600, Mike Latimer wrote: > In some cases (specifically, SUSE grub2 environments) it is possible to > fail to update the block entries in device.map. In turn, this causes an > invalid path to be returned in perl-Bootloader code, which causes the > conversion to f

Re: [Libguestfs] Labelling /etc/resolv.conf (rh#1089100)

2014-04-25 Thread Richard W.M. Jones
On Fri, Apr 25, 2014 at 11:40:35AM +0200, Pino Toscano wrote: > Hi, > > I was investigating rh#1089100, which is about /etc/resolv.conf not > being properly SELinux-labelled. > > Basically the problem is due to /etc/resolv.conf in the guest (so > available as /sysroot/etc/resolv.conf in the app

Re: [Libguestfs] Root btrfs partition listed twice?

2014-04-25 Thread Richard W.M. Jones
On Fri, Apr 25, 2014 at 01:12:08PM -0600, Mike Latimer wrote: > Hi, > > I know btrfs complicates filesystem lists due to the use of subvolumes. > However, I just noticed that the root partition itself ends up being listed > twice with list-filesystems, inspect-os, inspect-get-roots, etc... I'm

Re: [Libguestfs] [supermin] Be smarter about finding suitable kernel images

2014-04-27 Thread Richard W.M. Jones
On Sat, Apr 26, 2014 at 02:27:07PM +0200, Hilko Bengen wrote: > --- > src/kernel.ml | 43 --- > 1 file changed, 28 insertions(+), 15 deletions(-) > > diff --git a/src/kernel.ml b/src/kernel.ml > index ed5aea3..436b1b0 100644 > --- a/src/kernel.ml > +++ b/sr

[Libguestfs] [PATCH 2/2] Add a regression test for RHBZ#1091803.

2014-04-28 Thread Richard W.M. Jones
--- tests/regressions/Makefile.am| 2 ++ tests/regressions/rhbz1091803.sh | 39 +++ 2 files changed, 41 insertions(+) create mode 100755 tests/regressions/rhbz1091803.sh diff --git a/tests/regressions/Makefile.am b/tests/regressions/Makefile.am index ac7d

[Libguestfs] [PATCH 1/2] tar-in: Fix places where we didn't cancel the receive (FileIn) correctly along error paths (RHBZ#1091803).

2014-04-28 Thread Richard W.M. Jones
Thanks: Bo Fan. --- daemon/tar.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/daemon/tar.c b/daemon/tar.c index 548eb89..6723f3a 100644 --- a/daemon/tar.c +++ b/daemon/tar.c @@ -47,11 +47,14 @@ is_chown_supported (const char *dir) { size_t len = sysroot_le

Re: [Libguestfs] [PATCH] virt-v2v: Catch invalid initrd path

2014-04-28 Thread Richard W.M. Jones
On Mon, Apr 28, 2014 at 09:11:22AM -0600, Mike Latimer wrote: > On Friday, April 25, 2014 08:58:24 PM Richard W.M. Jones wrote: > > Sorry for the late reply, but I've been buried in the v2v rewrite for > > the past few days. I will take this patch into account when I get &

Re: [Libguestfs] [supermin] Be smarter about finding suitable kernel images and device trees

2014-04-28 Thread Richard W.M. Jones
On Mon, Apr 28, 2014 at 09:21:33PM +0200, Hilko Bengen wrote: > --- > src/kernel.ml | 58 ++ > 1 file changed, 38 insertions(+), 20 deletions(-) > > diff --git a/src/kernel.ml b/src/kernel.ml > index ed5aea3..7076aa5 100644 > --- a/src/kerne

Re: [Libguestfs] Adventures in building libguestfs on non-x86 architectures for Debian

2014-04-30 Thread Richard W.M. Jones
On Tue, Apr 29, 2014 at 11:18:01PM +0200, Hilko Bengen wrote: > Hi, > > things are progressing slowly, but I feel that eventually I'll be > getting there: supermin can be built on all Linux-based architectures > that are part of Debian/unstable[1] -- (except for sparc, but I'll > ignore that for n

[Libguestfs] [PATCH v5 NOT TO BE APPLIED 2/2] New tool: virt-p2v.

2014-04-30 Thread Richard W.M. Jones
This is a graphical standalone front-end to virt-v2v which can be run on physical machines (usually linked into a ISO or PXE boot image) to convert the physical machine to a virtual machine. --- .gitignore | 4 + Makefile.am| 3 + README | 2 + configure.ac

[Libguestfs] [PATCH v5 NOT TO BE APPLIED 0/2] virt-v2v and virt-p2v

2014-04-30 Thread Richard W.M. Jones
Still lots of work to go ... ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH] daemon: xattr: factorize do_getxattr and do_lgetxattr

2014-04-30 Thread Richard W.M. Jones
On Wed, Apr 30, 2014 at 04:00:20PM +0200, Pino Toscano wrote: > Move all the common code to a new _getxattr function, much like done for > other xattrs operations. > > Mostly code motion, no functional changes. > --- > daemon/xattr.c | 54 +++--- >

Re: [Libguestfs] [PATCH 2/2] Fix handling of passwords in URLs

2014-04-30 Thread Richard W.M. Jones
On Wed, Apr 30, 2014 at 06:22:41PM +0200, Pino Toscano wrote: > So far, passwords in URLs (eg http://user:password@host..) have been > handled as part of the username, and thus passing > add-drive path username:username:password ... > instead of > add-drive path username:username secret:passwor

Re: [Libguestfs] [PATCH] daemon: xattr: factorize do_getxattr and do_lgetxattr

2014-05-02 Thread Richard W.M. Jones
On Fri, May 02, 2014 at 10:22:10AM +0200, Pino Toscano wrote: > On Wednesday 30 April 2014 17:52:14 Richard W.M. Jones wrote: > > On Wed, Apr 30, 2014 at 04:00:20PM +0200, Pino Toscano wrote: > > > Move all the common code to a new _getxattr function, much like done >

[Libguestfs] [PATCH] New API: cpio-out converts a directory to cpio format.

2014-05-03 Thread Richard W.M. Jones
This is useful for generating Linux initramfses from other types of filesystems. For example: guestfish --ro -a disk.img -i cpio-out / - | gzip -9 > initrd.img --- daemon/Makefile.am | 1 + daemon/cpio.c| 124 +++ generator/actions.ml

[Libguestfs] [PATCH 0/1] New API: cpio-out converts a directory to cpio format.

2014-05-03 Thread Richard W.M. Jones
After developing this API, I realized I didn't need it for what I was trying to do :-/ However it might still be a handy API to have, so I'm posting it. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/lib

[Libguestfs] [PATCH] customize: random-seed file has moved again.

2014-05-05 Thread Richard W.M. Jones
Thanks, systemd. --- customize/random_seed.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/customize/random_seed.ml b/customize/random_seed.ml index 84236cd..8eedc1e 100644 --- a/customize/random_seed.ml +++ b/customize/random_seed.ml @@ -27,6 +27,7 @@ let rec set_random_seed (g : Guestfs.g

Re: [Libguestfs] [PATCH] Fix handling of passwords in URLs

2014-05-07 Thread Richard W.M. Jones
Sorry for the rather late review. The patch looks good, so please push it and I'll do some valgrind testing on it next time there is a release. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpr

Re: [Libguestfs] [PATCH 2/3] tests: fix srcdir!=builddir runs

2014-05-07 Thread Richard W.M. Jones
On Fri, May 02, 2014 at 12:29:08PM +0200, Pino Toscano wrote: > Export $(srcdir) for the tests, so a test script which invokes other > script(s) can locate them properly. Part of this patch should not be needed. According to automake.info: Test programs that need data files should look for

Re: [Libguestfs] [PATCH 1/3] build: fix srcdir!=builddir builds

2014-05-07 Thread Richard W.M. Jones
This patch series is fine, minus the bits setting srcdir in TESTS_ENVIRONMENT. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, t

Re: [Libguestfs] [PATCH] tests: simple test for execstack supermin

2014-05-07 Thread Richard W.M. Jones
On Fri, May 02, 2014 at 02:47:11PM +0200, Pino Toscano wrote: > Add a simple test which uses scanelf or readelf to detect whether the > supermin executable is really not executable. > > Kind of followup of commit c9f7a7998021e1cbe22a8ec325d43e2bdc3eff5a. ACK. (Not that executable stacks matter f

Re: [Libguestfs] [PATCH] inspect: Add support for Oracle Linux

2014-05-07 Thread Richard W.M. Jones
On Mon, May 05, 2014 at 05:24:04PM +0300, Nikos Skalkotos wrote: > Prior to this patch the library would return "rhel" instead of > "oraclelinux" for Oracle Linux OSes. Thanks for the patch. I will push it shortly. Rich. > generator/actions.ml | 4 > src/guestfs-internal.h | 1 + > sr

Re: [Libguestfs] [PATCH] test-charset-fidelity: allow to skip testing specific FSes

2014-05-07 Thread Richard W.M. Jones
On Mon, May 05, 2014 at 05:05:29PM +0200, Pino Toscano wrote: > + snprintf (envvar, sizeof (envvar) - 1, "%s_%s", ourenvvar, fs->fs_name); Is this right? I'm tempted to say it should be `sizeof envvar'. However my knowledge of C is not clear enough to say whether that would evaluate to the size

Re: [Libguestfs] XML parsing in libguestfs & recent libvirt CVE

2014-05-07 Thread Richard W.M. Jones
On Tue, May 06, 2014 at 07:31:08PM +0200, Pino Toscano wrote: > today the libvirt security notice LSN-2014-0003 [1] has been published, > fixing an arbitrary file reading and a potential DoS issue due to unsafe > XML reading (unchecked expansion of entities). > > We inspected libguestfs in the f

Re: [Libguestfs] [PATCH] Fix build on HPPA

2014-05-09 Thread Richard W.M. Jones
On Fri, May 09, 2014 at 11:48:43AM +0200, Pino Toscano wrote: > From: Helge Deller > > The HPPA assembler syntax is slightly different than the GNU as to keep > compatibility to the HP-UX assembler. > > Reported in https://bugs.debian.org/742797. > --- > src/bin2s.pl | 4 > 1 file changed,

Re: [Libguestfs] [PATCH 1/2] tests/syslinux: factorize search for mbr.bin

2014-05-09 Thread Richard W.M. Jones
On Fri, May 09, 2014 at 11:01:49AM +0200, Pino Toscano wrote: > --- > tests/syslinux/test-syslinux.pl | 21 ++--- > 1 file changed, 14 insertions(+), 7 deletions(-) > > diff --git a/tests/syslinux/test-syslinux.pl b/tests/syslinux/test-syslinux.pl > index d86c095..8a227d4 100755 >

Re: [Libguestfs] [PATCH 2/2] tests/syslinux: add new syslinux 6+ path of mbr.bin

2014-05-09 Thread Richard W.M. Jones
On Fri, May 09, 2014 at 11:01:50AM +0200, Pino Toscano wrote: > Reported in https://bugs.debian.org/746748. > --- > tests/syslinux/test-syslinux.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/syslinux/test-syslinux.pl b/tests/syslinux/test-syslinux.pl > index

Re: [Libguestfs] [PATCH] appliance: update Debian-specific package list

2014-05-09 Thread Richard W.M. Jones
On Fri, May 09, 2014 at 11:15:33AM +0200, Hilko Bengen wrote: > --- > appliance/packagelist.in | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/appliance/packagelist.in b/appliance/packagelist.in > index d241ec9..27106c8 100644 > --- a/appliance/packagelist.in > ++

Re: [Libguestfs] [PATCH] configure: always add the extra warnings

2014-05-09 Thread Richard W.M. Jones
On Fri, May 09, 2014 at 03:11:45PM +0200, Pino Toscano wrote: > Get rid of --enable-gcc-warnings and just add all the warnings in any > case; they are tested anyway, so only warnings supported by the compiler > will be used. > > Regarding -Werror, add a new --enable-werror which enables its use.

Re: [Libguestfs] [PATCH] tests: simple test for execstack supermin

2014-05-09 Thread Richard W.M. Jones
On Fri, May 02, 2014 at 02:47:11PM +0200, Pino Toscano wrote: > Add a simple test which uses scanelf or readelf to detect whether the > supermin executable is really not executable. FYI this test failed on ARM. It's a genuine failure showing that we are building a supermin binary with an executab

Re: [Libguestfs] [PATCH] Make test-execstack recognize SKIP_ variable

2014-05-10 Thread Richard W.M. Jones
On Sat, May 10, 2014 at 01:41:48PM +0200, Hilko Bengen wrote: > --- > tests/test-execstack.sh | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/test-execstack.sh b/tests/test-execstack.sh > index a9cb5e0..a02803b 100755 > --- a/tests/test-execstack.sh > +++ b/tests/test-execstac

Re: [Libguestfs] [PATCH] tests: simple test for execstack supermin

2014-05-12 Thread Richard W.M. Jones
On Mon, May 12, 2014 at 07:00:11PM +0200, Pino Toscano wrote: > On Friday 09 May 2014 22:19:02 Richard W.M. Jones wrote: > > So I will have to apply the same fix to the OCaml ARM compiler too. > > Judging from the Debian build logs of pristine supermin 5.1.8, > architecture

Re: [Libguestfs] How to expand a partition (along with the filesystem on it) on a device?

2014-05-12 Thread Richard W.M. Jones
On Sun, May 11, 2014 at 09:40:34PM -0500, Peng Yu wrote: > Hi, > > I want to expand /dev/sda5 so that it takes the remaining space in > /dev/sda. But virt-resize does not work. Does anybody know how to make > it work? Thanks. Indeed, virt-resize ignores logical MBR partitions, and as you discover

Re: [Libguestfs] new warnings in hivex-1.3.10

2014-05-13 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 04:22:18PM +0200, Olaf Hering wrote: > > hivex-1.3.10 does not pass the sles11sp3 post-build-checks anymore, > 1.3.8 was still ok. The relevant output is: > > ... > [ 57s] Hivex.xs: In function 'XS_Win__Hivex_node_name': > [ 57s] Hivex.xs:236: warning: implicit declara

Re: [Libguestfs] new warnings in hivex-1.3.10

2014-05-14 Thread Richard W.M. Jones
On Tue, May 13, 2014 at 06:13:54PM +0200, Olaf Hering wrote: > On Tue, May 13, Richard W.M. Jones wrote: > > > That could obviously have caused this warning, but only if you're > > using a version of Perl that doesn't have newSVpvn_utf8. If you don't > &g

Re: [Libguestfs] [PATCH 2/2] builder: respect the proxy also when downloading images (RHBZ#1096465).

2014-05-14 Thread Richard W.M. Jones
On Wed, May 14, 2014 at 06:00:56PM +0200, Pino Toscano wrote: > Missing from commit 87d79c2ee259ce51595ad3a924fd216f882dc477. > --- > builder/builder.ml | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/builder/builder.ml b/builder/builder.ml > index acb6129..95

Re: [Libguestfs] guestfsd crashes when the handle is closed

2014-05-14 Thread Richard W.M. Jones
On Wed, May 14, 2014 at 06:07:37PM +0200, Safa Rekik wrote: > Hello, > > I launched guestfsd in my guest with this command : guestfsd* -rv*. > When i close the handle the deamon crashes. > > This is the output i got (Deamon side) : > guestfsd: main_loop : new request,

Re: [Libguestfs] guestfsd crashes when the handle is closed

2014-05-15 Thread Richard W.M. Jones
On Thu, May 15, 2014 at 01:13:47PM +0200, Safa Rekik wrote: > For fedora 20 guest, this is the back trace output : > = > *(gdb) bt full* > #0 0xb73e2040 in exit () from /lib/libc.so.6 > No symbol table info available. > #1 0xb77263a8 in main_loop () > No symbol

Re: [Libguestfs] guestfsd crashes when the handle is closed

2014-05-15 Thread Richard W.M. Jones
On Thu, May 15, 2014 at 03:23:53PM +0200, Safa Rekik wrote: > Hello, > > This is the ouotput for fedora guest. > == > *#0 0xb73b7040 in exit () from /lib/libc.so.6* > No symbol table info available. > > *#1 0xb76fb3a8 in main_loop (_sock=_sock@entry=3) at

Re: [Libguestfs] guestfsd crashes when the handle is closed

2014-05-15 Thread Richard W.M. Jones
On Thu, May 15, 2014 at 04:47:36PM +0200, Safa Rekik wrote: > Hello, > > In the client side i have guestfish 1.26.1. > For the server, guestfsd was installed with libguestfs-live-service 1.26.1 > too. > So i don't think this is the problem. > > BTW, isn't ther a libguestfs-debuginfo packages for

Re: [Libguestfs] [PATCH] generator: c.ml - wrap non deamon function with recursive mutex

2014-05-16 Thread Richard W.M. Jones
On Thu, May 15, 2014 at 05:39:08PM +0200, mza...@redhat.com wrote: > + > + pr "gl_recursive_lock_define_initialized(static, global_lock)\n"; static? I suspect this only allows one libguestfs handle per process into the critical section at once. I think the lock needs to be per-handle unless I'm

Re: [Libguestfs] [PATCH] generator: c.ml - wrap non deamon function with recursive mutex

2014-05-16 Thread Richard W.M. Jones
On Fri, May 16, 2014 at 11:47:17AM -0400, Daniel P. Berrange wrote: > On Fri, May 16, 2014 at 04:44:41PM +0100, Richard W.M. Jones wrote: > > On Thu, May 15, 2014 at 05:39:08PM +0200, mza...@redhat.com wrote: > > > + > > > + pr "gl_recursive_lock_define_in

[Libguestfs] Opening compressed filesystems

2014-05-16 Thread Richard W.M. Jones
This is in reply to a question on IRC about opening compressed disk images. This is already possible -- in fact quite easy -- using nbdkit. It only works well for xz-compressed files which have been prepared using the --block-size option like this: xz --best --block-size=16777216 disk.img Yo

Re: [Libguestfs] Labelling /etc/resolv.conf (rh#1089100)

2014-05-19 Thread Richard W.M. Jones
On Mon, May 19, 2014 at 06:32:49PM +0200, Pino Toscano wrote: > The other possible solution it came into my mind is adding a new API, > say selinux_relabel or so, which would just handle daemon-side all the > details needed to make sure linux guests with selinux would have proper > labels on the

Re: [Libguestfs] [PATCH] fish: simplify output of 'supported'

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 01:31:07PM +0200, Pino Toscano wrote: > Print each line at once, making use of the padding features of printf > instead of doing it manually. > --- > fish/supported.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/fish/supported.c

Re: [Libguestfs] [PATCH] daemon: scrub-file: resolve the path before calling scrub (RHBZ#1099490).

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 03:33:31PM +0200, Pino Toscano wrote: > Resolve the given path within the chroot, so scrub can be invoked > outside the chroot on an already-resolved path. > Given that realpath is used, its availability is checked manually, > since scrub-file already depends on the "scrub"

Re: [Libguestfs] [PATCH] daemon: scrub-file: resolve the path before calling scrub (RHBZ#1099490).

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 06:16:37PM +0200, Pino Toscano wrote: > Good idea. Do you have also an idea which daemon functions, other than > scrub-files and realpath itself, might need such handling? Not without examining every call. The only other bug that has been filed in this area (by me as it h

Re: [Libguestfs] [PATCH 1/4] generator: add always-available optgroups

2014-05-20 Thread Richard W.M. Jones
cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW >From 4a7afe56aa3124284df6ca0d26dab75b9bda7f7a Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Tue, 20 May 2014 21:39:08 +0100 Subjec

Re: [Libguestfs] [PATCH 3/4] daemon: add sysroot_realpath

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 07:54:47PM +0200, Pino Toscano wrote: > Similar to sysroot_path, but first resolves (using realpath) the given > path within sysroot. > --- > daemon/daemon.h | 1 + > daemon/guestfsd.c | 21 + > 2 files changed, 22 insertions(+) > > diff --git a/daem

Re: [Libguestfs] [PATCH 2/4] Make realpath mandatory

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 07:54:46PM +0200, Pino Toscano wrote: > It has been used unconditionally already for quite some time, so having > just the "realpath" command conditional on the presence of it does not > make much sense. > > Drop the configure/build system handling of it, and make the "real

Re: [Libguestfs] [PATCH 4/4] daemon: scrub-file: resolve the path before calling scrub (RHBZ#1099490).

2014-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2014 at 07:54:48PM +0200, Pino Toscano wrote: > Resolve the given path within the chroot, so scrub can be invoked > outside the chroot on an already-resolved path. > > Add few tests in scrub-file for this and other similar issues. ACK. Rich. -- Richard Jones, Virtualization Gro

Re: [Libguestfs] [PATCH 1/4] generator: add always-available optgroups

2014-05-21 Thread Richard W.M. Jones
On Wed, May 21, 2014 at 10:47:04AM +0200, Pino Toscano wrote: > On Tuesday 20 May 2014 21:40:21 Richard W.M. Jones wrote: > > On Tue, May 20, 2014 at 07:54:45PM +0200, Pino Toscano wrote: > > > Support the possibility to have optional groups always enabled (e.g. > > > b

Re: [Libguestfs] [PATCH 4/4] daemon: scrub-file: resolve the path before calling scrub (RHBZ#1099490).

2014-05-21 Thread Richard W.M. Jones
On Wed, May 21, 2014 at 03:15:39PM +0200, Pino Toscano wrote: > Resolve the given path within the chroot, so scrub can be invoked > outside the chroot on an already-resolved path. > > Add few tests in scrub-file for this and other similar issues. > --- ACK whole series. Thanks, Rich. -- Richa

[Libguestfs] ANNOUNCE: libguestfs RHEL 7.1 preview packages available

2014-05-21 Thread Richard W.M. Jones
If you are running RHEL 7 betas or the RHEL 7 Release Candidate[1], or (in the near future) when RHEL 7 GA or CentOS 7.0 is released, then you may be interested in previewing the libguestfs packages for RHEL 7.1. We intend to rebase[2] libguestfs to 1.26 or 1.28 in RHEL 7.1. This will deliver man

[Libguestfs] [PATCH 0/2] fuse: Add guestmount --fd option (RHBZ#1100498).

2014-05-23 Thread Richard W.M. Jones
Add guestmount --fd option for RFE. See: https://bugzilla.redhat.com/show_bug.cgi?id=1100498 ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

<    1   2   3   4   5   6   7   8   9   10   >