Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-10-12 Thread Richard W.M. Jones
On Mon, Oct 12, 2020 at 04:14:27PM +0200, Martin Kletzander wrote: > - internal API usage (for example the mentioned make-fedora-img.pl still uses >luks_open) I'll fix these as I find them. > - various docs still refer to any encryption as LUKS and there is *lot* of > them Yup, that is

Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-10-12 Thread Martin Kletzander
On Fri, Oct 09, 2020 at 04:33:53PM +0100, Richard W.M. Jones wrote: On Fri, Oct 09, 2020 at 05:02:57PM +0200, Martin Kletzander wrote: Basically what I did was create a small disk, create one partition over the whole disk, then cryptsetup luksFormat the partition, open it and format it with a

Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-10-09 Thread Daniel P . Berrangé
On Fri, Oct 09, 2020 at 04:33:53PM +0100, Richard W.M. Jones wrote: > On Fri, Oct 09, 2020 at 05:02:57PM +0200, Martin Kletzander wrote: > > Still, since you cannot do the test for Bitlocker, my idea was that > > you could make the test for non-lvm parition encrypted by LUKS as > > that would

Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-10-09 Thread Richard W.M. Jones
On Fri, Oct 09, 2020 at 05:02:57PM +0200, Martin Kletzander wrote: > Basically what I did was create a small disk, create one partition > over the whole disk, then cryptsetup luksFormat the partition, open > it and format it with a filesystem (without any LVM). That is one > of the things you

Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-10-09 Thread Martin Kletzander
On Thu, Sep 17, 2020 at 01:39:56PM +0100, Richard W.M. Jones wrote: As discussed in the emails today, this is the third version addressing most points from the v1/v2 review. You will need to pair this with the changes in libguestfs-common from this series:

Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-10-06 Thread Richard W.M. Jones
On Tue, Oct 06, 2020 at 03:29:33PM +0200, Martin Kletzander wrote: > On Thu, Sep 17, 2020 at 01:39:56PM +0100, Richard W.M. Jones wrote: > >As discussed in the emails today, this is the third version addressing > >most points from the v1/v2 review. > > > >You will need to pair this with the

Re: [Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-10-06 Thread Martin Kletzander
On Thu, Sep 17, 2020 at 01:39:56PM +0100, Richard W.M. Jones wrote: As discussed in the emails today, this is the third version addressing most points from the v1/v2 review. You will need to pair this with the changes in libguestfs-common from this series:

[Libguestfs] [PATCH v3 0/8] Windows BitLocker support.

2020-09-17 Thread Richard W.M. Jones
As discussed in the emails today, this is the third version addressing most points from the v1/v2 review. You will need to pair this with the changes in libguestfs-common from this series: https://www.redhat.com/archives/libguestfs/2020-September/msg00050.html Rich.