Re: [Libguestfs] [PATCH 1/2] inspect: fstab: Canonicalize paths appearing in fstab.

On Tuesday, 6 December 2016 09:46:25 CET Richard W.M. Jones wrote: > For example, converts "///usr//local//" -> "/usr/local". > --- > src/inspect-fs-unix.c | 52 > +++ > 1 file changed, 52 insertions(+) > > diff --git a/src/inspect-fs-unix.c

Re: [Libguestfs] [PATCH 0/5] Improve inspection of /usr filesystems

On Tue, Dec 06, 2016 at 04:29:17PM +0100, Pino Toscano wrote: > Hi, > > this patch series improves the way /usr filesystems are handled: tag > them appropriately, so later on we can find them and merge results they > contain directly back for the root filesystem. > > The series includes also a

Re: [Libguestfs] [PATCH 4/5] inspect: fix existance check of /dev/mapper devices

On Tue, Dec 06, 2016 at 04:29:21PM +0100, Pino Toscano wrote: > @@ -1820,7 +1833,7 @@ resolve_fstab_device (guestfs_h *g, const char *spec, > Hash_table *md_map, >char *type, *slice, *disk, *part; >int r; > > - if (STRPREFIX (spec, "/dev/mapper/") && guestfs_exists (g, spec) > 0) { > +

Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.

On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > You can now use -o rhv (-o rhev is supported for compatibility). > > This LGTM -- the only concern is that "output:rhev" will disappear from > the

Re: [Libguestfs] [PATCH 0/5] Improve inspection of /usr filesystems

On Wednesday, 7 December 2016 08:29:54 CET Richard W.M. Jones wrote: > On Tue, Dec 06, 2016 at 04:29:17PM +0100, Pino Toscano wrote: > > Hi, > > > > this patch series improves the way /usr filesystems are handled: tag > > them appropriately, so later on we can find them and merge results they > >

Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.

On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > > You can now use -o rhv (-o rhev is supported for compatibility). > > > > This LGTM --

[Libguestfs] [PATCH v2] v2v: Rename RHEV to RHV throughout.

v2: - Fix virt-p2v messages too. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.

On Wednesday, 7 December 2016 10:10:36 CET Richard W.M. Jones wrote: > On Wed, Dec 07, 2016 at 10:56:05AM +0100, Pino Toscano wrote: > > On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > > > On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > > > > On Thursday, 1

Re: [Libguestfs] libguestfs and exporting to OVA/OVF

Am 22. Oktober 2016 00:03:30 MESZ, schrieb Emmanuel Kasper : >Le 21/10/2016 à 16:08, Richard W.M. Jones a écrit : >> On Thu, Oct 20, 2016 at 10:43:26PM +0200, Emmanuel Kasper wrote: >>> Hi >>> I've been looking for a standalone tool to create OVA/OVF VM files >based >>> on a

Re: [Libguestfs] [PATCH 5/5] inspect: gather info from /usr filesystems as well (RHBZ#1401474)

On Tue, Dec 06, 2016 at 04:29:22PM +0100, Pino Toscano wrote: > +static void > +collect_linux_inspection_info_for (guestfs_h *g, struct inspect_fs *root) > +{ > + size_t i; > + struct inspect_fs *usr = NULL; > + > + for (i = 0; i < g->nr_fses; ++i) { > +struct inspect_fs *fs = >fses[i]; > +

[Libguestfs] [PATCH v2] v2v: Rename RHEV to RHV throughout.

You can now use -o rhv (-o rhev is supported for compatibility). --- p2v/gui.c | 5 +- p2v/virt-p2v.pod | 13 ++- v2v/Makefile.am | 8 +- v2v/OVF.ml| 30 +++

Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.

On Wed, Dec 07, 2016 at 10:56:05AM +0100, Pino Toscano wrote: > On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > > On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > > > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > > > You can now use

Re: [Libguestfs] [PATCH v2] v2v: Rename RHEV to RHV throughout.

On Wednesday, 7 December 2016 10:16:18 CET Richard W.M. Jones wrote: > You can now use -o rhv (-o rhev is supported for compatibility). > --- I didn't check the v2v parts (I assume they are the same as in v1 of the patch) -- the new p2v bits LGTM. Thanks, -- Pino Toscano signature.asc

[Libguestfs] [PATCH v3] v2v: -o vdsm: Add --vdsm-compat flag. -o rhev: Drop support for RHV < 4.1 (RHBZ#1400205).

Support for RHEV with RHEL 6 nodes required us to output the old style qcow2 compat=0.10 images. Since RHEV 3.6 GA, RHEL 6 has not been supported as a RHEV node type. Since RHV 4.1, compat=1.1 is supported. (Support for compat=1.1 is uncertain in RHV 4.0 even on RHEL 7 nodes.) There are

[Libguestfs] [PATCH v3] v2v: -o vdsm: Add --vdsm-compat flag.

v3: Change the flag from --vdsm-compat-11 to --vdsm-compat=1.1 Also the --machine-readable output has changed. I have also added a test. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH 0/5] Improve inspection of /usr filesystems

On Wed, Dec 07, 2016 at 10:49:44AM +0100, Pino Toscano wrote: > On Wednesday, 7 December 2016 08:29:54 CET Richard W.M. Jones wrote: > > On Tue, Dec 06, 2016 at 04:29:17PM +0100, Pino Toscano wrote: > > > Hi, > > > > > > this patch series improves the way /usr filesystems are handled: tag > > >

[Libguestfs] [PATCH 1/3] Document modules.

Add documentation for the modules making up supermin. This is just documentation, there is no code change. --- src/Makefile.am | 9 + src/build.mli | 23 +++ src/chroot.mli | 25 + src/dpkg.mli| 22 ++

[Libguestfs] [PATCH 0/3] Miscellaneous improvements to supermin.

Document what each module does, using *.mli files. Remove the --dtb option, it's obsolete. Rename modules according to their purpose. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.

On Wed, Dec 07, 2016 at 11:19:47AM +0100, Pino Toscano wrote: > On Wednesday, 7 December 2016 10:10:36 CET Richard W.M. Jones wrote: > > On Wed, Dec 07, 2016 at 10:56:05AM +0100, Pino Toscano wrote: > > > On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > > > > On Tue, Dec 06,

Re: [Libguestfs] [PATCH 2/2] libvirt: read secrets of disks (RHBZ#1392798)

On Wed, Nov 16, 2016 at 12:59:39PM +0100, Pino Toscano wrote: > Read also the secrets associated to disks ( tag within ), > so qemu can properly open them later on. Looks good, ACK. Rich. > src/libvirt-domain.c | 130 > +++ > 1 file changed,

Re: [Libguestfs] [PATCH 1/2] libvirt: un-duplicate XPath code

On Wed, Nov 16, 2016 at 12:59:38PM +0100, Pino Toscano wrote: > Move the checks for empty xmlXPathObjectPtr, and for extracting the > result string out of it, to a new helper functions. > > This is just code motion, there should be no behaviour changes. > --- > src/libvirt-domain.c | 122 >

Re: [Libguestfs] [PATCH 1/2] daemon: allow to change the labels of swap partitions

On Fri, Nov 25, 2016 at 11:22:26AM +0100, Pino Toscano wrote: > --- > daemon/daemon.h | 1 + > daemon/labels.c | 3 +++ > daemon/swap.c| 21 + > generator/actions.ml | 4 > 4 files changed, 29 insertions(+) > > diff --git a/daemon/daemon.h

[Libguestfs] [PATCH v2 1/2] inspect: fix existance check of /dev/mapper devices

When checking for the existance of /dev/mapper devices found in the fstab of a filesystem, using guestfs_exists means they are checked as files in the guest, while they really appear as devices on the appliance. Instead, try the lvm name resolution anyway, and ignore them when they are reported as

[Libguestfs] [PATCH v2 2/2] inspect: gather info from /usr filesystems as well (RHBZ#1401474)

Flag the filesystems for Linux /usr properly as USR role, and detect some data out of it, like the distro information from an os-release (if present), and the architecture (since the binaries used for our architecture check will be available there only). Later on, collect the results in a way

Re: [Libguestfs] [PATCH 2/3] Split internal stuff out of guestfs.h

Oh and just make "guestfs-internal.h" include those other two files, and drop explicit includes of guestfs-internal-actions.h everywhere. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog:

Re: [Libguestfs] [PATCH 2/3] Split internal stuff out of guestfs.h

On Tue, Nov 08, 2016 at 02:30:19PM +0100, Pino Toscano wrote: > Create a new guestfs-private.h header, and move there the definitions of > all the actions with visibility VInternal, and all the private structs: > they are not meant to be used, not even seen, outside of the library. > > Include

Re: [Libguestfs] [PATCH 2/2] resize: shrink/expand swap partitions

On Fri, Nov 25, 2016 at 11:22:27AM +0100, Pino Toscano wrote: > Handle the swap partition on their own, rebuilding them using the > existing UUID and label. > > resize/resize.ml | 35 --- > resize/virt-resize.pod | 8 > 2 files changed, 36

[Libguestfs] [PATCH v2 0/2] Improve inspection of /usr filesystems

Hi, this patch series improves the way /usr filesystems are handled: tag them appropriately, so later on we can find them and merge results they contain directly back for the root filesystem. Changes in v2: - removed patches #1 and #2, already pushed - drop patch #3, no more needed - replace

Re: [Libguestfs] [PATCH v2 0/2] Improve inspection of /usr filesystems

On Wed, Dec 07, 2016 at 01:27:54PM +0100, Pino Toscano wrote: > Hi, > > this patch series improves the way /usr filesystems are handled: tag > them appropriately, so later on we can find them and merge results they > contain directly back for the root filesystem. ACK series. Rich. -- Richard

[Libguestfs] [PATCH v3 4/6] mllib: modify nsplit to take optional noempty and count arguments

Added two new optional arguments to nsplit: * noempty: if set to false empty elements are not stored in the returned list. The default is to keep the empty elements * count: specifies how many splits to perform; negative count (the default) means do as many splits as possible Signed-off-by:

[Libguestfs] [PATCH v3 6/6] v2v: ova: don't extract files from OVA if it's not needed

We don't have to always extract all files from the OVA archive. The OVA, as defined in the standard, is plain tar. We can work directly over the tar archive if we use correct 'offset' and 'size' options when defining the backing file for QEMU. This puts much lower requirement on available disk

[Libguestfs] [PATCH v3 3/6] v2v: ova: move the untar function

Move the untar function so it can be used later in the code. Signed-off-by: Tomáš Golembiovský --- v2v/input_ova.ml | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/v2v/input_ova.ml b/v2v/input_ova.ml index 61930f0..85954a3 100644 ---

[Libguestfs] [PATCH v3 0/6] Import directly from OVA tar archive if possible

v3: Addressed Pino's comments, namely: - input_ova.ml - untar takes list of paths - renamed untar_partial to untar_metadata - replaced uggly regex with nsplit - tests - test changes are part of the main commit - renamed test-data/guestfs-hashsums.sh to test-data/test-utils.sh - renamed