Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.
On Wed, Dec 07, 2016 at 11:19:47AM +0100, Pino Toscano wrote: > On Wednesday, 7 December 2016 10:10:36 CET Richard W.M. Jones wrote: > > On Wed, Dec 07, 2016 at 10:56:05AM +0100, Pino Toscano wrote: > > > On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > > > > On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > > > > > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > > > > > You can now use -o rhv (-o rhev is supported for compatibility). > > > > > > > > > > This LGTM -- the only concern is that "output:rhev" will disappear > > > > > from > > > > > the machine-readable output (and thus potentially breaking users). > > > > > I have PoC for handling better aliases for input & output modules, > > > > > I will polish and submit it. > > > > > > > > Hopefully they are parsing the --machine-readable output and so this > > > > won't be a problem :-) > > > > > > Well exactly: newer virt-v2v with "older" ovirt/rhv will not see > > > output:rhev anymore and thus not enable the VM import from VMware/etc. > > > > I think you mean newer virt-p2v and older virt-v2v? > > No, I mean other users of v2v which looks at the machine-readable > output. Not sure whether ovirt/rhv is one of them, but others might. RHV is just using RPM version dependencies. It doesn't look at --machine-readable at all. I don't know about other consumers. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.
On Wednesday, 7 December 2016 10:10:36 CET Richard W.M. Jones wrote: > On Wed, Dec 07, 2016 at 10:56:05AM +0100, Pino Toscano wrote: > > On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > > > On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > > > > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > > > > You can now use -o rhv (-o rhev is supported for compatibility). > > > > > > > > This LGTM -- the only concern is that "output:rhev" will disappear from > > > > the machine-readable output (and thus potentially breaking users). > > > > I have PoC for handling better aliases for input & output modules, > > > > I will polish and submit it. > > > > > > Hopefully they are parsing the --machine-readable output and so this > > > won't be a problem :-) > > > > Well exactly: newer virt-v2v with "older" ovirt/rhv will not see > > output:rhev anymore and thus not enable the VM import from VMware/etc. > > I think you mean newer virt-p2v and older virt-v2v? No, I mean other users of v2v which looks at the machine-readable output. Not sure whether ovirt/rhv is one of them, but others might. -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.
On Wed, Dec 07, 2016 at 10:56:05AM +0100, Pino Toscano wrote: > On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > > On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > > > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > > > You can now use -o rhv (-o rhev is supported for compatibility). > > > > > > This LGTM -- the only concern is that "output:rhev" will disappear from > > > the machine-readable output (and thus potentially breaking users). > > > I have PoC for handling better aliases for input & output modules, > > > I will polish and submit it. > > > > Hopefully they are parsing the --machine-readable output and so this > > won't be a problem :-) > > Well exactly: newer virt-v2v with "older" ovirt/rhv will not see > output:rhev anymore and thus not enable the VM import from VMware/etc. I think you mean newer virt-p2v and older virt-v2v? It should populate the combo box with the output of --machine-readable, so it should show the (old) 'rhev' option in this case. For older virt-p2v, newer virt-v2v, '-o rhev' still works. However I noticed there are places in virt-p2v where messages refer to "rhev", so I'll fix those in a follow-up patch. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.
On Wednesday, 7 December 2016 08:34:35 CET Richard W.M. Jones wrote: > On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > > You can now use -o rhv (-o rhev is supported for compatibility). > > > > This LGTM -- the only concern is that "output:rhev" will disappear from > > the machine-readable output (and thus potentially breaking users). > > I have PoC for handling better aliases for input & output modules, > > I will polish and submit it. > > Hopefully they are parsing the --machine-readable output and so this > won't be a problem :-) Well exactly: newer virt-v2v with "older" ovirt/rhv will not see output:rhev anymore and thus not enable the VM import from VMware/etc. -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.
On Tue, Dec 06, 2016 at 04:41:52PM +0100, Pino Toscano wrote: > On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > > You can now use -o rhv (-o rhev is supported for compatibility). > > This LGTM -- the only concern is that "output:rhev" will disappear from > the machine-readable output (and thus potentially breaking users). > I have PoC for handling better aliases for input & output modules, > I will polish and submit it. Hopefully they are parsing the --machine-readable output and so this won't be a problem :-) virt-p2v should be able to handle it anyhow. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [PATCH] v2v: Rename RHEV to RHV throughout.
On Thursday, 1 December 2016 14:35:07 CET Richard W.M. Jones wrote: > You can now use -o rhv (-o rhev is supported for compatibility). This LGTM -- the only concern is that "output:rhev" will disappear from the machine-readable output (and thus potentially breaking users). I have PoC for handling better aliases for input & output modules, I will polish and submit it. Thanks, -- Pino Toscano signature.asc Description: This is a digitally signed message part. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs
