Re: [Libguestfs] [libnbd PATCH] ci: Update lcitool to request cargo during CI
On Tue, Aug 15, 2023 at 04:33:38PM -0500, Eric Blake wrote: > Regenerate the CI build scripts with: > > ../libvirt-ci/bin/lcitool manifest ci/manifest.yml > > using libvirt-ci bumped with a pending patch: > https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/424 > > Signed-off-by: Eric Blake > --- > > CI is still not green, but I've been working on it today. I'm > currently waiting for a merge request to lcitool to land, if that > happens quickly, I can rework this commit message. I'm also playing > with pushing this patch to a forked repo, to see how it fares, before > sending it to the main repo. I'm not sure why Alpine builds are now hanging during interop/ (happened in the previous commit, not new to this one). There's another thread discussing how to fix the failures now showing up from too-old Rust. But libvirt-ci accepted my merge request, so I tweaked this, and it is now in as 49f98edd; and I will be doing a similar update to nbdkit shortly. Regarding awk failures seen in the previous commit for opensuse-tumbleweed, the OpenSUSE folks answered at https://bugzilla.suse.com/show_bug.cgi?id=1214365 that their change to drop gawk from their bare-bones repository for minimal CI images was intentional; but they didn't realize how many configure scripts depend on at least some form of awk, so they may still be fixing that in some other manner. In the meantime, they were in agreement with my resolution of explicitly requesting awk in any container with a configure script where it is not already pulled in from something else. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [libnbd PATCH] ci: Update lcitool to request cargo during CI
On Wed, Aug 16, 2023 at 11:56:52AM +0100, Richard W.M. Jones wrote: > > It's interesting that awk is required. I've been attempting to keep > nbdkit from requiring awk (but we do require sed). > > In config.log I see: > > $ grep -i awk config.log > configure:5226: checking for gawk > configure:5247: found /usr/bin/gawk > configure:5258: result: gawk > ac_cv_prog_AWK=gawk > AWK='gawk' > > but I can't tell where that's coming from ... Autoconf itself uses awk during ./config.status to generate config.h from config.h.in, and Automake requires it for 'make check' to support TAP output. A quick search of the generated configure finds this telling section: # We need awk for the "check" target (and possibly the TAP driver). The # system "awk" is bad on some platforms. # Always define AMTAR for backward compatibility. Yes, it's still used I agree that we don't directly use awk in any code we've written, but GNU tools have long assumed that any Unix-like system has awk available. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [libnbd PATCH] ci: Update lcitool to request cargo during CI
It's interesting that awk is required. I've been attempting to keep nbdkit from requiring awk (but we do require sed). In config.log I see: $ grep -i awk config.log configure:5226: checking for gawk configure:5247: found /usr/bin/gawk configure:5258: result: gawk ac_cv_prog_AWK=gawk AWK='gawk' but I can't tell where that's coming from ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
