Re: [Libmesh-devel] virtual Node, DofObject destructors

2013-01-28 Thread Roy Stogner
On Mon, 28 Jan 2013, John Peterson wrote: > This was my first thought, but like you I concluded that MI shouldn't > make a difference if neither parent has virtuals... It might make a difference if *one* parent has virtuals? I.e. maybe we saved 8 bytes in DofObject, but 16 in Node? > I can't e

Re: [Libmesh-devel] virtual Node, DofObject destructors

2013-01-28 Thread John Peterson
On Mon, Jan 28, 2013 at 2:16 PM, Roy Stogner wrote: > > On Mon, 28 Jan 2013, John Peterson wrote: > >> Did you check that this actually changed the size of Node? > > > That would smack of effort. I'm more of an ideas person. > > >> If yes, how did you check? > > > Fine, fine... > > I just wrote a

Re: [Libmesh-devel] virtual Node, DofObject destructors

2013-01-28 Thread Roy Stogner
On Mon, 28 Jan 2013, John Peterson wrote: > Did you check that this actually changed the size of Node? That would smack of effort. I'm more of an ideas person. > If yes, how did you check? Fine, fine... I just wrote a quick program to print sizeof(Node) on my (amd64 Linux) system. With the

Re: [Libmesh-devel] virtual Node, DofObject destructors

2013-01-28 Thread John Peterson
On Mon, Jan 28, 2013 at 12:09 PM, Kirk, Benjamin (JSC-EG311) wrote: > > On Jan 28, 2013, at 1:06 PM, Roy Stogner wrote: > >> Would it be sufficient to make the constructor and >> destructor protected? > > That was my immediate thought, pitfalls? I'm guessing you're closer to this > code ATM tha

Re: [Libmesh-devel] virtual Node, DofObject destructors

2013-01-28 Thread Kirk, Benjamin (JSC-EG311)
On Jan 28, 2013, at 1:06 PM, Roy Stogner wrote: > Would it be sufficient to make the constructor and > destructor protected? That was my immediate thought, pitfalls? I'm guessing you're closer to this code ATM than I am. If the destructor is protected, only Node and Elem can call it, so a us

Re: [Libmesh-devel] virtual Node, DofObject destructors

2013-01-28 Thread Roy Stogner
On Mon, 28 Jan 2013, Kirk, Benjamin (JSC-EG311) wrote: > On Jan 28, 2013, at 12:54 PM, Roy Stogner wrote: > >> The downside is that any attempt to destroy a Node via a DofObject >> could then fail horribly. This used to be a concern for us, when we >> had an API returning AutoPtr, but library

Re: [Libmesh-devel] virtual Node, DofObject destructors

2013-01-28 Thread Kirk, Benjamin (JSC-EG311)
On Jan 28, 2013, at 12:54 PM, Roy Stogner wrote: > The downside is that any attempt to destroy a Node via a DofObject > could then fail horribly. This used to be a concern for us, when we > had an API returning AutoPtr, but library code should be > fine now. > > Opinions? Yeah, actually needin